wallyworldbabbageclunk: we mis you00:18
babbageclunkoops! omw00:18
babbageclunkwallyworld: any idea why actions would just get queued as pending and never be run?01:21
babbageclunkworse - one did run and then others never have.01:21
babbageclunk(even on different units)01:21
wallyworldbabbageclunk: the unit agent watches actions and reacts - it marks them as running when it executes them. so if an action is not being run, you need to look at the unit agent to see why01:24
babbageclunkI can't see anything in the debug-logs, I'll have a look in the files.01:24
babbageclunkthanks wallyworld01:25
wallyworldbabbageclunk: i had a look at the action resolver in the uniter and there's no filtering - it really does just react directly to an action watcher that flicks across any queued/pending actions01:46
thumperbabbageclunk: actions require the hook-execution lock01:46
thumperbabbageclunk: look at the machine-lock file on the machine01:47
thumperand the juju_machine_lock command01:47
babbageclunknothing holding the lock - I can see the first run releasing the lock at the end, and I've had hooks run after that. Just not getting anything for the new pending actions I've added.01:48
babbageclunkso that means that the watcher isn't seeing them for some reason?01:51
wallyworldmaybe - you'd need logging in remotestate/watcher etc01:51
thumperbabbageclunk: if you specify juju.apiserver to TRACE you'll see the details of all the api calls01:52
thumperthat may help01:52
babbageclunkok, thanks01:53
babbageclunkthere's logging in remotestate/watcher for when the action watcher triggers, I can see it for the first one but not subsequent actions...01:55
babbageclunkit's almost like the actions watcher has stopped.02:02
wallyworldkelvinliu: the issue is that the secret labels in 2.7 include model name. that's not needed because the secrets for an app are created in the app's namespace and we know the model. if we remove that label it will work as 2.6.9 correctly uses the juju-app=foo label02:06
wallyworldconfigmap also uses model label02:06
wallyworldwe should only use model lable for global resources02:07
kelvinliuic. we should only have model labels for global resources02:07
wallyworldso it will be a quick fix02:07
kelvinliui will fix it after current pr landed.02:08
kelvinliuwallyworld: so I just tested on gke, aks working fine, microk8s failed due to this issue https://github.com/ubuntu/microk8s/issues/757  I will test CDK on aws after lunch.02:21
wallyworldsgtm, ty02:24
wallyworldkelvinliu: is latest change pushed?02:24
babbageclunkthumper: can I pick your brains about this?02:25
kelvinliuthe credential schema change,  yes, but I need rename the func name and to see if other clean up/rebase etc need to be done.02:26
wallyworldthat's ok, i might try and test too02:26
thumperbabbageclunk: sure02:31
babbageclunkin 1:1?02:31
wallyworldkelvinliu: testing with CDK on AWS, the LoadBalancer service is not getting an external IP so bootstrap fails. not sure if that's related. might be an issue with integrator03:23
kelvinliuwallyworld: my cdk is deploying, i will see if it's reproducable03:28
wallyworldkelvinliu: also, the nodes are missing the juju.io/cloud labels so i am raising a bug03:30
kelvinliuyeah, it's missing https://pastebin.ubuntu.com/p/xZMPxCwJYn/03:31
kelvinliuwallyworld: i tested on cdk/aws, all good for me. I didn't have the LB provision issue.03:58
wallyworldmust be my account or something03:59
kelvinliumissing -- trust?03:59
wallyworldjuju deploy charmed-kubernetes --overlay /home/ian/aws-overlay.yaml --trust03:59
wallyworldthat's supposed to work03:59
kelvinliui use the same cmd and copied overlay from the doc https://pastebin.ubuntu.com/p/WMgVhNQyTF/04:00
wallyworldyup, i did too04:05
wallyworldbabbageclunk: did you sort out the actions thing?04:12
babbageclunkwallyworld: nope04:17
babbageclunkit's really weird04:17
wallyworldwhat charm?04:18
babbageclunkwallyworld: it's my charm - but it doesn't seem like the watcher internals are passing along the update04:19
anastasiamacwallyworld: babbageclunk : PTAL https://github.com/juju/juju/pull/10801 - corrected creation of cloud call context04:20
wallyworldbabbageclunk: i'll try deploying a stock charm and see if actions work04:21
wallyworldbabbageclunk: hmmm, works for ubuntu-lite with a simple action i added04:24
babbageclunkwallyworld: and if you queue another action?04:24
wallyworldbabbageclunk: works04:29
wallyworldthis is on develop04:29
babbageclunkok, I think it's to do with jam's changes. Can I talk through with you a bit? I'm pretty unfamiliar with the hubwatcher code04:30
babbageclunkwallyworld: in standup?04:31
wallyworldanastasiamac: i have to duck out for a bit, a couple of quick initial questions have been left. i may be missing something04:44
anastasiamacwallyworld: updated04:56
wallyworldanastasiamac: while i look? https://github.com/juju/juju/pull/10800 small06:05
wallyworldhpidcock: did you need me to look at any wip?06:05
anastasiamacwallyworld: k06:06
hpidcockprobably monday morning, I'm pretty tired going to finish up a bit earlier06:09
wallyworldanastasiamac: with the network facade, that is a model facade right? so technically it is ok as is i would have thought?06:10
wallyworldas it always gets the right state when it is constrcuted06:11
wallyworldit's only controller facades that get controller state06:11
wallyworldand the same st is being passed in anyway06:12
anastasiamacwallyworld: with network ine becaue we r using the code in common, we could potentially have a controller facade using it (dunno for what but possible ... since nothing stops us)... I did not want it to be a possibility06:12
wallyworldfunc NewNetworkConfigAPI(st *state.State ...)06:12
anastasiamacwallyworld: i think with this experience, every time we need call context, we should construct it06:12
wallyworldso the change does not prevent that st above being passed in06:12
wallyworldi can see passing in the one st is useful though06:13
wallyworldand making the context off that06:13
wallyworldjust trying to understand the change06:13
anastasiamacwallyworld: with respect to networking facade, i.e. NewNetworkConfigAPI(...) like i said above - i don't think we should construct call context in constructor any longer... we should only construct it as needed in the individual call06:15
anastasiamacwallyworld: hence i've changed the signature and removed call context creation from constructor...06:18
wallyworldanastasiamac: func (s statePoolShim) GetModelCallContext(modelUUID string).... is there an issue there? we Release() modelState inside the func but then pass modelState.State as a return value expecting it can be used outside the func call.06:24
anastasiamacwallyworld: i don't think so.... the new implementation juts moves things around for convenience but is the same a old where we did call release in apiserver... and old one worked... so m sure the new one works too06:29
anastasiamacwallyworld: i tested live :D06:29
wallyworldok, that reference counting code ia a bit hairy and i need to re-learn it06:30
wallyworldstatepool, modelstatepool, systemstate etc etc06:30
anastasiamacthe pr fixes the issue in the bug :)06:31
anastasiamacand makes sure that all similar calls are not wrong06:31
wallyworldindeed, i just wanted to make sure there wasn't a st leak06:33
wallyworldor a premature release of state from the pool06:33
wallyworldi'm still not 100% but if it works....06:33
anastasiamacur concern is appreciate and all the vali questions :D06:33
wallyworldi don't know the code well enough anymore06:33
anastasiamacit works in practice :)06:33
anastasiamacyeah.. that m.UUID() gave me hell... the model we get above is is not a full model... it's interfaced... but i think u r right, it's cleaner to add a method to Interface than to do the convulated dance06:35
wallyworldyeah, got to add it to mocks etc but cleaner prod code06:43
manadartwallyworld: Should I look at https://bugs.launchpad.net/juju/+bug/1849744 today?07:01
mupBug #1849744: k8s upgrade to 2.7 results in broken apps <juju:Triaged> <https://launchpad.net/bugs/1849744>07:01
wallyworldmanadart: nope, i already know the fix07:03
wallyworldjust got to do a pr07:03
wallyworldit's about 3 lines of code and tests07:03
wallyworldi assume it's not blocking you?07:04
manadartwallyworld: OK. No not block me.07:08
achilleasamanadart: thanks for the bug link. I have approved 1077908:23
manadartachilleasa: Thanks.08:24
stickupkidmanadart, the branch stuff is still behind a feature flag right?09:36
manadartstickupkid: Yeah. "export JUJU_DEV_FEATURE_FLAGS=generations".09:37
stickupkidmanadart, nice nice09:37
stickupkidmanadart,  are we calling the code internally to juju, branches or generations09:52
manadartstickupkid: It was initially just generations before we started using the "branch" name. So the packages, state collection and some types still use that nomenclature.09:54
manadartstickupkid: "branch" is generally the term for in-flight, not-committed generations.09:54
manadartstickupkid: One committed, the generation seq is bumped and the model has a new "generation", a high-water mark if you will.09:55
manadartThere is a notion to make all changes use a branch implicitly, so each change will increment the model generation and you will be able to see a history of changes.09:56
manadart^^ Once committed...09:56
nammn_demanadart: if you want something small in the evening, a small PR regarding branches update  https://github.com/juju/juju/pull/10796 :D10:09
nammn_demanadart: was not 100% sure whats the way right now to work on status is, so I just opened the PR so that we can discuss in case we do it differently10:09
manadartnammn_de: OK, I'll take a look.10:10
manadartachilleasa: https://github.com/juju/juju/pull/1080210:39
manadartOops. Looks like we have never handled space info in address migrations.11:39
achilleasamanadart: approved PR; one mock seems to have escaped the renaming11:46
stickupkidmanadart, is there a way to see all branches ?12:57
manadartstickupkid: We are going to need such a command.13:03
nammn_deif someone wants to take a look at this small one. Changed the track err msg and update mockgen manadart ^ https://github.com/juju/juju/pull/1080413:39
nammn_deand the one we were just talking about how we read charm, simon already added nice comments https://github.com/juju/charm/pull/297 . I added my opnion why this also can be bad what i added13:40
stickupkidmanadart, before I add some qa steps, anychance of looking at the WIP https://github.com/juju/juju/pull/1080314:36
manadartstickupkid: Yep.14:37
N3tw0rKnoob question: how can i set the release of openstack, looks like it defaults to queens. Id like to set it to a more recent release.14:47
pmatulisN3tw0rK, if you're on an LTS the short answer is "UCA"15:05
N3tw0rKpmatulis, ok is there anything juju specific that needs to be done once the UCA repo is added to the nodes?15:09
pmatulisN3tw0rK, are you installing O/S charm by charm or using a bundle?15:12
N3tw0rKpmatulis, charms15:12
pmatulisthen this is the key syntax you need:15:13
pmatulisjuju deploy <openstack-charm> --config openstack-origin=cloud:bionic-train15:13
N3tw0rKpmatulis, Thanks!15:13
pmatulissome non-openstack charms (e.g. ceph) will use a different option:15:15
pmatulisjuju deploy ceph-osd --config source=cloud:bionic-train15:15
hmlachilleasa:  we pass the space names as tags in some places… and _default is not a valid space tag currently15:16
achilleasalike constraints?15:17
hmlachilleasa:  “juju spaces”15:17
achilleasaI sense a names.v3 PR coming soon...15:17
hmlachilleasa:  it would help with the Config validation as well.15:19
hmlachilleasa:  it’s a bit ugly really… i don’t think we want to allow just an name with understore in front15:26
achilleasacan we have the underscore in the end instead?15:26
stickupkidmanadart, it doesn't look like we validate the branch name in terms of uniqueness15:33
manadartstickupkid: I think we do for active branches, but you can use the name of a committed one.15:39
stickupkidmanadart, yeah, ok, so let's say if it's not committed you can't pick that branch name15:40
stickupkidmanadart, i'll add that validation15:40
nammn_demanadart: looks like my pr was not problem free. I need to address this and come back to you, probably I will remove the additional api call16:48
nammn_demanadart: seems like init cannot access the api yet16:49
webstrandI'm having trouble building juju 2.6.9; 2.1 builds fine. Any idea what I'm missing? http://dpaste.com/20WC57617:37
manadartwebstrand: Juju switch to dep since 2.1. Have you run "go make dep"?17:41
manadart*switched dammit.17:41
webstrandYep, I rebuilt all dependencies from Gopkg.lock17:42
mbeierlanyone else having charm build failures due to https://git.launchpad.net/layer-apt/ giving 503?18:10

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!