[00:27] wallyworld: free to talk now or later? [00:27] upgrade steps for caas [03:28] wallyworld: whenever you get a chance to have a peek at https://github.com/juju/juju/pull/10807 I'm not sure if this is going to be the best solution but it appears to work. [05:15] hpidcock: looking now, just finished meetings/interviews etc [05:15] wallyworld: np, take your time [05:58] hpidcock: looks good so far, a few questions [06:01] wallyworld: awesome thank-you [06:30] anastasiamac: here's a bunch of small CLI usability fixes https://github.com/juju/juju/pull/10808 for whenever, tomorrow fine [06:33] wallyworld: k... m still going thru tests so might fit them in... [06:34] wallyworld: arggh ... it'll clash with mine but k, i'll look now [06:36] i can wait till your lands [06:37] ha mine is not even proposed yet :( [07:05] anastasiamac: this may get fixed in your refactoring. doing some more tests with add-k8s, I see this error "ERROR empty controller name not valid" and it happens when I run add-k8s with no current controller in scope and no additional --client-only or --controller-only args. it looks like it has added the cluter locally and goes to then add to a controller but there isn't one and when it does jujuclient.ValidateControllerName( [07:05] c.ControllerName) it fails [07:06] wallyworld: yes, mayb... m on remov tests now... I'll finish what I need to do first, then look at what u've found [07:07] no worries, just wanted to let you know [07:07] in case it was relevant for the refactoring [07:07] wallyworld: ack.. i think i removed it coz that path's no longer relevant [07:08] yeah, thought that may have been the case [07:11] kelvinliu: PR is lgtm, i assume you want to merge it and do the upgrade step as a separate pr? [07:15] wallyworld: thanks for rv. I need introduce new facades to the worker to make steps to be able to construct broker which requires more work. so it's reasonable to continue in another PR. [07:15] sgtm [07:16] it is merging [07:16] so quick, thanks! [09:49] manadart: again almost the same pr, without changing mockdep for 2.6 https://github.com/juju/juju/pull/10809 [09:51] manadart: thanks again :D [09:53] manadart: while at it, wanted to go and learn more about metrics and how we do them. Any file/doc/test case you have a link to to get into? [09:54] nammn_de, it's CI day fyi [09:55] stickupkid: damn you right, have something for me? [09:57] nammn_de: You can look at the metrics worker and wind it up from there. There is also https://discourse.jujucharms.com/t/collecting-juju-metrics/1138. [10:18] manadart, i have a question, jump into ho quickly? [10:20] stickupkid: OMW. [13:48] stickupkid: one small acceptancetest readme addonhttps://github.com/juju/juju/pull/10813/files [14:52] stickupkid: good suggestion, too much copy paste of discourse [14:57] stickupkid: i commited your suggestion [14:58] nammn_de, done [15:43] Need a review of address type modification in juju/description. Should be a simple one: https://github.com/juju/description/pull/64 [15:45] manadart: looking [16:00] manadart: approved, just a comment on the PR text. [16:01] hml: Done; thanks. === hardy is now known as falencastro === mpjetta_ is now known as mpjetta