| mborzecki | morning | 05:58 |
|---|---|---|
| mborzecki | mvo: hey | 06:09 |
| mvo | hey mborzecki | 06:10 |
| mup | PR snapd#7608 closed: o/snapstate, etc: SnapState.Channel -> TrackingChannel, and a setter <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7608> | 06:23 |
| mborzecki | school run, back in 30 | 06:30 |
| zyga | hey | 06:32 |
| zyga | working on regression test for bug from Friday | 06:32 |
| mvo | hey zyga ! | 06:33 |
| mvo | zyga: did you identify the bug ? is it a difficult one? | 06:33 |
| mvo | zyga: also thanks for 7662 and friends | 06:34 |
| mvo | zyga: I cherry pick this now | 06:34 |
| mup | PR snapd#7674 opened: interfaces: de-duplicate emitted update-ns profiles (2.42) <Created by mvo5> <https://github.com/snapcore/snapd/pull/7674> | 06:44 |
| mborzecki | re | 07:02 |
| zyga | mvo: re, sorry, some morning school interrupts | 07:04 |
| zyga | mvo: not sure yet | 07:04 |
| zyga | mvo: give me one hour | 07:04 |
| mvo | zyga: sure | 07:06 |
| mvo | zyga: thanks for looking into this | 07:06 |
| zyga | mvo: not super hard | 07:31 |
| zyga | mvo: not kernel or anything like that | 07:31 |
| * mvo hugs zyga | 07:31 | |
| zyga | mvo: just overlooked and underused feature | 07:31 |
| zyga | mvo: workaround is tiny | 07:48 |
| zyga | mvo: proper fix requires a little bit more logic | 07:48 |
| zyga | mvo: I'll send workaround patches in one hour | 07:48 |
| zyga | mvo: should we have a 2.42.1 milestone on launchpad | 07:49 |
| mvo | zyga: feel free to add it | 07:50 |
| zyga | ok | 07:50 |
| === pstolowskiafk is now known as pstolowski | ||
| pstolowski | morning | 08:01 |
| mborzecki | pstolowski: hey | 08:03 |
| mup | PR snapd#7666 closed: tests: don't depend on GNU time <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7666> | 08:19 |
| mup | PR snapd#7668 closed: tests: tweak wording in mount-ns test <Simple 😃> <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7668> | 08:21 |
| mup | PR snapd#7675 opened: osutil: preseed mode helper <Prebaking> <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/7675> | 08:30 |
| mup | PR snapd#7676 opened: many: cherry pick test updates for 2.42 <Created by mvo5> <https://github.com/snapcore/snapd/pull/7676> | 08:33 |
| mup | PR snapd#7677 opened: interfaces/content: workaround for renamed target <Created by zyga> <https://github.com/snapcore/snapd/pull/7677> | 08:38 |
| pedronis | pstolowski: hi, to discuss 7675, can you make a list of the packages that would need to query PreseedMode ? | 08:39 |
| pstolowski | pedronis: sure, will do | 08:40 |
| zyga | mborzecki: can you look at https://github.com/snapcore/snapd/pull/7677 | 08:41 |
| mup | PR #7677: interfaces/content: workaround for renamed target <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7677> | 08:41 |
| zyga | mborzecki: it's a priority customer request | 08:41 |
| zyga | mvo: the test passed a single run, force pushed with commit typo and running across all machines | 08:43 |
| zyga | mborzecki: could you send a patch that disables xdelta for amazon? | 08:47 |
| zyga | mborzecki: for the resend in spread | 08:47 |
| pstolowski | pedronis: updated (added to the description) | 08:49 |
| mborzecki | zyga: the lzo with xdelta thing pops up on amazon? | 08:51 |
| zyga | mborzecki: yes, when invoked locally | 08:52 |
| zyga | https://www.irccloud.com/pastebin/MKaHiW7M/ | 08:52 |
| pstolowski | pedronis: if the concern is about having a global flag like this vs passing it around, my suggestion is to have it available though the helper first like proposed (in whatever package we find suits best), then replace it with something final after all the bits are in place | 08:54 |
| === msalvatore_ is now known as msalvatore | ||
| pedronis | pstolowski: where exactly is it used in apparmor ? | 08:56 |
| pedronis | in loadProfiles ? | 08:57 |
| pstolowski | pedronis: yes - to have --skip-kernel-load | 08:57 |
| mup | PR snapd#7678 opened: spread: disable secondary compression for deltas <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7678> | 09:14 |
| mborzecki | zyga: ^^ | 09:14 |
| zyga | 1-2-1 | 09:14 |
| zyga | thx | 09:14 |
| pedronis | pstolowski: can we have a quick HO in ~15 ? | 09:16 |
| pstolowski | pedronis: yes | 09:16 |
| pedronis | pstolowski: going to the standup | 09:31 |
| pstolowski | pedronis: ok, coming | 09:31 |
| * Chipaca can't stand up yet | 09:39 | |
| Chipaca | mvo: any feedback on #7669 vs #7670? | 09:43 |
| mup | PR #7669: snap, cmd/snap: support (but warn) deprecated multi-slash channel <Created by chipaca> <https://github.com/snapcore/snapd/pull/7669> | 09:43 |
| mup | PR #7670: cmd/snap: support (but warn) using deprecated multi-slash channel <Created by chipaca> <https://github.com/snapcore/snapd/pull/7670> | 09:43 |
| mup | PR snapd#7635 closed: tests/lib/gendevmodel: helper tool for generating developer model assertions <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7635> | 09:45 |
| pedronis | Chipaca: I haven't looked at them yet? what's the difference between, the summary says they are the same | 09:51 |
| pedronis | Chipaca: do we have code for daemon yet? | 09:52 |
| Chipaca | pedronis: the second one uses channel.Full instead of .Parse, I think it results in simpler code (the explanation is onthe second one, at the end of the description) | 09:53 |
| Chipaca | i'll have the daemon up before the standup today | 09:54 |
| pedronis | ok, thx | 09:54 |
| Chipaca | i think it's the last bit left | 09:54 |
| pedronis | Chipaca: plus reintroducing the code about risk switching | 09:54 |
| pedronis | that we had to revert | 09:54 |
| pedronis | it will probably need a rewrite though | 09:54 |
| Chipaca | pedronis: i wouldn't count that as part of this, but, yes that is also missing | 09:55 |
| Chipaca | pedronis: and then defaults | 09:55 |
| pedronis | yes | 09:55 |
| Chipaca | pedronis: some of this work will need tweaking for defaults, fwiw | 09:55 |
| pedronis | yes | 09:55 |
| Chipaca | as here we always do Full, and on install with defaults we need to not do so | 09:55 |
| Chipaca | i was tempted to do that from the start but thought better leave it simple for now | 09:56 |
| pedronis | Chipaca: no, the Full is probably fine, the question is more where the value comes from | 09:56 |
| Chipaca | anyway, got a meeting coming up, need to set up | 09:56 |
| mvo | Chipaca: was in a meeting | 10:01 |
| mup | PR snapd#7679 opened: many: changes to testing in preparation of Core 20 seed consuming code <Created by pedronis> <https://github.com/snapcore/snapd/pull/7679> | 10:04 |
| mup | PR snapcraft#2771 opened: python plugin: skip download and wheel for local sources <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2771> | 10:09 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/7677 is ready for review | 10:24 |
| mup | PR #7677: interfaces/content: workaround for renamed target <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7677> | 10:24 |
| zyga | mborzecki, pstolowski ^ priority customer bug | 10:25 |
| zyga | trivial code change + tests + rationale | 10:25 |
| pstolowski | zyga: looking | 10:31 |
| zyga | thank you guys | 10:32 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/7677 is green | 10:39 |
| mup | PR #7677: interfaces/content: workaround for renamed target <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7677> | 10:39 |
| pedronis | reviews for #7672 and #7679 would great, they are mostly reorg in preparation of actual Core 20 seed loading code | 10:39 |
| mup | PR #7672: seed: share auxInfo20 and makeSystemSnap via internal <Created by pedronis> <https://github.com/snapcore/snapd/pull/7672> | 10:39 |
| mup | PR #7679: many: changes to testing in preparation of Core 20 seed consuming code <Created by pedronis> <https://github.com/snapcore/snapd/pull/7679> | 10:39 |
| mvo | Chipaca: 7622 is ready for a review (after you finished the other things of course :) | 10:47 |
| Chipaca | mvo: thanks | 10:47 |
| * dot-tobias hi everybody | 10:56 | |
| zyga | mvo: do you want to get a security review for https://github.com/snapcore/snapd/pull/7677 | 11:19 |
| mup | PR #7677: interfaces/content: workaround for renamed target <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7677> | 11:19 |
| zyga | otherwise it's green and we could build a new edge core/snapd snap next | 11:19 |
| zyga | brb | 11:25 |
| mvo | zyga: sounds like we can merge and ask security for a retrospective one | 11:28 |
| mvo | zyga: it will just be on edge | 11:28 |
| mvo | mborzecki: 7302 has a conflict now | 11:33 |
| zyga | mvo: ok, mering | 11:35 |
| mup | PR snapd#7677 closed: interfaces/content: workaround for renamed target <Bug> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7677> | 11:36 |
| zyga | mvo: can you please remind me how to correctly trigger edge build, do I need to just do the snap build request or do I need to ensure the intermediate git is synchronized somehow? | 11:36 |
| mvo | zyga: for the snapd it will all happen automaitcally | 11:41 |
| mvo | zyga: for old school core its spread-cron that needs to merge a git tree first | 11:41 |
| mvo | zyga: https://travis-ci.org/snapcore/spread-cron/branches | 11:42 |
| zyga | mvo: so just "sit tight"? | 11:42 |
| mvo | zyga: and "snapd-vendor-sync" there | 11:42 |
| mvo | zyga: yeah or manually triggering this one | 11:42 |
| mup | PR snapd#7680 opened: daemon: parse and reject invalid channels in snap ops <Created by chipaca> <https://github.com/snapcore/snapd/pull/7680> | 11:50 |
| zyga | there's another thing called snap https://ai.google/research/pubs/pub48630/ | 12:08 |
| zyga | at some point everything will just be called foo, I guess | 12:08 |
| cmatsuoka | hello everyone | 12:15 |
| cmatsuoka | did we have a timezone shift at some point in the past two weeks? | 12:15 |
| cmatsuoka | I see all events in my calendar shifted one hour, and my time zone is correct | 12:16 |
| pstolowski | cmatsuoka: hey Claudio, welcome back! | 12:18 |
| pstolowski | cmatsuoka: yes, we switched from summer time yesterday | 12:20 |
| cmatsuoka | ah ok, I just wanted to make sure everything is consistent and I won't miss any meeting | 12:21 |
| zyga | mvo: refresh-app-awareness just got more complicated | 12:25 |
| zyga | cmatsuoka: hey :) | 12:25 |
| zyga | I need to sync with stgraber | 12:26 |
| mup | PR snapd#7678 closed: spread: disable secondary compression for deltas <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7678> | 12:34 |
| zyga | mvo: I have some ideas on how to fix this | 12:41 |
| zyga | mvo: would love to sync | 12:41 |
| zyga | mvo: feels like a week or two of work though | 12:41 |
| zyga | mvo: but would solve some issues in general without bothering us in the future | 12:41 |
| zyga | mvo, mborzecki: I updated the last comment on https://github.com/snapcore/snapd/pull/7547 with some details | 12:43 |
| mup | PR #7547: many: use a dedicated named cgroup hierarchy for tracking <Created by zyga> <https://github.com/snapcore/snapd/pull/7547> | 12:43 |
| pedronis | zyga: isn't how we do the tracking vs the other bits of awareness orthogonal anyway? | 12:44 |
| zyga | pedronis: some are intersecting, the agent is something we need the cgroup for | 12:45 |
| zyga | pedronis: we can re-design without the agent being present | 12:45 |
| zyga | pedronis: and continue work on the UX without that | 12:45 |
| zyga | pedronis: the cgroup gives us tracking without breaking systemd and a possibility to install the agent | 12:46 |
| pedronis | you mean the release the agent? | 12:46 |
| zyga | yes | 12:46 |
| zyga | I need to stop and think for a moment | 12:46 |
| zyga | on how to proceed | 12:46 |
| zyga | I need to make more tea anyway | 12:47 |
| zyga | perhaps we can work on part of the UX without the agent now and progress towards _a_ solution that would not affect LXD or be affected by LXD | 12:47 |
| zyga | and then integrate this so that the UX works only better | 12:47 |
| zyga | and the backend changes silently behind the scenes once everything is aligned | 12:47 |
| * zyga -> tea | 12:48 | |
| ijohnson | Wait so now the SU is in 1 hr | 12:56 |
| ijohnson | Right? | 12:56 |
| cmatsuoka | ijohnson: yes, it seems so | 12:57 |
| ijohnson | Hmmm | 12:57 |
| cmatsuoka | ijohnson: end of dst in europe | 12:57 |
| ijohnson | cmatsuoka: do you follow daylight savings time? The US switches next week so next week it seems to go back to 8 am local for me | 12:58 |
| ijohnson | But this week it's at 9 am local | 12:58 |
| ijohnson | I saw a few weeks ago on my calendar the time went to 9 AM and was kinda excited at the prospect of having 9 am meetings all winter | 12:58 |
| cmatsuoka | ijohnson: for me it was 10AM local time, now it's 11AM | 12:59 |
| ijohnson | Yeah it was 8 am on Friday now it's 9 am local for me | 12:59 |
| * ijohnson is quite confused that the timezone switch between US and EU don't at least happen at the same time | 13:01 | |
| cachio | mvo, is the standup delayed 1 hour? | 13:02 |
| cachio | I didn't receive the update | 13:03 |
| cachio | it used to be automatic | 13:03 |
| cmatsuoka | cachio: the standup should be 11AM in our timezone | 13:05 |
| cachio | cwayne, yes | 13:06 |
| cachio | cmatsuoka, yes} | 13:07 |
| cwayne | :) | 13:08 |
| Chipaca | cachio: the time didn't change, but the timezone did :) | 13:10 |
| Chipaca | it's all the german farmers fault | 13:10 |
| cachio | hhhehe | 13:11 |
| cwayne | Chipaca: thats who i blame all my problems on tbh | 13:12 |
| cwayne | bad run? german farmers did it. | 13:12 |
| pedronis | I commented a bit on some of the channels PRs, 7670 seems good to me, assuming we don't want a special error msg in 7680 | 13:15 |
| pedronis | Chipaca: ^ | 13:15 |
| === ricab is now known as ricab|lunch | ||
| Chipaca | pedronis: ack | 13:48 |
| Chipaca | cwayne: i haven't run in the last month because of my knee | 13:51 |
| mup | PR snapcraft#2772 opened: remote-build: improve resiliency for https connection issues <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2772> | 13:51 |
| Chipaca | cwayne: also the germans' fault | 13:51 |
| cwayne | Chipaca: thats rough, mine's been wonky as hell lately too | 13:52 |
| cwayne | damn germans | 13:53 |
| Chipaca | cwayne: wonky knees, doo doo doo | 13:54 |
| * cwayne has baby shark stuck in my head now | 13:55 | |
| === ricab|lunch is now known as ricab | ||
| mup | PR snapcraft#2773 opened: build providers: inject snapd snap for latest feature availability <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2773> | 14:51 |
| mup | PR snapcraft#2774 opened: remote-build: architecture handling <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2774> | 14:54 |
| Chipaca | sergiusens: <3 2773 | 14:59 |
| sergiusens | Chipaca: your review would be appreciated :-) | 14:59 |
| mup | PR snapcraft#2775 opened: remote-build: add clean flag <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2775> | 15:10 |
| mup | PR snapcraft#2776 opened: repo: convey proper error message when refreshing to invalid channel <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2776> | 15:37 |
| * cachio lunch | 15:40 | |
| * zyga finished talking to mborzecki and EODs | 16:09 | |
| zyga | mvo: sorry, the UX doc needs to wait, I'm exhausted by the complexity today | 16:09 |
| * mborzecki too | 16:09 | |
| pedronis | cachio: we are getting (again?) errors like: systemctl restart systemd-journald.service | 16:22 |
| pedronis | Job for systemd-journald.service failed. | 16:22 |
| pedronis | See "systemctl status systemd-journald.service" and "journalctl -xe" for details. | 16:22 |
| pedronis | cachio: https://api.travis-ci.org/v3/job/603911307/log.txt | 16:23 |
| Chipaca | pedronis: if we are, i can try my proposed fix this evening | 16:27 |
| Chipaca | pedronis: nearly finished reviewing 7679, but going to go out and do some exercise for a bit, will bbl | 16:34 |
| * Chipaca pokes a few other things before going | 16:37 | |
| mup | PR snapd#7672 closed: seed: share auxInfo20 and makeSystemSnap via internal <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7672> | 16:48 |
| cachio | pedronis, I'll take a look | 16:59 |
| cachio | degville, hey | 17:28 |
| cachio | I just updated the testing blogpost | 17:28 |
| cachio | with the feedback | 17:28 |
| degville | cachio: hello! want me to take a look? | 17:28 |
| cachio | when you have a time could yo uplease take a look | 17:28 |
| cachio | a quick one please | 17:28 |
| degville | cachio: yes, of course - no problem. | 17:28 |
| cachio | degville,thanks!!!! | 17:28 |
| === ijohnson is now known as ijohnson|lunch | ||
| mup | PR snapcraft#2773 closed: build providers: inject snapd snap for latest feature availability <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2773> | 17:55 |
| mup | PR snapcraft#2774 closed: remote-build: architecture handling <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2774> | 17:55 |
| === pstolowski is now known as pstolowski|afk | ||
| === ijohnson|lunch is now known as ijohnson | ||
| degville | cachio: I've just read through your post again - made a few comments on the changes, but really only minor suggestions! | 19:22 |
| cachio | degville, thanks a lot, I'll address them | 19:23 |
| degville | cachio: np! | 19:23 |
| kyrofa | Thanks guys for putting this room together to help us all with host networking (https://ai.google/research/pubs/pub48630/) | 19:32 |
| kyrofa | Google likes snap things. https://github.com/google/snappy | 19:33 |
| Pharaoh_Atem | libsnappy predates snapd, iirc | 19:33 |
| kyrofa | Oh I'm well aware :P | 19:34 |
| ijohnson | jdstrand_: hey is there any reason not to include usr/bin/paste in the base policy? that program is in both core and core18 and doesn't seem to pose any obvious security problems to me and it would simplify some shell scripting I'm doing :-) | 19:51 |
| === jdstrand_ is now known as jdstrand | ||
| jdstrand | ijohnson: hey, no, I'll add it to my list. I plan to do a misc policy updates PR for 2.43 and will add this | 19:55 |
| ijohnson | thanks jdstrand | 19:55 |
| mup | PR snapcraft#2776 closed: repo: convey proper error message when refreshing to invalid channel <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2776> | 20:10 |
| mup | PR snapcraft#2677 closed: erorrs: preserve quotes when printing SnapcraftPluginCommandError <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2677> | 20:13 |
| mup | PR snapcraft#2777 opened: cli: pass channels None when not doing a push --release <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2777> | 20:34 |
| mup | PR snapd#7622 closed: snap: make `snap known --remote` use snapd if available <Needs Samuele review> <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/7622> | 20:38 |
| Chipaca | whoops | 20:38 |
| Chipaca | pedronis: i just noticed yours was not one of the +1's on 7662 :-( | 20:38 |
| mup | PR snapd#7681 opened: tests: add info that could be used to determine why journalctl is failing to restart <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7681> | 20:40 |
| Chipaca | pedronis: any issues you had with it can be addressed in 7624 though so that's probably ok | 20:40 |
| pedronis | Chipaca: I marked myself long ago, mostly because of xerrors | 20:41 |
| pedronis | but then there was a prereq one already landed | 20:41 |
| Chipaca | pedronis: ah ok :) that's sorted with #7667 | 20:41 |
| mup | PR #7667: spread: enable bboozzoo/snapd-devel-deps COPR repo for getting golang-x-xerrors <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7667> | 20:41 |
| pedronis | Chipaca: my other question is how long it takes to fail? | 20:41 |
| pedronis | s/fail/fallback/ | 20:41 |
| Chipaca | pedronis: next to nothing | 20:43 |
| Chipaca | pedronis: there's no retrying, is what i mean | 20:43 |
| pedronis | ok | 20:43 |
| Chipaca | when it's 'the socket isn't there' at least :) | 20:43 |
| pedronis | ah | 20:44 |
| Chipaca | i guess you could have a hung snapd that makes things slower | 20:44 |
| pedronis | anyway that's the main case | 20:44 |
| pedronis | the next one doesn't seem to pay attention to auth though? | 20:44 |
| Chipaca | 7624? | 20:45 |
| pedronis | yes | 20:45 |
| Chipaca | I'm waiting for the master merge before looking at that one | 20:45 |
| * Chipaca lazy | 20:45 | |
| pedronis | ok | 20:45 |
| Chipaca | pedronis: but auth is a quick fail so should be handled ok | 20:45 |
| pedronis | anyway I marked it as I need to look at it | 20:45 |
| Chipaca | i'll be looking out for it in any case | 20:45 |
| pedronis | yea, my point is I don't think the code is looking for it | 20:45 |
| pedronis | atm | 20:45 |
| Chipaca | hmmm | 20:46 |
| Chipaca | i think i reviewed something along those lines in this context | 20:46 |
| Chipaca | a previous pr about download | 20:46 |
| Chipaca | i'll have a dig | 20:46 |
| Chipaca | pedronis: i'll take the dog for a walk before the temperature drops more, then i'll have a look | 20:47 |
| Chipaca | i think it might already be handled but not sure, don't remember exactly | 20:47 |
| Chipaca | anyway, ttfn | 20:47 |
| pedronis | same here | 20:50 |
| pedronis | ttfn | 20:50 |
| mup | PR snapcraft#2772 closed: remote-build: improve resiliency for https connection issues <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2772> | 21:07 |
| mup | PR snapcraft#2777 closed: cli: pass channels None when not doing a push --release <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2777> | 22:40 |
| mup | PR snapcraft#2768 closed: remote-build: autorecovery <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2768> | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!