| kelvinliu | wallyworld: got this pr to fix cm label config, +1 plz, thanks! https://github.com/juju/juju/pull/10815 | 00:19 |
|---|---|---|
| kelvinliu | label conflict | 00:21 |
| wallyworld | kelvinliu: can i get a review on this small fix? https://github.com/juju/juju/pull/10814 | 01:22 |
| kelvinliu | wallyworld: yep, looking | 01:22 |
| kelvinliu | wallyworld: lgtm thanks đź‘Ť | 01:28 |
| wallyworld | thumper: by "k8s" workload, do you mean charmed kubernetes bundle deployed to the specified cloud? | 01:49 |
| thumper | yes | 01:49 |
| thumper | it is more than trivial but not extreme like openstack | 01:49 |
| wallyworld | i might clarify | 01:49 |
| thumper | ok, thanks | 01:49 |
| wallyworld | also, i think kubernetes-core bundle will do | 01:50 |
| * thumper nods | 01:50 | |
| thumper | that deploys on lxd? | 01:50 |
| wallyworld | charmed kubernetes takes twice as long to settle | 01:50 |
| wallyworld | juist has HA componenets etc | 01:51 |
| wallyworld | yeah | 01:51 |
| wallyworld | last time i looked which was ages ago | 01:51 |
| wallyworld | kubernetes-core is just a slimmed down charmed k8s | 01:51 |
| babbageclunk | thumper: got a bit fiddlier than expected - not sure what to put in QA steps without suggesting commenting out Unwatch calls from a watcher. https://github.com/juju/juju/pull/10816 | 03:02 |
| thumper | babbageclunk: thanks | 03:02 |
| * thumper looks | 03:02 | |
| * thumper waves at alexisb | 03:43 | |
| hpidcock | wallyworld: I just realised that changing how we handle actions on k8s will prevent the --operator functionality of juju exec while the workload is initialising, for example if it got stuck or took a long time this could be an issue. Also might make implementing hooks that run on the workload more difficult. | 04:12 |
| hpidcock | so I'm not sure the new solution is better than the one we already ahd | 04:12 |
| wallyworld | hpidcock: did you want a HO to discuss | 04:15 |
| hpidcock | sure | 04:15 |
| anastasiamac | wallyworld: thumper https://github.com/juju/juju/pull/10817 | 05:06 |
| wallyworld | kelvinliu: this ensure all k8s resources have the expected juju annotations https://github.com/juju/juju/pull/10818 | 05:30 |
| kelvinliu | looking | 05:31 |
| wallyworld | anastasiamac: i got a question, quick HO | 05:35 |
| wallyworld | ? | 05:35 |
| anastasiamac | k | 05:35 |
| anastasiamac | m back in 1:1 | 05:36 |
| wallyworld | anastasiamac: sorry, got to restart chrome, one sec | 05:36 |
| anastasiamac | k | 05:36 |
| kelvinliu | wallyworld: so just want set annotations on all resources, but don't use them yet, right? | 05:41 |
| wallyworld | kelvinliu: nothing in code uses them. it's the same as for iaas. it's a way to mark resources created in the cloud as belonging to a particular controller, or adding user specified tags so they can look at a cloud dashboard and see certain annotations | 05:43 |
| wallyworld | or they might write a script to loist all resources with certain tags that match model config | 05:43 |
| kelvinliu | ok, lgtm, thanks | 05:43 |
| wallyworld | tyvm | 05:43 |
| wallyworld | anastasiamac: +1 with fixes | 06:27 |
| anastasiamac | wallyworld: m about to commit another one.. and will address ur comments.. ta | 06:28 |
| wallyworld | anastasiamac: let me know if i'm on crack etc with anything | 06:29 |
| wallyworld | hopefully it all makes sense | 06:29 |
| anastasiamac | u mean with respect to comments or in general? :-P | 06:31 |
| wallyworld | both | 06:32 |
| wallyworld | kelvinliu: any blockers with the custom resources? don't forget to include annotations :-) once my PR lands, you can copy of that | 06:36 |
| kelvinliu | wallyworld: still a bit early to see if there are any blockers.. | 06:36 |
| wallyworld | no worries | 06:37 |
| kelvinliu | but got some ideas | 06:37 |
| anastasiamac | wallyworld: k, committed my last wish... looking at ur comment to determine the presence of crack in ur bllodstream | 06:50 |
| wallyworld | we'll see... | 06:51 |
| hpidcock | wallyworld: still need to finish off unit tests, but you can take a look at the updated pr if you want https://github.com/juju/juju/pull/10807 | 07:19 |
| wallyworld | ok | 07:20 |
| madsage | good morning | 07:24 |
| anastasiamac | wallyworld: addressed all... heading for landing and m loking at ur pr before/during/after dinner | 07:46 |
| wallyworld | ty, can wait till tomorrow | 07:46 |
| anastasiamac | \o/ excellent I'll look tomorrow then :D | 07:46 |
| wallyworld | so long as we land before EOD | 07:47 |
| anastasiamac | yep... m hoping i'll land mine tonight so that u can rebase urs in the mornig and can review the rebased version :D | 07:47 |
| wallyworld | sgtm | 07:47 |
| wallyworld | i'll watch yours and rebase | 07:47 |
| anastasiamac | \o/ | 07:47 |
| nammn_de | morning manadart: is the activeBranch a local concept? Or do we also save it on the jujud/mongo side? | 09:55 |
| manadart | nammn_de: Morning. It is local. See: ~/.local/share/juju/models.yaml | 09:56 |
| nammn_de | manadart: 🦸 | 09:56 |
| nammn_de | manadart: juju/core/cache is jujud side cache, right? | 10:10 |
| manadart | nammn_de: It runs on controllers. The cached model is accessible from API server facades. | 10:11 |
| nammn_de | manadart: /cmd/* is everything related to the cli (juju) /apiserver/* is everything related to jujud agent (facade server, cache, ..)? | 10:16 |
| manadart | nammn_de: cmd has sub-packages for the CLI (juju) and agents (jujud). apiserver has sub-packages for facades that are accessible by clients/controllers/agents. The API server itself serves the facades, so the cached model is available to all of them. | 10:20 |
| nammn_de | manadart: uff, i need to let that sink and play a little. Thanks that helps a lot! | 10:21 |
| nammn_de | hey hml I tried to incorporate your suggestions. Was not 100% sure whats the best way as activebranch is a local information. https://github.com/juju/juju/pull/10796#discussion_r339236147 | 12:20 |
| hml | nammn_de: rgr, i’ll take a look now | 12:20 |
| hml | nammn_de: i was thinking that it wasn’t local only. but it appears to be after all. therefore the suggestion isn’t usable. :-D | 12:25 |
| === fenris is now known as Guest55271 | ||
| nammn_de | hml: ok :D, but I still tried to incorporate it a little and added it to the branchstatus struct in formatter and thus could remove it from the other struct, so less usage | 12:56 |
| hml | nammn_de: i saw. working on qa now to answer some questions of my own. | 12:57 |
| nammn_de | hml: ahh sure, no pressure | 12:57 |
| hml | nammn_de: i’m having not enought coffee syndrome trying to qa this morning. sorry! | 12:58 |
| nammn_de | rick_h: if you have some boring spare time : https://github.com/juju/juju/pull/10796 :D | 15:09 |
| manadart | nammn_de: Can I get you to QA this one? https://github.com/juju/juju/pull/10821/ | 15:09 |
| nammn_de | manadart: can do | 15:09 |
| hml | manadart: what does colures mean how you’ve used in a commit msg? google gives me a defintion related to equinoxes/solstices. :-) | 15:51 |
| manadart | hml: Which message? Might be a typo :) | 15:52 |
| hml | manadart: “Explicitly ignores errors for defered iterator colures in migration_import” sha 92308d3 | 15:52 |
| manadart | hml: Meant "closures". | 15:53 |
| hml | manadart: :-) | 15:58 |
| hml | manadart: reviewed 10821 left 2 comments. approval tic is up to whomever QA’s. | 15:59 |
| nammn_de | manadart: how can I check the `machine address space IDs` ? | 16:00 |
| manadart | nammn_de: Connect to Mongo and run db.machines.find().pretty(). See https://discourse.jujucharms.com/t/login-into-mongodb/309 | 16:01 |
| manadart | nammn_de: Appologies; too vague on QA steps. | 16:02 |
| nammn_de | manadart: does that mean, I bootstrap your code as maas1 -> save machineaddressspace; bootstrap your code as maas2; migrate mode maas1 to maas2 and check machineaddressspace of maas1 and maas2 are the same? | 16:05 |
| nammn_de | manadart: just read my test, its confusing. Here is mine in better: https://pastebin.canonical.com/p/kYxSKsKKx8/ | 16:08 |
| manadart | nammn_de: This is from my history: https://pastebin.canonical.com/p/wrpRTSvxkS/ | 16:10 |
| nammn_de | manadart: you my hero | 16:10 |
| nammn_de | thanks gonna test | 16:10 |
| nammn_de | im +1 for pasting history into qa steps, makes it for beginner, like me, easier | 16:11 |
| nammn_de | :D | 16:11 |
| hml | rick_h: manadart what do you think about renaming the model config “default-space” to “default-endpoint”? or at least within the code. It gets very confusing what the value is once you’re out of config code. | 16:29 |
| rick_h | hml: the endpoint is the thing in the charm (http or such) so not sure about default-endpoint. If internally to the code something like default-space-for-binding or something makes more sense/use I could see it | 16:30 |
| rick_h | hml: but it's a bit much for the operator in model-config imo, they get to cheat though and have a description and such in there | 16:30 |
| hml | rick_h: right… just inside the code… will cause problems long term i think. and get confused with other concepts | 16:31 |
| rick_h | hml: understand | 16:32 |
| manadart | rick_h hml: Now that there is no default for the model config value, I expect references to the default space name to dry up in favour of the config... | 16:46 |
| rick_h | manadart: right, but at least then there's one place to look and it'll notice when there is a value in place | 16:48 |
| rick_h | manadart: or am I missing a link? | 16:48 |
| rick_h | manadart: in the end the config is the "single source of truth" vs having a flag on the space struct "what's the default one from the list"? or really back to implementation detail | 16:49 |
| hml | manadart: it’s still confusing to have this thing config.DefaultSpace(). running around the code for now. | 16:49 |
| hml | not to be confused with what we’ve been calling the default space. or empty space. | 16:50 |
| hml | it can always be changed back once we’re gotten to the end of this project. | 16:51 |
| manadart | rick_h, hml: I can't see the issue. We now have the alpha/starter space, and the model config for the default. | 16:52 |
| manadart | Just change the current default consts. AlphaSpaceID, AlphaSpaceName or some such. | 16:53 |
| nammn_de | manadart: i did the qa, same version worked. Upgrade as well, but not sure about one output here: https://pastebin.canonical.com/p/PjNWFB7Vjd/ there is one space_id=1 | 16:53 |
| hml | manadart: pondering | 16:54 |
| manadart | nammn_de: Yeah, if the instance poller runs, it will update the address space from MAAS. Probably better to have done it on another substrate. | 16:54 |
| hml | manadart: i’ll try the AlphaSpaceName change, that might get us away from thinking that the space with ID 0 is a true default. | 16:58 |
| bdx | hello, I am working at the dc with our a few of our engineers today. We are trying to figure out how to enable juju to deploy workloads on a bare metal k8s, and having issues getting operator and workload storage configured correctly it seems. Wondering if anyone has experience in configuring workload and/or operator storage for a bare metal k8s? | 18:40 |
| rick_h | bdx: I saw that folks were saying that they tend to do that with a file service on discourse but not setup on bare metal since the workloads are tied to the storage locations on the node | 18:59 |
| bdx | rick_h: I see | 19:01 |
| bdx | we have the rbd provisioners configured https://paste.ubuntu.com/p/HsNjtNYrCy/ | 19:03 |
| bdx | we are trying to make sense of how to get juju use either of those storage pools for workload and operator storage | 19:04 |
| bdx | we have followed this document through multiple times https://discourse.jujucharms.com/t/setting-up-static-kubernetes-storage-tutorial/1193 | 19:05 |
| bdx | as well as a few others | 19:05 |
| bdx | we will be cycling on this today and the rest of the week, I'll report back with findings | 19:07 |
| bdx | there seems to be a few good docs on juju/k8s storage out there, its just that none of them show the full picture (start to finish) of adding storage and getting a workload to run using that storage | 19:13 |
| bdx | I feel like we are really close ... | 19:13 |
| bdx | in getting hostpath and rbd provisioners to work | 19:13 |
| bdx | going to keep at it, can't be too far off | 19:14 |
| === Cynerva_ is now known as Cynerva | ||
| bdx | heres what we did to get it working https://discourse.jujucharms.com/t/k8s-on-metal-storage-configuration-for-use-with-juju/2281/4?u=jamesbeedy | 21:50 |
| anastasiamac | timClicks: do we have 2.7-rc release notes or do I need to update existing 2.7-b1 | 23:01 |
| anastasiamac | timClicks: nm | 23:10 |
| wallyworld | hpidcock: can i get a review on this PR. it's a simple approach without requiring environ version (which gets messy and is a lot more work; i'd rather keep it up our sleeves for other things) https://github.com/juju/juju/pull/10819 | 23:13 |
| hpidcock | Np, give me a seond, making coffee | 23:15 |
| anastasiamac | wallyworld: a trivial change, PTAL https://github.com/juju/juju/pull/10826 | 23:33 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!