/srv/irclogs.ubuntu.com/2019/11/01/#juju.txt

kelvinliuhpidcock: we only sync charm files, jujud to workload pod now, right?02:58
kelvinliuin init container stage?02:58
hpidcockcharm files + ca.crt + operator.yaml02:58
hpidcockjujud is copied from the init-container's image02:58
kelvinliuwhat happens if we have a 2.6 model, we upgrade to 2.7, the workload pods does't re-init.02:59
kelvinliuso all files are missing, we won't be able to run actions stuff unless all pods are killed and re-init03:00
kelvinliui think we still check if all dependencies are there or not before running an action. if no, syncs files first.03:03
kelvinliuinit container is like a performance enhancement, but we can't just rely on it to provide the deps.03:04
hpidcockno we don't copy over anything in the exec anymore. wallyworld: safe to assume 2.6 models don't support running actions?03:06
hpidcockprobably should add a block for that03:06
hpidcockcheck*03:06
wallyworldhpidcock: kelvinliu: yeah, k8s actions not supported in 2.603:07
wallyworldto test the actions upgrade issue, will need to use a iaas model03:08
hpidcockwallyworld: should we add a check to make sure actions don't run on 2.6 models for CAAS?03:08
hpidcocktechnically exec should work, you just won't be able to use juju-run03:09
kelvinliuproblem here is 2.7 models were upgraded from 2.6 won't be able to run actions as well03:09
hpidcockor other actions03:09
wallyworldwe could add a check03:09
wallyworldwhy won't upgraded 2.7 models fail?03:09
wallyworld*work03:09
hpidcockthe 2.6->2.7 models should be able to run actions since the deployment/statefulset will change with the new operator image on the init-container03:13
kelvinliunot sure why my mariadb wasn't re-init03:15
hpidcockcould have been timing, but that is concerning03:17
kelvinliuEnsureService is only called if podspec has changes, right?03:20
kelvinliuor it's not called03:21
wallyworldthat is the idea but when the agent restarts it loops through everything03:21
wallyworldthe check is done for pod-spec-set03:21
kelvinliugood, good. i think it's just a bit delayed. ignore me, plz! 😃03:27
hpidcockscaring me half to death haha, I already have nightmares that the pod-init doesn't work 😨03:30
kelvinliuhahaha sorry for scared u... 😂03:41
wallyworldhpidcock: this is the fix for add-k8s https://github.com/juju/juju/pull/1084204:29
hpidcockwallyworld: on it04:29
kelvinliuwallyworld: this is the fix for actionID, https://github.com/juju/juju/pull/10841 thanks!04:48
wallyworldlooking04:49
wallyworldkelvinliu: lgtm, would be good to do a test on an iaas model04:55
kelvinliuyep04:56
hpidcockwallyworld: one problem with https://github.com/juju/juju/pull/1084205:34
anastasiamacwallyworld: kelvinliu: https://github.com/juju/juju/pull/10843 - to addres add-k8s with pipe output :D06:14
wallyworldyay looking06:14
anastasiamacat the end was very simple... i was petrified that i'd have to write a complex test but it was a breeze (thnx to a kind sould that did smth similar) :D06:15
wallyworldhpidcock: ah yes, i had it as the k8s types but changed at last minute06:15
wallyworldwill fix06:15
anastasiamac(and I mean kelvinliu of course!)06:15
anastasiamacwhen i say a 'kind soul'06:16
wallyworldlgtm ty06:17
kelvinliuanastasiamac: lgtm as well, thanks! 😊06:17
anastasiamactvym!!06:21
hpidcockwallyworld: let me know when that change is up, I was unable to finish my testing06:25
wallyworldhpidcock: changes up, i just tested with microk8s again. external will not work until we allow externalName to be passed in. but loadbalancer works06:40
wallyworldwhich is the main bit06:40
hpidcockLGTM06:45
wallyworldyay ty06:47
wallyworldi'll just do a bit more testing06:47
timClickswallyworld: pr 10842 will be an absolute game changer07:35
wallyworldi guess so. the fact it was broken was because we really only tested with public k8s, microk8s, or cdk07:56
wallyworldanything that adds new clusters to the mix is good07:57
wallyworldbe interesting to see any uptick in interest07:57
=== grumboo is now known as grumble

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!