[02:58] hpidcock: we only sync charm files, jujud to workload pod now, right? [02:58] in init container stage? [02:58] charm files + ca.crt + operator.yaml [02:58] jujud is copied from the init-container's image [02:59] what happens if we have a 2.6 model, we upgrade to 2.7, the workload pods does't re-init. [03:00] so all files are missing, we won't be able to run actions stuff unless all pods are killed and re-init [03:03] i think we still check if all dependencies are there or not before running an action. if no, syncs files first. [03:04] init container is like a performance enhancement, but we can't just rely on it to provide the deps. [03:06] no we don't copy over anything in the exec anymore. wallyworld: safe to assume 2.6 models don't support running actions? [03:06] probably should add a block for that [03:06] check* [03:07] hpidcock: kelvinliu: yeah, k8s actions not supported in 2.6 [03:08] to test the actions upgrade issue, will need to use a iaas model [03:08] wallyworld: should we add a check to make sure actions don't run on 2.6 models for CAAS? [03:09] technically exec should work, you just won't be able to use juju-run [03:09] problem here is 2.7 models were upgraded from 2.6 won't be able to run actions as well [03:09] or other actions [03:09] we could add a check [03:09] why won't upgraded 2.7 models fail? [03:09] *work [03:13] the 2.6->2.7 models should be able to run actions since the deployment/statefulset will change with the new operator image on the init-container [03:15] not sure why my mariadb wasn't re-init [03:17] could have been timing, but that is concerning [03:20] EnsureService is only called if podspec has changes, right? [03:21] or it's not called [03:21] that is the idea but when the agent restarts it loops through everything [03:21] the check is done for pod-spec-set [03:27] good, good. i think it's just a bit delayed. ignore me, plz! 😃 [03:30] scaring me half to death haha, I already have nightmares that the pod-init doesn't work 😨 [03:41] hahaha sorry for scared u... 😂 [04:29] hpidcock: this is the fix for add-k8s https://github.com/juju/juju/pull/10842 [04:29] wallyworld: on it [04:48] wallyworld: this is the fix for actionID, https://github.com/juju/juju/pull/10841 thanks! [04:49] looking [04:55] kelvinliu: lgtm, would be good to do a test on an iaas model [04:56] yep [05:34] wallyworld: one problem with https://github.com/juju/juju/pull/10842 [06:14] wallyworld: kelvinliu: https://github.com/juju/juju/pull/10843 - to addres add-k8s with pipe output :D [06:14] yay looking [06:15] at the end was very simple... i was petrified that i'd have to write a complex test but it was a breeze (thnx to a kind sould that did smth similar) :D [06:15] hpidcock: ah yes, i had it as the k8s types but changed at last minute [06:15] will fix [06:15] (and I mean kelvinliu of course!) [06:16] when i say a 'kind soul' [06:17] lgtm ty [06:17] anastasiamac: lgtm as well, thanks! 😊 [06:21] tvym!! [06:25] wallyworld: let me know when that change is up, I was unable to finish my testing [06:40] hpidcock: changes up, i just tested with microk8s again. external will not work until we allow externalName to be passed in. but loadbalancer works [06:40] which is the main bit [06:45] LGTM [06:47] yay ty [06:47] i'll just do a bit more testing [07:35] wallyworld: pr 10842 will be an absolute game changer [07:56] i guess so. the fact it was broken was because we really only tested with public k8s, microk8s, or cdk [07:57] anything that adds new clusters to the mix is good [07:57] be interesting to see any uptick in interest === grumboo is now known as grumble