[00:25] PR snapcraft#2795 opened: manifest: track and annotate `primed-stage-packages` [01:49] hm core refreshed and now google-play-music-desktop-player broke? [06:35] morning [06:38] Hey mborzecki [06:38] Please read the review I got from Jamie [06:39] We need to discuss this [06:39] zyga: hey hey, i've landed the fix for master yesterday, so please update your PRs if needed [06:39] Perhaps at 8:30? [06:39] mborzecki: will do [06:39] zyga: yeah, 830 sounds fine [06:47] zyga: duh, epel8 build failed on s390x :/ [06:50] mborzecki: order one to debug at home ;D [06:50] haha [06:51] mborzecki: I rebased and pushed on https://github.com/snapcore/snapd/pull/7726 [06:51] PR #7726: RFC: change how snapd tracks processes [06:51] the other two can wait, we need to discuss them first [06:52] mborzecki: I also enabled f31 locally and confirmed 7726 *passes* there [06:53] zyga: nothing we can fix though https://kojipkgs.fedoraproject.org//work/tasks/4109/38804109/root.log Eighth_Doctor probably knows if this is being addressed [06:54] yeah, let's ignore that [07:06] brb [07:18] hmm mvo isn't around yet [07:19] * zyga adds test for https://github.com/snapcore/snapd/pull/7724 [07:20] PR #7724: cmd/snap-confine: tracking processes with classic confinement [07:20] mborzecki: I have a swap day for Friday [07:20] mborzecki: I'll get a swap day for Monday at the sprint [07:20] mborzecki: and two days for travel [07:20] mborzecki: but I have a feeling I wont ever take them :/ [07:20] that's nearly a swap week now [07:20] unlimited company vacation? :) [07:21] zyga: btw. with your tweek from yday, it looks like you're prepping up fro the 4-day working week, tryign to squeeze 5 days worth of work into 4 days :P [07:21] and the productivity is up :) [07:22] :D [07:22] I wish I had 4 day week [07:22] or that 5 hour workday [07:22] I feel tired lately [07:31] mvo: morning [07:31] hey mvo [07:32] hey mborzecki and zyga [07:32] mvo: it's been a long evening [07:32] mvo: pinged you in https://github.com/snapcore/snapd/pull/7721 could use your input there [07:32] PR #7721: gadget: add support for hybrid partitioning schemas <⛔ Blocked> [07:32] https://github.com/snapcore/snapd/pull/7722 :) [07:32] PR #7722: cmd/snap-confine: add sc_join_sub_group [07:32] mborzecki: thanks, I have a look [07:42] PR snapd#7652 closed: o/ifacestate,interfaces,interfaces/policy: slots-per-plug: * [07:46] * zyga -> breakfast [07:54] * zyga pushed a patch to https://github.com/snapcore/snapd/pull/7724 and now _really_ does breakfast [07:54] PR #7724: cmd/snap-confine: tracking processes with classic confinement === pstolowski|afk is now known as pstolowski [08:07] mornings [08:08] pstolowski: hey [08:50] * zyga breaks to rest for a while [09:06] * dot-tobias hey all [09:08] hey dot-tobias :) [09:10] hi, I'm getting an error when running snap commands (and in the snap service as well) about meta/snap.yaml not being found. but the file is obviously there [09:14] this is from a "snap try" [09:16] ackk: is it visible from the preserved mount namespace? [09:16] ackk: to find out: sudo nsenter -m/run/snapd/ns/maas.mnt [09:16] ackk: stat /snap/maas/current/meta/snap.yaml [09:18] zyga, it's not maas this time :) [09:18] ackk: /o\ :D [09:18] zyga, stat fails [09:18] zyga, (it's canonical-rbac) [09:18] now you can explore what is there [09:19] zyga, https://paste.ubuntu.com/p/V9mn5GZztg/ [09:20] check what is mounted there [09:20] zyga, from within the ns or outside? [09:21] zyga, from outside I see nsfs on /run/snapd/ns/canonical-rbac.mnt type nsfs (rw) [09:22] ackk: inside, where it is broken please [09:22] mvo: core 2.42.1 has been in candidate since Monday, will it get promoted to stable this week or did someone discover issues? Asking for an anxious stakeholder 😊 [09:23] zyga, https://paste.ubuntu.com/p/FG4g8mBRNX/ [09:24] PR snapd#7727 opened: tests: improve TestDoPrereqRetryWhenBaseInFlight to fix occasional flakiness [09:25] ackk: and on the host? [09:25] zyga, https://paste.ubuntu.com/p/6GqMpSKWVt/ [09:25] zyga, note, this is in a bionic container [09:25] (on disco as host) [09:26] right [09:26] ideally compare what is mounted where you see the snap.yaml [09:26] and what is mounted where you don't [09:29] zyga, so the /snap directory inside is empty apart from those 2 files, which seems broken? [09:35] dot-tobias: it was planned to go to stable yesterday, I need to check what happend, worst case is that it gets promoted this monday [09:45] mborzecki: so [09:46] mborzecki, mvo: that branch can be scrapped [09:46] but we can do something else still that's supported by systemd [09:46] ogra: https://snapcraft.io/beebeep - you gonna update that? looks like a new release in edge? [09:46] but snap-confine will depend on dbus [09:46] and will require to use dbus to talk to systemd to run anything that is not a service [09:46] and will need to know if something is a service or not [09:46] that's the status quo [09:47] zyga: hm reading #fedora-devel now [09:47] zyga: ehh, so dbus and scope then? [09:47] yes [09:47] no other way [09:47] damn, that sucks [09:48] I'm trying to pull some documentation that's better than just reading the source [09:48] zyga: so if i'm reading this right, fire up transient scope, wait for it, then move the process to that scope right? [09:48] yes [09:48] StartTransientUnit and AttachProcessesToUnit [09:49] and it should be a scope, not a slice, for the reasons I gave on #fedora-devel [09:49] hm not exactly something we can simulate as separate steps in systemd-run [09:49] mborzecki: wanna jump into this? :) [09:50] zyga: fixing up the f31 pr, but let's sync afterwards maybe? [09:50] sure [09:50] I was supposed to rest anyway [09:50] ogra: in fact there's an even newer upstream release. 5.8.2 - you should setup automatic builds :D [09:50] zyga: btw. one scope per user right? [09:51] if only there was a service for automated snap builds [09:51] PR pc-amd64-gadget#23 opened: Add missing partitions and improve grub.cfg-recovery [09:51] mborzecki: I don't know yet [09:51] mborzecki: I think ... not [09:51] mborzecki: I thik it's just one scope if I'm right [09:51] but let me write a prototype first [09:51] zyga: https://gist.github.com/bboozzoo/76b1535c93686a27bb7fdbaad0f560f7#user-process some notes from before [09:52] zyga: there's even a note about separate scope for snaps [10:07] mvo: Thanks for the update! (re Core update release) [10:53] mvo: btw i've been puzzling over this 'have two grub.cfg' and i'm not sure i understand it [10:53] doh, "{\"error_list\":[{\"code\":null,\"message\":\"Nonce is missing or [10:54] pstolowski: where was that? [10:54] Chipaca: https://api.travis-ci.org/v3/job/608640768/log.txt [10:54] Chipaca: google:fedora-30-64:tests/main/selinux-lxd [10:55] pstolowski: log seems truncated [10:55] anyway, i guess we need to retry those :-/ [10:55] Chipaca: ah i restarted the job assuming .txt would be kept [10:56] no worries [11:01] popey, yeah, will update it... i asked upstream about taking it over but he didnt reply (we actually had an active conversation that somehow died from his side) [11:02] Chipaca: in a meeting right now [11:02] Chipaca: but happy to talk to talk after [11:02] ogra: cool. i wanted to pimp it on the snapcraft social account [11:02] but don't want to do that if it's not up to date [11:02] great, i'll test the edge version today and will promote it if it works [11:03] popey: ogra: maybe pimping it is the push needed for them to take it on? [11:03] yeah, perhaps [11:03] well, once we pimp it, the numbers will rise [11:03] it already has quite a few installs, but I think we can probably double it [11:03] the numbers are pretty high already ... i think its my most downloaded snap atm [11:03] I had never heard of it before today [11:04] did you know you can tell if it's your most downloaded by going to https://snapcraft.io/snaps [11:04] (an it still has one prob ... it doesnt beep :P ... ) [11:04] it shows a graph at the top [11:04] yeah [11:04] https://usercontent.irccloud-cdn.com/file/IQu0dsu0/Screenshot%20from%202019-11-07%2011-04-27.png [11:05] 90k ? [11:05] whats that ? [11:05] ogra: popey: maybe update the description so it doesn't say you need to unzip it? [11:05] yeah :) [11:05] one of yours [11:05] Chipaca, lol, thanks, will do [11:05] no, not mine. just one i have access to [11:06] I bet diddledan has a nice looking graph on his page :) [11:06] (that snap was actually the result of an ubuntu-users ML discussion... i only invested like 30min into it to prove how quick one can make a snap out of 3rd party SW) [11:06] (higher than any of mine) [11:06] nice [11:06] put another 30 mins in :) [11:06] nah, rather 1h or two [11:06] it never really got polished [11:06] is it a pulseaudio problem? [11:07] ok, I won't pimp it till you get audio and the theme looking a bit less.... Windows 95 [11:07] it uses some KDE audio lib [11:07] maybe use the kde frameworks snap [11:07] some outdated thing ... [11:07] to re-use their libs [11:07] oh, arts? [11:07] no, the thing after arts [11:07] something with q or p ... i forgot the name [11:08] phonon ! [11:08] ah yes [11:08] jdstrand: some news [11:08] jdstrand: bad news: we cannot do what I did in that PR [11:08] See, this is one thing I love about snaps, is preserving this old crap :) [11:08] haha [11:08] see also: mosaic [11:08] jdstrand: good news: we can ask systemd to do exactly that for us [11:09] jdstrand: bad news: it requires us to talk to systemd over dbus [11:09] jdstrand: good news: it really works [11:09] mosaic has nearly 300 installs. Lunatics :) [11:09] jdstrand: good news: it does not change the snapd sice of the task much, the only difference is that the location is a scope so it looks like snap.foo.bar.scope [11:10] jdstrand: bad news it's somewhat racy, we need to create a transient unit with the pid of the process we want to have [11:10] jdstrand: and if that fails we instead need to attach process to the scope [11:10] jdstrand: if that fails we need to retry creating the unit [11:11] popey, well, it is one of these things you install, try out once and forget [11:11] true [11:12] * popey schedules a tweet about mosaic for 7th January, when it will be 23 years old [11:12] i'm sure i have an idling mosaic install on one of my machines that i only tried once [11:13] * popey looks at Chipaca [11:13] * popey looks at the wikipedia page for netscape navigator [11:13] * popey looks back at Chipaca [11:14] popey: I know! [11:14] :D [11:14] popey: but the on-disk filesystem seems to be incompatible :-( [11:14] I need to give it a weekend [11:14] popey: something changed _on disk_ since the libc5 days [11:14] at least that's what the errors tell me [11:14] popey: HOWever, mosaic isn't the oldest software in the store :) [11:14] the birthday is 21s February, so you have until then :) [11:15] oh? [11:15] popey: mosaic is from 1993 [11:15] popey: simcity is from 1989 [11:15] is simcity in the store? [11:15] obvs [11:15] i didnt find it [11:16] popey: 'micropolis' [11:16] oh! [11:16] popey: simcity is (tm) ea [11:16] popey: micropolis is a build from the now-free-software simcity code [11:16] clever [11:16] * popey hugs diddledan [11:16] * popey gets that on the hype train [11:17] one of the nicest things about these old-as-hat things is that they're tiny :) [11:17] bah [11:17] $ beebeep [11:17] ln: failed to create symbolic link '/home/ogra/snap/beebeep/13/.config/gtk-2.0/gtkfilechooser.ini': File exists [11:18] /snap/beebeep/13/beebeep: error while loading shared libraries: libxcb.so.1: wrong ELF class: ELFCLASS64 [11:18] so that requires some actual work it seems [11:19] ogra: the elves class war! sounds like a socialist dystopia d&d thing [11:20] man, spread suite on f31 is messy [11:20] it's like the stuff breaks in most akward ways [11:24] quick errand, back in 30 [11:40] * zyga lunch [11:41] Chipaca: back now, if you want we can have a quick HO (now or later) about the two grubs/uc20 etc [11:41] Chipaca: s/now/in 5min/ :) [11:42] mvo: digging into some bugs atm [11:42] mvo: didn't we land a fix to allow snapd in a model? [11:42] in fact this model here has snapd [11:47] crap .. the new beepeep will need core18 ... [11:48] ogra: everybody's on core18 these days [11:48] doh #2, x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" [11:49] pstolowski: _where_ are those coming from?! i got the too, a few days ago [11:49] Chipaca: https://api.travis-ci.org/v3/job/608640768/log.txt (not restarting it this time ;)) [11:49] Chipaca: seems that those debian-sid tests failed because of that [11:50] yeah [11:51] pstolowski: i've raised it with the store, but please let me know if you see it again (and in what distro) [11:52] it might be a broken CA wotsit on debian, for all i know [11:53] Chipaca: uhmm. going to restart it again [11:53] pstolowski: k [11:54] PR snapd#7470 closed: DRAFT: core20 snap install [11:56] cmatsuoka: 👋 [11:56] Chipaca: hello [11:56] Chipaca: yeah, snapd should work, I think we are at the point now where the next missing piece is the extraction of the kernel [11:56] cmatsuoka: do you know if, as well as the kernel, we need to have the initrd extracted for secure boot? [11:56] hey cmatsuoka ! good morning :) [11:57] mvo: hi. good morning. I just closed #7470 because all parts are handled elsewhere, I hope you don't mind [11:57] PR #7470: DRAFT: core20 snap install [11:57] Chipaca: my understanding is ( cmatsuoka please correct me if I'm wrong) that the uc20 kernel will be a single file with an embedded initrmafs [11:57] ahhhh [11:58] cmatsuoka: yeah, thats great [11:58] i was just thinking / remembering the days of single-blob kernel+initramfs (on a floppy) [11:58] Chipaca: I'm not sure this is the case today though, I need to check [11:58] Chipaca: haha - it all comes back (what is a floppy btw?) [11:58] mvo: that thing that looks like a vending machine [11:59] Chipaca: lol [11:59] Chipaca, mvo: yes, I think the idea is still to have a single file [11:59] mvo: that was in reference to this, btw: https://mobile.twitter.com/fea0er/status/1160099135569063936 [12:00] Chipaca, cmatsuoka I just extracted the pc-kernel snap and it looks like at least today there is still an initramfs :/ [12:00] Chipaca, mvo: at that time I was probably rebuilding my kernels to avoid using initrds [12:01] cmatsuoka: dhcp in the kernel, but tinyX in the initrd [12:03] hm, let me try something :-) [12:06] mvo, Chipaca: I didn't check the latest kernel snap but a few weeks ago it was quite outdated, I had to inject newer versions to run those entropy and crash tests [12:12] cmatsuoka: thanks, thats good to know [12:18] zyga: I filed a bug report about it: https://pagure.io/releng/issue/8977 [12:19] ok, i'm going out for a bit [12:20] * zyga goes to implement the new thing [12:24] mvo: looks like having an embedded initramfs means recompiling the kernel every time you need to change the initramfs [12:24] it's not just appending one to t'other [12:24] Chipaca: uh, that will make testing very inconvenient [12:24] yes [12:25] maybe there's a workaround, none of this is too well documented [12:26] anyway, i really need to step out for a bit :) [12:26] * Chipaca goes, now [12:26] Eighth_Doctor: thanks! [12:27] re [12:28] Eighth_Doctor: so releng is the right place for problems like this? [12:28] usually, yes [12:29] it means something went wrong when the packages were imported from the Red Hat CDN into Koji [12:29] Eighth_Doctor: got it! [12:38] Chipaca: silly question, I thought the uefi grub has regexp build-in, I boot with -bios ...OVMF.fd but I dont't get regexp in my grub. did I misundersttood? [12:38] Chipaca: anyway, not urgent, need to get lunch first :) [12:39] hmm ... diddledan do you know anything about the alsa-libs part not working on build.s.io ? seems it stumbles over the ftp url [12:39] works fine locally [12:42] * pstolowski lunch [12:54] ok, here we go ... switching to http download helps :) [12:54] mborzecki: back? [12:54] zyga: yes [12:55] mborzecki: I added a hack and it works [12:55] mborzecki: using the dbus api now [12:55] I'll run a spread pass now [12:55] mborzecki: I need to check instances as I'm worried that _ is invalid in scopes [12:56] but that's fine, we can escape if needed [12:56] zyga: _ ? [12:56] yes [12:56] zyga: does systemd complain or just mishebaves? [12:56] mborzecki: I didn't try it yet [12:57] zyga: ah, ok, so it's written down somewhere, tha's fine then [12:57] yeah, whatever it is it's okay [12:57] I _think_ the situation is somewhat okay now [12:57] but [12:57] I need to check one last thing [12:57] is using delegate breaking services now [12:57] or not [12:57] given that we tell systemd what we did [12:57] (the suspense continues) [13:12] popey, the beebeep snap is updated and works so far (it even beeps now!!) but i have a hard time convincing my system to be english for an updated screenshot [13:12] popey, mind installing it from --edge and do a screenshot of the window ? [13:12] sho thang [13:12] gracias ! [13:12] does it use bonjour? [13:13] yeah ... [13:13] needs two machines if you actually want to chat ... and on first start it offers to create a username, pick different ones on different machines [13:13] jdstrand: around? [13:14] voice messages dont work (yet) btw [13:14] I once had a train using my phone as an insecure hotspot. Some rando connected to it, and I saw them show up via bonjour in pidgin. I pinged them and said "Yes, it is okay to use my hotspot" :D [13:14] mborzecki: I think the next step is to implement that in C [13:14] bonjour is awesome. [13:14] mborzecki: but apart from that... not terrible? [13:14] yep ... [13:15] too bad android doesnt support it at all :( [13:15] (all my core installs around the house use it (using the avahi snap) but my phone always needs the IP anyway ... [13:16] my first snap using "audio-playback" !! [13:17] * ogra knows jamie will like that [13:17] funnily pulse is still autoconnecting ... not sure why [13:21] ogra: sent you some via telegram [13:22] oh drat, I think jamie is off [13:22] oh well === ricab is now known as ricab|lunch [13:23] Chipaca: it's odd that one cannot install a classic snap on core with --jailmode [13:24] bah, since when do we have these silly minimal size restrictions for screenshots ! [13:24] use convert to scale it up :D [13:28] brb [13:30] cachio: hey, do we tweak the umask in fedora images for our spread tests? [13:34] popey, i used gimp to add a transparent frame :P [13:35] popey, anyway, website updated ... i'll promote it to stable now and we should be done [13:35] that looks much better! [13:35] thanks ogra <3 [13:35] will line up a social post [13:36] bah and now chromium is stuck :P [13:37] aaand ... promoted [13:42] ogra: Is there a way to build a Core image in which only *one* snap is not from latest/stable? E.g. I want all snaps from the normal stable channel, but one snap from other-track/stable. [13:43] required-snaps in the model assertion complains about invalid snap names if I use the notation that's allowed in build-snaps, i.e. `snap-name/track/channel` [13:43] dot-tobias: AFAIK no, known limitation [13:44] dot-tobias, not sure, i know there was a request to support that a while ago, but i dont know if anything was implemented yet [13:51] zyga: you were working on #1851480, yes? [13:51] Bug #1851480: Hooks are not included in slot/plug label expressions [13:51] Chipaca: no, dot-tobias is [13:52] orly [13:52] dot-tobias: should I set the bug to in progress? [13:53] Chipaca: Not really, haven't had the time to start yet. Will ping here once there's something, have to dig into Go + snapd inner workings first [13:54] dot-tobias: should I assign the bug to you? [13:54] Chipaca: if you set it to in progress then please assign it to someone (dot-tobias) [13:54] Chipaca: Yes please, unless there's someone idling around craving to fix this, I'll try to get to it until next week [13:55] dot-tobias: what's your lp nick? [13:55] dot-tobias: oh, btw, I'll be in US west coast timezone all of next week [13:56] dot-tobias: and typically busy [13:56] I'm always on IRC but if I'm not responding this is probably why [13:56] Chipaca: https://launchpad.net/~glancr → or you mean the display name? [13:56] zyga: Good to know, thanks for the heads-up 😊 [13:57] zyga, ogra: Thanks for the feedback re ubuntu-image, I could've had a quick look at the ubuntu-image bug tracker before stealing your time: https://bugs.launchpad.net/ubuntu-image/+bug/1815580 → seems to me like --snap my-snap:channel is supported, though one needs to remember to juggle required-snaps in the assertion + --snap args for ubuntu-image [13:57] Bug #1815580: Support for snap prepare-image --snap== [13:57] dot-tobias, yeah ... thats a workaround/hack to overcome the current limitation ;) [14:02] dot-tobias: just got clarification that core is actually promoted to stable, its just not at 100% rollout yet [14:03] mvo: Ah, great! Helps a lot, thank you for inquiring on my behalf. Much appreciated [14:06] mborzecki, no, we don't [14:07] roadmr, so i got this graph at the top of https://snapcraft.io/snaps ... any idea why my most used snap is not in the list/graph at all ? [14:08] (mjpeg-streamer has way more users than any other snap i own but is not listed at all in that overview ... on its own metrics page it is fine though) [14:10] cachio: pushed the last batch of fixes to #7702, the suite should be able to run succesfully on f31 now [14:10] PR #7702: tests: adding fedora 31 to google-unstable backend [14:10] dot-tobias: you're welcome [14:15] mborzecki, thanks a lot === ricab|lunch is now known as ricab [14:27] mvo: can we restrict refresh-app-awareness to 18.04+ [14:28] mvo: if so I think this can be done [14:28] OR can we backport systemd ;_) [14:28] zyga: sounds like a question for foundations [14:28] mvo: then I can rephrase my question as [14:28] Chipaca: how do you run qemu/kvm to get the uefi grub? or is there a way to know which one was run? [14:29] mvo: can I really require proper systemd version for this and not implement any hacks [14:29] mvo: then if so I will focus on that [14:29] mvo: and we can discuss backport as an option for foundations [14:29] mvo: but I personally would not cry if it was not on 16.04 [14:29] zyga: I think its a conversation - chances are not that great but its worth a shoot [14:29] zyga: maybe the relevant bits can simply be backported [14:29] mvo: the feature is coupled to systemd running as a user session manager [14:30] mvo: i go by the splash screen, but i think you can ask grub, but i'd need to get the efi-able box up to confirm (and i can't access it rn) [14:30] mvo: aka 16.04 not having that, when that feature was implemented the APIs were created to support that [14:30] mvo: basically, enter grub's commandline and see what "echo $prefix" prints [14:30] supporting such an old release as 14.04 was gonna be painful eventually :-) [14:30] if it says EFI, it isn't EFI [14:30] Chipaca: ok, I will poke around - I tried "regexp" iirc and that gave me an error [14:30] mvo: ah, then you're not in EFI [14:30] mvo: you need to copy regexp.mod in as well for that to work [14:30] mvo: (EFI grub has regexp built in) [14:31] Chipaca: I'm sure I'm holding it wrong, echo $prefix says (hd0,gpt2)/EFI/ubuntu [14:31] mvo: it goes in EFI/ubuntu/i386-pc/regexp.mod [14:31] Chipaca: but *maybe* I have the uc18 grub [14:31] Chipaca: let me try to download the focal one [14:32] mvo: the grub on the machine you run ubuntu-image impacts the grub on the image? [14:32] mvo: note it's booting in i386-pc mode afaict (the error should mention it) [14:32] mvo: so you'll need to find that mod, not the amd64 one you probably have [14:32] Chipaca: I had to build my own pc gadget and I suspect it build it against core18 [14:33] Chipaca: again, thanks, that is good to know [14:33] Chipaca: ha! I have grub 2.02 but focal has 2.04 so its all my fault [14:35] mborzecki: check this out [14:35] mborzecki: the test passes on 64 bit 16.04 [14:35] mborzecki: fails on 32 bit 16.04 [14:35] ?!?!? [14:35] on the 32bit it doesn't have AttachProcessToUnit [14:35] Unknown method 'AttachProcessesToUnit' or interface 'org.freedesktop.systemd1.Manager'. [14:36] but it really really works on 64bit [14:36] zyga: just do it twice on 32bit so you have 64 :-p [14:36] * zyga spawns shell to confirm this [14:36] but [14:36] mvo: ^ this might indicate that we're not in hot water [14:36] as 16.04 x86_64 is where most of the sweet spot for support starts [14:37] or perhaps our 32bit images are old [14:37] I'll know soon (tm) [14:38] I imagine the 64bit has a newer version somehow. It certainly seems odd for an API to not exist in a supposedly same release with different bittiness [14:40] diddledan: I suspect it's just a fluke in our test image [14:40] cachio: are 32 bit and 64 bit images for ubuntu 16.04 in sync? [14:40] "computer says no" [14:40] zyga, in sync? [14:40] cachio: I suspect systemd version is different between them [14:41] cachio: are the packages updated equally [14:41] zyga, on Monday both were updated [14:41] interesting [14:41] thanks, I'll know the details soon [14:42] zyga, I don't have the details about that update [14:42] I know we update && upgrade [14:42] and install all the snapd dependencies [14:58] PR snapd#7683 closed: overlord/ifacestate: remove automatic connections if plug/slot missing [15:06] mborzecki: I went towards uuid named scope [15:06] mborzecki: this works on 16.04+ [15:12] mvo: is https://bugs.launchpad.net/snapd/+bug/1848567 fixed in 2.42.1? [15:12] Bug #1848567: autogenerated per-snap snap-update-ns apparmor profile may contain many duplicate mount rules causing excessive parser memory usage [15:12] did you cherry pick that apparmor parser memory fix? [15:14] zyga: it is [15:15] ta [15:15] zyga: but we need someone from foudnations to actually approve the SRU :/ [15:17] cmatsuoka: posted some comments under #7723 [15:18] PR #7723: snap-bootstrap: create encrypted partition [15:18] zyga: I am here now [15:18] mborzecki: thanks! [15:18] jdstrand: hey! [15:18] jdstrand: so ... so much progress [15:18] :D [15:18] zyga: that is good news :) [15:18] jdstrand: where do I start, I think the news is indeed good [15:18] jdstrand: I sent an update to the PR [15:19] ah, I only read backscroll [15:19] jdstrand: I wanted to ask you how you feel about dbus [15:19] https://github.com/snapcore/snapd/pull/7722#issuecomment-551086170 [15:19] * cachio lunch [15:19] PR #7722: cmd/snap-confine: add sc_join_sub_group [15:19] zyga: let me read. otoh I have a comment, but let me read what you have [15:20] jdstrand: tl;dr; we cannot do the move but we can ask systemd to do the move by calling a dbus methodf [15:20] that's all, I'll let you read the details [15:21] zyga: right [15:22] zyga: oh, heh, that comment is basically backscroll :) [15:22] xnox: can I build a new pc gadget with core20 ? I think you did a build against core18 but that means we have grub 2.02 without regexp in there which will not work with the latest grub.cfg that john added [15:23] * jdstrand reads patch [15:23] jdstrand: the API exists on 16.04+ [15:23] not on 14.04 [15:24] jdstrand: the patch in the -wip branch does the two-way dance (with attach as a fallback) but I since reworked it [15:24] I think that is ok with how we defined 14.04 support [15:24] jdstrand: to spawn a new scope each time [15:24] jdstrand: with uuid inside [15:24] but let me keep reading [15:24] jdstrand: yes, I'm happy with that, 14.04 is ok [15:24] ok [15:25] Chipaca: I get a uc20 that boots now \o/ with your grub.cfg. it hangs in initrd but thats ok :) [15:26] jdstrand: for the dbus call I was thinking to use sd-dbus C API, since we link to libudev which is a differently-named version of systemd it is not a new dependency [15:27] zyga: hehe, busctl [15:27] yes :D [15:27] take that security [15:27] let's system() out to busctl [15:27] :D [15:27] \o/ [15:27] but it helped to prototype this [15:27] ok, more seriously [15:27] of course :) [15:28] so, it is super validating that my interpretation of that page was reasonable and my highlevel idea is what upstream recommends, even if I didn't precisely know how to do it ;P [15:29] this isn't options 1-3 though [15:29] anyhoo [15:29] cool that there is a way with systemd [15:30] sil2100: hey, I noticed its your SRU day, can I ask you to review the 2.42.1 SRU in unapproved please :) ? [15:30] (it is sorta 3 I guess) [15:30] ok [15:30] * zyga checks the 1-3 list again [15:31] zyga: it doesn't really matter. what I had forgotten and you reminded me today and yesterday is dbus is required [15:31] jdstrand: there's one more cool thing there that I could mention [15:31] please do [15:31] jdstrand: systemd has a concept of a controller [15:32] jdstrand: I'm not 100% sure how this is meant to be used [15:32] but [15:32] jdstrand: you can have a unit that a controller watches over [15:32] jdstrand: and it will tell you when it wants to wrap it up cause the job died [15:32] jdstrand: and I was wondering if that's like notification for us [15:32] oh [15:32] yeah [15:32] interesting [15:32] jdstrand: but before I would go there I'd have to check more [15:32] jdstrand: it's not documented, I read most of what I found by reading systemd directly [15:32] * jdstrand nods [15:32] jdstrand: there's a property on a scope [15:32] jdstrand: controller [15:33] jdstrand: it's not a cgroup controller [15:33] jdstrand: it's a dbus path of the place you can call [15:33] jdstrand: and it calls it with one method, RequestStop or something like that [15:33] jdstrand: it _smells_ like something reaching into a container via a container manager [15:33] jdstrand: but I think we don't need to rely on that [15:33] jdstrand: just found it interesting [15:34] jdstrand: to answer your earlier question [15:34] jdstrand: this is mode 1 a [15:34] zyga: it makes sense> you put everything in places so systemd could track. it has a way to tell you about what it is tracking. that would obviate the need for the parsing code [15:34] jdstrand: which is the :-) (happy face) variant [15:34] jdstrand: I was thinking we _might_ keep the parsing code [15:34] Chipaca: you're interested in nonce logs? [15:35] jdstrand: until snap-confine can be told it's starting a service [15:35] mborzecki: sure [15:35] jdstrand: then we could only do the scope for user commands [15:35] jdstrand: and not for services where it is ... weird [15:35] zyga: maybe that is what nspawn uses [15:35] Chipaca: https://paste.ubuntu.com/p/wMr9Wq66BB/ [15:35] jdstrand: and I think this makes sense in more ways actually [15:35] jdstrand: because it means all kinds of workloads are managed by systemd now [15:35] jdstrand: services, user services, non-service apps and hooks [15:36] jdstrand: each one is understood by systemd as a thing [15:36] jdstrand: we could even feed it with unit level meta-data [15:36] jdstrand: like Description [15:36] jdstrand: man page references [15:36] jdstrand: perhaps we could even reference snaps or whatever, I'd have to check [15:36] jdstrand: since we make a dbus call and we can populate anything that a scope unit can model [15:37] zyga: ok, so as exciting as this is, I have some reservations about dbus, but I think we may be able to mitigate those concerns. hear me out (I'll type .. when done) [15:37] jdstrand: understood [15:38] a) calling dbus from snap-confine is going to bring a significant attack surface into snap-confine in terms of addressable apis in the address space [15:38] b) calling dbus is going to bring some likely undesired rules into the apparmor profile [15:38] mvo: so the pc-gadget in launchpad is built againt focal, with focal binaries. I can retrigger that, download, unsquashfs, sed core18 to core20 and release into the store [15:39] mvo: despite declaring core18, all binaries inside it are from focal [15:39] c) the combination of a and b is likely going to weaken the security posture of our hardening (primarily apparmor, but see address space) [15:39] xnox, cheater !!! :) [15:40] d) having a dbus call in the list of things we do is going to really slow things down. not a big deal for a service, but for a non-daemon, yikes [15:40] ogra: i only am blocked on IS to deploy my launchpad-buildd changes, and for my launchpad UI branches to be merged and deployed by webops. [15:40] (now to the mitigations) [15:40] ogra: it's not like i didn't do everything to fix our infra to do the right thing properly first. [15:40] * ogra hugs xnox ... i wasnt serious :) [15:41] jdstrand: as a remark, a, b and c *might* not be needed if I can make it work from snap-run before setuid happens [15:41] reading the patch, I was happy to see that we first create the scope and then slice based on the security label [15:42] if that is the full label with command name, potentially not as nice [15:42] scope/slice? there's only scope, the slice is what we got originally [15:42] (as in given to us by systemd) [15:43] I was happy cause I thought, ok, the first command invocation was slow, but then we can just add stuff ourselves, which is fast [15:43] but then you said to add stuff, we need the second api [15:44] zyga: I said slice trying to use systemd parlance, but might've mispoke. I meant the scope ends up being a branch and the security label a leaf [15:44] yes, that's correct [15:44] (back to soliliquy) [15:45] and the second api requires a dbus call, so every snap command invocation needs the calls [15:45] so (I [15:45] 'm getting there) [15:46] the first thought is, have a snap-dbus-helper in go that snap-confine calls out to [15:46] we can profile transition to it and alleviate the setuidness/address space/expanding policy issues [15:46] (a-c) [15:47] if we fork/exec this we don't have to wait on it. we let it do its thing and perform the move any time later [15:47] (d) [15:48] mvo: i think i will take your PR and push it into the store [15:48] the snap run idea is interesting as well. we can discuss the merits of that [15:48] .. [15:48] so I think that's the thing to investigate now [15:48] my thinking is as follows: [15:49] snap run checks if a service is being started [15:49] if so, nothing new needs to happen [15:49] we can use existing systemd cgroup machinery for services to find what we need [15:49] if this is not a service or it is a hook then we call the dbus api from go and move snap run to a new scope with UUID + snap security tag in the name [15:50] snapd side we can differentiate those and scan /sys/fs/cgroup/{,systemd} [15:50] in both cases holding a lock we can build the security-tag -> definitely-not-running data set [15:51] (and if possibly running we know the PIDs that existed at the time) [15:51] .. [15:51] oh and perhaps as a side note, I would not go and optimize the dbus part until we know how much it really costs [15:51] zyga: it is 100 going to cost. feel free to measure it [15:52] 100% [15:52] how much, I don't know [15:52] but, in theory, this can happen asynchronyously [15:53] it easily measurable, but don't do the measuring with busctl [15:53] it's* [15:53] so, does this api work with user sessions? [15:54] zyga: I would be surprised that a non-root process could move itself to a new leaf [15:54] zyga@eoan:~/go/src/github.com/snapcore/snapd$ time busctl --user call org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager StartTransientUnit 'ssa(sv)a(sa(sv))' testing.$(cat /proc/sys/kernel/random/uuid).scope fail 1 PIDs au 1 $BASHPID 0 [15:54] o "/org/freedesktop/systemd1/job/787" [15:54] real 0m0,010s [15:54] user 0m0,006s [15:54] sys 0m0,003s [15:54] which would be required with snap run [15:54] it can if all the permissions match [15:54] the pid is the same as the invoker and owner of the unit [15:54] zyga: the permissions being the uid/gid on the leaf? [15:54] (since you can move to a service as well) [15:55] not on the leaf, on the unit [15:55] scopes have no oner [15:55] since they are crated dynamically and are injected relative to where you are [15:55] after I invoked that call I got move tod: [15:55] 0::/user.slice/user-1000.slice/user@1000.service/testing.ba4454d6-0242-49ac-864e-e6ab1d6c2fb4.scope [15:55] *moved to [15:55] try it [15:55] zyga: ok, so that would mean the scope would need to be per command, and per command per uid owner, no? [15:55] no root needed [15:56] there's a per command scope, yes [15:56] my point is that the owner of each scope matches the invoker because that's the only way to have a scope [15:56] there's no unit for a scope file on disk [15:56] zyga: how do you calculate the uuid? [15:56] I ask the kernel for one, look at the command above [15:57] that's another thing that would block in low entropy scenarios [15:57] could* [15:57] yes, alternative is to just use a counter [15:57] jdstrand: but I wasn't sure what is doing the counting [15:57] well, not block, but I guess this isn't a security mechanism [15:57] for things like sessions or systemd-run [15:57] a counter would be preferred if we can count reliably [15:58] but that might imply we need to maintain the counter in snap confine [15:58] alternatively perhaps we could open a tmp file on /run/snapd/counters [15:58] and the inode of that file is the value [15:58] but ... [15:58] no ... that is broken [15:58] anyway, I think uuid is "good enough" to proceed [15:59] zyga: can you mockup the series of 0::s from the /proc/pid/cgroup for when a snap daemon starts, then a snap command is started twice by the same user and then a snap command is started once by a different user? [16:00] yeah, hold on [16:00] * jdstrand wants to visualize the end result to make sure we are on the same page [16:00] note that it depends on "where" the user is [16:00] in particular it differs if I run firefox from the dock [16:00] or run it from the terminal :) [16:00] I'll show you [16:00] zyga: sure, mix two calls from the dock and one from the terminal in [16:01] zyga: (this would likely turn into a requested code comment ;) [16:03] zyga: while you are doing that, it means that dbus must be up and running before a snap can be started (unless we fork off). that is perhaps fine since systemd probably needs it itself early on, but a consideration nonetheless [16:03] jdstrand: indeed, I think there is a way to depend on it though [16:03] I mean [16:03] it's socket activated [16:04] so no need to really [16:04] * jdstrand is trying to think through side effects [16:04] potentially will slow down the first thing that is started, but shouldn't be a concern [16:08] zyga: I'll also say, this is probably not something that we can land in master before the sprint due to time constraints, measuring, etc. however, I think that mvo would be able to speak to this well. eg, "lots of investigative work was done and the probably is now fully understood. there were systemd interactions that complicated things, and we wanted to ensure we implemented something robust. until [16:08] last week, everything was brittle, but now we know the methodology to use (confirmed with upstream) and we are working through the most performant and robust design. we should have that in the next week or so. I [16:09] While we missed the roadmap item, I [16:09] 'm pleased with the work and the solid direction" [16:09] or similar [16:09] :) [16:09] if it were me, I would handle it that way. it isn't my call though [16:10] what is my call is letting you know that I'm concerned about rushing this. we should get Samuele signoff imho [16:10] mvo: fyi ^ [16:11] firefox started from gnome shell: 0::/user.slice/user-1000.slice/user@1000.service/testing.cbdc667d-d3e6-4246-8ecb-7461ba346f51.scope [16:11] s/probably/problem/ [16:11] various programs started from the shell: [16:11] 0::/user.slice/user-1000.slice/user@1000.service/testing.cd8f04c3-56d2-425a-a74a-0693440a78a3.scope [16:11] 0::/user.slice/user-1000.slice/user@1000.service/testing.dd2b526f-379f-465c-a704-10eb243fa991.scope [16:11] (all as my user) [16:12] odd, this is fedora 31, I think I noticed that it used to have some more variance before [16:12] (please show the leaves as well [16:12] ) [16:12] zyga: this might be better understood in a pastebin [16:12] yeah, I'll collect it, sorry for pasting in-the-middle work [16:12] jdstrand: in a meeting, will read backlog [16:12] the leaves are owned my my user [16:13] [zyga@fedora31 ~]$ ls -ld /sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/testing.dd2b526f-379f-465c-a704-10eb243fa991.scope [16:13] drwxr-xr-x. 2 zyga zyga 0 11-07 17:01 /sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/testing.dd2b526f-379f-465c-a704-10eb243fa991.scope [16:13] no worries. I want to be able to see all of it so we can discuss by referencing line numbers [16:13] ok [16:14] zyga: ftr, I'm *very* encouraged by this as an overall concept. how we iron out the details of the concept is all we're talking about [16:14] (ie, the scope/delegate/dbus bits) [16:14] (the snap run bits are the details :) [16:15] (or snap-confine, etc, etc...) [16:15] 0::/system.slice/sleep.service <- a regular service [16:15] * zyga collects everything [16:29] thanks [16:30] hey marcustomlinson, is it okay if I adopt your patch at https://github.com/snapcore/snapd/commit/49114d576feb371a27fa4c0d5074dfa487aab358 to merge into snapd? I will need to refactor it a bit before we can merge it likely, and we can't use the 3rd party dep you have there, but this is great work and I would like to see it merged into snapd (as well as use it more for snap startup performance investigations) [16:31] if you'd like I can just add commits on top of your commit in a branch, or I could just make a new commit with your changes there and provide attribution in the commit message/PR description [16:31] ijohnson: either is fine, I don't mind :) [16:31] ijohnson: and yes please! go ahead [16:34] jdstrand: so I have a little bit [16:34] https://www.irccloud.com/pastebin/mlAOGSGg/ [16:36] zyga: fyi, my comment in the pr without putting any time constraints on you: https://github.com/snapcore/snapd/pull/7722#issuecomment-551159049 [16:36] PR #7722: cmd/snap-confine: add sc_join_sub_group [16:36] jdstrand: I'm nearly convinced this doesn't need to be in snap-confine [16:37] jdstrand: I'll try to move this to snap run [16:37] jdstrand: with uuid and stuff [16:37] jdstrand: 0 changes to snap confine would be a sweet deal out of this work [16:39] zyga: ok, so with this you are skipping the security label [16:39] jdstrand: yeah, I think so [16:39] jdstrand: well, [16:39] zyga: that is one of the things I wanted to get on the same page about. I was still thinking there would be a leaf [16:39] jdstrand: given where we've been so far I think it's hard to say so for sure ;-) [16:39] * jdstrand nods [16:40] jdstrand: the leaf is the scope here, no/ [16:42] zyga: what is happening at line 15? the ls seems to contain the same thing as the new scope [16:42] in line 15 I just check the ownership of the scope [16:42] marcustomlinson: great, thanks! [16:42] in line 12 I read it [16:42] oh, I missed -d [16:42] it's printed on line 13 [16:43] sorry [16:43] no worries :) [16:47] zyga: remind me, StartTransient unit with Delegate is enough to keep systemd happy and for us to track? [16:47] without delegate [16:47] delegate was needed to be able to move a process there later [16:47] I was trying to read backscroll and lost track of that [16:47] ah right [16:47] but given that it dependso n more recent systemd and using an uuid is good enough I don't think we need to use that [16:47] this is purely for tracking and don't need to move [16:47] so just starting a transient unit of type scope with snap-run PID [16:48] yes [16:48] we could even leverage that in hooks [16:48] where we "try" to kill hooks that are long running [16:48] but now we can really actually stop them [16:48] reliably [16:49] zyga: and the real thing my do s/testing/snap-run/ (or something) [16:49] might* [16:49] (for the scope name) [16:49] are you asking about the scope name to use for real? [16:49] yes [16:50] or were you thinkg the security label? [16:50] I think it should be f($SNAP_SECURITY_TAG), something like snap.PKG{,.hook}.NAME.$UUID [16:50] ok [16:50] we can shuffle those around to look nice [16:50] but I think it's a good start [16:50] and as I mentioned earlier, only for non-service apps and hooks [16:51] services are good to go as is [16:51] zyga: with this, every command invocation gets a new uuid. when are these cleaned up? will systemd be able to handle potentially thousands of these? [16:51] they are automatically cleaned by systemd [16:51] I can try how it scales [16:52] I think we'd need to understand that with the uuid approach [16:53] zyga: not saying we need to be thinking like this, but, it would seem ok if the best implementation used newer systemd features. we could downgrade from one to another but more I was thinking perhaps systems without a new enough systemd don't get the feature [16:53] zyga: thinking being, this is mostly handy for desktop, and desktop tends to keep moving forward [16:53] zyga, jdstrand still in a meeting - but if we have dbus in the hot path of starting snaps we should probably get some sense how fast/slow this is, i.e. if it makes starting snaps slower [16:53] anyway, just something for back of mind [16:54] given that this is supported in 16.04 I think it's a good idea as-is [16:54] zyga: I was more talking if the uuid approach wasn't as great as it could be, but we aren't there yet [16:54] jdstrand: ah [16:54] I see [16:55] jdstrand: I ran 1000 commands this way and they are not in sysfs anymore [16:55] mvo: yes. we discussed that and agree it needs to be measured. there are options that might allow us to fork and move on and let the child do the dbus stuff asynchronously [16:56] mvo: not sure how that would work with the current 'as of this minute transient unit via snap run' thinking, but yes, we agree it must be looked at [16:57] jdstrand: we could send the method and perhaps not wait for the reply [16:57] zyga: those were command that exited though. how about 1000 sleep 600 commands? [16:57] jdstrand: but something of this kind, it's really a message dispatch [16:57] jdstrand: you read my mind :) [16:57] zyga: I [16:57] meh [16:57] jdstrand: though I did a sleep $i instead ;) [16:57] (different keyboard) [16:57] zyga: I'm assuming they exited that is [16:58] jdstrand: yep [16:58] jdstrand: while they are running you can see them [16:58] https://www.irccloud.com/pastebin/KdUgFNrZ/ [16:58] zyga: yeah, send and forget is perhaps good enough. I wonder how that command can fail (and we therefore lose track of a pid) [16:58] they even can be checked [16:59] jdstrand: well, it's either that or wait :) [16:59] zyga: well, if we fork, the child can wait and retry [16:59] and if that fails? [17:00] then we lose it [17:00] sure but at some point: 1) you are failing but the app is running 2) the app is running untracked [17:00] it could be seen as best effort in that regard [17:00] yep [17:00] though I would not go there initially, we need to see how it works still [17:00] PR snapcraft#2782 closed: snapcraft: introduce click-based YAML configuration file support [17:00] which by far most of the time would be great [17:00] jdstrand: re cgroups, they are cleaned up as the scopes become empty [17:01] zyga: right, so the thing exits, systemd sees the last one left, it removes the scope. makes sense [17:01] jdstrand: there's one reason we might want to use a delegate though [17:02] jdstrand: using a delegate we could have another leaf level [17:02] jdstrand: and attach eBPF programs there [17:02] jdstrand: perhaps we will have to for device cgroup [17:02] zyga: I wonder how well that works with name=systemd since, aiui, they woul dhave to poll the cgroup.proc file rather than listen on cgroup.events in v2 [17:03] zyga: also for the cpu/mem discussion yesterday [17:03] jdstrand: for cpu/mem it is relevant [17:03] jdstrand: we cannot do that according to systemd rules [17:03] jdstrand: you cannot write to anything that you are not a delegate of [17:03] jdstrand: you can ask systemd to change properties of existing scopes/services [17:03] zyga: but maybe we just use systemd apis to control systemd's cpu/mem handling? [17:03] jdstrand: but not externally by poking at sysfs directly [17:04] right [17:04] yes, I think that's good if we can do that [17:04] * jdstrand nods [17:04] because the alternative is that we do use delegates for services [17:04] exactly [17:04] i.e. have a slice (not a scope) [17:04] * jdstrand nods [17:04] and put Delegate=snaps.slice [17:04] and then inside that be system manager and handle things [17:04] but I think ... that's systemd's job [17:04] s/system/service/ [17:05] right. we are trying to play nicely with it and leverage it, so why not for this too? [17:05] it does mean we are probably forever coupled to systemd [17:06] it is imaginable for an alternative init to be used with what we have now (service management, timers, etc) [17:06] even if that is a heap of work [17:06] this talks us a bit farther down the systemd path [17:06] takes* [17:06] jdstrand: yes, but perhaps to good effect, [17:06] I may not have slept enough last night ;) [17:07] jdstrand: for instance killing hooks was sys-v init style [17:07] zyga: oh for sure, just calling it out. not a blocker [17:08] I think I'll wrap up for now [17:08] zyga: a property I like about snap run is that the correct user is doing the dbus call [17:08] it's 18:00 and I want to not repeat yesterday [17:08] and you are right this won't land before the sprint [17:08] zyga: a property I like about snap-confine is it is in a position to organize things rigidly [17:09] zyga: food for thought [17:09] hmm, now that I think of it [17:09] zyga: this was *super* interesting and fruitful [17:09] I think as a user I got a polkit prompt from the shell [17:09] ohh.... [17:09] need to double check that [17:09] that is important. that is cached [17:10] wait, I'm dumb [17:10] zyga: if snap-confine is back on the table, I think I feel quite strongly we need a helper and that be written in go [17:10] (not saying it is) [17:11] no prompt [17:11] I was passing --system :D [17:11] just for back of mind [17:11] https://www.irccloud.com/pastebin/8wRREiYV/ [17:11] I'll double check that on ubuntu with v1 [17:11] same [17:11] * jdstrand nods [17:11] no prompt [17:11] yeah, come to think of it [17:12] so it can safely live in snap-run [17:12] you wouldn [17:12] t need polkit for --user (duh) and it is also ok for the unconfined user to call the apis that systemd exports. moving this down doesn't affect the properties of the resource limits... [17:13] and snap run is pre confinement [17:13] well, except when it isn't (snap calling snap) [17:13] jdstrand: snap calling snap is semi-supported [17:13] there might be more to investigate there [17:13] jdstrand: I don't know what actually relies on it nowadays [17:13] yeah [17:13] jdstrand: and apart from that, it only works in devmode [17:13] but we should understand the implications [17:14] jdstrand: as otherwise snap-confine cannot reassociate with pid-1 mount ns [17:14] jdstrand: so in strict mode it is refused anywa [17:14] also, make sure that classic doesn't have any gotchas [17:14] *anyway [17:14] jdstrand: I _think_ it doesn't [17:14] I mean, classic is not affecting this in any way as far as I can see [17:14] zyga: yep, thanks so much for the work and discussion. we'll definitely pick this up, next week if not sooner [17:15] jdstrand: tomorrow I'll focus on making snap-run do this via go-dbus [17:15] zyga: sure. a classic snap can call sddbus itself. anyway, just thinking through pain points and things to document [17:15] jdstrand: both in a standalone PR and in a wip PR with the snapd side using it [17:16] zyga: have nice evening :) have a beer or do something fun. I think we cracked the overall approach :) [17:16] I think so [17:16] I don't know if I have any at home :) [17:16] but I plan to see what the family is up to upstairs === pstolowski is now known as pstolowski|afk [17:17] this might be cause to leave the cave [17:17] thank you for your focus, attention and wisdom :) [17:17] haha [17:17] yes [17:17] zyga: back at you :) [17:17] (and thanks!) [17:17] see you tomorrow or if we miss each other somehow at the sprint next week :) [17:17] sounds good. take care [17:17] o/ [17:17] * zyga EODs [17:23] jdstrand, mvo: I wrote down the implementation plan on https://github.com/snapcore/snapd/pull/7722#issuecomment-551179377 [17:23] PR #7722: cmd/snap-confine: add sc_join_sub_group [17:24] I didn't include things like testing and measurement because I want to EOD but I agree those will happen [17:24] zyga: for when you come back online. when thinking about the benefits of snap run, lets also consider what is required for device (and freezer) cgroup (equivalents) going forward. ie, perhaps that means snap-confine calling a helper is better to have a uniform approach going forward (or not, just don't want you to do snap run only to realize we maybe didn't think that all the way through with future work) [17:24] just wanted to write it down while fresh [17:24] ah, heh [17:24] ha [17:24] freezer can go away at some point via new mount api [17:24] in pure v2 we should just really assume you have matching kernel and use new syscalls [17:25] devices are more complex because they require (helper or not) eBPF attached to cgroup [17:25] we cannot do that unless we ask for delegate unit [17:25] that perhaps makes sense [17:25] there's some special handling that happens then [17:25] right [17:25] because the eBPF programs systemd itself uses are added with different mode [17:25] zyga: yeah, lets discuss more tomorrow, get some rest :) [17:25] so that all programs run (aka multi mode) [17:25] my ony point is if we know that, and we know what that will sorta look like, maybe we look at tracking through that lens [17:26] anyway, enjoy your evening :) [17:26] I think we can use helpers or bake it into snap* but it needs the delegate "hop" at some point [17:26] but that's a good observation that we can align on this for other features [17:26] mvo: yeah, :) [17:26] * zyga really EOD now [17:26] mvo: are you out of your meeting? [17:29] jdstrand: yes [17:34] mvo: hey, so that is a lot of backscroll. let me get you the most important thing for next week (outside of the comments in the PR we made in the last day) [17:35] jdstrand: thats super nice of you, thank you! [17:36] jdstrand: I will have dinner now but you can mail or /msg me the important bits if that is ok [17:37] mvo: a) I think we want pedronis to review this and b) https://paste.ubuntu.com/p/7HdCp9p9K5/ [17:37] mvo: that is fine. enjoy dinner [17:37] jdstrand: thank you! [17:37] jdstrand: yeah, thanks for the pastebin, I think thats a reasonable answer. will you be in vancouver? [17:38] mvo: meh, in the paste: /the probably/the problem/ [17:38] mvo: I will [17:38] mvo: I have limited availability tomorrow (similar to today; front loaded the week with work) [17:39] mvo: but in Vancouver next week and zy ga and I will continue to discuss this [17:40] jdstrand: excellent! [18:37] * Chipaca EODs [19:19] * cachio afk [19:33] PR snapd#7724 closed: cmd/snap-confine: tracking processes with classic confinement [22:46] having issue where calculating the version of the maas snap is failing now with snapcraft [22:46] i now see in the logs [22:47] fatal: not a git repository (or any of the parent directories): .git [22:47] fatal: not a git repository (or any of the parent directories): .git [22:47] some reason the .git directory is no longer being copied into the VM [22:47] using just source: . [22:47] with no source-type defined [22:47] any ideas on why that is occurring now, when it didn't happen before [22:48] sergiusens: ^