[03:45] <thumper> here's a very boring review for someone: https://github.com/juju/juju/pull/10884
[03:45] <thumper> long and boring and almost all mechanical
[03:46] <thumper> 157 files, +764 −622
[03:46]  * thumper packs up for sprint
[03:50] <anastasiamac> wallyworld: thank you for the review! r u k with my take o re-phrase?
[03:54] <wallyworld> looking
[03:58] <wallyworld> anastasiamac: made a suggestion
[04:04] <anastasiamac> wallyworld: i know that historically we have only updated regions... however potentially it can b other properties too... like auth-types...
[04:04] <anastasiamac> wallyworld: i think i'd rather just say 'to update public clouds ...' without any further detail
[04:05] <wallyworld> yeah true. not too fussed on that bit of the wording, although region is really what it's about 99% of the time. more fussed with "from a central location" bit. doesn't really matter how, users just need to know it will happen
[04:05] <anastasiamac> ta
[04:54] <wallyworld> hpidcock: kelvinliu: bug 1851763 may be a rc stopper. it may just be CK on maas. microk8s worked for me this morning and i think CK on say AWS or Azure works. could one of you please confirm that is the case so we can narrow this down to just a maas issue. i need to get stuff done for the sprint
[04:54] <mup> Bug #1851763: [2.7 rc2] can't deploy k8s-based model re-using cloud controller <juju:New> <https://launchpad.net/bugs/1851763>
[04:56] <kelvinliu> wallyworld: im looking it now
[05:01] <wallyworld> ty, i need to get stuff sorted if i can get away from the keyboard
[05:05] <kelvinliu> np,
[06:25] <kelvinliu> wallyworld: I tested, lxd controller <- microk8s; IaaS controller <- azure CK; IaaS controller <- aws CK; all working, so I think it should be just maas and not related with CaaS.
[06:29] <wallyworld> kelvinliu: gr8 tyvm. the suspicion is that we are copying across the spaces for the controller cloud when a new model is added, and not doing a check that the model uses the same cloud
[06:29] <wallyworld> maas controller cloud has spaces, k8s cloud doesn't
[06:37] <kelvinliu> briefly look on apiserver/facades/client/modelmanager/modelmanager.go, didn't find any space related change.
[06:41] <wallyworld> joe will look into it
[06:44] <kelvinliu> thanks
[09:38] <gnuoy> Hi, we just switched over to using juju 2.7 candidate and out charm testing broke. The problem is that when test a charm we use a bundle which uses all supporting  charms from the charm store and uses the local copy of the charm undertest. We reference the charm undertest in the bundle like this:
[09:38] <gnuoy> charm: ../../../nova-cell-controller
[09:39] <gnuoy> because the overlay with that in lives inside the charm here:
[09:39] <gnuoy> nova-cell-controller/tests/bundles/overlays
[09:40] <gnuoy> and the local paths seem  to relative to the overlay location
[09:40] <gnuoy> this worked in 2.6 but in sit I get:
[09:40] <gnuoy> ERROR cannot deploy bundle: the provided bundle has the following errors:
[09:40] <gnuoy> charm path in application "nova-cell-controller-cell2" does not exist: /nova-cell-controller
[09:40] <gnuoy> Soes anyone know of a 2.7 change that might account for this ?
[09:40] <gnuoy> s/Soes/Does/
[09:43] <stickupkid> gnuoy, nope, but a bug will be useful
[09:44] <stickupkid> gnuoy, https://bugs.launchpad.net/juju/+bugs?field.tag=bitesize
[09:44] <stickupkid> sorry ignore the bitesize query part
[09:44] <stickupkid> https://bugs.launchpad.net/juju/+filebug
[09:44] <gnuoy> stickupkid, thanks. tbh  if a full qualified path works in 2.6 I may just switch to doing that.
[09:44] <gnuoy> (seems to work  in 2.7)
[09:54] <nammn_de> manadart rick_h stickupkid Pr is now in a reviewable state. Happy to get some input! https://github.com/juju/juju/pull/10867
[09:54] <stickupkid> training day
[09:59] <nammn_de> stickupkid: ahhh you right its friday
[12:59] <manadart> Need a review for the k8s-on-MAAS fix: https://github.com/juju/juju/pull/10886
[13:00] <achilleasa> manadart: looking
[13:01] <achilleasa> manadart: why is AllSpaces returning no subnets on maas even though they seem to have space IDs in the DB?
[13:04] <manadart> achilleasa: https://github.com/juju/juju/blob/bdaefb0a07d6b033ef5c3499085889fb9f8fccb1/state/spaces.go#L98 :)
[13:05] <achilleasa> should I fix it now?
[13:05] <manadart> achilleasa: Yep.
[13:15] <achilleasa> manadart: hmmm... space.Subnets() may potentially return an error...got to change the return signature for NetworkSpace() :-(
[14:29] <manadart> Simple one: https://github.com/juju/juju/pull/10887
[14:31] <rick_h> manadart:  is the space removal bits intended?
[14:32] <manadart> rick_h: Yeah, that was an indirection for space lookups that no longer happen for client API addresses.
[14:32] <rick_h> all good, I first read that as a "fix typo" and then saw deleted code but see the full comment on there
[14:32] <rick_h> +1
[14:34] <achilleasa> manadart: so, now the machiner will only update the linklayer devices while the instancepoller will update the provider addresses, correct?
[14:36] <manadart> achilleasa: The instancepoller will need to merge link-layer data if it differs from what is there. Otherwise we won't have provider IDs for any of that data.
[14:36] <manadart> In addition to setting those machine collection addresses.
[14:38] <achilleasa> manadart: gotcha
[14:42] <danboid> Is there a dedicated irc channel for Ubuntu openstack?
[14:43] <danboid> I've been unable to SSH into any instances I have deployed with Ubuntu openstack
[14:45] <rick_h> danboid:  definitely https://help.ubuntu.com/community/OpenStack
[14:45] <danboid> The web UI says it has deployed successfully but looking at the log it doesn't look like the vm is being assigned an IPv4 address (contrary to what the web UI says) nor is it copying my SSH key
[14:45] <rick_h> oh hmm, guess that's just openstack. I know they've also got something else
[14:46] <rick_h> there's this but that's more for the charming/operations side but might be able to help https://docs.openstack.org/charm-guide/latest/find-us.html
[14:50] <danboid> rick_h, Thanks, I'll try there
[15:01] <nammn_de> rick_h:  here is the pr where i need some input for qa/ux related things https://github.com/juju/juju/pull/10867
[15:06] <rick_h> ty nammn_de
[15:06] <nammn_de> rick_h: I tried to follow the doc spec as much as possible :D
[15:08] <rick_h> sweet
[15:08] <rick_h> building now
[15:42] <aisrael> rick_h: Do you know when 2.7 rc2 was released?
[15:43] <aisrael> nm, looks like yesterday
[15:43] <rick_h> aisrael:  yesterday?
[15:43]  * rick_h can't keep track of time
[15:44] <rick_h> aisrael:  one know issue causing an rc3 monday morning for a corner case of k8s models on top of maas contorller https://bugs.launchpad.net/juju/+bug/1851763
[15:44] <mup> Bug #1851763: [2.7 rc2] can't deploy k8s-based model re-using cloud controller <juju:Fix Committed by manadart> <https://launchpad.net/bugs/1851763>
[15:45] <aisrael> rick_h: okay. I saw there's an rc3 candidate in edge. We're chasing a couple potential bugs right now and will file them asap
[15:45] <nammn_de> stickupkid: the acceptancetest fix regarding cli https://github.com/juju/juju/pull/10888
[15:45] <aisrael> All related to k8s
[15:45] <nammn_de> small one
[15:45] <rick_h> aisrael:  sounds good thanks for filing
[15:46] <rick_h> aisrael:  ty for testing the RC, much better to find stuff there.
[16:00] <rick_h> nammn_de:  not sure it's direct in your PR but heads up https://bugs.launchpad.net/juju/+bug/1851853
[16:00] <mup> Bug #1851853: a rolled back commit shows as a commit in list-commit <juju:Triaged> <https://launchpad.net/bugs/1851853>
[16:00] <rick_h> nammn_de:  doing a proper test with a different charm that has config this time
[16:01] <rick_h> nammn_de:  but I think that commit 0 might be a real issue
[16:12] <nammn_de> rick_h: thanks! Oh ahhh, I think I have a small error in the query, let me change that. I suspect that i should have not searched for completed
[16:12] <nammn_de> let me fix that
[16:12] <rick_h> nammn_de:  cool
[16:13] <rick_h> I'll keep poking
[16:13] <rick_h> mmmm, back to non-dark roast coffee so yummy :P
[16:13] <nammn_de> it should work for not aborted ones, because as it now, i think, it will always show aborted ones with id ==0 :D
[16:13] <rick_h> nammn_de:  oh lol
[16:16] <manadart> nammn_de: bson.M{"completed": bson.M{"$gte": 1}} should be generation-id instead of completed.
[16:19] <nammn_de> rick_h manadart: yeah thought so as well,  patch is up :D
[16:19] <nammn_de> manadart: thansk for taking the quick look!
[16:20] <rick_h> nammn_de:  ok, rebuilding/back to poking ty
[16:54] <rick_h> nammn_de:  ok, ty this feels really cool to play with
[16:54] <rick_h> nammn_de:  feedback inbound, and the rolled back ones are good now with the patch
[16:55]  * rick_h is trying to think if we have anything else in juju that's date ordered
[16:55] <rick_h> I like the commits in reverse order but don't want to flip/flop if we do it another way somewhere else...but I can't think of where we would
[17:04] <nammn_de> rick_h: thanks for the feedback will work it in next week.  list-users cuts off the output after the day. I can change that to that as well
[17:04] <achilleasa> rick_h: perhaps a --sort=asc/desc flag?
[17:04] <nammn_de> achilleasa: sounds good to me, I can add that
[17:05] <rick_h> nammn_de:  oh yea, definitely don't want to just keep a day
[17:05] <achilleasa> nammn_de: I am pretty sure git has a similar flag for logs
[17:05] <rick_h> nammn_de:  yea, let's not do the flag yet
[17:05] <rick_h> nammn_de:  but just desc and we'll tweak it after using it more for longer periods of time
[17:06] <nammn_de> how "much" of the date do you think makes the most sense for list-commit?
[17:06] <nammn_de> 2019-11-06  || 2019-11-06 hh:ss ?
[17:07] <nammn_de> *hh:mm
[17:07] <rick_h> nammn_de:  so I assumed the human readable thing did 12m ago, 4hrs ago, 10 days ago?
[17:07] <nammn_de> rick_h: ahhh sure
[17:07] <rick_h> is that not what it's doing? when I looked on my demo controller it was saying "12m ago" and figured it was human readable-ling
[17:08] <nammn_de> its doing both,  if its further away than a timeline it shows the yyyy-mm-dd, else the human readable thingz
[17:08] <nammn_de> thats why i got confused
[17:08] <rick_h> nammn_de:  ah, ok that's find
[17:09] <rick_h> err fine
[17:09] <rick_h> nammn_de:  so cheat off what that's doing please :)
[17:09] <nammn_de> rick_h: will do, cheating off is my skill
[17:50] <manadart> rick_h: Backport service removal script: https://github.com/juju/juju/pull/10889