| nammn_de | stickupkid: mind having a quick look? https://github.com/juju/charm/pull/298 This now should fix the unit tests on most occasions | 13:14 |
|---|---|---|
| nammn_de | stickupkid? | 15:10 |
| nammn_de | *: I added some tests as you metnioned | 15:10 |
| nammn_de | could you take a look again? | 15:11 |
| stickupkid | nammn_de, done :D | 15:11 |
| nammn_de | stickupkid: ha, thanks! I was struggling to find a good way to test the timeout | 15:12 |
| stickupkid | yeah, i thought you might, but it was worth seeing if it was possible | 15:12 |
| nammn_de | In the end I let the context be a parameter | 15:12 |
| nammn_de | because i was struggling to either "mock" the context and/or command | 15:12 |
| stickupkid | anyone know how to get the controller name? | 16:15 |
| stickupkid | from state? | 16:15 |
| stickupkid | achilleasa, ? | 16:16 |
| achilleasa | stickupkid: you mean the alias used by the client? | 16:27 |
| stickupkid | ho quickly? achilleasa | 16:28 |
| achilleasa | omw | 16:28 |
| rick_h | doh he's gone | 18:22 |
| rick_h | achilleasa: heads up that a controller name tracked as config is on the roadmap for 20.04 | 18:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!