/srv/irclogs.ubuntu.com/2019/11/14/#juju.txt

nammn_deachilleasa manadart is there a way to find out the fullname of the controllermodel?10:40
manadartnammn_de: What do you mean by full name? It is always "controller".10:41
nammn_demanadart: ohh, i meant with the fullname the owner name as well.10:42
nammn_deright now `upgrade-model` assumes the current account name for a upgrade. So does upgrade-controller. I want to find the controller owner to inject a correct model name10:43
manadartnammn_de: "juju show-model controller" has "name", which is the full name.10:47
nammn_demanadart: thanks!10:49
achilleasamanadart: is it possible to (temporarily) override the state clock inside a test?10:54
achilleasaI am trying to write a test using WaitAdvance but timers are being created by other parts of the test suite10:55
manadartachilleasa: Which suite?10:56
achilleasaMachineSuite; I am testing the changes to the model machine watcher that I am working on10:56
achilleasa(see comments in https://github.com/juju/juju/pull/10902)10:56
achilleasaI could make the watcher c-tor accept a clock (or make it take functional options) but that is ugly/overkill (for options)10:57
manadartWould it work to change StateSuite.SetUpTest to only instantiate the suite's Clock if nil, then you could derive from MachineSuite, and in that SetUpTest set the clock before calling the base SetUpTest?11:02
achilleasafor my use case, the watcher pulls the clock from st.clock(); so if the clock gets injected it will be used by other things (e.g. txnwatcher) which means that I get more waiters on the clock (2 or 3 more)11:06
achilleasait wouldn't be a problem if the test was running in state instead of state_test...11:06
manadartachilleasa: Mock the clock?11:12
manadartachilleasa: I think it would be much nicer to do this everywhere and move away from the test clock.11:13
achilleasabut I am already using the test clock?11:14
achilleasaah... as in gomock?11:14
manadartachilleasa: Yep.11:14
achilleasanot sure if it's worth the effort here.... maybe just add a method to give me the watcher with a clock.Clock in export_test?11:15
achilleasa(yuk!)11:15
achilleasamanadart: nah... I will just add a "SetClock" helper and try to patch it by checking the interface...11:22
stickupkidmanadart, got a sec, quick question11:27
hmlmanadart: ready for review if you have a few: https://github.com/juju/juju/pull/1090315:35
manadarthml: Yep, taking a ride home this minute, but I will review once home.15:36
hmlmanadart:  rgr15:37
stickupkidanyone up for a CR on a backport? https://github.com/juju/juju/pull/1090615:59
achilleasastickupkid: looking16:01
hmlanastasiamac: review pls https://github.com/juju/juju/pull/1090921:52
* anastasiamac looking21:53
=== narindergupta is now known as narinderguptamac

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!