| rick_h | timClicks: yea, ipv6 comes from time to time but never becomes critical enough to get it scheduled unfortunately | 02:48 |
|---|---|---|
| wallyworld | kelvinliu: don't forget to remove these comments fromt the toml file! eg # source = "github.com/ycliuhw/charmrepo" | 04:04 |
| kelvinliu | wallyworld: sure, I will need to update the depfile after charm.v6 PR landed. | 04:06 |
| kelvinliu | wallyworld: so ru happy for me to land it now? | 04:06 |
| wallyworld | i can take one quick look again | 04:07 |
| wallyworld | needa break from these online modules | 04:07 |
| kelvinliu | k thx | 04:07 |
| kelvinliu | the charm-tool repo needs to be merged manually | 04:08 |
| wallyworld | kelvinliu: juju/charm and juju/juju look fine | 04:10 |
| wallyworld | what's the charm-tool repo? | 04:11 |
| wallyworld | url? | 04:11 |
| kelvinliu | wallyworld: https://github.com/juju/charm-tools/pull/555 | 04:11 |
| wallyworld | kelvinliu: ty, merge done | 04:13 |
| kelvinliu | thx | 04:13 |
| wallyworld | kelvinliu: once your stuff lands, here's a charm-helpers one https://github.com/juju/charm-helpers/pull/394 | 04:13 |
| wallyworld | no hurry and not critical for rc5 | 04:14 |
| wallyworld | *as | 04:14 |
| kelvinliu | ok | 04:14 |
| wallyworld | looks like i got a travis issue to fix | 04:15 |
| wallyworld | after coffee | 04:15 |
| wallyworld | kelvinliu: i updated the tests to patch the cmd_exists function. if you're happy, can you Approve? | 05:22 |
| kelvinliu | wallyworld: done, thx! | 05:24 |
| hpidcock | wallyworld: https://github.com/juju/juju/pull/10928 | 05:26 |
| hpidcock | you're running eoan right? | 05:27 |
| wallyworld | hpidcock: o am | 05:28 |
| wallyworld | *I | 05:28 |
| wallyworld | hpidcock: seems we use 0.1.2.3 in a few places | 05:29 |
| hpidcock | Yeah this seems to be the only test I found affected | 05:30 |
| hpidcock | but maybe there are more ¯\_(ツ)_/¯ I'll run tests again locally | 05:30 |
| wallyworld | would benice to change them all to be consistent | 05:31 |
| wallyworld | jujud agent tests now pass | 05:31 |
| hpidcock | ok yep, I'll make the change and run all the tests | 05:31 |
| wallyworld | with the change | 05:31 |
| hpidcock | :D | 05:31 |
| hpidcock | ehh wallyworld there are way too many references to 0.1.2.* addresses and not everything can be changed to 127.0.0.2+n addresses, since they are used in spaces stuff. It's probably safer to just move things one by one. | 06:39 |
| wallyworld | ok | 06:40 |
| wallyworld | are there any others that can be done easily? | 06:41 |
| wallyworld | ie to fix a test failure | 06:41 |
| hpidcock | no other tests fail | 06:41 |
| gnuoy | stickupkid, fwiw I tried to reproduce issue 366 on a cut down deploy but failed. So, I've added more details on reproducing it to the issue report. | 11:42 |
| stickupkid | gnuoy, I've got a potential fix | 11:43 |
| gnuoy | stickupkid, oh, that was quick. I shall keep everything crossed! I have a test environment I can try things out with if thats any help. | 11:44 |
| stickupkid | gnuoy, https://github.com/juju/python-libjuju/pull/367 - I'm going to double check against your repro steps this afternoon | 12:24 |
| rick_h | morning folks | 12:28 |
| gnuoy | stickupkid, thanks, I can test it too. I don't really understand why the remote application is missing or are you suggesting that the missing remote application is a transitive state ? fwiw the deploy I used to reproduce the issue it still exhibiting it. | 12:29 |
| === hml_ is now known as hml | ||
| stickupkid | gnuoy, i can replicate with your setup | 13:35 |
| stickupkid | gnuoy, i'll keep looking | 13:35 |
| gnuoy | kk, thanks stickupkid | 13:35 |
| stickupkid | gnuoy, what version of pylibjuju are you using? | 13:52 |
| gnuoy | stickupkid, I pip installed it without any bounds. | 13:53 |
| gnuoy | $ pip freeze | grep juju | 13:53 |
| gnuoy | juju==2.6.3 | 13:53 |
| stickupkid | gnuoy, can you try my PR, I think it should work | 14:00 |
| gnuoy | stickupkid, that seems to fix my issue, thanks. | 14:19 |
| stickupkid | gnuoy, amazing, ty | 14:21 |
| gnuoy | stickupkid, do you think the travis failures against your PR are unrelated to the change > | 15:07 |
| gnuoy | ? | 15:07 |
| stickupkid | gnuoy, travis is unreliable for pylibjuju, jenkins gives the best review analysis | 15:12 |
| gnuoy | kk | 15:12 |
| === sfeole is now known as sfeole_away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!