| mup | PR snapcraft#2825 opened: remote-build: remove need to specify user <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2825> | 02:49 |
|---|---|---|
| mup | PR snapd#7798 closed: interfaces/browser-support: allow reading status of huge pages <Simple 😃> <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7798> | 05:17 |
| mup | PR snapd#7801 closed: tests/main/gadget-update-pc: use a program to modify gadget yaml (2.42) <âš Critical> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7801> | 05:17 |
| mup | PR snapd#7779 closed: interfaces: misc updates for u2f-devices, browser-support, hardware-observe, et al <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7779> | 05:20 |
| mup | PR snapd#7804 opened: interfaces: misc updates for u2f-devices, browser-support, hardware-observe, et al (2.42) <Created by mvo5> <https://github.com/snapcore/snapd/pull/7804> | 05:32 |
| zyga | good morning mvo | 05:34 |
| zyga | mborzecki: hey | 06:33 |
| mborzecki | morning | 06:33 |
| mborzecki | zyga: hey | 06:33 |
| zyga | mborzecki: yesterday stuff was red all the time | 06:33 |
| zyga | I went to bed after 3rd round of restart-and-pray | 06:33 |
| zyga | I saw mvo merge and restart things that managed to land last night after I went to bed | 06:34 |
| mborzecki | there was a unit test failing on moster, but looks like it's fixed now | 06:34 |
| zyga | yeah | 06:34 |
| zyga | jamie fixed it | 06:35 |
| mborzecki | ok, cool | 06:35 |
| zyga | https://www.phoronix.com/scan.php?page=news_item&px=Linux-5.2-Go-Register-Corrupt | 07:21 |
| zyga | re | 07:26 |
| mborzecki | zyga: that's encouraging | 07:29 |
| Eighth_Doctor | for some godforsaken reason, I haven't fallen asleep yet | 07:54 |
| Eighth_Doctor | but anyway, looks like snapd 2.42.2 and snapd-glib 1.54 landed in all Fedora releases and EPEL 7 and EPEL 8 | 07:54 |
| pedronis | mvo: hi, I commented a bit on the next two UC20 PRs | 08:00 |
| === pstolowski|afk is now known as pstolowski | ||
| pstolowski | good morning | 08:03 |
| mvo | pedronis: thanks! | 08:05 |
| mborzecki | mvo: thanks for updating #7795 | 08:08 |
| mup | PR #7795: overlord/snapstate: pick up system defaults when seeding the snapd snap (2.42) <âš Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7795> | 08:08 |
| mborzecki | pstolowski: hey | 08:09 |
| mborzecki | Eighth_Doctor: yay! | 08:09 |
| mvo | mborzecki: no worries, let's hope it's fine this time | 08:14 |
| mborzecki | haha, #7799 is a nice playground for bikeshedding about performance with artificial microbenchmarks | 08:23 |
| mup | PR #7799: osutil/mount: de-duplicate code to use a list <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7799> | 08:23 |
| pedronis | pstolowski: hi, your prebake trello card seems to be still about the spike, vs landing the pieces | 08:27 |
| pedronis | I mean in Doing | 08:27 |
| pstolowski | pedronis: hey, right, will update, thanks | 08:27 |
| pedronis | thx | 08:28 |
| mup | PR snapd#7805 opened: osutil/mount: optimize flagOptSearch some more <Created by zyga> <https://github.com/snapcore/snapd/pull/7805> | 08:33 |
| zyga | pstolowski: hey | 08:48 |
| pedronis | zyga: ^ is that related to Ian's perf findings ? | 08:48 |
| zyga | pstolowski: simple one for the morning? https://github.com/snapcore/snapd/pull/7803 | 08:48 |
| mup | PR #7803: interfaces: remove reservedForOS from commonInterface <Created by zyga> <https://github.com/snapcore/snapd/pull/7803> | 08:48 |
| zyga | pedronis: yes | 08:49 |
| zyga | pedronis: it's a bit of a wake up thing | 08:49 |
| zyga | the original is still faster if we optimize allocation with popcount l | 08:49 |
| pstolowski | zyga: sure.. interesting, i though i removed it at some point when validation was delegated to policy check | 08:50 |
| zyga | thanks! | 08:50 |
| mup | PR snapd#7803 closed: interfaces: remove reservedForOS from commonInterface <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7803> | 08:50 |
| zyga | mvo: 2.42.3 is okay except for waiting for CI right? | 08:56 |
| zyga | mvo: I can jump into my regular feature work now | 08:56 |
| mvo | zyga: correct | 08:56 |
| mvo | zyga: once stuff is green I will release | 08:56 |
| pstolowski | Chipaca: hey, per yesterday's suggestion from pedronis, i'm happy to take https://github.com/snapcore/snapd/pull/7320 from you if that's ok | 08:56 |
| mup | PR #7320: snap/pack, cmd_pack: 'snap pack --check-skeleton' checks interfaces <Needs Samuele review> <Created by chipaca> <https://github.com/snapcore/snapd/pull/7320> | 08:56 |
| Chipaca | pstolowski: sure | 08:57 |
| Chipaca | pstolowski: was there more to do there? | 08:57 |
| pstolowski | Chipaca: there are a couple of comments, e.g. special casing for 'snap run' | 08:58 |
| pstolowski | Chipaca: i'll probably get to it in a day or two | 09:01 |
| Chipaca | right | 09:02 |
| ogra | jdstrand, do you actually want to boot without SD ? (sorry, i'm at a trade show so only saw your ping now) ... if you can live with SD, just copy the writable partition over to the USB drive, re-label the SD one to "writable-old" and make sure the USB one is labeled "writable" ... | 09:03 |
| zyga | pstolowski: that pip feature is super useful | 09:16 |
| zyga | pstolowski: thank you again | 09:16 |
| zyga | pstolowski: it works on top of vmware | 09:16 |
| mborzecki | zyga: pip? | 09:16 |
| pstolowski | zyga: yep it's super nice | 09:17 |
| mborzecki | as in picture-in-picture? | 09:17 |
| zyga | mborzecki: picture in picture | 09:17 |
| zyga | https://usercontent.irccloud-cdn.com/file/BH5R96NZ/pip-over-vmware.png | 09:17 |
| mborzecki | zyga: a macos thing? | 09:17 |
| zyga | mborzecki: safari feature | 09:17 |
| zyga | yeah | 09:17 |
| pstolowski | zyga: would be cool if it worked with meet/ho | 09:18 |
| zyga | does it? | 09:18 |
| pstolowski | nope | 09:18 |
| mup | PR snapd#7804 closed: interfaces: misc updates for u2f-devices, browser-support, hardware-observe, et al (2.42) <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7804> | 09:26 |
| pedronis | mborzecki: what's the plan with 7796, on its own is supposed to fail no? | 09:30 |
| pedronis | (it's failing on other random stuff atm) | 09:30 |
| mborzecki | pedronis: failed as planned https://paste.ubuntu.com/p/4rjfhJzjBT/ | 09:33 |
| pedronis | mborzecki: do you plan to change to contain the fix? land it with manual and do another PR? | 09:34 |
| mborzecki | pedronis: i'll be pushing the fix in snapstate into that branch | 09:34 |
| pedronis | ah ok | 09:34 |
| pedronis | it will need a summary change | 09:35 |
| pedronis | (stating the obvious in case :) ) | 09:35 |
| mborzecki | mhm | 09:41 |
| mborzecki | zyga: do you remember the bit we had in the spec that worked around fedora's patching of /bin/sh to /usr/bin/sh ? | 09:41 |
| zyga | yes | 09:42 |
| zyga | what about it? | 09:43 |
| mborzecki | zyga: must be blind, i'm looking at our spec and a downstream one and don't see it | 09:43 |
| zyga | one sec :) | 09:43 |
| zyga | mborzecki: we only have it in our test code | 09:44 |
| zyga | https://github.com/snapcore/snapd/pull/7614/files#diff-556bb7431481e375713ea3e0883a771aL111 | 09:44 |
| zyga | I remove it here | 09:44 |
| zyga | it's not downstream | 09:44 |
| mup | PR #7614: cmd/snap-confine: implement snap-device-helper internally <Created by zyga> <https://github.com/snapcore/snapd/pull/7614> | 09:44 |
| mborzecki | zyga: right, i was asking in the context of https://bugs.launchpad.net/snapd/+bug/1824158 | 09:45 |
| mup | Bug #1824158: compatibility bug with fedora <snapd:Confirmed for maciek-borzecki> <https://launchpad.net/bugs/1824158> | 09:45 |
| zyga | mborzecki: it's the impossible task of using one program from both contexts | 09:46 |
| zyga | mborzecki: not sure what you are asking about specifically | 09:46 |
| zyga | mborzecki: the bug is still present | 09:46 |
| zyga | it's fixed by the PR I referenced | 09:47 |
| mborzecki | zyga: downstream had _brp_mangle_shebangs_exclude ^/bin/(bash|sh)$, but that got dropped when updating to 2.41, don't recall why | 09:52 |
| zyga | I don't recall why either | 09:52 |
| zyga | perhaps accident? | 09:52 |
| mborzecki | Eighth_Doctor: do you recall whether that mangling workaround was no longer needed? | 09:53 |
| mup | PR snapd#7806 opened: tests/lib/prepare: drop workarounds for rpmbuild rewriting /bin/sh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7806> | 10:05 |
| pstolowski | dot-tobias: ping | 10:05 |
| zyga | mborzecki: why do you want to drop https://github.com/snapcore/snapd/pull/7806 | 10:06 |
| mup | PR #7806: tests/lib/prepare: drop workarounds for rpmbuild rewriting /bin/sh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7806> | 10:06 |
| zyga | it's not going to pass today, is it? | 10:07 |
| mborzecki | zyga: ohmygiraffe works on f31 without the rewrite, quite sure it picked up the drm dervices since there's opengl interface involved | 10:07 |
| zyga | mborzecki: because f31 has v2? | 10:07 |
| zyga | I mean, it's premature | 10:08 |
| mborzecki | zyga: it's f30 | 10:08 |
| mborzecki | the system i tried it on | 10:08 |
| zyga | on f31 you don't have device cgroup | 10:08 |
| zyga | on f29 it will regress | 10:08 |
| zyga | unless I'm missing something | 10:08 |
| zyga | we should not drop that yet | 10:08 |
| jamesh | zyga: a while back, you said you were working on a better way to detect snap confined apps than reading the cgroup proc file. Has any progress happened with that? | 10:17 |
| zyga | jamesh: yes, there's been a lot of progress on this topic | 10:17 |
| zyga | jamesh: but the means have changed | 10:17 |
| zyga | jamesh: because of all kinds of unexpected complexity | 10:17 |
| zyga | jamesh: I'm working on this today actually | 10:18 |
| pedronis | Chipaca: hi, maybe you could get to do a first review of #7771 when you have a moment ? | 10:18 |
| mup | PR #7771: o/hookstate/ctlcmd: snapctl is-connected command <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/7771> | 10:18 |
| Chipaca | a'yup | 10:18 |
| zyga | jamesh: the status quo is that we'll use a systemd _scope_ for all non-service processes | 10:18 |
| zyga | jamesh: and typical service cgroup for services | 10:18 |
| jamesh | zyga: awesome. Is it still a file we can read from the process's mount namespace, or something else? | 10:19 |
| zyga | jamesh: I'll share the details if you want | 10:19 |
| zyga | jamesh: but if you wait a day you I will have the new PR up | 10:19 |
| zyga | jamesh: a means to check if a process belongs to a snap involves reading /proc/[pid]/cgroup | 10:20 |
| zyga | jamesh: one _can_ spoof this | 10:20 |
| zyga | jamesh: but it's true for all snaps | 10:20 |
| zyga | jamesh: does this make sense so far? | 10:21 |
| jamesh | zyga: I can wait for the PR. I'm mostly interested in terms of improving xdg-desktop-portal's snap support | 10:21 |
| mborzecki | zyga: hm looks like you fixed it a while ago https://github.com/snapcore/snapd/commit/641adbf815db392248134a6cfe9650e1abf89575 | 10:21 |
| mborzecki | zyga: https://github.com/snapcore/snapd/pull/7049 yeah, that'd explain why it works now | 10:22 |
| zyga | mborzecki: interesting :) | 10:22 |
| mup | PR #7049: cmd/snap-confine: handle device cgroup before pivot <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7049> | 10:22 |
| zyga | mborzecki: but even if we run it, will it run correctly? | 10:22 |
| jamesh | zyga: so I mostly want something that (a) doesn't depend on AppArmor like the current code does, (b) is unlikely to change over snapd versions | 10:22 |
| zyga | it won't run in one of the two spaces | 10:22 |
| === pedronis_ is now known as pedronis | ||
| zyga | jamesh: a) is true b) is something we can try to promise to keep | 10:22 |
| mborzecki | zyga: yes, it's run either by s-c inside the host ns, or udev also in host ns | 10:22 |
| zyga | jamesh: a) also works across cgroup v1 and v2 | 10:22 |
| jamesh | zyga: false positives are not too bad, since we'd be shelling out to "snap routine portal-info" to get the actual information | 10:23 |
| zyga | jamesh: that's great | 10:23 |
| jamesh | which could do something snapd version specific | 10:23 |
| zyga | brb | 10:26 |
| pedronis | mvo: 7797 will need updating because of 7792 | 10:28 |
| mvo | pedronis: yeah, I will do as soon as one of them lands | 10:29 |
| mup | PR snapd#7807 opened: snap-bootstrap: remove SNAPPY_TESTING check, we use it for real now <Simple 😃> <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7807> | 10:29 |
| mup | PR snapd#7794 closed: many: backport pull request #7773 from zyga/fix/lp-1852361 <âš Critical> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7794> | 11:08 |
| mup | PR snapd#7795 closed: overlord/snapstate: pick up system defaults when seeding the snapd snap (2.42) <âš Critical> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7795> | 11:08 |
| zyga | mvo: woot, thank you | 11:08 |
| mborzecki | yay | 11:20 |
| mborzecki | so .3? | 11:20 |
| mup | PR snapcraft#2826 opened: Copy npm and npx binaries in snap <Created by guilhem> <https://github.com/snapcore/snapcraft/pull/2826> | 11:26 |
| Chipaca | pstolowski: almost +1 on 7771 | 11:27 |
| mvo | zyga, mborzecki *thank you* ! | 11:28 |
| pstolowski | Chipaca: ty | 11:29 |
| zyga | mvo: as soon as .3 is out I'll do a suse version | 11:30 |
| mvo | zyga: working on it now, had a meeting before | 11:36 |
| zyga | cool, no rush :) | 11:36 |
| pedronis | mvo: mborzecki: what about 7796 ? | 11:47 |
| mborzecki | pedronis: i did the change we discussed, waiting for spread test, but still have some wonderings about the fix | 11:59 |
| mborzecki | need to run a quick errand, back in 30 or so | 12:00 |
| mup | PR snapd#7808 opened: release: 2.42.3 <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7808> | 12:06 |
| mvo | pedronis: you mean what about 7796 for 2.42.3? | 12:09 |
| pedronis | mvo: yes | 12:15 |
| cachio | pstolowski, hey | 12:18 |
| pstolowski | cachio: hi | 12:18 |
| cachio | I am researching the test bad-interfaces-warm | 12:20 |
| cachio | and I see an error when we execute on arm devices | 12:20 |
| cachio | pstolowski, this is the otuput of the snap install https://paste.ubuntu.com/p/XpY4spwC5Q/ | 12:21 |
| mvo | pedronis: I thought we said it's not criticial for this release, has that changed? we also don't have a fix yet, correct? i.e. so far this is the regression test | 12:21 |
| pedronis | mvo: it is kind of critical given we don't know how they use the device | 12:22 |
| pedronis | mvo: it's the third aspect that is not critical | 12:22 |
| cachio | pstolowski, I see that on edge and beta | 12:23 |
| cachio | pstolowski, is it a bug? | 12:24 |
| cachio | right? | 12:24 |
| pstolowski | cachio: no. unless the test failed? | 12:25 |
| pstolowski | cachio: this is a new test about bad plug/slots | 12:25 |
| pstolowski | cachio: snap install will warn if there are bad plugs/slots | 12:26 |
| cachio | pstolowski, the test fails | 12:26 |
| pstolowski | cachio: can you show me the full output? | 12:26 |
| cachio | pstolowski sure | 12:27 |
| cachio | https://paste.ubuntu.com/p/zGzjtTdRjs/ | 12:27 |
| mvo | pedronis: ok, that sounds like we need a .4 :/ let me tag it with 2.42. and critical | 12:28 |
| pedronis | mvo: sorry, I thought it was clear we wanted a fix for this in too | 12:29 |
| cachio | mvo, hey, should I invest time testing .3? | 12:29 |
| cachio | if we are going to have a .4? | 12:29 |
| mvo | pedronis: I misunderstood, sorry | 12:29 |
| mvo | cachio: yes, .4 there will be | 12:29 |
| cachio | ok | 12:30 |
| pstolowski | cachio: is this test run against latest snapd? looks like the new functionality is not there | 12:31 |
| cachio | on edge if failing with the same error | 12:33 |
| pstolowski | hmm or maybe there is a race and warning is not immediately available | 12:33 |
| pstolowski | cachio: do you have shell with this failrue? | 12:33 |
| cachio | pstolowski, yes | 12:33 |
| cachio | I am refreshing to edge now | 12:33 |
| pstolowski | cachio: can you execute 'snap warnings' ? | 12:33 |
| cachio | No warnings. | 12:34 |
| cachio | with beta | 12:34 |
| cachio | letme refresh to edge | 12:34 |
| cachio | pstolowski, same output with core on adge | 12:42 |
| cachio | pstolowski, using this core 16-2.42.2+git1570.35c66d9 | 12:42 |
| cachio | also: No warnings. | 12:42 |
| zyga | mborzecki: https://github.com/snapcore/snapd/pull/7806#pullrequestreview-323645799 | 12:46 |
| mup | PR #7806: tests/lib/prepare: drop workarounds for rpmbuild rewriting /bin/sh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7806> | 12:46 |
| mup | PR snapd#7799 closed: osutil/mount: de-duplicate code to use a list <Simple 😃> <Created by anonymouse64> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7799> | 12:47 |
| ijohnson | zyga, mborzecki: so I stayed up all night and hand wrote GPU assembly and was able to get that mount opts parsing code down to 4 planck time units! | 12:53 |
| zyga | ijohnson: hehe | 12:53 |
| zyga | hey :) | 12:53 |
| ijohnson | Morning :-) | 12:53 |
| zyga | ijohnson: I think the original would be still fastest with the only extra change to get the array size done up front | 12:54 |
| pstolowski | hey ijohnson | 12:54 |
| pstolowski | does anyone know how to map our short git1570.35c66d9 version number to git log? | 12:54 |
| mborzecki | re | 12:54 |
| mborzecki | ijohnson: hahah ;) must have been a great deal of fun | 12:55 |
| zyga | ijohnson: did you see 7805? | 12:55 |
| pstolowski | cachio: i suspect core doesn't have my change yet for some reason as was a case already in the past. i need to decode that git version string to check | 12:57 |
| ijohnson | zyga: I saw the email notifications y'all had more optimizations, but haven't really looked yet | 12:58 |
| pstolowski | cachio: this is backed up by the fact that even snap warnings doesn't show anything | 12:59 |
| ijohnson | pstolowski: is that from the edge channel? IIRC that git commit is from some other repo that builds the core snap on edge | 12:59 |
| cachio | pstolowski, I can check on amd64 | 12:59 |
| cachio | pstolowski, I found the problem | 13:00 |
| cachio | snapd-vendor-sync is not running | 13:00 |
| pstolowski | whew | 13:00 |
| zyga | whee | 13:01 |
| cachio | pstolowski, I'll check the vm to see why | 13:01 |
| zyga | thinkpad cover arrived | 13:01 |
| cachio | pstolowski, thanks | 13:01 |
| pstolowski | cachio: yw | 13:01 |
| pstolowski | ijohnson, cachio is vendor sync / other repo making this version number completely different from our git revisions~? | 13:02 |
| cachio | pstolowski, yes | 13:03 |
| pstolowski | huh | 13:03 |
| cachio | snapd-verdor-sync does not use github | 13:03 |
| pstolowski | that's annoying | 13:03 |
| * ijohnson goes back to breakfast | 13:05 | |
| mup | PR snapd#7797 closed: devicestate: make /var/lib/snapd/seed available in install mode <UC20> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7797> | 13:06 |
| * Chipaca takes a break, and reboots while at it | 13:14 | |
| zyga | good progress on cgroup bits, one last annoying spread test and I'll open a PR for initial review | 13:21 |
| === ricab is now known as ricab|bbl | ||
| zyga | thnkpad is fixed :) | 13:50 |
| zyga | uhhh | 13:56 |
| zyga | it's not | 13:56 |
| mborzecki | zyga: thinkpad is never broken, it's only an transient non-working state | 13:56 |
| zyga | the part was broken | 13:56 |
| zyga | heh | 13:56 |
| zyga | that's ok | 13:56 |
| zyga | it's silly | 13:56 |
| mborzecki | unless it's cooling, it's broken by design | 13:57 |
| zyga | part of the bottom cover is broken | 13:57 |
| zyga | but that's ... enough | 13:57 |
| zyga | I guess | 13:57 |
| zyga | spending more money on this is probably not worth it | 13:57 |
| mup | PR snapd#7800 closed: tests: add Ubuntu Eoan to google-sru backend <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7800> | 13:59 |
| zyga | ijohnson: did I understand you correctly that snap-confine without root was the topic you mentioned? | 14:06 |
| zyga | like without root at all | 14:06 |
| ijohnson | zyga: https://forum.snapcraft.io/t/permissions-problem-using-snapcraft-in-azure-pipelines/13258/10?u=ijohnson | 14:07 |
| ijohnson | no, "/" is not root-owned is the issue | 14:07 |
| zyga | ah | 14:07 |
| zyga | what's fun | 14:07 |
| zyga | and weird | 14:07 |
| zyga | we can relax that check I guess | 14:07 |
| zyga | is there a corresponding bug report? | 14:08 |
| ijohnson | no I don't think so | 14:08 |
| zyga | ok | 14:09 |
| zyga | I'd like to understand why / is 501 though, it's a bit silly and odd | 14:10 |
| zyga | I'll read the thread after the standup | 14:10 |
| Chipaca | dot-tobias: ping | 14:14 |
| ijohnson | pstolowski: let me know if you want me to look at your service branch, wasn't sure if that's one of your current open PR's or a local branch | 14:18 |
| pstolowski | ijohnson: thanks, it's not proposed yet; i'll dig a bit more myself. will definately ask you for a review when ready. nb, have you discussed any particular approach for fixing snapctl side? | 14:20 |
| ijohnson | pstolowski: there's this forum post: https://forum.snapcraft.io/t/systemctl-service-management-unification/13808 I need to post an update from the discussion I had with folks after that on the plan so yes we have discussed the approach, I forgot to put it on the forum :-) | 14:21 |
| pstolowski | ijohnson: great, ty! | 14:22 |
| mborzecki | pedronis: i've updated #7796 | 14:39 |
| mup | PR #7796: overlord/snapstate: make sure configuration defaults are applied only once <âš Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7796> | 14:39 |
| mborzecki | heh, typo | 14:42 |
| mup | PR snapd#7776 closed: interfaces: add login-session-observe for who, {fail,last}log and loginctl <Needs Samuele review> <Created by jdstrand> <Merged by jdstrand> <https://github.com/snapcore/snapd/pull/7776> | 14:42 |
| mborzecki | off to pick up the kids | 14:43 |
| pedronis | mvo: mborzecki: small comment on ^ | 14:50 |
| pedronis | heh, I mean #7796 | 14:50 |
| mup | PR #7796: overlord/snapstate: make sure configuration defaults are applied only once <âš Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7796> | 14:50 |
| pstolowski | Chipaca: I think I addressed all your comments to #7771 | 14:56 |
| mup | PR #7771: o/hookstate/ctlcmd: snapctl is-connected command <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/7771> | 14:56 |
| Chipaca | pstolowski: thank you | 14:58 |
| mup | PR snapd#7793 closed: devicestate: read modeenv early and store in devicestate <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7793> | 14:58 |
| ijohnson | pstolowski: I updated https://forum.snapcraft.io/t/systemctl-service-management-unification/13808/7?u=ijohnson with what we discussed in that meeting | 15:02 |
| === ricab|bbl is now known as ricab | ||
| pstolowski | ijohnson: thanks for that and for the exhaustive description of the problem. looks like it may be a separate PR that's a prerequisite for my current set of changes | 15:04 |
| ijohnson | pstolowski: ok, does this mean you are now blocked on me working on that? I think I'm at a point now where I can switch to doing that instead of the performance stuff, just need to get folks to agree on what we should do now I think | 15:05 |
| mup | PR snapd#7809 opened: interfaces: remove leftover reservedForOS <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7809> | 15:07 |
| pstolowski | ijohnson: ah, you inteded to do that? i thought it was passed to me after your initial changes to services. yes, this is kinda blocking, i'm not sure there is a way around that | 15:08 |
| ijohnson | pstolowski: yes that was the plan that I was going to work on that after I wrapped up the performance stuff. but if you're totally blocked on it, considering I will be out on thurs + friday, perhaps it makes more sense for you to get started on that | 15:09 |
| pstolowski | ijohnson: right, it may be best if i take it (as long as it doesn't make your plate empty ;)) | 15:11 |
| ijohnson | I'm sure mvo can find something else for me to work on :-) | 15:11 |
| mvo | ijohnson: haha, I'm not worried about this | 15:12 |
| pstolowski | :) | 15:13 |
| pstolowski | ijohnson, mvo: ok, i'll take it then | 15:13 |
| ijohnson | zyga: I think https://github.com/snapcore/snapd/pull/7805 is ready to merge now :-) | 15:13 |
| mup | PR #7805: osutil/mount: optimize flagOptSearch some more <Performance 🚀> <Created by zyga> <https://github.com/snapcore/snapd/pull/7805> | 15:13 |
| zyga | looking | 15:14 |
| zyga | ijohnson: I may do more ;) | 15:14 |
| zyga | ijohnson: but it was fun, thank you | 15:14 |
| mup | PR snapd#7805 closed: osutil/mount: optimize flagOptSearch some more <Performance 🚀> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7805> | 15:15 |
| * cachio lunch | 15:15 | |
| ijohnson | you're welcome :-) always happy to help in this way | 15:15 |
| mup | PR snapd#7810 opened: devicestate: add reading of modeenv to uc20 firstboot code <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7810> | 15:24 |
| zyga | Chipaca: are you a forum admin? | 15:25 |
| zyga | Chipaca: could you please fork https://forum.snapcraft.io/t/snap-layouts/7207/36 to a new thread | 15:25 |
| Chipaca | zyga: a moderator, not an admin, but i can fork | 15:26 |
| Chipaca | zyga: thread title? | 15:26 |
| Chipaca | and category plz | 15:26 |
| zyga | python3 application with external module | 15:26 |
| zyga | snap | 15:26 |
| zyga | I think that matches it | 15:26 |
| zyga | careful, the reporter is writing more in the original thread | 15:26 |
| zyga | so you may need to wait a sec | 15:27 |
| zyga | ah | 15:27 |
| zyga | I see you just did | 15:27 |
| zyga | cool, thanks! | 15:27 |
| Chipaca | zyga: i can move the reply too | 15:27 |
| zyga | thanks | 15:28 |
| zyga | he is still typing | 15:28 |
| Chipaca | zyga: was that the right place to cut it? | 15:28 |
| zyga | yeah | 15:28 |
| Chipaca | ok | 15:28 |
| zyga | that's great | 15:28 |
| mborzecki | re | 15:53 |
| * zyga dinner | 15:58 | |
| mborzecki | pedronis: thanks for the comments, updated 7796 with little tweaks to make that if more readable | 16:00 |
| mvo | cmatsuoka: do you think you could give 7792 a look? | 16:08 |
| mvo | mborzecki: thanks so much for this fix! | 16:09 |
| cmatsuoka | mvo: checkint it | 16:16 |
| cmatsuoka | checking it | 16:16 |
| mvo | ta | 16:16 |
| pedronis | mborzecki: +1, thanks | 16:19 |
| mborzecki | mvo: pedronis: thanks! | 16:34 |
| pedronis | is master broken? | 16:41 |
| pedronis | it seems there were again out-of-sync landings | 16:41 |
| pedronis | yes :/ | 16:43 |
| mborzecki | pedronis: https://github.com/snapcore/snapd/pull/7809 should fix master | 16:44 |
| mup | PR #7809: interfaces: remove leftover reservedForOS <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7809> | 16:44 |
| pedronis | ah | 16:45 |
| pedronis | yes | 16:45 |
| mvo | pedronis: 7792 landed so you can do the followup with the wording tweaks | 16:47 |
| pedronis | mvo: thx | 16:48 |
| mup | PR snapd#7792 closed: snap-bootstrap: write /run/mnt/ubuntu-data/var/lib/snapd/modeenv <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7792> | 16:48 |
| pedronis | mvo: I finished the code for plug-names/slot-names, waiting for fixed master (because I rebased on it) before pushing though | 16:49 |
| zyga | mvo: sorry about the trouble | 16:49 |
| * zyga overcame an issue with lxd just now :) | 16:50 | |
| zyga | whee | 16:50 |
| zyga | and learned a lot :) | 16:50 |
| mvo | pedronis: cool, yeah, I have another (small) PR waiting for this too | 16:50 |
| pedronis | mvo: actually I might have spotted a bug | 16:54 |
| pedronis | mvo: seedDir needs to be seed not seed/systems | 16:55 |
| mvo | pedronis: oh, right! nice catch, thank you! | 16:55 |
| pedronis | mvo: I can fix in this PR if you want, or at least try | 16:56 |
| zyga | lol | 16:56 |
| zyga | I was wondering what kept spawning qemu | 16:56 |
| zyga | I was running "spread ... ubuntu-18.04-64:tests/main" | 16:57 |
| zyga | notice the lack of google: | 16:57 |
| pedronis | mvo: mmh, no the code is right just a bit confusing | 16:58 |
| zyga | ondra: hey | 16:59 |
| zyga | around? | 16:59 |
| pedronis | mvo: these are the changes I have in mind: https://github.com/pedronis/snappy/commit/7fe73e0848db2db203e1d42439d024a8f8bad1d8 | 17:05 |
| === pstolowski is now known as pstolowski|afk | ||
| mvo | pedronis: looks good! | 17:34 |
| ijohnson | jdstrand: hey do you have some time today to chat about bpf (i.e. seccomp) and non-root owned "/" ? it's an issue for folks using github actions / azure pipelines because for some reason "/" is not root-owned | 17:39 |
| zyga | ijohnson, jdstrand: if you do please include me | 17:40 |
| vidal72[m] | is snapd 2.42.3 available in snap? | 17:45 |
| zyga | vidal72[m]: .4 will be available in a few days | 17:48 |
| zyga | vidal72[m]: mvo is doing the release today | 17:49 |
| mvo | vidal72[m]: .3 is available in candidate, .4 is scheduled for today but testing is a bit tricky today (some unrelated issues) | 17:50 |
| zyga | I'll call it a day soon | 17:55 |
| zyga | but it's a good day because I've confirmed everything is working as expected | 17:55 |
| * zyga fired last run of spread across all OSes to see if it has any extra issues | 17:55 | |
| * zyga EODs | 18:02 | |
| zyga | ttyl! | 18:02 |
| mup | PR snapd#7809 closed: interfaces: remove leftover reservedForOS <Simple 😃> <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7809> | 18:18 |
| mup | PR snapd#7811 opened: cmd/snap-bootstrap: some small naming and code org tweaks <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/7811> | 18:20 |
| pedronis | mvo: I merged master fix and proposed ^ | 18:20 |
| mup | PR snapd#7812 opened: asserts: parse plug-names/slot-names constraints <Created by pedronis> <https://github.com/snapcore/snapd/pull/7812> | 18:24 |
| === ^arcade_droid is now known as zarcade_droid | ||
| mup | PR snapd#7813 opened: interfaces/policy: enforce plug-names/slot-names constraints <Created by pedronis> <https://github.com/snapcore/snapd/pull/7813> | 18:27 |
| mvo | pedronis: thank you! | 18:56 |
| mup | PR snapd#7814 opened: overlord/snapstate: make sure configuration defaults are applied only once (2.42) <âš Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7814> | 19:02 |
| mup | PR snapd#7807 closed: snap-bootstrap: remove SNAPPY_TESTING check, we use it for real now <Simple 😃> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7807> | 20:15 |
| mup | PR snapd#7808 closed: release: 2.42.3 <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7808> | 20:16 |
| mup | PR snapd#7815 opened: tests: reduce the complexity of the test-snapd-sh snap <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7815> | 22:45 |
| === arnatious_ is now known as arnatious | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
