kelvinliu | wallyworld: https://github.com/juju/juju/pull/10961 +1 plz | 00:50 |
---|---|---|
wallyworld | kelvinliu: there's 3 places to change | 00:51 |
wallyworld | setup.iss etc as well | 00:51 |
wallyworld | look at a closed pr from the bot for what to cange | 00:51 |
kelvinliu | yep | 00:51 |
kelvinliu | wallyworld: updated | 00:53 |
wallyworld | kelvinliu: merged. i'll start a doc when i'm done with xtian | 00:54 |
kelvinliu | wallyworld: thanks! | 00:55 |
babbageclunk | thumper: have you got a moment for a quick chat? Want to make sure I understand something about watchers. | 01:45 |
thumper | babbageclunk: sure | 01:45 |
thumper | jump in 1:1 | 01:45 |
babbageclunk | yup | 01:45 |
thumper | wallyworld, kelvinliu: there is more than one file to update for the version number | 02:02 |
kelvinliu | thumper: yeah, there are 3 | 02:02 |
thumper | kelvinliu: ah, I was just looking at the initial PR files changed | 02:03 |
kelvinliu | refresh, haha | 02:03 |
kelvinliu | wallyworld: https://github.com/juju/juju/pull/10963 to add k8s python client to operator pod; +1 plz | 02:59 |
achilleasa | manadart: when you 've got a bit of time can you please take a look at https://github.com/juju/juju/pull/10964? | 09:01 |
manadart | achilleasa: Yep. | 09:07 |
achilleasa | manadart: the aliasing was intentional to avoid confusion. Initially I tried to replace juju/network with core/network so we could reference the types as network.InterfaceInfo but it looked like a mess esp between files and their _test siblings so I decided to have consistent aliasing everywhere | 10:00 |
manadart | achilleasa: We can live with it for now. | 10:01 |
achilleasa | btw, I 've noted this in the PR description. It should make renaming easier when network gets eventually phased out in favor of core/network | 10:02 |
manadart | stickupkid: As discussed: https://github.com/juju/juju/pull/10965 | 11:30 |
nammn_de1 | stickupkid initial pr for cmr saas migration: https://github.com/juju/juju/pull/10967 after your pr is merged i can test whether this would work. At least it is finding the correct controller/model and redirects correctly | 16:43 |
stickupkid | nammn_de1, i'm not here tomorrow, so it might not be till next week, i'm almost done on applicationOffers, the release got in the way | 16:44 |
stickupkid | nammn_de1, still around? | 18:00 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!