[05:42] <anastasiamac> wallyworld: PTAL when/if u get a chance https://github.com/juju/juju/pull/10968
[07:12] <wallyworld> looking
[11:19] <nammn_de1> manadart mind taking a look at that? https://github.com/juju/juju/pull/10943 stickupkid said he approved on trello but maybe he forgott on gh
[11:20] <manadart> nammn_de1: Sure.
[12:18] <nammn_de1> manadart: thanks for the review
[12:18] <manadart> nammn_de1: Sure.
[12:19] <nammn_de1> the reason I had 2 getters was
[12:19] <nammn_de1> that the migration/firewallrules interface
[12:19] <nammn_de1> "needs" a wellknownservice of type string
[12:20] <nammn_de1> wanted to follow how we right now seem to do the migrations
[12:21] <nammn_de1> I could alternatively remove the migrations/firewallRules file and do everything in migration_import
[12:22] <nammn_de1> manadart: https://github.com/juju/juju/blob/70869ebce8e8f914a5ff68c410d7a2f5434a61ce/state/migrations/firewallRules.go#L15
[12:22] <achilleasa> nammn_de1: ^^ could you please snake case that file?
[12:23] <achilleasa> (name)
[12:23] <nammn_de1> achilleasa: oh yeah
[12:23] <nammn_de1> puh
[12:23] <nammn_de1> didnt even realize
[12:24] <manadart> nammn_de1: If you need that to be a string in order not to depend on the type in state, move the type and consts to core/firewall.
[12:25] <manadart> I think the firewall type itself could go there, but there's no need to do that at this point.
[12:25] <nammn_de1> manadart: ahh that makes sense. Didn't even took a proper look at core
[12:26] <manadart> nammn_de1: firewall doesn't exist in core; just create it.
[12:37] <nammn_de1> manadart: oh, i meant the general concept of core. Just read through the doc.go :D
[14:43] <nammn_de1> manadart: this should be reviewable again https://github.com/juju/juju/pull/10943
[14:49] <nammn_de1> + added a comment on your comment  https://github.com/juju/juju/pull/10967#discussion_r352162753 Maybe I couldnt follow you fully what you meant
[16:12] <hallback> At my previous company (Scania, Sweden) we've been using reactive charms on CentOS 7 for almost a year now in production. This has required some small modifications on charmhelpers and layer-basic (PR made by Erik Lönroth already), and I decided to share that today: https://github.com/juju/charm-helpers/pull/400
[22:07] <rick_h> hallback:  awesome, I've been wanting to catch up on that to see what gaps there were
[22:07] <rick_h> hallback:  good stuff, look forward to giving it a go
[23:32] <pmatulis> er, on 2.7 is it normal for 'juju credentials' to hang?