/srv/irclogs.ubuntu.com/2019/12/04/#juju.txt

wallyworldhpidcock: this looks bigger than it is - small code changes but significant test boilerplate, deletion of unused code etc https://github.com/juju/juju/pull/1098204:13
hpidcockon it04:14
wallyworldty, sorry in advance04:18
wallyworldit was a bitch to write04:18
hpidcockwallyworld: LGTM, tried it out on gce with no issues05:37
wallyworldhpidcock: awesome, ty05:43
wallyworldstill go 3 pacgaes to go, won't be as hard05:43
wallyworldi tested with k8s as well05:44
wallyworldas they use resources etc05:44
timClickscould someone please take a look at a discourse answer I've just given and check that it makes sense? I should really log off https://discourse.jujucharms.com/t/how-to-deploy-charms-to-specific-clusters-on-vsphere-cloud/2396/809:04
manadartstickupkid or nammn_de1: https://github.com/juju/juju/pull/1098309:57
stickupkidlove it when this happens https://paste.ubuntu.com/p/ccsyVWTC5r/10:34
achilleasastickupkid: you can just claim that one of the two contains a zero-width unicode character :D10:38
manadartachilleasa: Did you have any success with that test in your patch?12:09
achilleasamanadart: still chasing it down :-(12:17
achilleasaI am down to sprinkling fmt.Printf statements everywhere...12:18
* achilleasa needs stronger coffee...12:18
gnuoykwmonroe, hi there, a work aroundthat was put into layer basic sometime ago (https://github.com/juju-solutions/layer-basic/pull/51/files) seems to be no longer valid (https://github.com/juju-solutions/layer-basic/issues/149). I'd like to put up a PR to remove the workaround but am concerned I might set the world on fire. Do you have any thoughts on the issue ?14:13
gnuoyfwiw just removing the allow_hosts line works for me but am I guessing that was needed in the original work around14:14
gnuoys/but am I/but I'm/14:15
achilleasamanadart: hmmm... I still need to add a "NewScopedProviderAddressInSpace" c-tor though16:16
manadartachilleasa: Yeah, that's OK for now.16:16
nammn_de1rick_h and anyone else regarding the "not returning an error if no controller is found". I would love to have some opinions on this one https://github.com/juju/juju/pull/10985/files#diff-bcdb02984a8543f1187ed21cb4812a8fL206 Just opened a draft to see how one could handle it. Wrote more on the gh PR16:45
rick_hnammn_de1:  cool otp but will take a peek after lunch ty16:46
nammn_de1rick_h: sure its just initial draft to discuss possible solutions, as this would require changes on multiple places16:47
achilleasamanadart: I think I found the issue that broke that test...16:53
manadartachilleasa: nice.17:15
achilleasamanadart: when I added the new shims for testing the link layer device update path I accidentally made the StateMachine interface in the instancepoller test code incompatible with what FindEntity returned...17:29
achilleasaobviously it worked with the mocked state in the instancepoller package but exploded for that particular agent test17:29
kwmonroehey gnuoy, i've read the upstream issues once per hour since you pinged me, and i still don't have a good feeling about the ramifications of removing allow_hosts.  punting to cory_fu because he loves issues like https://github.com/juju-solutions/layer-basic/issues/14917:54
gnuoyhaha, sounds good to me17:58
cory_fukwmonroe, gnuoy: Since we have a pre-bootstrap step to update pip & setuptools, as long as those get the new enough version to have the "never use easy_install" behavior for packages using install_requires, I think it should probably be ok.  Definitely should get plenty of testing, though.17:59
cory_fuOh, it probably depends more on the version of pip & setuptools used by the build process, actually, rather than at deploy time.18:00
cory_fuShould make it easier to test, at least.18:00
cory_fuOh, nm, that bit is in fact to ensure that the bootstrap phase doesn't hit pypi for some packages.  So it does require a deploy test, and it requires one in a network-restricted environment (or at least blocking pypi, or maybe checking the logs for indications that pypi is being used)18:03
cory_fugnuoy: So, testing will be a pain, but I'm cautiously optimistic that it will work fine.18:03
cory_fuI really really hope we can come up with a better method for dependency management for charms soon (new framework, then maybe backported to reactive).  I'm hopeful that the ESM stuff can inform us on better patterns18:05
babbageclunkwallyworld: I'm updating the CrossModelRelations client to be able to talk to either v2 or v1 of the server API (expanding the v1 events into v2 ones if needed). I don't think I need to do that for the RemoteRelations, since that's inside one controller - the API version will always be >= than the "client" (actually a worker in the controller agent anyway).22:40
babbageclunkwallyworld: does that make sense to you?22:40

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!