zygagood morning07:19
zygaos upgrade, brb07:19
zygare again07:37
* zyga looks at his inbox07:37
zygaeh, first mail is to pay taxes07:40
zygaoh well07:40
zygasdhd-sascha: found your mail07:41
zygasdhd-sascha: do you mind if I answer here07:41
zygaI prefer IRC over email any day of the week07:41
sdhd-saschazyga: no - but some task i already have done yesterday07:42
zygasdhd-sascha: about snap run test - I is up to you, perhaps the snap run test is overcrowded and deserves to be split into run, run + strace, run + gdb and run + ltrace07:43
zygaabout wayland, yay!07:43
zygaas for /etc/debian_version, I think it's more complex because 1) we want to stop sharing /etc with the host 2) if it is a symlink that points to /usr it will be useless (like os-release on some systems) 3) usually reading os information is not really necessary, apart from "vanity" reasons like "you are running $foo" screens - what's the motivation behind reading /etc/debian_releae?07:45
zygasdhd-sascha: as for spread, that's easy, just build it from github and run with locally made images07:45
zygasdhd-sascha: you can fetch some of my older images from spread.zygoon.pl07:45
zygasdhd-sascha: those images are made with autopkgtest create image tools but really, any tool that spits out a machine with password auth is okay (for simplicity)07:46
sdhd-saschazyga: i run: ~/work/src/github.com/snapcore/snapd$ spread -v qemu:ubuntu-18.04-6407:47
sdhd-saschaAnd then i currently get only no connection07:47
zygasdhd-sascha: your mileage will vary in some cases as we tweak our images more than not for certain aspects that are murky but you should have a good start that will let you iterate x10 locally before pushing a PR and having to wait for travis + spread in gce07:47
zygahow did you make the image?07:47
sdhd-saschaI build spread by myself - will look how the best way to connect to the serial of qemu...07:47
zygasdhd-sascha: no no07:47
zygathe image07:48
zygaremark about adding more snap-types, most likely you won't get that because it involves snap architects and store changes to implement07:48
zygaas for /run/systemd/sessions, grep through interfaces, if nothing sensible is there discuss a new interface design on the forum07:49
zygathe actual implementation is the easiest chunk07:49
zygasdhd-sascha: so how did you get the ubuntu 18.04-64 image?07:49
sdhd-saschazyga: i use autpkgtest like in Hacking.md07:49
zygado you get anything if you run spread with -vv ?07:50
sdhd-saschazyga: /run/systemd/sessions works with #788107:50
mupPR #7881: intreface: login-session-control - added missing dbus commands <Created by sd-hd> <https://github.com/snapcore/snapd/pull/7881>07:50
zygasdhd-sascha: and lastly, reviews are always awesome07:53
zygasdhd-sascha: those will help you get up to speed the most IMO07:53
sdhd-saschazyga: thank you :-)07:55
sdhd-saschazyga: today spread do something. don't know why, but it's fine07:55
zygasdhd-sascha: local spread runs are 10x heavier on network than CPU07:56
zygasdhd-sascha: I recommend exploring proxy options for apt, at least07:56
zygasdhd-sascha: there are some more savings to be had after you get thorough this07:56
zygasdhd-sascha: read spread.yaml for ideas on what the host environment is used (tip, grep for host:)07:57
sdhd-saschazyga: yes - i have to take a look, why the MAAS proxy doesn't work here07:57
zygasdhd-sascha: I'm not familiar with maas proxy07:57
sdhd-saschait's simple a mod' in /etc/apt/apt.conf.d/XX-proxy after deployment - no magic07:58
zygasdhd-sascha: aha, spread.yaml requires explicit opt-in08:00
zygayou need to set some environment variables that get passed down the the virtual machine / container that is started by spread08:00
zygahey pawel08:08
zygaI'll work from the kitchen until the office warms up08:16
zygapstolowski: it was -4 this morning08:16
mupPR snapd#7882 opened: devicestate: only run ensureBootOk() in "run" mode <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7882>08:37
zygaand back now08:41
zygamvo: do you urgently need reviews or can I focus on branch iteration?08:42
mvozyga: branch iteration is fine, 7880 is a blocker right now, I need to poke around this area a bit, the PR is not ready :(08:48
zygamvo: good luck and feel free to drag me into this :)08:51
pstolowskizyga: uhm... here https://i.paste.pics/f06e76ec6b4420a5e8cc5c006bbdcca4.png08:52
zygathat's just like real winter :)08:53
zygahmm are we in a split09:30
zygahas anyone seen maciek today?09:31
pstolowskizyga: according to hr calendar he is off today09:37
pedronishe said so in the standup yesterday09:37
pedronishe'll be back tomorrow09:37
zygathanks, I must have missed that09:37
pedronismvo: hi, bare was fixed, I looked at what is needed to land #7594 but got confused by the revisions of test-snapd-busybox-static, we can chat about it in the standup09:58
mupPR #7594: tests: replace "test-snapd-base-bare" with real "bare" base snap <Created by mvo5> <https://github.com/snapcore/snapd/pull/7594>09:58
mvopedronis: ok10:00
mvohas anyone checked why we have red tests right now?10:39
zygamvo: nope, let me look10:50
zygamvo: I'm running spread in qemu locally and trying to fix something but didn't notice red10:50
zygamvo: interfaces-audio-playback-record is failing on 16.0410:51
zygalooking at why10:51
zygait fails in a suspicious way10:52
zygalooking at the next PR10:53
zygamvo: there's a typo in your PR https://github.com/snapcore/snapd/pull/7880/files#r35652996810:55
mupPR #7880: snapstate: add support for UC20 gadget in {Config,Gadget}Defaults <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7880>10:55
zygamvo: next PR has name upsetting commit checker (from sdhd-sascha)10:56
zygamvo: next PR has apt-hooks failure with no useful failure10:57
zygas/failure/error messages/10:57
zygamvo: next PR has gofmt issues (from jamie)10:57
zygamvo: seems to be nothing specific but the audio recording failure is worrying10:58
zygamvo: feels like it could break the relase10:58
zygamvo: do you want me to pursue this further?10:58
mvozyga: that's fine, I'm in a meeting right now though10:59
zygapstolowski: just a random though, in snap is-connected we could say something super basic if stdout is a tty11:28
mvojust fyi - I branched 2.43 now11:34
mupPR snapd#7883 opened: snapstate: relax gadget constraints in ConfigDefaults Et al <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7883>11:34
mvostill open for selected cherry picks11:34
pstolowskizyga: we could yes, although when the pr was reviewed we opted for removing any verbosity that i initially had. fwtw snapctl is meant ot be used by scripts/apps, so i'm not sure if output is that useful11:34
zygapstolowski: snapctl yes11:36
zygaI meant "snap"11:36
zygapstolowski: note that the verbosity would obviously not be there in a "if snap is-connected foo bar; then" scenario11:36
zygamvo: sounds great11:36
mupPR snapd#7880 closed: snapstate: add support for UC20 gadget in {Config,Gadget}Defaults <UC20> <⛔ Blocked> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7880>11:37
pstolowskizyga: sorry, i thought you misstyped. i don't remember we ever considered snap is-connected11:38
zygapstolowski: ah, I see11:38
zygado we plan to have it for consistency?11:39
pstolowskii see how this could be handy as a shortcut over of snap interfaces / snap connections. at the same time it was meant to address the deficiency on snapctl side (which doesn't exist on snap side). i don't know, guess it's a question to pedronis_11:42
* cachio afk12:01
sdhd-saschazyga: i will be back in at the evening. (the PR name i have changed)12:05
mupPR core18#144 opened: Add efibootmgr to the extra packages <Created by sil2100> <https://github.com/snapcore/core18/pull/144>12:12
zygasdhd-sascha: sounds good12:12
sdhd-saschazyga: is offtopic - but did you use raspberry-pi4 ? i got a response from request to the maintainers, that they work on the network support for u-boot. I need this, because rpi4 can only network boot the kernel, but not the initrd ... And with u-boot, it would then possible to boot ubuntu-core over network, e.g. with MAAS :-)12:20
zygasdhd-sascha: I have a rpi4 but I didn't try the new ubuntu images yet, AFAIK there's no ubuntu-core image for it yet12:21
zygasdhd-sascha: as for netboot, I don't know how it boots enough to answer12:21
sdhd-saschazyga: currently it needs beta-firmware for network-boot. I already boot a kernel and nfs as root-filesystem.12:26
sdhd-saschaAnd about ubuntu-core for rpi4. We can use the default image for arm64 the kernel and modules are always the same12:26
mupPR snapd#7884 opened: snapstate: check gadget model constraints in checkSnap <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7884>12:26
=== pedronis_ is now known as pedronis
zygasdhd-sascha: I'm not pursuing that today if you are interested in it I would suggest asking sil2100 or ogra for pointers12:27
mvopedronis_: a review for 7883 would be great, this should unblock the seeding in install mode12:27
pedronismvo: about #7879, I'm fine merging it for edge once we have cut 2.43,  if it works then, we can cherry pick it, it seems it's localized enough for that12:27
mupPR #7879: devicestate: use httputil.ShouldRetryError() in prepareSerialRequest <Created by mvo5> <https://github.com/snapcore/snapd/pull/7879>12:28
pedronismvo: ok, resting a bit after my doc appt/lunch, will looke in a bit12:28
mvopedronis: thanks12:39
ograzyga, sdhd-sascha https://people.canonical.com/~ogra/snappy/raspberrypi4/core18/12:51
ogranot using our kernel though ...12:51
sdhd-saschaogra: :-) yes, i forgot where it was12:52
pedronismvo: lots of PRs are red though ? general master problem? (I havent looked)12:52
sdhd-saschapedronis, mvo: maybe something with debian-sid12:55
zygapedronis: I loked earlier today and it didn't seem like a single problem13:01
zygapedronis: each PR was red for a distinct reason13:01
pedronisfun, not. ok13:01
zygapedronis: though one was worrisome13:03
zygapedronis: audio-record seems broken for real now13:03
zygapedronis: perhaps our images got some changes / packages got rolled back or worse, updated with patches dropped13:03
pedronisok, we need to rope in jdstrand on that13:04
zygajdstrand: the log is https://api.travis-ci.org/v3/job/623567687/log.txt13:05
zygajdstrand: the job is https://travis-ci.org/snapcore/snapd/builds/62356768313:05
zygajdstrand: ^ it looks serious13:05
pstolowskihmm i just saw it on my PR13:12
cmatsuokacachio: good morning. a question about our GCE hosts, do they support nested VMs?13:13
pedronismvo: I did a pass of reviews13:15
jdstrandzyga (cc pedronis): it isn't serious, the mediation patches went through SRU today: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/178142813:19
mupBug #1781428: please enable snap mediation support <patch> <verification-done> <verification-done-bionic> <verification-done-xenial> <pulseaudio (Ubuntu):Fix Released13:20
mupby jamesh> <pulseaudio (Ubuntu Xenial):Fix Released by jamesh> <pulseaudio (Ubuntu Bionic):Fix Released by jamesh> <https://launchpad.net/bugs/1781428>13:20
jdstrandI'll submit a PR to flip on xenial and bionic13:20
zygajdstrand: I'm confused, how did this test pass before?13:20
zygaI get it now13:20
zygaI misread the failure message I guess13:20
zygathank you, that's great news13:20
jdstrandzyga: because yesterday the patches weren't in -updates but today they are13:20
* zyga nods13:21
mupPR snapd#7885 opened: tests: 16.04 and 18.04 now have mediating pulseaudio <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7885>13:27
jdstrandzyga: there you go ^13:27
zygajdstrand: was this in 2.43? if so mvo needs to cherry-pick it13:28
jdstrandzyga: yes and I just milestoned it13:28
jdstrandwell, let me triple check that13:28
jdstrandyes, it was13:29
cachiocmatsuoka, hey, sorry for the delay13:29
cachiocmatsuoka, yes, they do but not any instance13:29
cachiocmatsuoka, just the instances that we use for nightly execution do13:29
mupPR snapd#7886 opened: tests: 16.04 and 18.04 now have mediating pulseaudio - 2.43 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7886>13:31
zygajdstrand: thank you!13:31
jdstrandI created that ^ for 2.43 to make it quick13:31
cmatsuokacachio: the question is because for testing core20 installation we may need a nested VM (so we can enable secure boot and software tpm)13:32
jdstrandnot excellent timing on the SRU approval, would've been nice to have had it done before the commit, but good we have the mediation now13:32
cachiocmatsuoka, it can be done13:32
cmatsuokacachio: can I run a test on one of those instances? how do I access one of them?13:33
cachiocmatsuoka, yes13:33
cachiocmatsuoka, use google-nested backend13:33
cachioit is in the spread.yaml of snapd project13:34
cmatsuokacachio: ah ok, thanks!13:34
cachioplease ping me if you need any help on this13:35
cachiocmatsuoka, ~13:36
=== ricab is now known as ricab|lunch
cmatsuokacachio: testing here, thanks!13:42
cmatsuokacachio: is there any stability difference between the xenial and bionic systems? and how's the stability overall, is it working perfectly or do we have crashes from time to time?13:44
cachiocmatsuoka, those are stable13:45
ijohnsonmorning folks13:45
cachiodidn't see any error on those13:45
cmatsuokacachio: great, thanks!13:47
mupPR snapd#7887 opened: [RFC] seed,devicestate: check gadget model constraints when seeding <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7887>13:57
stgrabermvo: I see 2.42.5 made it to candidate yesterday, any idea when this will hit stable?14:11
mvostgraber: it's getting phased to stable after our standup which is now14:12
zygastgraber: talk about nice customer service, you ask for it and you get it :)14:12
mvostgraber: so the first couple of percent will go out in ~30min or so and then it will ramp up over the next hours, the details of the phasing cachio  knows14:12
mvostgraber: and sorry again for the trouble14:13
stgrabersounds good, thanks14:13
zyganiemeyer: hello14:18
zyganiemeyer: I made a small PR for spread for your consideration https://github.com/snapcore/spread/pull/9414:18
mupPR spread#94: qemu: invoke qemu in a portable way <Created by zyga> <https://github.com/snapcore/spread/pull/94>14:19
zyganiemeyer: it's literally a one liner but not sure about the architecture portability aspect14:19
zyganiemeyer: I'm happy to iterate, just need something that operates outside of Debian14:19
niemeyerzyga: I'm in a meeting at the office today.. can you please ping me by Friday so we can look at it together?14:19
zyganiemeyer: sure, is Friday okay?14:20
niemeyerYeah, I should be back late tonight14:20
zygacheers, see you then!14:20
mupPR snapd#7885 closed: tests: 16.04 and 18.04 now have mediating pulseaudio <⚠ Critical> <Created by jdstrand> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7885>14:30
cachiostgraber, hey, progressive release for 2.42.5 started14:54
cachio25% of the devices are receiving the update now14:55
cachiothe percentage will grow during the day14:55
=== ricab|lunch is now known as ricab
jdstrandpedronis: hey, can you give https://forum.snapcraft.io/t/certbot-request-for-classic-snap-approval/6240/19 a look (you'll need to read from https://forum.snapcraft.io/t/certbot-request-for-classic-snap-approval/6240/7 and lower (my, rbasak's and upstream comments on the approach, not the side conversation on use of the interface)15:22
jdstrandrbasak: also, fyi, https://forum.snapcraft.io/t/certbot-request-for-classic-snap-approval/6240/1715:22
jdstrandpedronis: feel free to discuss in the topic. (I'm stepping away to an appt)15:23
pedronisjdstrand: likely I'll look at it in my morning tomorrow15:23
pedronisI have other things today15:23
rbasakjdstrand: thanks! Assuming that output from a connection hook will end up in the console, are you saying that (yet to be confirmed by others) printing a warning from the hook and later at runtime will be sufficient?15:26
rbasakjdstrand: and separately, do you know what the store will do in terms of autoconnection for plugins published by the same publisher as the certbot snap itself, and am I right in thinking this would be acceptable (since same publisher)?15:27
jdstrandrbasak: I'm not sure it will go to the console. you might need to use it to manage something that the certbot command might have to consult. not ddictating implementation. be tasteful, etc, but something needs to come up somewhere imo15:29
jdstrandrbasak: the store will auto-connect from the same publisher, but we can override that15:29
jdstrandif desired15:29
pedronishook output doesn't go the console, so far we don't have mechanism to do that15:29
jdstrandI don't think it is though, since collectively it is all 'upstream'15:29
pedronisin general we don't expect them to be running always with somebody watching15:30
pedronis(I haven't read the thread yet as I said)15:30
jdstrandright, that is what I though. but it can manage something (eg, a file) for something else to look at15:30
jdstrandgotta run (appt)15:31
cachiopedronis, hi, do you know if there was any change in snapd that could produce we are calling more times to the store service /names ?15:32
rbasakjdstrand: OK, so in that case the warning can be at runtime of certbot only, right? And that might be automated (eg. via the systemd timer that certbot installs). Normally the first time the user would run certbot by hand to set it up, but I can imagine an adversarial scenario where someone convinces a user to add and connect the plugin after initial setup. In this case, the systemd timer will run the15:33
rbasakthird party code without the user ever seeing the message.15:33
rbasakjdstrand: is that acceptable to you?15:33
pedroniscachio: no, if anything we reduced it but you probably want to discuss with Chipaca when he's around15:33
rbasakjdstrand: if not, I'm not sure how to achieve what you want with the current snapd.15:33
cachiopedronis, because it is producing that the store is sending an error to snapd like this https://paste.ubuntu.com/p/JY69dz4vwP/15:33
cachiopedronis, ah, ok15:33
cachioI'll talk to jhon in that case15:34
pedronismvo: did a pass on #7887, nothing that haven't already mentioned15:47
mupPR #7887: [RFC] seed,devicestate: check gadget model constraints when seeding <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7887>15:48
ijohnsonjdstrand: pedronis: it's a bit silly but you could have a connection hook that always fails with a message explaining the ramifications of connecting that interface unless there's a config set like `snap set $SNAP_NAME <other-snap-name>=ok`15:51
ijohnsonhere I think the connection hook could introspect what the name of the other snap that is being connected to to determine what config item to check, but I would need to check how that works15:51
* zyga looks after lucy for an biur15:52
mvopedronis: thanks!15:53
mupPR snapd#7888 opened: tests: disable apt-hooks test until it can be properly fixed <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7888>15:53
* cachio lunch15:54
mupPR snapd#7889 opened: overlord,o/snapstate: make sure we never leave config behind <Created by pedronis> <https://github.com/snapcore/snapd/pull/7889>16:17
pedronismvo: anything I should review?16:21
ijohnsonpedronis: jdstrand: I put an example into the certbot forum topic for certbot16:21
pedronisijohnson: yes, it's by design that we don't tell snap detail of the other side16:23
mvopedronis: I updated 7884 - I will look into converting constraints -> model now16:23
ijohnsonyeah that's what I thought from looking at it16:23
pedronismvo: +116:29
ograjdstrand, ijohnson reading that certbot discussion i wonder if i'm missing anything here ... afaik classic snaps can provide interfaces but not consume them ... did that policy change recently ?16:45
ijohnsonogra: I don't think in this case certbot is consuming anything from the interface at all, it's just using the connection hooks and the existence of that connection to do something in the classic snap16:47
ijohnsonogra: the classic snap directly executes "snap connections" to see what connections are connected16:47
ograwell, and the "snap connect .." (to exec the interface hook) was the bit i thought was denied16:48
mvocachio: 7888 has failed :/16:48
mvocachio: some strange error I have no seen yet16:48
ogra(beyond a store upload block for such snaps, but thats indeed just an override)16:48
cachiomvo, checkign16:50
mvocachio: thank you16:50
cachiomvo, there is a PR for fixing this error #787716:51
mupPR #7877: tests: avoid mask rsyslog service in case is not enabled on the system <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7877>16:51
cachioI'll restart the job16:51
cachiomvo, thanks for hte heads up16:51
ijohnsonogra: not sure about the store denial, but the example snap I have locally works fine if the snap is classic, the interface hooks are still run under confinement16:56
ograaha ... well, i thought in the past the snap connect command used to cause an error16:57
ograif thats not the case anymore then i'm just behind on knowledge16:57
mvocachio: thank you!16:59
cachiomvo, yaw16:59
pedroniscachio: do we need #7888 to be back to green?17:18
mupPR #7888: tests: disable apt-hooks test until it can be properly fixed <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7888>17:19
cachiopedronis, I restarted the failed job17:19
cachiopedronis, it should finish in 10 minutes17:19
cachiopedronis, merged17:30
mupPR snapd#7888 closed: tests: disable apt-hooks test until it can be properly fixed <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7888>17:31
jdstrandogra, ijohnson: there would need to be a review-tools override. this novel use of the content interface has been used once elsewhere. it is open for everyone since the snapd team might want to design something a bit better17:40
jdstrandogra, ijohnson: it isn't*17:40
* cachio afk 10mins17:43
* zyga resumes working17:46
ograjdstrand, yeah17:58
mupPR snapd#7890 opened: tests/many: quiet lxc launching, file pushing <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7890>18:24
mupPR snapd#7891 opened: devicestate: use correct model constraints in remodel/gadget updates <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7891>18:51
mupPR snapd#7887 closed: [RFC] seed,devicestate: check gadget model constraints when seeding <UC20> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7887>18:52
jdstrandrbasak: exploring ijohnson's idea would probably be best, but if it turns into a timer/journald thing, that is maybe ok. the other thing that could be done is to use a 'snap set' on the certbot snap to allow 3rd party plugins at all19:16
jdstrandrbasak: that in and of itself doesn't help much due to cut and paste, but if the option was like: snap set certbot allow-3rd-party-plugins-for-admin=true19:22
jdstrandrbasak: or something scary and eye catching. again, just an idea19:23
jdstrandroadmr: hi! can you pull 20191211-1947UTC?19:47
jdstrandroadmr: since the last request, it is all overrides and updates for the new 2.43 interfaces19:48
mupPR snapd#7886 closed: tests: 16.04 and 18.04 now have mediating pulseaudio - 2.43 <⚠ Critical> <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7886>19:58
mupPR snapd#7890 closed: tests/many: quiet lxc launching, file pushing <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7890>19:58
roadmrjdstrand: sure thing, we're still stuck deploying the last one I pulled but I'll put this in the queue :)20:05
jdstrandroadmr: if it would make it any easier, using this one instead of the last would be fine. up to you20:06
roadmrjdstrand: well it's a sort of pipeline, the other one is in the pipeline regardless20:07
* cachio afk20:07
mupPR snapd#7882 closed: devicestate: only run ensureBootOk() in "run" mode <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7882>20:23
sdhd-saschaijohnson: hi, commented the PR20:54
sdhd-saschais it possible, that there is some race-conditions on the tests ? Maybe they share some common resource, so if they run parallel on two or more repos, that they crash ? I'm new to snapd, so i didn't read the full source of the integration tests yet20:56
sdhd-saschacachio: I see you also commented on 7865.20:59
mupPR snapd#7883 closed: snapstate: relax gadget constraints in ConfigDefaults Et al <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7883>21:07
roadmrjdstrand: wow, this review-tools change broke 12 tests in the dashboard test suite :/21:32
=== pedronis_ is now known as pedronis
pedronisroadmr: I suppose it's snap_declaration tests?  we added quite a few interfaces21:36
roadmrpedronis: yes, looks like it21:37
pedronisroadmr: let me know if I can help or something isn't clear21:37
roadmrpedronis: sure, I'll probably need a review on the MP that adjusts the tests21:38
roadmraudio-playback was added, pulseaudio was removed?21:38
pedronisroadmr: ok, np doing that21:38
pedronisroadmr: pulseaudio wasn't removed but it's property changed21:38
pedronisso it belong to different categories21:38
pedronisroadmr: so I expect in those tests it will disapper from some sets and appear in others21:39
roadmrpedronis: right I have pulseaudio in EXPECTED_NOT_PRIVILEGED_INTERFACES, where should it be now?21:40
roadmris it privileged now?21:40
pedronisroadmr: yes21:40
pedronisbut I don't remember exactly the name of the vars and sets21:40
pedronisI would need to look21:41
roadmrpedronis: thanks, no problem, I just moved it to EXPECTED_PRIVILEGED_INTERFACES and that one test passes now21:41
roadmr11 more to go :) (Maybe this will fix some others too)21:41
pedronisroadmr: some tests have used it explicitly those will be more fun21:43
roadmrpedronis: I'm all for fun :)21:43
pedronisroadmr: for the tests that use it explicitly maybe s/pulseauio/audo-playback/ is the easiest21:43
roadmrpedronis: sure, I can try that21:44
pedronisah, maybe not21:44
pedronisneed to think21:44
pedronisroadmr: maybe they are fine as they are if they don't fail, it seems about the slot side21:46
pedronisroadmr: where are the failures? mostly test_base ?21:46
roadmrpedronis: https://pastebin.canonical.com/p/sqY2K8K6V6/21:47
pedronisroadmr: ok, I can't look at that immediately and it's quite late here, can we continue tomorrow?21:49
roadmrpedronis: totally, not a problem21:49
roadmrpedronis: thanks!21:49
=== arnatious_ is now known as arnatious
mupPR snapd#7892 opened: many: pass a Model to the gadget info reading functions <Created by pedronis> <https://github.com/snapcore/snapd/pull/7892>21:58
roadmrpedronis, jdstrand : (for tomorrow) wip on fixing these tests https://code.launchpad.net/~roadmr/software-center-agent/+git/software-center-agent/+merge/37665721:59
pokknoob question. Is there any example of how to get a timer/service running? All I can find is people talking about how it should be used. Looking at the timers /etc/systemd/system is useful. But where should I be placing my own, user created, timer?22:51
pokkI'll just go with my home dir I guess.23:19

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!