| === ben_r_ is now known as ben_r | ||
| hallyn | sarnold: i ... don't mean to be negative, but that security/apparmor/lib/path.h:get_buffers() is not the most intuitive. Seems like a comment wouldnt' go amiss. | 14:58 |
|---|---|---|
| hallyn | (jj's not onhere and you signed the commit off, so i'm mentioning it to you :) | 14:58 |
| hallyn | i mention it bc there's a patch on linux-security-module@vger.kernel.org and i frankly can't tell whether it's right or not | 14:58 |
| cascardo | teratorn: can you report a bug, then? https://launchpad.net/ubuntu/+source/linux/+filebug | 16:09 |
| teratorn | cascardo: won't let me attach multiple files; timeout error on hitting submit; yeah i'm done | 16:49 |
| sarnold | hallyn: so right you are, after five minutes of reading I'm still not sure what it does :) thanks | 19:03 |
| hallyn | sarnold: thank you for making me feel less stupid :) | 19:04 |
| sarnold | hallyn: I have to wonder if it'd be easier to read with just ## instead of CONCATENATE and so on, but .. hrmph :) | 19:07 |
| hallyn | well it looks like get_buffers(a, b) returns "a->buf[b]". which makes no sense given that aa_buffers() sends it one variable | 19:11 |
| sarnold | hallyn: heh, I just did a git pull to see what might be new there and it's all vastly different from what I had i my local checkout | 19:58 |
| hallyn | yes. same fn names, completely different behavior :) | 20:52 |
| hallyn | and i just can't seem to follow it. i'll ask jj when he's around | 20:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!