[14:58] <hallyn> sarnold: i ...  don't mean to be negative, but that security/apparmor/lib/path.h:get_buffers() is not the most intuitive.  Seems like a comment wouldnt' go amiss.  
[14:58] <hallyn> (jj's not onhere and you signed the commit off, so i'm mentioning it to you :)
[14:58] <hallyn> i mention it bc there's a patch on linux-security-module@vger.kernel.org  and i frankly can't tell whether it's right or not
[16:09] <cascardo> teratorn: can you report a bug, then? https://launchpad.net/ubuntu/+source/linux/+filebug
[16:49] <teratorn> cascardo: won't let me attach multiple files; timeout error on hitting submit; yeah i'm done
[19:03] <sarnold> hallyn: so right you are, after five minutes of reading I'm still not sure what it does :) thanks
[19:04] <hallyn> sarnold: thank you for making me feel less stupid :)
[19:07] <sarnold> hallyn: I have to wonder if it'd be easier to read with just ## instead of CONCATENATE and so on, but .. hrmph :)
[19:11] <hallyn> well it looks like get_buffers(a, b) returns "a->buf[b]".  which makes no sense given that aa_buffers() sends it one variable
[19:58] <sarnold> hallyn: heh, I just did a git pull to see what might be new there and it's all vastly different from what I had i my local checkout
[20:52] <hallyn> yes.  same fn names, completely different behavior :)
[20:53] <hallyn> and i just can't seem to follow it.  i'll ask jj when he's around