/srv/irclogs.ubuntu.com/2020/01/09/#snappy.txt

sdhd-saschaIs there some documentation about the future snapd & snapcraft ? Would like to help, if i can, but need more information before i change something.00:24
ijohnsonsdhd-sascha: for snapd at least, there's various things on the forum with the backlog tag, but you might be best served by talking with mvo in EU morning, as mvo would know best on what would be something for you to work on, as we have a good number of features in flight all being worked on by somebody and mvo would know best what would be open00:28
mborzeckimorning06:14
mborzeckizyga: hey, are you around? got a mystery for you https://github.com/wekan/wekan-snap/issues/103#issuecomment-57221169207:22
mborzeckimvo: hey07:28
mvohey mborzecki ! good morning07:30
zygagood morning07:32
zygamborzecki: looking07:32
mvohey zyga07:32
mborzeckizyga: can't find any other explanation other than /tmp not existing yet, but that doesn't make much sense07:33
zygamborzecki: not having read all of the thread yet, do you know what is /tmp on the host?07:33
zygais it a special filesystem?07:33
mborzeckizyga: not in my centos7 install07:34
zygamborzecki: small note, private tmp is at /tmp/snap.$name/tmp07:37
zygamborzecki: I wonder what changed that caused it to break07:39
zygamborzecki: did we roll out snapd updates there?07:39
mborzeckizyga: as i understand it, the first report was that it broke after the refresh07:40
zygaof what?07:41
zygaof the snap or snapd?07:41
mborzeckizyga: i understood the snap was refreshed, but i can double check07:43
zygaok07:43
zygahmmm07:43
zygaimmediately I cannot think of a reason07:43
zygaunless I remember my unix wrong07:43
zygayou socket() to make a socket07:43
zygaand you bind() it to create a file in the FS for AF_UNIX sockets that are not abstract07:44
zygaI cannot even imagine how that can cause ENOENT to be returned07:44
mborzeckizyga: afaik bind(/foo/bar/baz) can get you ENOENT if /foo/bar does not exist07:45
zygasure but for /tmp?07:45
zygathat's super weird07:45
zyga       ENOENT A component in the directory prefix of the socket pathname07:46
zyga              does not exist.07:46
zygaI would do this:07:46
zygacreate a small python snap07:46
zygathat just tries the same07:46
zygaask the reporter to snap pack07:46
zygaand snap install it07:46
zygaand see what we get07:46
zygaI would also collect 1) kernel version 2) any virtualization/container system in use07:46
sdhd-saschagood morning07:51
zygahey sdhd-sascha07:52
sdhd-sascha:-)07:52
sdhd-saschazyga: how do you guys handle different timezones in messages ?07:54
zygasdhd-sascha: in which messages?07:54
sdhd-saschadon't want make people to wake up07:54
zygayou mean on IRC?07:55
zygaI think everyone just handles that differently07:55
sdhd-saschayes07:55
zygait's not like it's an IRC-alarm-clock next to bed :)07:55
sdhd-saschain my last position, i had my phone every second week loud.  Because i could get emergence calls07:55
sdhd-saschazyga: yeah :-)07:56
sdhd-saschaso, the phone is silent for most people?07:56
sdhd-saschaemergency calls07:57
zygasdhd-sascha: I don't get IRC notifications on my phone07:58
zygacannot speak how others handle that07:58
sdhd-saschazyga: i have silent info on phone. But didn't have to time to watch.07:58
zygaafk07:59
sdhd-saschazyga: my last company was a medical laboratory. which works 24 / 707:59
sdhd-saschaijohnson: thank you :-)08:00
pstolowskimorning08:01
zygahey pawel08:08
mupPR snapd#7966 closed: tests: first core20 test fixes <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7966>08:13
mborzeckipstolowski: hey08:15
mvohey pstolowski08:17
mborzeckizyga: heh, got a snap with app like this https://paste.ubuntu.com/p/xWjB2wc4m5/ declared as a service, can't reproduce across 50+ installs08:18
kristian_Hello we are having problems accessing api.snapcraft.io, so we can't update or install any packages the way we are used to. forum.snapcraft.io works sometimes and sometimes not. pinging snapcraft.io doesn't work either for us.08:19
kristian_We have this problem on all our ubuntu machines, any help on how to debug this? Could we have been blacklisted?08:20
mborzeckimvo: can you take a look at https://github.com/snapcore/snapd/pull/7967 ? it's a simple PR with some additional tests for snapstate backend and snapd snap scenario08:22
mupPR #7967: overlord/snapstate: improve snapd snap backend link unit tests <Remodel 🚋> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7967>08:22
zygare08:23
mborzeckimvo: opened a separate review so that the snapd on core will be smaller08:23
sdhd-saschamvo: if you have time, it would be nice to talk.08:26
mvokristian_: hm, when did this start? maybe bloodearnest knows about connectivity issues with the store, I'm not aware of anything right now.08:27
mvomborzecki: oh, nice. I have a look now08:27
mupPR snapd#7772 closed: wrappers: write and undo snapd services on core <Remodel 🚋> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7772>08:27
mvomborzecki: you said you opened a separate review - what number is that?08:29
mvosdhd-sascha: hey, I think that can be arranged08:30
mborzeckimvo: i meant 7967 as separate review08:30
mborzeckimvo: the last bit is snapstate changes, will open that once 7967 lands (and 7772 just landed)08:31
sdhd-saschamvo: yeah :-) but it is in no hurry since I still have a few things to do08:31
mvosdhd-sascha: ok - see /msg08:31
mvomborzecki: nice08:31
pedronismvo: hi, thanks for reviewing Ian's PR, of course we need some parts of the early boot stuff after that change...  we should discuss after the standup, I just fear we need to think through the complexities of the kernel info we put in the modeenv08:32
pedronis#7940 needs a 2nd review08:34
mupPR #7940: boot: implement SetNextBoot in terms of bootState.setNext <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/7940>08:34
mupPR snapd#7968 opened: tests: enable regression suite on core20 <Created by mvo5> <https://github.com/snapcore/snapd/pull/7968>08:52
mvopedronis: thanks, let's discuss after the standup then08:56
bloodearnestkristian_: mvo: hi, no known issues with store connectivity right now.09:17
bloodearnestkristian_: can you run mtr api.snapcraft.io?09:18
bloodearnestfrom your affected machines09:18
mupPR snapd#7969 opened: snap: default to "--direct" in `snap known` for 2.43 <Created by mvo5> <https://github.com/snapcore/snapd/pull/7969>09:22
mvopedronis: the above pr is for the bit of snap known we talked about yesterday, should be the last missing bit before I can release 2.43 :)09:23
pedronisok09:23
mupPR snapd#7940 closed: boot: implement SetNextBoot in terms of bootState.setNext <UC20> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7940>09:25
mvopedronis: probably best if Chipaca has a look at 7969 first, maybe my approach is too big of a hammer09:26
* Chipaca likes big hammers and cannot lie09:26
kristian_bloodearnest, yes I can09:31
kristian_mose of them are loss 0%, some hosts are ???09:31
kristian_one is constantly at a loss around 99%09:31
Chipacamvo: glad it's in the 2.43 branch :)09:33
pedronismvo: btw, now that BootParticipant has exactly one method we could probably just have boot.SetNextBoot but not urgent09:33
mupPR snapd#7967 closed: overlord/snapstate: improve snapd snap backend link unit tests <Remodel 🚋> <Created by bboozzoo> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/7967>09:40
bloodearnestkristian_: right, so you have a bad link in your path to our datacenter I'm afraid :(09:42
kristian_bloodearnest, hmm which one? how can we fix that? is that something that our ISP has to do?09:47
bloodearnestkristian_: your ISP, or one that they use or peer with - it's likely there's nothing you can do directly. Can you post the mtr output?09:48
bloodearnestkristian_: is there a VPN involved at all in the path?09:48
kristian_https://dpaste.org/BDvg09:50
kristian_sorry it removes the tabs somehow09:51
pedronismborzecki: the distros using snap-mgmt don't have the issue in #7922, right ?09:51
mupPR #7922: packaging, tests: stop services in prerm <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7922>09:51
kristian_bloodearnest, ^09:51
mborzeckipedronis: yes, because snap-mgmt is part of snapd package and must be run before the package is fully removed (basically in prerm)09:53
zygaafk for 15 minutes10:10
zygaI should eat something10:10
sdhd-saschamvo: thank you for the talk :-)10:14
mupPR snapcraft#2856 closed: meta: convert Application's `adapter` from string to enum <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2856>10:15
mvosdhd-sascha: my pleasure!10:17
mupPR snapcraft#2857 closed: meta: enable Snap to be fully initialized with __init__ parameters <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2857>10:18
zygaBack now10:34
mvothanks Chipaca for the review10:34
* Chipaca goes for coffee10:50
bloodearnestkristian_: looks like there may be an issue with london backbone, I'm seeing ~40% loss on one link10:50
bloodearnestnothing we can do about it but wait for it to be fixed10:50
bloodearnest(our DC is in London, hence the affect)10:52
bloodearnestkristian_: your report has short hostames (-w for long), but it looks like Level3 are having some issues, as my problem link is with them also10:54
sdhd-saschamvo: in 7624 the merge conflict is really wired - i will look for it11:04
mvosdhd-sascha: aha, I can fix that for you11:04
* Chipaca really goes for coffee11:05
mvosdhd-sascha: I was also wondering if for 7624 we start with making "--direct" the default and then do a followup with the fix for the resume in indirect mode (does that make sense?)11:06
sdhd-saschamvo: well, it's okay. For me i need to understand the changes first ;-)11:06
mvosdhd-sascha: ok, just let me know if I can help you with that one11:06
sdhd-saschamvo: i'm sure i will figure it out. But not soo fast, like you would do11:07
sdhd-saschamvo: i just started to merge, without understanding the changes ;-) like: `meld <(git show master:cmd/snap/cmd_download.go) <(git show cmd/snap/cmd_download.go)` ... and so on11:08
mvosdhd-sascha: ok, good luck and let me know if you have questions!11:09
mvosdhd-sascha: any help on this PR is welcome!11:09
sdhd-saschamvo: thank you - i love to help11:09
mvoa second review for 7969 would be great11:13
zygamborzecki: hey11:20
zygagot a selinux denial11:20
zygatype=AVC msg=audit(01/09/20 11:09:57.766:971) : avc:  denied  { setgid } for  pid=5731 comm=snap-discard-ns capability=setgid  scontext=system_u:system_r:snappy_mount_t:s0 tcontext=system_u:system_r:snappy_mount_t:s0 tclass=capability permissive=111:20
zygacapability setgid11:20
mborzeckizyga: discard does setgid now?11:20
zygacould this be related to the fact that snap-confine is not setgid root now11:20
zygaand snap-confine calls snap-discard-ns sometimes11:21
zygaperhaps ahead of calling it it should setegid(0)11:21
zygalike it does for snap-update-ns11:21
mborzeckiyeah11:21
zygamborzecki: my question to you is what does this say11:21
zygathat setgid was attempted but denied?11:21
zygaor something else11:21
mborzeckizyga: exactly that, setgid was attempted by snappy_mount_t context, which isn't whitelisted, the command was snap-discard-ns11:22
zygacool, thanks11:22
mborzeckizyga: s-c called s-d-n right?11:22
zygayes11:22
kristian_bloodearnest, so nothing we can do nor our ISP it's something an snappy's side?11:24
kristian_the weird thing is that this is only a problem with our network, if we use a mobile network it works fine11:25
* sdhd-sascha lunch11:29
zygafixed and respawned selinux test11:35
zyganow let's commit this11:35
mupPR snapd#7970 opened: snap-repair: use dirs.SnapSeedDir instead of seed.yaml <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7970>11:40
sdhd-saschahey, does anybody use a git diff filter, so that git understand the language better ? since years, i want to test something like that.11:47
threshare there any issues with snap store infra atm?  keep getting "error: cannot refresh "firefox": unexpectedly empty response from the server (try again later)" from snap refresh firefox11:53
pedronismvo: #7970 is not enough, we'll fail later in initDeviceInfo11:57
mupPR #7970: snap-repair: use dirs.SnapSeedDir instead of seed.yaml <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7970>11:57
pedronis(as I commented in the standup doc)11:58
zygaafk for 15-20 minutes11:59
mvopedronis: yeah, I can close again, was a low-hanging fruit but maybe too low-hanging12:03
mvoseconds reviews for 7968, 7969 would be great, hopefully pretty easy both of them12:04
mupPR snapd#7968 closed: tests: enable regression suite on core20 <Created by mvo5> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7968>12:06
cachiomvo, hey12:07
mvocachio: hey12:07
mborzeckicachio: hey, do the updates of arch images work ok now?12:07
mvocachio: I made some progress on the tests, hopefully I have something to merge for you soon12:07
cachiomvo, I have this already open https://paste.ubuntu.com/p/gN6NW7Kng5/12:08
mvocachio: thanks for the merge12:08
mvocachio: yeah, I talked to foundatins, it's a known bug, we can ignore it for now12:08
cachiomborzecki, I needed to use "pacman-key --refresh-keys" to fix the problem12:08
cachiothe same I was using but now while preparing the image12:08
cachiomborzecki, your change also failed12:09
cachiomborzecki, now the image is being created well again12:10
mvocachio: 7971 could be an interessting in-between step, we need your PR too, it enables a bunch more but with 7971 we can hopefully enable ~80% of the main tests12:10
mupPR snapd#7971 opened: tests: enable a lot of the tests of main on uc20 <Created by mvo5> <https://github.com/snapcore/snapd/pull/7971>12:10
cachiomvo, taking a look to 7971, thanks for the PR12:12
mupPR snapd#7970 closed: snap-repair: use dirs.SnapSeedDir instead of seed.yaml <UC20> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7970>12:12
mvocachio: thank you!12:13
mvocachio: I cherry picked some your work too, thanks for this! it will unfortunately create conflicts but I can help resolving those12:13
cachiomvo, no problem12:13
mvowe are approving 50 open prs again, yay, 2 pages are within reach :)12:14
mborzeckicachio: hah, glad that it's working now12:18
sdhd-saschazyga: you mention, that you run single spread test locally ? what cmdline do you type?12:22
zygasdhd-sascha: typically something akin to12:23
zygaSPREAD_DEBUG_EACH=0 spread -debug -v google:ubuntu-16.04-64:tests/main/snap-run12:23
zygafor example12:23
zygaI pick the OS and the test to match the change I'm doing12:23
zygayou won't be able to use google backend yourself as that requires a key to spawn machines in gcloud12:24
zygayou can replace that with qemu:12:24
zygaand fetch or make a compatible image12:24
zygalocal testing benefits tremendously from caching, otherwise it's almost entirely network bound12:24
zygaIO and CPU are not a significant factor in my experience12:24
zygayou also need about 20-40GB of free space12:24
zygafor qemu -snapshot12:24
sdhd-saschazyga: thank you - i understand :-)12:25
zygasdhd-sascha: local testing also benefits from -reuse and -resend12:26
zygaas that saves some cost per run12:26
zygasdhd-sascha: -reuse keeps the vm for another pass12:27
zygasdhd-sascha: -resend sends updated tree12:27
bloodearnestkristian_: the problem is neither your side or snappy side - it's in the middle I'm afraid.  Mobile network likely uses a completely different path, and thus is unaffected. As are most folks, or else we'd be seeing alerts and more issues12:27
sdhd-saschazyga: updated tree ? did you mean the git tree ?12:28
zygasdhd-sascha: updated tree, even without git commits12:28
zygaas you edit and change stuff12:28
zygaunless you use -resend you will not get any changes12:29
sdhd-saschaah, ok :-)12:29
zygaassuming you use -reuse :)12:29
sdhd-saschamvo: i didn't see anything about "--indirect". Just took the PR and merged the conflicted files. The rest was automerged by git. The tests are currently running locally. Manually black box test works with and without "--direct" option.12:53
sdhd-saschaThe merged source is here: https://github.com/sd-hd/snapd/tree/snap-donwload-via-snapd-212:53
sdhd-saschaDon't know how to get the source into the PR (i think i didn't had the permissions)12:53
sdhd-saschaWhat is about this test "TestDownloadViaSnapd" ??? Looks for me like a integration test. Should the Test-Server not be `mocked` or something ? I don't know how to mock in golang, yet.12:53
mupPR snapd#7922 closed: packaging, tests: stop services in prerm <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7922>12:57
pedronissdhd-sascha: we generally prefer using httptest.NewServer liberally vs trying to mock http stuff12:58
sdhd-saschapedronis: thank you :-)12:58
sdhd-saschahow can i launch them, locally?12:59
pedronissdhd-sascha: launch what?12:59
sdhd-saschawait, .. i read about "httptest.NewServer"13:00
sdhd-saschaI ask about launch, because i got a real http-query on snapd if i run the test, which contains this call `RedirectClientToTestServer`13:00
pedronisah, something is wrong then13:01
pedronisthat's the purpose of s.RedirectClientToTestServer13:01
pedronisnot to use a real snapd13:01
sdhd-saschathank you.13:02
pedronisyou can look how it is implemented in main_test.go13:03
pedronisit is using httptest.NewServer, but that's probably not the issue13:03
pedronismore the config bit, if redirecting is not working13:03
mupPR snapd#7972 opened: overlord/snapstate, wrappers: undo of snapd on core <Remodel 🚋> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7972>13:17
pedronispstolowski: answered and/or addressed your comments in #793413:17
mupPR #7934: o/ifacestate,o/devicestatate: merge gadget-connect logic into auto-connect <Created by pedronis> <https://github.com/snapcore/snapd/pull/7934>13:17
ijohnsonI tried a new alarm clock this morning which slowly got brighter like a sunrise which was great til the light turned off... That's not how the sun works13:17
pstolowskipedronis: ty, looking13:17
sdhd-saschaijohnson: :-D13:25
mupPR snapcraft#2848 closed: common: generate run scripts which can execute independently <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2848>13:28
zygahmmmm13:28
mborzeckipedronis: thanks for the comment under 7972, i was kind of expecting this, the other version added new method to the snapstate backend iface but it was equally non transparent13:35
pedronismborzecki: as long as it was magical it was ok, but now if we have to ship state 3 level down the appeal starts to diminish13:35
mborzeckipedronis: maybe we can quickly chat about that before/after the standup?13:36
pedronismborzecki: maybe before, we have something UC20 to discuss after already13:36
pedronis(afaik)13:37
mborzeckipedronis: ok, let me grab some coffe and i'll join the standup HO13:37
zygalunch13:37
zygaand debugging13:37
zygaI broke up my patches13:37
zygaand now something fails :) oh well13:38
=== ricab is now known as ricab|lunch
mvosdhd-sascha: cool, thank you, I have a meeting now, then I have a look13:51
sdhd-saschamvo: just this second i force pushed the test13:52
sdhd-saschamvo: but didn't look if all cases are handled ...13:52
mvosdhd-sascha: quite possible, I remember that test was very tricky13:58
mvosdhd-sascha: what I meant with "--indirect" was that in this PR maybe we should make "--direct" the default (that's what we have today) and instead of --indirect as an option to go via snapd. then we can fix all the missing bits in --indirect (resume of download is missing today) and once that is finished flip the default again.13:59
sdhd-saschaah, understood14:02
mvosdhd-sascha: great, thank you!14:06
ackkmvo, hi about https://bugs.launchpad.net/snapd/+bug/1817276, did you see my last comment?14:07
mupBug #1817276: snapfuse use a lot of CPU inside containers <maas> <snapd:Fix Released by mvo> <https://launchpad.net/bugs/1817276>14:07
sdhd-saschamvo: i can switch direct and indirect. if it should ?14:07
ackkmvo, I happen to have a running maas here on my laptop which was idle (I was doing other things) and suddenly squashfuse is using 100%cpu14:07
mvoackk: I haven't, let me see (in a meeting right now, so will probably be a bit slow)14:08
ackkit's still going, laptop fan is going crazy14:08
mvosdhd-sascha: yeah, that would be great14:08
zygaand i found the part that made it fail, yay!14:09
mvoackk: can you see where snapfuse that is running and eating so much cpu comes from? i.e. which snapfuse binary path is used?14:11
ackkmvo, sigh, it's dead now14:12
mvoackk: it's strange, we definitely need to debug this some more (our side)14:12
mvoackk: oh no :/14:12
mvoackk: sorry for the trouble there :(14:12
ackkmvo, no probl14:12
ackkI can try again the scenario from my comment (this one was a different case)14:12
ackkmvo, I *think* the reason it went creazy is that maas went crazy respawing processes because it seems at times when I refresh the snap services from the old version don't get killed, so the new ones fail to start14:13
ackkmvo, (which might be a separate issue)14:13
ackkmvo, I had the snap installed with "try" from an unpacked snap, then I switched with refresh --amend to get the one from the store14:14
zygaijohnson: reviewed14:22
ijohnsonzyga: thanks will look after SU14:24
sdhd-saschamvo: just pushed into my repo, the default direct case .14:31
sdhd-saschamvo: the integration test needs fixes next14:31
ackkmvo, fwiw I couldn't reproduce the issue from my last comment now...14:34
sdhd-saschazyga: thank you. -resend and -reuse works great :-)14:38
zygasdhd-sascha: some extra hints to look at: look at spread.yaml look for proxy settings, setting up a proxy for the classic packaging system (e.g. apt-cacher-ng) saves tons of tons of bandwidth and time14:39
zygasdhd-sascha: you can go further and optimize time for big snaps like core and core18 by applying some tricks as well14:39
sdhd-saschazyga: did you have custom backend_* list for apt-cacher ?14:45
zygabackend?14:45
zygano, I  think not14:45
zygajust a stock value14:45
zygait works good for rpm packages as well14:45
sdhd-saschaok, thank you14:45
* zyga sees slow traffic to the store14:47
kristian_bloodearnest, sorry I just don't understand - should I contact my ISP regarding this issue? Or is there absolutely nothing we can do?14:49
zygainstalling core --edge takes forever now14:55
zygais store in trouble?14:56
ograstatus page looks fine14:56
zygatype=AVC msg=audit(01/09/20 14:58:04.383:746) : avc:  denied  { setgid } for  pid=27854 comm=snap-discard-ns capability=setgid  scontext=system_u:system_r:snappy_mount_t:s0 tcontext=system_u:system_r:snappy_mount_t:s0 tclass=capability permissive=114:59
zygathis won't go away :/14:59
zygahmm14:59
zyganeed to think about why14:59
zygaI bet it's the lcok14:59
zyga*lock14:59
mvoackk: thanks for the updates! still in meetings .(15:01
sdhd-saschamvo: all existing tests are now green and direct is default. I commented in the PR15:09
=== ricab|lunch is now known as ricab
mvosdhd-sascha: nice, that sounds great! I'm still in meetings :/ but I will look as soon as I can. feel free to open a new PR based on the existing one with your updates though, that will means people like Chipaca  can review while I sit here in meetings15:11
Chipacagreen tests? eww15:11
sdhd-saschamvo: wait - ... i took your repo which was listed in the PR .15:11
sdhd-saschaChipaca: has passed - locally15:12
* zyga tries and idea, runs spread and goes for a tea break15:12
Chipaca:)15:12
* sdhd-sascha goes to work on own ubuntu-core and figuring out, how to split sway into reusable parts (maybe some more snapcraft-extensions)15:14
* ijohnson takes quick break15:28
mvo7969 needs a second review (pretty please :)15:42
pedronis#7934 is also ready for a 2nd review, is not simple though15:46
mupPR #7934: o/ifacestate,o/devicestatate: merge gadget-connect logic into auto-connect <Created by pedronis> <https://github.com/snapcore/snapd/pull/7934>15:46
mupPR snapd#7969 closed: snap: default to "--direct" in `snap known` for 2.43 <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/7969>15:53
ijohnsonzyga: so the issue is that black is complaining about the unused variable in that python PR I have15:57
ijohnsonzyga: is there a "pythonic" way to just have a variable exist without being used?15:57
ijohnsonmaybe `if var: pass` or something ?15:58
ijohnsoncachio: hey did you or anybody else look at the dbus failures on uc20 (i.e. netplan) ?15:59
cachioijohnson, sure, on master?16:00
mvosdhd-sascha: hey, just had a quick look at your sd-hd/snapd:snap-download-via-snapd-2 changes, looks very reasonable, it seems like it has a base branch that is based on something other than snapcore/snapd which seems to confuse github but the commit looks fine, I can cherry pick them into the open PR 762416:00
mvosdhd-sascha: thanks for working on this!16:00
mupPR #7624: snap: make `snap download` download via snapd if available <Created by mvo5> <https://github.com/snapcore/snapd/pull/7624>16:00
ijohnsoncachio: no I think on your (or maybe mvo) PR to enable the full test suite on uc2016:00
ijohnsoncachio: so not on master16:00
ijohnson(yet)16:01
cachioijohnson, in the mvo's branch, the netplan test is disabled16:01
ijohnsoncachio: ok cool16:01
cachioon mine is not, but it is not gonna be merged16:01
sdhd-saschamvo: i can rebase it for you ;-)16:01
ijohnsoncachio: so I take it no-one else has looked into it yet?16:01
cachioI'll take alook again today to that test16:01
cachioijohnson, yes please16:02
ijohnsoncachio: ok I will look today in the PM16:02
cachioI am still trying to fix tumbleweed16:02
cachioijohnson, thanks!!!16:02
sdhd-saschamvo: wait - i took it from your repo and merged it with snapd:master ?.16:03
* sdhd-sascha my wife is home - afk16:03
cjwatsonijohnson: is it really black that's complaining, rather than something like flake8?16:03
ijohnsoncjwatson: hmm actually I'm not sure what is complaining let me look16:03
ijohnsonI thought I had configured black but maybe it's something else16:04
cjwatsonijohnson: if it's flake8 then see http://flake8.pycqa.org/en/latest/user/violations.html#in-line-ignoring-errors perhaps16:04
ijohnsonI guess it is flake8 that is complaining about the variables16:09
mvoijohnson: 7971 should be ready, it's general flakiness that holds it back16:10
mvoijohnson: but the netplan failure is strange, I just had no time yet to debug16:10
ijohnsonmvo: I looked at the netplan error I think it's something more structurally wrong with dbus activated services on uc2016:11
ijohnsoncould be something needs to be added to writable or some permissions are set wrong16:11
ijohnsonnot sure yet16:11
mvoijohnson: aha, that makes sense. we can ask foundations for help here I guess16:11
ijohnsonmvo: I will look at it a bit later today, but in the meantime could I get a quick review on https://github.com/snapcore/snapd/pull/7973 pretty please :-) ?16:12
mupPR snapd#7973 opened: boot.go: split makebootable family into its own file <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7973>16:12
mupPR #7973: boot.go: split makebootable family into its own file <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7973>16:12
pedronismvo: can somebody else look into this, I thought ijohnson has already a lot of UC20 things on his plate16:12
mvopedronis: yeah, totally, he should not look into this, sorry if I gave this impression16:12
mvo(cc ijohnson -^)16:13
ijohnsonok, I will keep on uc2016:13
Chipacapopey: you're better at figuring out this stuff than I am: last two comments on https://forum.snapcraft.io/t/6093 seem to be sensible answers but don't have much to do with the problem being discussed. Suspect future spammers. WDYT?16:16
pedronisijohnson: reviewed, thanks, couple of nitpicks16:17
ijohnsonack, working on it now16:18
popeyChipaca: i do wish i was an admin and not just a mod on that forum. I dont have access to the same admin tools that help me spot these things as I do on the ubuntu discourse16:19
Chipacapopey: I'd give you admin if I could :)16:19
* Chipaca is also just a moderator16:19
popeyin fact...16:20
mupPR snapcraft#2860 opened: backport fixes for 3.9 <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2860>16:22
* Chipaca goes for a walk16:23
mupPR snapd#7960 closed: tests: use unbuffered python output for daemons, misc formatting <Simple 😃> <Test Robustness> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/7960>16:27
pedronisijohnson: btw, given there is already a baseBootSuite, it's probably not too hard to have a separate test fill too16:32
pedronis*test file16:32
ijohnsonpedronis: do you want to try and split that out now before making further changes?16:33
pedronisijohnson: as you prefer really, it's not crucial atm16:33
pedronisjust noticed16:33
mupPR snapd#7974 opened: many: run black formatter on all python files <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7974>16:40
ijohnsonzyga: ok this is the last I'm going to do with the python stuff for a while, but that PR is just the formatter changes, no substantial code changes16:40
* ijohnson switches back to uc2016:41
=== msalvatore_ is now known as msalvatore
mupPR snapd#7975 opened: release: 2.43 <Created by mvo5> <https://github.com/snapcore/snapd/pull/7975>16:41
ijohnsonpedronis: I agree I think it's a good idea to split the makebootable tests off too, I just created a PR stacked on top of the other one17:19
ijohnsonopened as 797617:19
mupPR snapd#7976 opened: boot: split makebootable tests into their own file <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7976>17:20
* zyga is doing homework with the kids and will return to resume work in about an hour17:20
zyga2020-01-09 16:36:08 Successful tasks: 558217:20
zyga2020-01-09 16:36:08 Aborted tasks: 017:20
zyga2020-01-09 16:36:08 Failed tasks: 217:20
zyga    - google:fedora-30-64:tests/main/selinux-clean17:20
zyga    - google:fedora-31-64:tests/main/selinux-clean17:20
mupPR snapd#7977 opened: snap: add (hidden) `snap download --indirect` option to download via snapd <Created by mvo5> <https://github.com/snapcore/snapd/pull/7977>17:21
mvosdhd-sascha: just fyi, I cherry-picked your --indirect things and pushed as 7977, thanks again for your help here17:22
* mvo wonders how much Chipaca will hate the idea of snap download --indirect :)17:22
Chipacamvo: i don't hate it17:24
mborzeckizyga: got logs?17:25
mvoChipaca: excellent :)17:31
mupPR snapd#7978 opened: data/selinux, test/main/selinux-clean: update the test to cover more scenarios <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7978>17:56
sdhd-saschamvo: nice :-)18:09
sdhd-saschamvo: you work on the snap maas ?18:10
sdhd-saschaMAAS18:10
mvosdhd-sascha: i don't work on that ackk does18:35
mvosdhd-sascha: and yeah, nice indeed, hopefully that can land soon18:35
sdhd-saschaok. I only want to know, if it's possible to mix a `apt install` with a `snap'ed maas`18:36
sdhd-saschaif so - then i would add a `snap maas region` here18:36
sdhd-saschai mean `maas-rack`18:37
mupPR snapd#7971 closed: tests: enable a lot of the tests of main on uc20 <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7971>18:37
mupPR snapd#7979 opened: boot: drop NameAndRevision, use snap.PlaceInfo instead <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7979>18:48
=== ijohnson is now known as ijohnson|lunch
=== ijohnson|lunch is now known as ijohnson
mupPR snapcraft#2861 opened: meta: remove Application's `prepend_command_chain` <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2861>19:48
* zyga returns to work on selinux policy bit19:51
mupPR snapd#7625 closed: cmd/snap-confine: stop being setgid root <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/7625>20:02
mupPR snapd#7980 opened: packaging,snap-confine: stop being segid root <Created by zyga> <https://github.com/snapcore/snapd/pull/7980>20:02
mupBug #1859084 opened: network-control interface seems to be broken on the Raspberry Pi 3 running Ubuntu Core 18 <Snappy:New> <https://launchpad.net/bugs/1859084>22:02
mupPR snapcraft#2862 opened: python plugin: remove bzr workaround <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2862>23:19
mupPR snapcraft#2863 opened: spread tests: use source-depth: 1 for plainbox tests <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2863>23:37
mupPR snapd#7981 opened: snap-bootstrap: create encrypted partition <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/7981>23:52
mupPR snapd#7723 closed: snap-bootstrap: create encrypted partition <UC20> <â›” Blocked> <Created by cmatsuoka> <Closed by cmatsuoka> <https://github.com/snapcore/snapd/pull/7723>23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!