[01:06] <thumper> ugh...
[01:06] <thumper> testing parallism is hard
[02:34] <babbageclunk> review for a small merge to develop anyone? https://github.com/juju/juju/pull/11116
[02:43] <thumper> babbageclunk: lgtm
[02:43] <babbageclunk> thanks!
[02:43] <babbageclunk> and anastasiamac!
[02:43] <anastasiamac> \o/ same minute :)
[02:44] <anastasiamac> i was telling u on irc that m looking but it erred on me ;(
[02:48] <thumper> lucidone: what was the ubuntu sso issue with launchpad?
[02:48] <thumper> lucidone: do you have a launchpad ID?
[02:51] <lucidone> I have an ubuntuone login, and logging in to launchpad presented an ubuntuone login form which didn't accept my email/password combination
[03:32] <thumper> lucidone: what is your login?
[03:51] <kelvinliu> wallyworld_: https://github.com/juju/juju/pull/11112 got this PR to add MutatingWebhookConfiguration support, could u take a look when u got time? thanks!
[03:51] <wallyworld_> yup, after meeting
[04:12] <kelvinliu> ty
[04:15] <Bandu> hi
[09:20] <nammn_de> manadart achilleasa pr (show-space) is ready to be reviewed. I still need to run qa on aws. Maas qa seems to be fine. Output and design doc is linked. I still need to match the output a little by adding a custom parser. Though codewise is mostly done: https://github.com/juju/juju/pull/11088
[09:21] <nammn_de> so I am happy for the first in review :D
[09:23] <nammn_de> and would be great if you have some error cases in mind as you have a lot of knowledge in spaces
[10:02] <nammn_de> rick_h:^ for the output of the command. Im thinking about having a --long output which includes subnets sub information and without
[10:23] <manadart> nammn_de: Finished reviewing.
[10:42] <manadart> For review: https://github.com/juju/description/pull/71
[10:46] <achilleasa> manadart: looking
[10:54] <nammn_de> manadart: great thanks for the review! Almost done, just don't understand this comment: https://github.com/juju/juju/pull/11088#discussion_r366786850
[10:54] <nammn_de> do you mean rename it to EntityParams?
[10:57] <manadart> nammn_de: Sorry, I meant `params.Entities`.
[11:29] <nammn_de> manadart: I have written some tests for applications and machinecount before I moved the methods out of space to a shim to decouple them. The tests itself are a little big and I wouldn't call them unit test as they are using state quite a lot.
[11:29] <nammn_de> https://github.com/nammn/juju/blob/0f681aff1d504fe2323a082e9ecbaa20cf027259/state/spaces_test.go#L81
[11:29] <nammn_de> What do you suggest doing with them? Moving them? Changing them?  Removing altogether? TestApplications and TestMachineCount
[17:03] <nammn_de> hml: i tried to incorporate your feedback on creating stubs and did it the following way: https://github.com/juju/juju/pull/11088/files (under apiserver/...). The tests itselfes still needs to be added. Just want to know if thats what you meant]
[17:03] <hml> nammn_de: looking
[17:06] <nammn_de> hml: I tried to not import state in apiserver
[17:24] <hml> nammn_de:  the common apiserver code is used to pull in common functionality for the apis to use.  not for use by the apiserver side code itself.
[17:25] <hml> nammn_de: Life() is a good example. and used all over.
[17:25] <hml> nammn_de: there is a common LifeGetter.
[17:26] <hml> nammn_de:  pulling the machine common into network common looks odd to me.
[17:30] <hml> nammn_de:  in apiserver/…/spaces/ you can add a Machine interface to be used by the stateShim.  it only needs to implement AddressesBySpaceID() at first glance
[17:42] <achilleasa> hml: got one question for utils/306
[17:43] <hml> achilleasa:  just a sec
[17:44] <hml> achilleasa:  sure, what’s up?
[17:44] <achilleasa> hml: just a comment about whether that func must be public
[17:45] <hml> achilleasa:  yeah, it doesn’t have to be, i was following the precendent in the pkg already
[17:45] <hml> achilleasa:  I could go either way on that
[17:46] <achilleasa> hml: I think having one entrypoint and delegating to different impls based on the args is cleaner. In this case, the two functions have almost (variadic vs slice for certs) the same signature
[17:46] <hml> achilleasa:  sure, i can do that
[17:52] <achilleasa> hml: as I will EOD in a couple of min, do you want to take a stab at the install hook for k8s? Unless I'm mistaken, it should be a matter for removing an if block somewhere...
[17:52] <hml> achilleasa:  sounds like fun!  :-) a nice change from docs
[17:53] <nammn_de> hml, : thanks I will keep that in mind, I am still sometimes in a state of figuring out which package is meant for what
[17:55] <hml> nammn_de: https://pastebin.canonical.com/p/xC2zxW8DBV/
[17:55] <hml> nammn_de: it’s interesting figuring those bits out.
[17:56] <nammn_de> hml, : great! yeah it is, asking a lot and reading it up helps me a lot, thanks again
[17:56] <hml> nammn_de: also put a hint about using collections/set NewStrings() in your pr too.
[17:56] <hml> it’s very useful!
[18:00] <nammn_de> hml,: will do :)!
[21:42] <kelvinliu> wallyworld_: a quick one, forward port webhook pr to 2.7
[21:42] <kelvinliu> https://github.com/juju/juju/pull/11118
[21:42] <kelvinliu> thanks!
[21:43] <wallyworld_> kelvinliu: lgtm
[21:43] <kelvinliu> ty