/srv/irclogs.ubuntu.com/2020/01/20/#snappy.txt

mborzeckimorning06:24
zygahey mborzecki07:51
zygamborzecki: who's in today?07:51
mborzeckizyga: hey, happy blue monday ;)07:52
zygaoh is that today?07:52
zygaI'm feeling pretty happy :)07:52
zygamore branch iteration07:53
zyganeed to double check roadmap work07:53
mborzeckizyga: mvo, samuele and Chipaca are out, maybe cmatsuoke too (?) he mentioned something during the standup didn he?07:53
zygamborzecki: chachio is out too AFAIR07:53
mborzeckizyga: oh, right, summer time ;)07:53
mborzeckizyga: oh, and ian is out today too?07:54
zygahaha really?07:54
zygain that case we can just chat in #snappy-pl ;)07:54
mborzeckihahah07:54
mborzeckizyga: have you read about the drama in rust community?07:56
mborzeckizyga: https://words.steveklabnik.com/a-sad-day-for-rust07:56
zygano, did someone die?07:57
zygahmmm07:57
zygaI will call my programs unsafe.c ;)08:01
zygathis whole thread re-affirms my perception that most social networks are poison08:02
zygaand reddit is particularly bad08:02
zygait's one to argue with someone you know08:02
zygait's another thing to play the game "endless waves of people talking you down"08:02
mborzeckizyga: idk, imo twitter takes the crown08:02
mborzeckias the worst social network08:03
zygaI disagree for a single reason08:03
zygatwitter is more of a rain08:03
zygayou can get hit by drops and stuff08:03
zygabut it's not a place where you are under a open pipe08:03
zygareddit has sub-reddits that amplify this08:03
zygareddit has "better" thread tools that amplify efficiency of negative feedback08:03
zygait doesn't negate twitter being junk in other forms but I haven't seen as much crap there, specifically on FOSS topics08:04
zygahey pawel08:04
mborzeckipstolowski: hey08:04
pstolowskiheyas08:04
zygadzindybry08:04
mborzeckizyga: yeah, readdit is quite effective at spreading negative feedback, though imo still twitter is where most drama takes place, and it's a short ride from twtitter to shitty news outlets everywhere08:05
zygamborzecki: for general news yes08:05
zygamborzecki: e.g. trump08:06
zygamborzecki: but my entire foss/twitter interaction was way better than reddit08:06
zygato change the topic slightly08:06
zygaI was playing with C code coverage over weekend08:06
zygaspecifically using clang on macos08:06
zygaand I learned a few things08:06
mborzeckizyga: old dog, new tricks? :)08:07
zygamore like alt toolchain I rarely use08:07
zygamy toy library has better code coverage now08:08
ograit is just all these fancy new languages you all use ... rust ... go ... nobody complains about shell on reddit ;)08:08
zyganot at 100% yet but much closer08:08
zygaalso wrote a few new manual pages08:08
zygaI'd say 1/3 of the API has manual pages now08:08
zygaogra: oh08:08
mborzeckizyga: about C, did you use that pvs studio open source license and tried to analyze out C bits?08:08
zygaI found a cool thing for shell08:08
zygaone sec08:08
zygamborzecki: yes I did08:08
* ogra sits in awe .... new things !08:09
zygaogra: a pep-8 like thing for shell08:09
zygaoh gosh, how was it called...08:09
ograshellcheck on steroids ?08:09
mborzeckismellcheck probably :)08:09
ogra*sniff* *sniff*08:09
zygaoh well, I cannot remember08:11
zygamaybe I'll recall it08:11
ograi'ts fine ... usually my code doesnt survive long enough to be worth checking it for pep-8 before someone rewrites it in a fancy lang ;)08:12
mborzeckizyga: https://github.com/openstack/bashate ?08:12
zygamborzecki: no, it had a more polite name08:12
zygaI should have kept the tab08:12
ograbtw, i finally managed to get gnome-shell up on core with mir-kiosk on the weekend (only very rudimentary yet) ...08:14
ogramy snapcraft.yaml only has ~100 layout overlays yet (with more to come i guess)08:15
ogralayouts really rock !08:15
ogra(until you decide to move an overlayed dir to single files with an upgrade and cant uninstall the sanp anymore at least :P )08:16
zygauh08:16
ograwhat would be a really helpful feature would be "overaly every file thats in the snap but not in core in one go"08:18
ogra*overlay08:18
ograi.e. simply diffing the dir structure and binding all non-existent files ...08:19
ograi was surprised how many bits and pieces are still hardcoded in gnome and not overridable by env vars ... (search paths for data in /usr/share etc ... )08:21
ogra... and finding out that even gnome-terminal doesnt run without dbus, systemd and logind anymore was a rather shocking moment ... half of it is javascript nowadays !!08:23
mupPR snapd#8020 closed: interfaces/apparmor: fix doc-comments, unnecessary code <Simple 😃> <Created by anonymouse64> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8020>08:59
zygamborzecki: do you think you could look at https://github.com/snapcore/snapd/pull/798009:01
mupPR #7980: packaging,snap-confine: stop being setgid root <Created by zyga> <https://github.com/snapcore/snapd/pull/7980>09:01
mborzeckizyga: sure09:01
* zyga has enormous headache :/09:33
zygathe air today is terrible09:33
mborzeckizyga: so is atmospheric pressure, was suppsoed to be 1050hPa09:35
zygauh, that's high09:35
mupPR snapd#7995 closed: debian: check embedded keys for snap-{bootstrap,preseed} too <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7995>09:35
zygahey mvo09:35
zyga:)09:35
mvohey zyga09:35
mborzeckimvo:  hey!09:35
zygaany news?09:36
mvohey mborzecki09:36
pstolowskihi mvo !09:36
mvomborzecki, zyga not much yet09:36
mvohey pstolowski09:36
mborzeckizyga: though the pressure sensor in my phone is showing 1024hPa09:37
mvobut it looks like we need to revert the do-not-show-writable PR, I think john is on this. or are there more news?09:38
zygamvo: do not show writable PR?09:38
zygamvo: are you referring to /writable unmounting we do?09:38
mvozyga: yeah, let me try to give you more context09:38
mvozyga: looks like statvfs("/writable") was used and that is no longer working09:39
zygamvo: yeah, I know this from last week - did we find out why they are doing it?09:39
mvozyga: monitor diskspace09:39
zygammm09:39
zygait's not really reliable09:40
zygabut I see09:40
mvozyga: because we do not work well when we run out of diskspace09:40
mvozyga: yeah, we need to fix the out-of-diskspace problem09:40
zygaI mean the check itself is also unreliable09:40
mupPR snapd#8018 closed: spread.yaml: fix ubuntu 19.10 and 20.04 names <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8018>09:40
zygabecause partitions09:40
mvozyga: in what way?09:40
mvozyga: can you expand that a bit please?09:40
zygabecause /writable is just one directory09:40
zygamaybe /writable/user-data is another09:41
zygait's not fixed in stone09:41
zygait's just a way to observe current implementation on some systems09:41
mvozyga: aha, I see. but for their devices it's all on a single partition. but in general yes, it may not be09:41
mvozyga: yeah, thanks, I get what you mean now09:41
zygamvo: I'm okay to revert this for now but I'd like not to be hostage to /writable09:42
zygaas in, that it is a single partition and that you can stat it to know disk space09:42
mborzeckibtw. this isn't reported in any way in /sys right?09:42
mvozyga: yeah, I think we may need to short-term revert, and then ensure we deprecate this mount and then remove it again in 1-2 releases09:42
zygamvo: agreed09:42
zygamborzecki: it might be09:42
mvozyga: thanks!09:42
mvomborzecki: a good question, that would be interessting09:42
mborzeckimvo: /sys/ext4/<device> constains some files but none that seems to carry size/free info09:44
* mvo nods09:44
zygamborzecki: ironically09:44
zygamvo: stat -f $HOME is an equally good check09:44
mborzeckizyga: heh, yeah, but looks like i can trigger fs errors :P09:45
zygamvo: maybe we should not revert09:45
zygamvo: but instead ask to tweak the one-liner stat check09:45
zygamvo: AFAIK it's one customer and one bit in their software09:45
mvozyga: yeah, I will explore if that is possible09:45
zygamvo: thank  you09:45
zygamvo: would certainly be more in line with what would work long term IMO09:45
mborzeckizyga: and you need a mounted fs to check free space too?09:45
mvomborzecki: haha - really?09:45
zygamborzecki: yes09:46
mvozyga: will this work inside the snap too?09:46
zygamvo: yes, stat is not mediated09:46
zygamvo: nor is statfs09:46
zygamvo: but I can double check if you want me to09:46
* zyga checks on a pi next 09:46
mvozyga: if it's not too much hassle would be nice09:46
mvozyga: a good alternative will make the conversation easier09:47
zygamvo: it works09:49
zygahttps://www.irccloud.com/pastebin/r6fnRvXK/09:49
zygamvo: this is on 2.43.109:49
zygamvo: so I'd vote +1 on customer change rather than our change unless they strongly oppose09:49
zygamvo: but even if they oppose we should have a proper interface for disk space09:50
zygamvo: statfs on a random picked directory is not it09:50
mvozyga: does "snapd-hacker-toolbelt.busybox stat -f $HOME" also work?09:50
mvozyga: +1 for proper interface09:50
mvozyga: also we should just be able to handle low/no diskspace better09:50
zygamvo: yes because $HOME is expanded in unconfined shell09:50
zygamvo: and it is unmediated as far as apparmor is concerned09:51
zygamvo: it is also working with snap rewritten home09:51
zygahttps://www.irccloud.com/pastebin/wBLAE3nq/09:51
mvozyga: nice, I will see if we can get away with this then09:51
zygacool :)09:51
zygaI didn't think of this last week09:52
zygabut I think it's a clean solution out of this problem09:52
zygaI need to grab painkillers, as infrequently as I use them I cannot work with constant headache :?09:52
zygamvo: high-pressure wave across .pl09:52
zygabrb09:52
mvozyga: uh, good luck!09:56
mupPR snapd#8022 opened: Revert #7421 <Created by chipaca> <https://github.com/snapcore/snapd/pull/8022>10:00
zygaback10:01
__chip__zyga: 👋10:03
zygahey __chip__ :)10:03
__chip__zyga: can you take a look at #8022 ? there was a conflict in the revert so I hand-edited a couple of files, but I'm not sure they came out OK. I ran the spread test but the conflicts were in 1604 test files that don't seem to be exercised ((?))10:04
mupPR #8022: Revert #7421 <Created by chipaca> <https://github.com/snapcore/snapd/pull/8022>10:04
__chip__concretely tests/main/mount-ns/google.ubuntu-core-16-64/PER-USER-16.expected.txt and tests/main/mount-ns/google.ubuntu-core-16-64/PER-SNAP-16.expected.txt10:04
__chip__were the ones with conflicts10:04
zygaok10:05
__chip__(I'm not sure they're exercised as that spread test only runs in 1804)10:05
zyga__chip__: FYI check out the conversation with mvo just above10:05
__chip__zyga: I've only just logged onto irc so i'll have to wait for ubuntulog2 for that :)10:05
zyga__chip__: idea to use stat -f $HOME instead of the revert10:06
zyga__chip__: and ask the customer to use that instead10:06
__chip__zyga: $HOME, or /home ?10:06
zyga__chip__: due to how statfs works they can check /var/snap, /var/lib/snapd and other places10:06
__chip__$HOME is probably /root FWIW10:06
zyga__chip__: /home would work as well10:06
zygathat works too btw10:07
__chip__yep10:07
__chip__zyga: I think we can ask the customer to make any amount of changes, the issue is the timeline10:07
zyga__chip__: I was concerned about cementing /writable as an interface10:07
zyga__chip__: changing stat on their side is a one liner10:07
__chip__agreed, and note i targeted the release branch with the pr, not master10:07
zygaand it works in past snapd versions as well10:08
zyga__chip__: sure, I just wanted to recap what was said above10:08
__chip__zyga: i wouldn't presume to know the timeline of them releasing a one liner10:08
__chip__but yeah if they can change it quicker than we can revert it, +210:08
zygayeah10:08
zygaI don't know either10:09
__chip__in any case that's async10:09
__chip__we can have this pr ready to go if they come back with '2 months to get this rolled out to prod'10:09
zygaI'll adjust your PR to pass10:09
__chip__ah, the PR title is probably wrong :-) thanks10:09
__chip__zyga: i pinged you on telegram before coming on here because sprint-mode10:13
__chip__zyga: you can ignore that now :-D10:13
__chip__also it might've gone to your spanish phone #10:14
zygaI see it now :)10:14
__chip__:)10:14
zygait's my proper telegram number btw10:14
__chip__i see you seeing it10:14
mborzeckicjwatson: hi, do you have access to the machine where https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1860324 occurred?10:15
mupBug #1860324: snapd crashed and can't start: "Re-refresh task has 1 tasks waiting for it" <amd64> <apport-bug> <bionic> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1860324>10:15
* __chip__ out10:15
cjwatsonmborzecki: yes, it's my normal development laptop10:28
mborzeckicjwatson: can you post the output `snap changes` command? or if snapd cannot start, then make sure it's stopped and try `snap debug state /var/lib/snapd/state.json` and post that10:29
cjwatsonmborzecki: added to the bug10:32
mborzeckicjwatson: thanks!10:33
mborzeckihmmm, so switch-snap channel got added, and everything is ordered before it, incl rerefresh10:37
zygamborzecki: ?10:41
mborzeckizyga: see the bug report ^^10:42
mborzeckiheh, Switch snap "gitlptools" from channel "latest/stable" to "stable"10:43
zygauh10:43
zygathat's not good10:43
mborzeckiwish chipaca was around ;)10:43
mborzeckihm potentially same thing with toggle-snap-flags task10:44
zygasnap debug state is lovely10:46
zygabut that argument could be optional (state file path)10:46
pstolowskizyga: it would be super useful to teach it more things10:54
zygapstolowski: now's the chance to merge ;-)10:54
pstolowskizyga: haha10:55
mupPR # closed: core#38, core#107, core#108, core#11011:50
mupPR # opened: core#38, core#107, core#108, core#11011:51
mupPR snapcraft#2886 opened: Use ensure_dir_exists instead of mkdir -p <Created by MarcusTomlinson> <https://github.com/snapcore/snapcraft/pull/2886>12:18
mborzeckicjwatson: would you be able to attach the output of `sudo cat /var/lib/snapd/state.json| jq '.data.snaps.gitlptools'` too?12:29
cjwatsonmborzecki: done12:30
mborzeckicjwatson: cool, thanks12:30
zygamborzecki: any closer?12:36
mborzeckizyga: no, not really, added a managers level test, but can't seem to reproduce it12:40
pstolowskimborzecki, zyga it's pretty scary we have logger.Panicf("Re-refresh task has %d tasks waiting for it.", numHaltTasks)12:42
zygamborzecki: do you have a theory what is going on?12:42
zygapstolowski: are we hitting that?12:42
* zyga is out of sync with that bug12:43
pstolowskizyga: yep, it's in the desc of the PR12:43
pstolowskiJan 20 09:54:38 niejwein snapd[9861]: panic: Re-refresh task has 1 tasks12:43
zygauh12:43
zygaI see12:43
zygasome assumption doesn't hold12:43
zygais this code in the candidate branch?12:43
pstolowskiyeah.. root cause is something else, but we shouldn't do this..12:44
zygacan we degrade  that to an error12:44
zygaso that some refresh goes on12:44
zygaI really think we should not panic :/12:44
pstolowskiyeah, not in the task handler that is bound to be re-run12:44
zygabrb,12:45
pstolowskimborzecki: so yeah, as you said above (sorry, just catching with the backlog on that bug), it's because of adding switch-snap-channel12:47
zygare12:49
pstolowskimborzecki, zyga so i think (afair from talking to pedronis long time ago) the basic invariant has always been for check-refresh to be the last task. UpdateWithDeviceContext seems to have bug as it can append to tasks from doUpdate12:57
mborzeckipstolowski: i think it's related to having channel: "stable" in the state, and the code around that does a simple lexical comparison12:58
pstolowskimborzecki: that may be another problem then.. but as is, I think nothing prevents UpdateDeviceContext from appending task after check-rerefresh, in which case check-rerefresh will panic12:59
mborzeckipstolowski: so we have possible aliases update, a task gets added, then rerefresh (why is the alises update done at all?), then level up the call stack, switch channel is added because snapstate channel is "stable", while we currently resolve "stable" (that came from the command line) to "latest/stable"13:01
mborzeckipstolowski: oh, and another problem, now snapd is stuck and panics, how we get out of that ;)13:03
mborzecki(other than editing the state)13:03
pstolowskimborzecki: i see. i suppose it would end up badly also with a switch from stable, to say latest/edge?13:03
pstolowskimborzecki: bummer..13:05
pstolowskiwe shouldn't panic in task handlers :(13:05
pstolowskifirst time to use recovery mode?13:05
cjwatsonFor myself I'm perfectly happy to edit the state if given instructions on how to do that correctly, but I assume this might affect others13:10
mborzeckihmm edited my state in a way that should break it, but no luck there13:20
=== ricab is now known as ricab|lunch
mupPR snapcraft#2885 closed: lifecycle: only warn when a default provider snap is missing <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2885>14:04
mupPR snapcraft#2886 closed: Use ensure_dir_exists instead of mkdir -p <Created by MarcusTomlinson> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2886>14:04
mupPR snapcraft#2887 opened: 3.9 cherrypicks <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2887>14:17
zyganet issues?14:26
zygayeah, I have net issues at home14:26
zygasil2100: https://github.com/snapcore/pi-gadget/issues/13 did you see?14:29
mupPR snapd#8023 opened:  devicestate: encryption regardless of grade <Created by mvo5> <https://github.com/snapcore/snapd/pull/8023>14:36
zygare14:59
ijohnsonmborzecki: thanks for the PR to etrace, the options there aren't well documented :-(15:03
mborzeckiijohnson: figured it's a WIP :)15:03
ijohnsonmborzecki were you using it to measure a cli program or did the window name stuff not work?15:04
ijohnsonYes still a WIP15:04
=== ricab|lunch is now known as ricab
mborzeckiijohnson: started with `etrace run ls`15:04
ijohnsonAh yes that probably just got stuck15:05
mborzeckipstolowski: haha, got `panic: Re-refresh task has 1 tasks waiting for it.`15:09
pstolowskimborzecki: re stable vs latest/stable, it seems we have a bug in that we don't normalize --stable and then stable != latest/stable in snapstate's Update15:11
pstolowskimborzecki: uhh, what did you do? how?15:11
mborzeckipstolowski: let me open a PR15:11
mborzeckihowever, i still ahve no idea how we ended up tracking the 'stable' channel expliclitly in the state15:12
zygamborzecki: good work L)15:12
pstolowskimborzecki: i've a theory on that15:12
zyga:)15:12
pstolowskimborzecki: in patch 6_3 we only normalize tracking channel, but not the channel sequence (maybe that's fine, i don't know). perhaps that revision was installed with older snapd so didn't get normalized. revisions installed with new snapd get the full channel inside sequence15:14
mupPR snapd#8024 opened: overlord/snapstate: add reproducer for LP#1860324 scenario <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8024>15:18
mborzeckipstolowski: ^^15:19
pstolowskimborzecki: as for aliases you're right, the number of aliases changed, and this resulted in check-rerefresh task (because reportUpdated is non zero)15:19
mborzeckipstolowski: yeah, and snap declarations are refreshed on their own15:19
oSoMoNjdstrand, hey, I would welcome your opinion on bug #185964315:39
mupBug #1859643: [snap] cannot use shared NSS db <snap> <chromium-browser (Ubuntu):Triaged by osomon> <https://launchpad.net/bugs/1859643>15:39
om26erzyga I need your input on https://forum.snapcraft.io/t/software-based-presentation-remote-or-need-an-interface-to-talk-uinput/1395116:03
zygammm16:03
zygalooking16:03
zygaresponded16:05
mupPR snapcraft#2887 closed: 3.9 cherrypicks <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2887>16:17
om26erThanks ^ I replied ;-)16:22
zygaom26er: reading16:22
zygaom26er: can you please run that and attach a strace to the thread16:23
zygaom26er: ideally strace -e ... that limits to the relevant parts16:23
zyga(probably open + ioctl or open + write)16:23
zygaom26er: thank you!16:23
om26erSure, I will do that16:23
zygaom26er: btw, is the rest of what I said sensiblke?16:23
zygaom26er: it could be handled by the user session daemon, perhaps16:23
zygaom26er: also, do you know how this differs in wayland?16:24
zygadoes wayland have a proper event injection API?16:24
om26erzyga I think the X11 interface allows access to /dev/uinput hence it works fine in that environment. Not sure if the wayland interface allows that16:24
zygaom26er: apart from interfaces in snapd16:25
zygaom26er: I mean, x has an explicit message to inject events16:25
zygaom26er: so you can either push them back from linux side16:25
zygaom26er: or talk to X and tell it "here's an event"16:25
zygaom26er: do you know how _this_ aspect looks like in Wayland?16:25
om26erno, not aware about internals of wayland at all :/16:26
om26erWill need to look if wayland has a "higher level" of input injection API of sorts16:27
zygaom26er: ok16:27
om26erthat discussion might be relevant https://lists.freedesktop.org/archives/wayland-devel/2017-March/033514.html16:28
om26erinterestingly Jamie had some feedback on a related topic a while back https://bugs.launchpad.net/snappy/+bug/162263916:32
mupBug #1622639: Snap access to /dev/uinput <snapd-interface> <Snappy:Triaged> <https://launchpad.net/bugs/1622639>16:32
zygare17:07
zygaswitching gears to one more PR17:11
zygabut I'll EOD in about an hour17:11
abeatoijohnson, maybe you know, how something like 'Dec 12 21:56:18 evt2-integration-3 snapd[1225]: stateengine.go:150: state ensure error: Get https://api.snapcraft.io/api/v1/snaps/sections: dial tcp: lookup api.snapcraft.io: no such host' could happen?17:25
ijohnsonabeato: looks like dns resolution failure17:25
abeatoijohnson, yeah, but they seem to have access... weird17:26
ijohnsonabeato: how do you know they have access ? was this a temporary failure perhaps ?17:27
abeatoit does not look like that - maybe they use a proxy though17:27
abeatoI'll ask them back17:27
ijohnsoncould be proxy issue17:28
* zyga takes a break18:11
=== msalvatore_ is now known as msalvatore
mupPR snapd#8025 opened: overlord/snapstate: add reproducer for LP#1860324 scenario (2.43) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8025>19:23

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!