[00:00] <sdhd-sascha> you. all, too :-)
[00:13] <sdhd-sascha> Ian. It's nice to read your message. Because my thing in my brain remembers, or something.. thank you, for learning ; -) just rembering the timezones ;-)
[00:45] <mwhudson> how can i see when a branch is going to close?
[06:36] <mborzecki> morning
[06:54] <mup> PR snapd#8028 closed: tests: use test-snapd-upower instead of upower <Test Robustness> <⚠ Critical> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8028>
[08:04] <pstolowski> morning
[08:05] <zyga> good morning
[08:05] <zyga> mwhudson: what do you mean?
[08:06] <mwhudson> zyga: branches autoclose in 30 days right?
[08:06] <zyga> mwhudson: ah, I see
[08:06] <zyga> I _think_ so
[08:06] <zyga> but I only used branches once
[08:06] <zyga> and I didn't look at it after the week I needed it
[08:06] <mwhudson> i'm sure i've seen the date a branch is due to close at somewhere in some command's output
[08:06] <mwhudson> but i can't remember what
[08:14] <roadmr> zyga, mwhudson : they do, and closure date might show in snapcraft status output
[08:14] <roadmr> not sure snap info shows that
[08:15] <roadmr> actually pretty sure snap info does NOT show that because it doesn't show branches at all :)
[08:16] <roadmr> mwhudson: confirmed, you need to own the snap and use "snapcraft status" to see branch expiration timedate
[08:16] <mwhudson> oh wait part of why i'm confused is that the branches i care about have already closed :)
[08:16] <mwhudson> roadmr: thanks for checking that though :)
[08:16] <roadmr> mwhudson: :P
[08:24] <mborzecki> zyga: pstolowski: hey
[08:33] <mborzecki> zyga: do you remember a discussion about debug symbols in snaps?
[08:34] <mborzecki> zyga: there's a discussion about stripping arch packages, and someone brought up Clear Linux debug symbols support: https://docs.01.org/clearlinux/latest/guides/clear/debug.html#
[08:34] <mborzecki> zyga: imo it does look intriguing
[08:46] <mup> PR snapd#8030 closed: tests: add a command-chain service test <Simple 😃> <Created by chipaca> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8030>
[08:51] <zyga> mborzecki: yes, I do
[08:52] <zyga> mborzecki: indeed, that is interesting
[08:52] <zyga> mborzecki: can you add this so the thread somewhere or add a card to investigate it later
[09:29] <zyga> gosh, I'm so sleepy today
[09:31] <mborzecki> zyga: the fact that it's snowing doesn't make it better i suppose
[09:31] <zyga> snownig?
[09:31] <zyga> *snowing?
[09:31] <mborzecki> zyga: or at least it's pretending to snow here
[09:31] <zyga> really?
[09:31] <zyga> it's raining here
[09:31] <zyga> at +3
[09:31] <roadmr> snowesome!
[09:32] <zyga> I wish we had a real winter
[09:32] <zyga> not this fake winter thing
[09:33] <mborzecki> zyga: yeah, snowing very lightly and it melts right away
[09:33] <zyga> I'm fighting the mount-ns test and the gadget test now
[09:33] <zyga> I'll make real coffee (decaf doesn't work but doesn't cause headaches) and keep pushing
[09:34] <roadmr> in soviet russia vinter melts you
[09:34] <mborzecki> zyga: can you take a look at https://github.com/snapcore/snapd/pull/8029 ?
[09:34] <mup> PR #8029: tests: use test-snapd-upower instead of upower <Test Robustness> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8029>
[09:34] <zyga> oh, that's a 2.43 backport
[09:34] <zyga> sure
[09:35] <zyga> +1
[09:35] <zyga> shall we just merge? I think so
[09:38] <mborzecki> https://github.com/snapcore/snapd/pull/8027 is green, i'd land it and start working on a followup
[09:38] <mup> PR #8027: snap: disable auto-import in uc20 install-mode <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8027>
[09:38] <zyga> mborzecki: I see what you mean now, that's great
[09:38] <zyga> it's green
[09:38] <zyga> let's land
[09:39] <zyga> though ian wanted to look
[09:39] <zyga> can you work on a follow-up
[09:39] <zyga> ian should be up soon-ish
[09:41] <mborzecki> zyga: yeah, i will
[09:41] <mborzecki> quick errand, back in 1h or so
[09:42] <zyga> ok
[09:45] <zyga> hmm
[09:45] <zyga> what's /image.fstab?
[10:02] <mup> PR snapcraft#2874 closed: Sync fixes from snapcraft-desktop-helpers (LP-1661626 & broken XDG link) <Created by MarcusTomlinson> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2874>
[10:08] <pstolowski> zyga, mborzecki are you guys familiar with test suites in spread?
[10:08] <zyga> pstolowski: as much as we all are
[10:08] <zyga> what's up?
[10:09] <pstolowski> zyga: i defined a new one (which is a carbon copy of existing one, plus tweaks), but getting: error: nothing matches provider filter
[10:09] <zyga> pstolowski: can you show me ze code
[10:09] <pstolowski> spread -debug google-nested:ubuntu-18.04-64:tests/nested/preseed/
[10:10] <zyga> you need an entry in spread.yaml
[10:10] <zyga> and a directory with actual tests
[10:10] <pstolowski> zyga: https://pastebin.ubuntu.com/p/7YRs9qT6w7/
[10:10] <zyga> pstolowski: did you add tests to tests/nested/preseed?
[10:11] <pstolowski> zyga: https://pastebin.ubuntu.com/p/3HFjMMrG7b/
[10:11] <zyga> is the task manual?
[10:12] <pstolowski> zyga: it's manual:true in the suite definition, not in the task ()it's the same for existing nested tests
[10:12] <zyga> hmm
[10:13] <zyga> can you spread -list and see it?
[10:13] <zyga> brb
[10:14] <pstolowski> aha, it's not shown, maybe indentation is off in the yaml
[10:20] <pstolowski> nope, indentation is fine.. it must be something silly
[10:24] <zyga> pstolowski: silly idea
[10:24] <zyga> pstolowski: build spread and printf the yaml it loads
[10:24] <zyga> pstolowski: or maybe spread -list -vv will show that, dunno
[10:24] <zyga> I wonder what is
[10:25] <pstolowski> zyga: indeed -vv prints it
[10:25] <zyga> pstolowski: backends?
[10:25] <zyga> and if you remove manual: true?
[10:27] <zyga> ha
[10:27] <zyga> I found a bar of chocolate
[10:27] <zyga> it was on top of the fridge
[10:27] <zyga> probably hid it so  that kids would not devour all xmas stuff at once
[10:28] <zyga> $wife doing orange juice and needed to fetch the juicer
[10:28] <pstolowski> :)
[10:30] <pstolowski> removing manual:true doesn't help. my suite is visible as spread.Suite with -vv. something doesn't match somewhere apparently
[10:30] <zyga> can you check backends
[10:30] <zyga> I had an issue somewhere a while ago
[10:30] <zyga> where a test would just not execute on anything defined
[10:30] <zyga> because backends or systems didn't match
[10:37] <pstolowski> zyga: aaah, silly me, solved. backends systems definition vs test's system as you said, thank you!
[10:37] <zyga> cool :)
[10:37] <pstolowski> i'll need sergio to figure out 19.10 and 20.04 on gc
[10:43] <zyga> mborzecki: can you look at https://github.com/snapcore/snapd/pull/8031 when you are back
[10:43] <mup> PR snapd#8031 opened: tests: update mount-ns test tables <Created by zyga> <https://github.com/snapcore/snapd/pull/8031>
[10:43] <mup> PR #8031: tests: update mount-ns test tables <Created by zyga> <https://github.com/snapcore/snapd/pull/8031>
[10:43] <zyga> mborzecki: in particular I think I found a bug in writable paths configuration
[10:44] <zyga> mborzecki: as /etc/systemd/system is mounted twice
[10:56] <mborzecki> re
[10:56] <zyga> mborzecki: o/
[10:57] <mborzecki> oh, that's interesting
[10:57] <mborzecki> zyga: does that only happen on core?
[10:57] <zyga> system or machine-id?
[10:58] <zyga> I think only on core
[10:58] <zyga> let me check
[10:58] <mborzecki> /etc/systemd/system moutned twice
[10:58] <zyga> yeah
[10:58] <zyga> note that it is mounted on HOST
[10:58] <zyga> so it's there before we touch it
[10:59] <mborzecki> zyga: maybe related to /etc/systemd/system coming from writable
[10:59] <zyga> I bet some code manually does it
[10:59] <zyga> I checked core18 and it's only listed once
[10:59] <mborzecki> or the whole /etc/systemd, don't remember how wriable-paths is set up in 18
[10:59] <zyga> so ... dunno
[11:02] <sdhd-sascha> hey, is there another interface for the call `sched_setscheduler` ? I only found `process-control`, `docker`, `browser` ? It seems that music-application, like synthezier and midi-sequencer also needs this.
[11:04] <zyga> I don't think so
[11:04] <zyga> there used to be rtkit
[11:04] <sdhd-sascha> hmm, `process-control` could be good enough.
[11:04] <zyga> that would allow apps to use it without privs
[11:04] <zyga> sdhd-sascha: do you have an app that needs it?
[11:04] <sdhd-sascha> zyga: true, thank you
[11:04] <sdhd-sascha> in #snapcraft, there i test `gsequencer` snap https://bazaar.launchpad.net/~jkraehemann/+junk/gsequencer-3/files
[11:05] <sdhd-sascha> i just see this call in the logs. Is not for me
[11:13] <zyga> mborzecki: check this out
[11:14] <zyga> https://www.irccloud.com/pastebin/89vWxX4n/
[11:14] <zyga> just a quick prototype
[11:18] <zyga> the diff is tiny, I'll check how it changes the usability of the data
[11:19] <zyga> I suspect it will let us see meaningful diffs across core systems
[11:19] <zyga> brb
[11:19] <zyga> mborzecki: also note the machine-id thing
[11:19] <zyga> it feels very fishy
[11:19] <zyga> unless I am looking at some tmpfs-not-persistent view
[11:19] <zyga> but I doubt taht
[11:19] <zyga> *that
[11:34] <mup> PR snapd#8027 closed: snap: disable auto-import in uc20 install-mode <UC20> <Created by mvo5> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8027>
[11:37] <zyga> re
[11:38] <zyga> hey ian!
[11:38] <zyga> thanks for merging that
[11:38] <zyga> mborzecki: ^ follow-up space ready
[11:38] <mborzecki> mhm
[11:39] <ijohnson> Hey folks
[11:40]  * ijohnson is not really here yet
[12:09] <pstolowski> hi ijohnson!
[12:18] <mup> Issue core20#12 opened: Drop consoleconf from the core snap <Created by xnox> <https://github.com/snapcore/core20/issue/12>
[12:18] <mup> PR core20#11 opened: Add arm64 architecture <Created by xnox> <https://github.com/snapcore/core20/pull/11>
[12:19] <zyga> eh, mup still gives bad github urls
[12:21] <zyga> mborzecki: I simplified the differential idea, I love it
[12:21] <zyga> mborzecki: thank got python has type inheritance on base types
[12:21] <zyga> mborzecki: so all I needed was sint(int) that renders as {:+}
[12:21] <zyga> and a few patch-ups to use sint() when diffing
[12:21] <zyga> I'll check how this behaves in reality in core16
[12:21] <zyga> but I'm very optimistic now
[12:22] <zyga> mborzecki, ijohnson: I'd like to land this https://github.com/snapcore/snapd/pull/8031
[12:22] <mup> PR #8031: tests: update mount-ns test tables <Created by zyga> <https://github.com/snapcore/snapd/pull/8031>
[12:22] <zyga> green
[12:22] <zyga> please review / object
[12:54] <mup> PR snapd#8032 opened: boot, cmd/snap(-bootstrap): move run mode and system label detection to boot <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8032>
[12:55] <mborzecki> cmatsuoka: ^^ can you take a look
[12:55] <cmatsuoka> mborzecki: sure, I'm just finishing a fix here
[12:55] <zyga> guys, I need to skip standup
[12:55] <zyga> or I'll join from the go
[12:56] <zyga> need to help wife as she drives around with lucy
[12:56] <cmatsuoka> ack
[12:56] <zyga> plus no food at home and starving to eat out
[12:56] <zyga> I'll keep working on a feature branch on the ho
[12:56] <zyga> *go
[12:58] <mup> PR snapd#8033 opened: Tweak/differential mount ns <Created by zyga> <https://github.com/snapcore/snapd/pull/8033>
[12:59] <ijohnson> zyga: yeah I reported the mup GitHub issue links to Gustavo a while ago
[12:59] <zyga> ^ just a draft, partial data change, won't pass
[12:59] <ijohnson> zyga: also yes I will review your branch after SU
[12:59] <zyga> ijohnson: I think I did so as well
[12:59] <zyga> ijohnson: thanks!
[12:59] <zyga> going now
[12:59] <zyga> ttyl
[12:59] <zyga> I'll publish testbed-tool today
[12:59] <zyga> didn't figure out a better name, open to rename later
[13:09] <mborzecki> ijohnson: have you started looking into a spread test for kernel failover? if not i can look into that
[13:12] <mup> PR snapcraft#2888 opened: elf: read ELF type when extracting attributes <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2888>
[13:15] <ijohnson> mborzecki: do you mean for the uc20 kernel extraction? I have not yet done a spread test, but I have started a bit what we talked about with pedronis on Friday about panic'ing in the mock bootloader
[13:25] <mborzecki> ijohnson: i can try with actual broken kernel, to see how complicated that is
[13:31] <zyga> re
[13:31] <zyga> online in the back seat
[13:31] <zyga> all three kids accounted for
[13:31] <zyga> dog included
[13:31] <zyga> man
[13:31] <zyga> we travel like polish memes
[13:34] <ijohnson> mborzecki: I tried the failover with an empty file as the kernel.efi but the bootloader just hung, so if you had a real broken kernel that panicked immediately that would be better for tests
[13:35] <cmatsuoka> can I un-approve a PR after I already approved it?
[13:35] <mborzecki> cmatsuoka: you can dismiss your review
[13:35] <mborzecki> cmatsuoka: should be near the bottom of the page, where the ci checks are listed
[13:35] <cmatsuoka> hmm, let me see...
[13:36] <cmatsuoka> Ok, nice, thanks!
[13:43] <ogra> zyga, https://imgur.com/a/XtGYPeI ... about 200 layout entries now ... but it runns fully confined (as root, no gdm/lightdm though)
[13:44]  * ogra is very surprised to not see an actual performance impact from these many layouts 
[13:46] <zyga> ogra: OMG
[13:46] <zyga> I need to rework some layout code to make it better
[13:46] <ogra> it would be really awesome to have  something luke "auto-layout" ...
[13:47] <ogra> simply diff $SNAP with / and automatically add bindmounts and symlinks for all non-existing files in /
[13:47] <ogra> s/luke/like/ ... :)
[14:01] <mborzecki> ijohnson: standup?
[14:24] <diddledan> mborzecki, sit down!
[14:24] <mup> PR snapcraft#2889 opened: meta: always generate snapcraft-runner to workaround classic PATH bug <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2889>
[14:26] <zyga> back!
[14:27] <zyga> what did I miss
[14:27] <zyga> mborzecki: is the standup over?
[14:27] <mborzecki> diddledan: rinse and repeat :)
[14:27] <mborzecki> zyga: yup
[14:28] <ijohnson> zyga: you missed the part where I heroically came in at the last minute to standup
[14:28] <zyga> haha
[14:28] <zyga> if you were a moment longer I could have joined too :)
[14:28] <zyga> but no worries
[14:28] <ijohnson> :-)
[14:28] <zyga> my standup update is simple: fixed one more branch (green), working on leaky tests
[14:28] <ijohnson> also did you see my comment on your core20 mount ns PR?
[14:28] <zyga> as an associated brach-off I updated mount-ns tables
[14:28] <zyga> ijohnson: not yet
[14:29] <zyga> and I'll open another PR that does differential tables
[14:29] <ijohnson> just a quick thing not sure if you had a typo or if we do actually have an issue there
[14:29] <zyga> probably not a typo
[14:30] <ijohnson> hmm :-/
[14:30] <zyga> ijohnson: so (/dev/sda3)/EFI/ubuntu was mounted as /boot/grub
[14:30] <zyga> ijohnson: (if this syntax makes sense)
[14:30] <zyga> ijohnson: is that unexpected?
[14:30] <ijohnson> yes that makes sense
[14:30] <ijohnson> your PR description said /boot/grub was from /boot/EFI
[14:30] <zyga> ijohnson: in any case I think this PR showed some suspicious stuff and I'm happy I updated those tables
[14:30] <ijohnson> (missing the /ubuntu) at the end
[14:30] <zyga> ah, probably mistake there :)
[14:30] <ijohnson> :-)_
[14:30] <zyga> I did type the commit by hand
[14:31] <zyga> while outside I got a veggie burger
[14:31] <zyga> and it was ... good
[14:31] <zyga> not great but not bad either
[14:31] <zyga> need to try some more
[14:34] <zyga> ijohnson: I revised the commit message
[14:34] <mup> PR snapd#8024 closed: overlord/snapstate: add reproducer for LP#1860324 scenario <Created by bboozzoo> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/8024>
[14:34] <mup> PR snapd#8025 closed: overlord/snapstate: add reproducer for LP#1860324 scenario (2.43) <Created by bboozzoo> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/8025>
[14:35] <ijohnson> zyga: have you tried the "impossible burger" ?
[14:35] <zyga> ijohnson: nobody sells them here yet
[14:35] <zyga> but I heard about it
[14:35] <ijohnson> zyga: ah I see
[14:35] <ijohnson> I haven't tried it myself yet either
[14:35] <ijohnson> I really like these black bean veggie burgers from the supermarket though
[14:36] <ijohnson> don't remember the brand
[14:36] <zyga> I love beetroot burgers
[14:36] <zyga> we make them at home
[14:36] <ijohnson> interesting never tried beetroot burgers
[14:36] <mborzecki> zyga: beetroot in place of meat or the bun?
[14:36] <zyga> mborzecki: meat
[14:36] <zyga> it's not pure beetroot, I can ask my wife for the recipe
[14:37] <zyga> but the taste is insane :)
[14:37] <zyga> I love those really
[14:37] <zyga> we bake them in the oven
[14:37] <mborzecki> btw. if it has no mean, can it still be called a burder or does it downgrade to sandwich at that point? :P
[14:37] <mborzecki> s/mean/meat/
[14:37] <zyga> and when we make a batch it's usually 30-50
[14:37] <zyga> we eat half and freeze the rest or give them away
[14:38] <zyga> mborzecki: I think nobody can claim it is not a burder ;-)
[14:38] <zyga> https://github.com/snapcore/snapd/pull/8031 <- review please
[14:38] <mup> PR #8031: tests: update mount-ns test tables <Created by zyga> <https://github.com/snapcore/snapd/pull/8031>
[14:38] <zyga> it's just the data tables
[14:38] <zyga> and I can open the follow-up on top
[14:43] <mup> PR snapd#8034 opened: fix for lp:1860324 for 2.43 <Created by chipaca> <https://github.com/snapcore/snapd/pull/8034>
[14:44] <__chip__> 👋
[14:44] <zyga> hey __chip__
[14:44] <__chip__> #8034 should be interesting
[14:44] <mup> PR #8034: fix for lp:1860324 for 2.43 <Created by chipaca> <https://github.com/snapcore/snapd/pull/8034>
[14:44] <zyga> __chip__: ouch, updated vs updates!
[14:44] <__chip__> as soon as samuele can there'll be one against master (already pushed so you can look at it if you want but not proposed so missing my test)
[14:45] <zyga> mhm
[14:45] <zyga> thank you for finding the time to propose those at the sprint!
[14:45] <__chip__> to be clear, this is a bug on master, 2.43 just makes it more likely
[14:45] <zyga> we'll get them reviewed
[14:45]  * zyga nods
[14:45] <__chip__> but it's subtle enough that it warrants another 2.43, at least the last time i was able to talk about it with mvo
[14:46] <zyga> __chip__: did any new data on the __writable__ issue came up at the sprint?
[14:47] <__chip__> zyga: not yet, i think we're waiting for info from $customer but i don't know if we've asked them yet :|
[14:47] <__chip__> zyga: i'll ask
[14:47] <ijohnson> __chip__: zyga: I asked the customer in the bug but didn't hear anything back
[14:47] <zyga> ack, thank you guys
[14:48] <__chip__> ijohnson: was the customer reading the bug, or did it need to go via field?
[14:48] <__chip__> 'cause all i was going to do was ask field :)
[14:48] <__chip__> (which i can still do, sometimes the cable needs jiggling)
[14:48] <ijohnson> __chip__: the customer reported the bug and responded to a question I asked on Friday so I assume that they are reading it, but they might have been busy with other things mon/tues
[14:49] <zyga> __chip__: the bug tracker was customer specific so I would expect they follow it
[14:49] <__chip__> ah
[14:49] <__chip__> k
[14:49] <ijohnson> __chip__: yeah probably worth trying to talk to John Agosta in CPT to raise it with them
[14:49] <ijohnson> raise it -> make sure that the customer tries our suggestionss
[14:49] <__chip__> ijohnson: will do
[14:50] <ijohnson> __chip__: ack thanks
[14:52] <mborzecki> __chip__: thanks for the PR! edited the title so that the title checks are happy
[14:53] <__chip__> ah, yeh thanks
[15:28] <mup> PR snapd#8035 opened: data/selinux: workaround incorrect fonts cache labeling on RHEL7 (2.43) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8035>
[15:28] <mborzecki> pstolowski: ^^
[15:28] <pstolowski> sure
[15:49] <zyga> mborzecki, ijohnson: ping on https://github.com/snapcore/snapd/pull/8031 please
[15:49] <mup> PR #8031: tests: update mount-ns test tables <Created by zyga> <https://github.com/snapcore/snapd/pull/8031>
[15:49] <zyga> it's just data tables!
[15:49] <ijohnson> zyga: but it's almost 2000 lines of data tables! :-)
[15:49] <zyga> yes but they are what we do today
[15:49] <zyga> we can argue if that's correct but that's just a snapshot
[15:50] <zyga> note that I don't mind if you read them in detail
[15:50] <zyga> the next PR after that will make it less painful to do changes
[15:50] <zyga> (after another painful change though)
[15:50] <ijohnson> hmm wasn't your re-numbering option supposed to prevent things like this?
[15:50] <zyga> it makes them less severe
[15:51] <zyga> but as I explain in the follow-up
[15:51] <zyga> it's not immune to insertion in the middle
[15:51] <zyga> that causes re-numbering
[15:51] <zyga> the follow-up switches to delta encoding
[15:51] <ijohnson> i.e. for xenial it was `1:1 /system-data/etc/systemd/user /etc/systemd/user rw,relatime shared:45 - ext4 /dev/sda3 rw,data=ordered` and now it's just `1:1 /system-data/etc/systemd/user /etc/systemd/user rw,relatime shared:46 - ext4 /dev/sda3 rw,data=ordered`
[15:51] <zyga> so insertions in the middle don't affect the rest as much as they did
[15:51] <ijohnson> the only difference being that 45 changed to 46
[15:51] <zyga> yeah
[15:51] <ijohnson> but I thought you sorted it and re-numbered it?
[15:51] <ijohnson> oh wait I see what you mean
[15:51] <zyga> yes but something else became :45
[15:51] <ijohnson> there's a new thing that was added
[15:52] <zyga> right
[15:52] <ijohnson> sorry a bit slow today
[15:52] <zyga> I mean, it's not perfect, it's already a bit distant from the totally volatile original
[15:52] <zyga> but this will make it better :)
[15:52] <zyga> the problem is that core tables are out of date
[15:52] <zyga> because those test were disabled
[15:53] <zyga> and we missed some updates the core snap being reflected
[15:53] <ijohnson> zyga: submitted
[15:53] <ijohnson> err approved
[15:53] <zyga> :D
[15:53] <zyga> thank you!
[15:54] <zyga> I'll open the follow up shortly
[15:54] <ijohnson> zyga: but also I do like the relative numbering idea to reduce the diff to protect against this kind of thing
[15:54] <zyga> yeah
[15:54] <zyga> it's super costly and painful to read
[15:54] <mborzecki> yeah, we'll know more once the tests are enabled on core
[15:54] <zyga> just doing classic side now
[15:54] <zyga> and I'll fix those bugs with gadget snaps
[15:54] <zyga> at least one
[15:54]  * zyga braces for the fight!
[15:54] <mup> PR snapd#8031 closed: tests: update mount-ns test tables <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8031>
[15:58]  * ijohnson recommends zyga look for the mount ns excalibur
[15:58] <mup> PR snapd#8036 opened: snapstate: refactor things to add the re-refresh task last <Created by pedronis> <https://github.com/snapcore/snapd/pull/8036>
[16:08] <zyga> ijohnson: https://github.com/snapcore/snapd/pull/8033
[16:08] <mup> PR #8033: tests: switch mount-ns test to differential data set <Created by zyga> <https://github.com/snapcore/snapd/pull/8033>
[16:08] <zyga> ijohnson: I love how github rendered some of the diffs
[16:08] <zyga> https://github.com/snapcore/snapd/pull/8033/files#diff-9593b62bc67b4cedc7e7106954025f18
[16:08] <zyga> e.g. here
[16:09] <zyga> it's clear what only the relevantparts are changed
[16:09] <zyga> and I can really read the diff
[16:09] <zyga> 16.04 -> 18.04 is just a few changes
[16:09] <zyga> that are all explainable
[16:09] <ijohnson> yes that is very nice
[16:10] <zyga> wow' it's raining heavily now
[16:10] <ijohnson> do you have an example of what it would look like if a new mount was added in the middle to see that the generated diff is very small then ?
[16:10] <zyga> https://usercontent.irccloud-cdn.com/file/ckBZMBmf/classic%2016.04%20vs%20classic%2018.04%20mount%20ns
[16:10] <zyga> just look at this
[16:10] <zyga> those are real tables for 16.04 and 18.04
[16:10] <zyga> with changes in the middle
[16:11] <ijohnson> that's great
[16:11] <ijohnson> much much better, good work!
[16:11] <ijohnson> maybe include that screenshot in the PR as a comment for other reviewers?
[16:11] <zyga> yeah
[16:11] <zyga> good idea
[16:12] <zyga> https://usercontent.irccloud-cdn.com/file/7loYb2PY/core%2016%20vs%20core%2018%20mount%20ns
[16:12] <zyga> this one is a lot different
[16:12] <zyga> but the diff is really readable now
[16:14] <ijohnson> here's a silly question - do we even need those mount numbers at all for your actual tests?
[16:14]  * ijohnson doesn't remember what the actual original test looks for
[16:14] <zyga> that's a good question
[16:14] <zyga> it's hard to answer
[16:14] <zyga> for the shared: parts I'd strongly say yes
[16:14] <zyga> for the major:minor it's useful but probably for debugging (i.e. it will tell you what the device really was)
[16:15] <zyga> for mount_id parent_id it's also less clear but perhaps for debugging
[16:15] <zyga> I think the strongest case is for the shared: master: numbers
[16:15] <zyga> those really mean stuff
[16:15] <ijohnson> right
[16:15] <zyga> as in, right vs broken
[16:15] <ijohnson> hmm well something to think about perhaps
[16:16] <zyga> screenshot added
[16:17] <zyga> oh, 14.04 !
[16:17] <zyga> forgot about that
[16:17] <zyga> I'll force-push one more change
[16:17] <zyga> ah, no
[16:17] <zyga> it's not there, just enabled too many things locally
[16:17] <zyga> uff :)
[16:20] <zyga> ijohnson: I'll do one more pass locally without the major:minor
[16:20] <zyga> and perhaps an --exclude feature
[16:20] <zyga> to remove some of the annoying cgroup changes that caused breakage before
[16:20] <zyga> but first... tea break
[16:21] <zyga> it's still cold in the office :/
[16:21] <zyga> I wonder if winter comes at all this year
[16:22] <ijohnson> zyga: shall I bring some snow to frankfurt for you to take home?
[16:22] <ijohnson> :-)
[16:22] <zyga> haha, I wonder if you actually will
[16:22] <zyga> with the climate upside down
[16:22] <zyga> march may be snowy
[16:22] <roadmr> we had days above zero in Montreal, in January... go figure
[16:23] <zyga> roadmr: yesterday the temperature in warsaw and in the canary islands was the same
[16:23] <zyga> +6
[16:23] <roadmr> haha
[16:23]  * zyga goes fetch that tea
[16:23] <roadmr> definitely a more valid comparison than "it's as cold as mars"
[16:23] <roadmr> at this rate it'll be "it's hotter than venus"
[16:25] <zyga> (robot announcing the weather) GOOD MORING REMAINING HUMANS; TODAY IS A LOVELY DAY WITH TEMPERATURES AT AROUND +370C; NIGHT WILL BE BELOW ZERO, BELOW -200C TO BE EXACT; HA HA HA; STAY WARM WARM-BLOODS!
[16:26] <roadmr> more slaves for my robot colony
[19:47] <mup> PR snapcraft#2890 opened: extensions: add opengl extension to support classic and strict <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2890>
[20:54]  * sdhd-sascha oh - oh ... i don't wan't to disturb someone ---- big sorry ;-)
[21:03] <sdhd-sascha> is it for you the same, that younge poeple want learn ? or is this only my person who is strange...
[21:03] <sdhd-sascha> wan't
[21:04] <sdhd-sascha> i consider, you can be `consuldant` ... or ... but didn't work..
[21:05] <sdhd-sascha> hmm... d... mn
[21:10] <sdhd-sascha> have had visit .. i talk about tesla - and that every informtic-problem is solved now ... and so on...
[21:11] <sdhd-sascha> ...
[21:11] <sdhd-sascha> (my wife is afraid, that i'm again a plant eater .. ;-) )
[21:26] <sdhd-sascha> zyga: hey, again, thank you ;-) the python library i mean ,  was used by `conjure-up` ... but can't remember *widget..*