| cjwatson | Could anyone look at https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377974, which is a quick dependency upgrade? And maybe also https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377881 and https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377946, which do some more Breezy porting? | 13:17 |
|---|---|---|
| ilasc | cjwatson: they look good - one small comment / question on one of them (might be seeing double there though) | 13:42 |
| cjwatson | thanks | 13:42 |
| cjwatson | ilasc: also https://portal.admin.canonical.com/C123862/ FYI (that's your livefs webhooks DB patch) | 13:43 |
| ilasc | cjwatson: thanks! was looking at the wiki to see what's process for db patches | 13:45 |
| cjwatson | I have your turnip MP open for review though probably won't finish before your EOD | 13:46 |
| cjwatson | ilasc: https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess is the master doc, but possibly confusing if you're coming to it cold. The strictly-ordered steps from this point are (1) IS will do a fastdowntime deployment of your patch (2) we merge that revision from db-stable to master (3) you can land code that depends on that patch once it's otherwise good | 13:49 |
| ilasc | :) thanks Colin, that's ok - I'm in the process of addressing comments from review of Webhooks for LiveFS - not blocked by Turnip | 13:49 |
| cjwatson | I'm not completely sure (2) is documented clearly | 13:49 |
| ilasc | cjwatson: oh, ok, your summary is far better then what I was reading :) | 13:50 |
| cjwatson | But you might have noticed stuff like https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377918 lately | 13:50 |
| cjwatson | That was literally just "push a particular commit from db-stable to a branch in order to be able to raise an MP for it" | 13:51 |
| cjwatson | (used to be a completely vile invocation of bzr pqm-submit that I always forgot ...) | 13:51 |
| cjwatson | Anyway, at this point we wait for IS | 13:52 |
| ilasc | :) ok, that example helps, thanks! | 13:52 |
| cjwatson | Is anyone actually likely to be interested in reviewing the details of https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377977 or https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378001 ? I'm somewhat inclined to just self-approve since they're almost entirely tests | 16:43 |
| cjwatson | And giant | 16:43 |
| cjwatson | (Beautiful Soup 4 porting work) | 16:43 |
| SpecialK|Canon | I am largely through one of the bs4 ones | 16:51 |
| SpecialK|Canon | I figured I'm deserving of some penance | 16:52 |
| SpecialK|Canon | (by all means self-approve) | 16:52 |
| SpecialK|Canon | I was just feeling curious | 16:52 |
| SpecialK|Canon | (378001) | 16:54 |
| cjwatson | to some extent this is mainly digging up stuff I did ages ago and never quite finished (and thus was still lying around in bzr branches) | 16:56 |
| cjwatson | but beautifulsoup is currently the first thing that fails when one tries to bootstrap LP with py3, so it reminded me of it | 16:56 |
| SpecialK|Canon | :D | 16:58 |
| * cjwatson kicks off a full test run on the next branch in the series, which finishes off a few loose ends and actually removes Beautiful Soup 3 | 17:00 | |
| SpecialK|Canon | niiiice | 18:11 |
| cjwatson | SpecialK|Canon: Still around? Would like a quick review of https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378007 to unstick buildbot | 18:20 |
| cjwatson | (local package fork vs. slight in-tree customisation ... on balance I think I still prefer the latter) | 18:21 |
| SpecialK|Canon | cjwatson: done - cheers | 19:56 |
| SpecialK|Canon | I'd definitely pick the latter as well | 19:57 |
| cjwatson | thanks | 20:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!