[13:17] Could anyone look at https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377974, which is a quick dependency upgrade? And maybe also https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377881 and https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377946, which do some more Breezy porting? [13:42] cjwatson: they look good - one small comment / question on one of them (might be seeing double there though) [13:42] thanks [13:43] ilasc: also https://portal.admin.canonical.com/C123862/ FYI (that's your livefs webhooks DB patch) [13:45] cjwatson: thanks! was looking at the wiki to see what's process for db patches [13:46] I have your turnip MP open for review though probably won't finish before your EOD [13:49] ilasc: https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess is the master doc, but possibly confusing if you're coming to it cold. The strictly-ordered steps from this point are (1) IS will do a fastdowntime deployment of your patch (2) we merge that revision from db-stable to master (3) you can land code that depends on that patch once it's otherwise good [13:49] :) thanks Colin, that's ok - I'm in the process of addressing comments from review of Webhooks for LiveFS - not blocked by Turnip [13:49] I'm not completely sure (2) is documented clearly [13:50] cjwatson: oh, ok, your summary is far better then what I was reading :) [13:50] But you might have noticed stuff like https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377918 lately [13:51] That was literally just "push a particular commit from db-stable to a branch in order to be able to raise an MP for it" [13:51] (used to be a completely vile invocation of bzr pqm-submit that I always forgot ...) [13:52] Anyway, at this point we wait for IS [13:52] :) ok, that example helps, thanks! [16:43] Is anyone actually likely to be interested in reviewing the details of https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/377977 or https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378001 ? I'm somewhat inclined to just self-approve since they're almost entirely tests [16:43] And giant [16:43] (Beautiful Soup 4 porting work) [16:51] I am largely through one of the bs4 ones [16:52] I figured I'm deserving of some penance [16:52] (by all means self-approve) [16:52] I was just feeling curious [16:54] (378001) [16:56] to some extent this is mainly digging up stuff I did ages ago and never quite finished (and thus was still lying around in bzr branches) [16:56] but beautifulsoup is currently the first thing that fails when one tries to bootstrap LP with py3, so it reminded me of it [16:58] :D [17:00] * cjwatson kicks off a full test run on the next branch in the series, which finishes off a few loose ends and actually removes Beautiful Soup 3 [18:11] niiiice [18:20] SpecialK|Canon: Still around? Would like a quick review of https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378007 to unstick buildbot [18:21] (local package fork vs. slight in-tree customisation ... on balance I think I still prefer the latter) [19:56] cjwatson: done - cheers [19:57] I'd definitely pick the latter as well [20:06] thanks