| nammn_de | manadart: I was trying to use your newly added deltaops for controllersettings (juju-ha-space ..) and realized those are in their own collection. With this, I changed the `deltaops` function. Does that make sense? https://github.com/nammn/juju/blob/48c527fba46e0c5057e1feda909ba635c957449c/state/settings.go#L536 Or did I overlook something and the | 09:55 |
|---|---|---|
| nammn_de | `settings` collection is still the right collection for this? | 09:55 |
| manadart | nammn_de: Sorry, I meant to reply to your question. You want something more like this: https://pastebin.canonical.com/p/H5mmbX6WKM/ | 10:06 |
| nammn_de | manadart: ahhh makes sense. Thanksss | 10:06 |
| stickupkid | manadart, looking at the integration test - I thought we fixed the issue with missing relation scope? | 10:35 |
| stickupkid | manadart, https://paste.ubuntu.com/p/BbZfwgqtdT/ | 10:35 |
| stickupkid | also "yeah boi" - I'm laughing so hard - haha | 10:36 |
| === skay is now known as Guest49404 | ||
| manadart | stickupkid: Sorry, was just OTP. Is that with develop? | 11:04 |
| stickupkid | manadart, well your branch | 11:04 |
| manadart | stickupkid: You updated the dep and installed it? | 11:08 |
| stickupkid | make install'ed it | 11:08 |
| manadart | So was that migrating the offering model, or the consuming one? | 11:11 |
| stickupkid | offering | 11:14 |
| stickupkid | can ho once you're free manadart | 11:17 |
| manadart | stickupkid: Daily | 11:34 |
| nammn_de | manadart: To change the spaces for constraints I see the following options: get constraints for each type (applications, machine, units..) and change these OR just get all constraints as collection and edit these. What do you think makes the most sense? Im thinking about the latter because of implementation ease | 11:35 |
| nammn_de | manadart: hmm but if I think about it, this could potentially be a lot of docs constraints to at least check and then change.. | 11:43 |
| nammn_de | ahhh no it might make the most sense to just query for the space and then to change that subset =D | 11:45 |
| manadart | nammn_de: Yes. | 11:46 |
| achilleasa | manadart: populating modelUUID/DocID did the trick! | 11:53 |
| manadart | achilleasa: Nice. | 11:53 |
| nammn_de | manadart: another thing. I realized because I query the constraints collection itself and need to write them back again I need the "_id". As I don't know whether the doc is a machine, application ect. | 12:12 |
| nammn_de | I see the following options: | 12:12 |
| nammn_de | 1: add _id to constraintsDoc <-- I would prefer this | 12:12 |
| nammn_de | 2: use own constraintsDoc struct . What do you think? Or another suggestion in mind? | 12:12 |
| manadart | nammn_de: Just add `DocID string `bson:"_id"` like we do elsewhere. | 12:21 |
| nammn_de | manadart: great, will do | 12:21 |
| achilleasa | anyone up for a CR for https://github.com/juju/juju/pull/11156 ? | 13:02 |
| manadart | achilleasa: I can look. | 13:06 |
| stickupkid | manadart, if you have a relation to another CMR model, if you try and destroy the controller, it fails, is this something you ran into? | 15:10 |
| manadart | stickupkid: Yes, this is known and will not be changed (there is an LP bug). That is why the migration integration tests force-destroy the offer before teardown. | 15:14 |
| stickupkid | manadart, this is annoying as we can't tear down a controller if an integration test fails | 15:14 |
| stickupkid | manadart, i.e. the integration test doesn't know about the relation | 15:15 |
| manadart | stickupkid: Ah, yes. | 15:15 |
| stickupkid | manadart, this is why the integration jujus are hanging around, even if you told them to be destroyed | 15:15 |
| manadart | stickupkid: I wonder if the bash-based suites would allow us to register extra tear-down... | 15:15 |
| stickupkid | manadart, i'm unsure | 15:16 |
| stickupkid | manadart, defer but in shell | 15:16 |
| stickupkid | haha | 15:16 |
| manadart | stickupkid: Exactly :) | 15:17 |
| stickupkid | all i want is closures | 15:25 |
| stickupkid | manadart, i wonder if we can ask for all relations? | 15:25 |
| stickupkid | manadart, and just kill them all off | 15:26 |
| manadart | stickupkid: Could work I guess. | 15:27 |
| stickupkid | manadart, got it to work with the check, but need to work on the destroying issue | 15:38 |
| stickupkid | i'll update your pr | 15:38 |
| stickupkid | https://github.com/juju/juju/pull/11155 | 15:52 |
| stickupkid | manadart, got it working, not the defer thing, but cleaning up the offers | 17:03 |
| stickupkid | get in there | 17:03 |
| stickupkid | CR https://github.com/juju/juju/pull/11157 | 17:11 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!