[01:25] <wallyworld> kelvinliu: you can adapt this https://pastebin.ubuntu.com/p/yyxJnT54nj/
[01:26] <kelvinliu> wallyworld: ok, thanks
[01:26] <wallyworld> loop until call count is reached
[01:26] <wallyworld> you can call c.Fail() if needed etc
[01:47] <kelvinliu> yep
[02:19] <babbageclunk> ugh, has anyone had a situation where goimports keeps adding an import for logger even though there's a logger defined in a different file in the package?
[02:20] <wallyworld> sometimes, pita
[02:20] <babbageclunk> it's bloody weird!
[02:22] <hpidcock> babbageclunk: why don't you just forget goimports exists? you were in ignorant bliss for so long
[02:23] <babbageclunk> I would but it's great except when it doesn't work right.
[02:24] <hpidcock> babbageclunk: are you using gopls yet?
[02:24] <babbageclunk> hpidcock: stockholm syndrome basically
[02:24] <babbageclunk> hpidcock: nope not yet
[02:25] <babbageclunk> hpidcock: is it good? Or is it... bad?
[02:25] <hpidcock> babbageclunk: a bit of both
[02:25] <babbageclunk> like everything then
[02:25] <hpidcock> babbageclunk: mostly good
[02:31] <babbageclunk> hmm, might try it sometime
[06:01] <wallyworld> kelvinliu: is the vsphere PR good to land?
[06:18] <kelvinliu> wallyworld: nah, Im refactoring one of the failed suite to use gomock
[06:21] <wallyworld> no worries
[06:21] <wallyworld> kelvinliu: did they fix your phone?
[06:21] <kelvinliu> yes, they gave me a new phone and it's free. : )
[06:22] <wallyworld> wow, and so they should have
[06:22] <wallyworld> they broke it
[06:23] <kelvinliu> yeah, i think they know the guy didn't fix the screen last time.
[06:23] <kelvinliu> correctly
[06:24] <wallyworld> i bet he's in trouble
[06:24] <kelvinliu> im fixing mfa
[06:27] <kelvinliu> hope he won't be in trouble too much
[06:27] <wallyworld> who knows with Apple
[09:42] <nammn_de> manadart achilleasa stickupkid: let's say I add an DocID string `bson: _id`  field.  How can I say that I only want to set the constraints for everything of that struct except that DocID? Such that I don't come into the immutable `_id` error? Or do I have to set that for each field separately ([]bson.DocElem..) ?
[09:43] <stickupkid> nammn_de, for selection or inserting?
[09:44] <nammn_de> stickupkid: oh sry, forgott the e.g. link https://github.com/nammn/juju/blob/bfa6bd8e2d2b664381c1e833a9fd2f5b7bf94953/state/constraints.go#L92
[09:44] <stickupkid> nammn_de, if it's inserting, then make a new type without a doc id ?
[09:44] <nammn_de> stickupkid: okay, that was my other thought.
[09:44] <nammn_de> stickupkid: thought maybe there is something easier :/
[09:44] <stickupkid> it's juju, nothing is easy :wink:
[09:46] <nammn_de> stickupkid: haha okay, thanks!
[09:48] <stickupkid> manadart, updated to include forcing, I think it's a good shout
[09:52] <manadart> stickupkid: Yep.
[10:09] <stickupkid> manadart, https://github.com/juju/juju/pull/11155 <- I got this working - you think we should move of from draft?
[10:10] <manadart> stickupkid: Yep.
[11:21] <nammn_de> manadart: rename-space now is review ready.  QA steps works well for me https://github.com/juju/juju/pull/11143
[11:22] <manadart> nammn_de: OK.
[11:27] <achilleasa> Can I get a CR on https://github.com/juju/juju/pull/11158?
[11:28] <stickupkid> achilleasa, looking now
[11:40] <achilleasa> stickupkid: Do I need to add empty stubs for older API versions?
[11:40] <stickupkid> offically yes
[11:40] <stickupkid> but actually it's ok, but yeah you should
[11:41] <achilleasa> stickupkid: ok, I will add them together with the missing comments
[11:47] <achilleasa> stickupkid: pushed a commit. Is that ok or did I forget something?
[11:52] <stickupkid> achilleasa, looks good
[12:08] <manadart> Upgrade step for the systemd unit file relocation: https://github.com/juju/juju/pull/11159.
[16:54] <nammn_de> manadart: I still need to fix the unit tests and do some cleaning. Just wanted to know beforehand whether you meant the modeloperation like this: https://github.com/juju/juju/pull/11143
[16:58] <stickupkid> achilleasa, congrats on the book :)
[16:58] <achilleasa> stickupkid: thanks :-)
[17:05] <nammn_de> achilleasa: yeah congrats!
[17:11] <rick_h> manadart:  doh sorry, never hit submit on assigning you that bug. just hit submit now