/srv/irclogs.ubuntu.com/2020/01/30/#snappy.txt

mupPR snapd#8068 closed: tests: tweak and enable tests on ubuntu 20.04 <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8068>06:07
mvohey mborzecki06:10
mborzeckimvo: hey06:10
zygaHey mvo07:46
mborzeckimvo: pushed the change with link structure to #797207:46
mborzeckizyga: hey07:46
mupPR #7972: overlord/snapstate, wrappers: undo of snapd on core <Remodel 🚋> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7972>07:46
zygaI was woeking till 2am07:46
zygaSomewhat sleepy still07:46
zygaKids woke me up07:46
zygaSick and staying at home07:46
mborzeckizyga: i know you were playing c&c red alert :P07:46
zygaI wish :-)07:46
zygaI went for a walk at 2am07:47
zygaWith my sleeping dog in my hand :]07:47
zygaHe dislikes water so much I had to carry him for a while to convince him to walk07:48
zygaI wrote first spread tests for apparmor prompting07:48
zygaI’ll start later today07:51
zygaNeed to wake up first07:51
pedronismborzecki: mvo: hi, is one of you going to work on #8064 this morning?07:57
mupPR #8064: boot: add Device iface to coreKernel <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8064>07:57
mborzeckipedronis:  i was thinking about #8001 but i can look into 8064 first08:02
mupPR #8001: boot: enable UC20 kernel extraction and bootState20 handling <Needs Samuele review> <UC20> <â›” Blocked> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8001>08:02
pedronismborzecki: I made comment there and I didn't make on 800108:03
pedronismvo extracted it08:03
mupPR # closed: core-build#11, core-build#22, core-build#26, core-build#37, core-build#51, core-build#5808:16
mupPR # opened: core-build#11, core-build#22, core-build#26, core-build#37, core-build#51, core-build#5808:17
mvomborzecki: thank you, I check 797208:23
mupPR snapd#8070 opened: dirs: fixlet for XdgRuntimeDirGlob <Simple 😃> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8070>08:33
* Chipaca returns from the doctor's and has breakfast09:04
mupPR snapd#8071 opened: o/auth,daemon: do not remove unknown user <Created by pedronis> <https://github.com/snapcore/snapd/pull/8071>09:05
pedronisChipaca: ^09:05
Chipacapedronis: you ok with the toctou race there?09:06
pedronisChipaca: for now yes09:06
pedronisthe current behavior is kind of worse09:07
Chipacapedronis: the alternative would be to hold the lock, check, remove the system user without --remove, remove the system user, remove the home and spool09:07
Chipacayour question last night left me thinking and that's what i thought we'd do09:07
Chipacaer09:07
Chipacainsert 'release the lock' after 'remove system user'09:08
pedronisChipaca: well, if you think is doable simply enough you can do it on top of my PR09:08
pedronisotherwise leave possible todo09:08
Chipacagah i made a mess09:08
Chipacapedronis: the alternative would be to hold the lock, check, remove the system user without --remove, remove the auth user, release the lock, remove the home and spool09:08
Chipaca^ there better09:08
Chipacathe split of the current remove-user-and-home being so as not to hold the lock for ages09:09
pedronisyes, I understand that09:09
pedronisChipaca: I also think that snap remove-user email should do something, given create-user email09:11
pedronisbut that we can deal with it09:11
Chipacapedronis: given we're looking it up anyway, sure :-)09:11
pedronis(it's a bit of a mess of its own)09:11
pedronisbecause there might many users with the email and some might not have a username09:12
zygao/09:24
zygahow are you guys09:24
Chipacazyga: we're latest/edgy09:28
pedroniscould be better09:29
zygatired?09:29
zygaI'm energized, despite not sleeping much09:29
mborzeckimvo: pedronis: i've updated #806409:39
mupPR #8064: boot: add Device iface to coreKernel <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8064>09:39
mvomborzecki: thank you!09:41
Chipacadid the change to warn about invalid seeds get done?09:44
Chipacakenvandine: where should bugs for desktop-launcher go, on launchpad?09:51
pedronismborzecki: thanks, small remark09:52
Chipacamvo: maybe you know ^^09:53
mvoChipaca: do you know the package name? I guess not :) or a binary name in /usr or something?09:54
mborzeckipedronis: ack09:54
Chipacamvo: i mean the snapcraft desktop laucnher helper thing09:54
Chipacadesktop-helper? worker-dancer? warrior-priest?09:55
mvoChipaca: haha - sorry, now I get what you mean09:55
mvoChipaca: my guess is snapcraft itself but I'm not super confident, kenvandine will know but it's very early for him I guess09:56
Chipacayou mean kenvandine isn't a robot?09:57
Chipacamvo: I think I'm leaving #1861177 as New so either you or Ian take a look at it when it's your triage day09:57
mupBug #1861177: seccomp_rule_add is very slow <patch> <server-next> <snapd:New> <libseccomp (Ubuntu):Triaged> <https://launchpad.net/bugs/1861177>09:57
mvoChipaca: nice! let me check that09:59
mvoChipaca: that looks pretty neat09:59
Chipacamvo: i'm assuming the <patch> bit :-)09:59
Chipacanot the actual 'iz slow' bit09:59
mvoChipaca: yeah, the patch bit10:03
mvomborzecki: feedback in 7972, looks very nice now10:10
Chipacapedronis: I hope https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1860769/comments/3 isn't too much of a lie :-)10:11
mupBug #1860769: should record changes after snap transactions <etckeeper (Ubuntu):Confirmed> <snapd (Ubuntu):Triaged> <https://launchpad.net/bugs/1860769>10:11
ograChipaca, https://github.com/ubuntu/snapcraft-desktop-helpers/issues10:14
Chipacaogra: what part of 'on launchpad' is that10:14
Chipacaalso why is that still pointing people to rocketchat10:16
Chipacais rocketchat/snapcraft still a thing?10:16
ograo idea, but that tree is the source people typically include in their snapcraft.yaml to get the launchers10:18
ogras/o/no/10:18
mborzeckimvo: can you take a look at #8064 ?10:29
mupPR #8064: boot: add bootloader options to coreKernel <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8064>10:29
pedronismvo: #8064 needs some kind of 2nd review10:29
mborzeckiif it's ok, i'll land it an update 8001 accordingly10:29
mvopedronis, mborzecki sure, on it10:31
pedronis#8071 also needs a 2nd review10:33
mupPR #8071: o/auth,daemon: do not remove unknown user <Created by pedronis> <https://github.com/snapcore/snapd/pull/8071>10:33
mvopedronis: was looking at this one as we speak :)10:34
pedronismborzecki: 8064 should be ok to land once gree and then we can pick up 800110:36
pedronisgreen10:36
mupPR snapd#8071 closed: o/auth,daemon: do not remove unknown user <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8071>10:36
zygapedronis: (post merge) https://github.com/snapcore/snapd/pull/8071#pullrequestreview-35072328510:36
mupPR #8071: o/auth,daemon: do not remove unknown user <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8071>10:36
mborzeckipedronis: ok10:36
pedronisChipaca: #8071 is in, you might want to update your PRs also consider zyga suggestion but I thought of it myself and not sure whether it makes the message too clunky10:37
mupPR #8071: o/auth,daemon: do not remove unknown user <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8071>10:37
Chipacapedronis: which suggestion would that be?10:38
pedronisChipaca: https://github.com/snapcore/snapd/pull/8071#pullrequestreview-35072328510:38
Chipacagrah, it now conflicts10:38
Chipacanot fair10:38
pedronisChipaca: not suprising though, no10:39
* Chipaca takes a break11:00
mupPR snapd#8064 closed: boot: add bootloader options to coreKernel <UC20> <Created by mvo5> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8064>11:14
juliankHey folks, I ended up with 6 loop devices with deleted snap squashfs: https://paste.ubuntu.com/p/ry5ZKGqxCS/11:21
zygahey11:21
juliankThis machine has an uptime of 9 days11:21
juliankIt's running focal11:21
zygathis is a known issue, it feels like a systemd / libmount bug11:21
zygawe never manage loop devices ourselves11:21
zygait is reported on launchpad11:22
juliankhmm11:22
juliankThe problem is that, as mentioned on #ubuntu-devel, these now show up in nautilus, confusing users (in this case, me)11:23
juliankNot sure how to solve that11:23
juliankProbably udisks should look if backing file is in /var/lib/snapd/snaps, and then set HintIgnore to true11:24
zygathere's logic like that11:31
zygait's a different problem11:31
zygait shows up as deleted, unmounted loop device you can mount (??) by clicking on it11:31
zygabut it isn't possible because it is deleted11:31
zygaI really don't know what to do about it, apart from chasing kernel/libmount/systemd internals11:32
zygaI think we used to have a reproducer script11:32
zygabut perhaps I'm confusing this with another issue11:32
juliankzyga: Oh you can absolutely mount them, the loop device still has an open file descriptor, so the inode is never actually freed11:40
zygathe loop devices, yes11:41
zygathe backing file they used is not linked to the filesystem anymore (but still takes space)11:41
juliankyes11:41
juliankCouldn't snapd like look once each hour / after it updates a snap for loop devices that point to deleted snap files and delete them?11:43
juliankHah no11:44
juliankIf I losetup -d the loop device it remains active11:44
ograwell, effectively systemd should do this11:45
juliankogra: But I can't even do it manually, so something is off there11:45
juliankAh11:45
juliankSo closing my telegram window removed the loop device11:46
juliankWhich I guess means the loop device is used in a different mount namespace?11:46
ograhmm, doesnt for me .... but then ... unity7 here ...11:47
juliankOK, I also ran losetup -d multiple times before, it might have marked it for dettachment11:47
ograyeah, that might be11:47
juliankConfirmed11:51
juliankThe lxd snap still has deleted loop devices mounted11:52
juliank/proc/1425517/mounts:/dev/loop53 /bin/kmod squashfs ro,nodev,relatime 0 011:52
juliankand various other processes11:53
juliankI don't understand why the mount point is listed as /bin/kmod, though11:55
juliankRunning unmount /bin/kmod inside the namespace a few times made all except one lxd snap loop device go away11:57
ogralxd modprobing something inside the container ?11:57
ograprobably squashfuse related ?11:58
zygajuliank: if you come up with a reliable way to reproduce11:59
zygawe can start chasing this more aggresively11:59
zygaaggressively12:00
juliankhmm I'm not sure I have time to come up with a reproducer12:08
juliankGiven the number of lxd in there, I'd sort of expect that just switching around lxd versions should trigger this, but not tried it12:09
mupPR snapd#8070 closed: dirs: fixlet for XdgRuntimeDirGlob <Simple 😃> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8070>12:17
pedronismvo: is #7999 ready for re-review?12:57
mupPR #7999: devicestate: allow encryption regardless of grade <UC20> <â›” Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/7999>12:57
mvopedronis: yes, I think so13:11
pedronismvo: it's failing though? it's a new initramfs to land?13:13
pedronis*it needs13:13
=== ricab is now known as ricab|lunch
mvopedronis: yeah, I pinged dimitri earlier13:25
mvopedronis: but yeah, this will only work once the initrd can open it13:26
zygamborzecki: can you look at https://github.com/snapcore/snapd/pull/8067#discussion_r372947893 please13:32
zygais that sensible?13:32
zygaif so I'll make that happen and we can merge this13:32
zygamaybe for .3?13:32
mupPR #8067: cmd/snap-confine,tests: support x.y.z nvidia version <Created by zyga> <https://github.com/snapcore/snapd/pull/8067>13:32
zygamvo: we will have .3 - correct?13:32
mvozyga: well, maybe13:33
mvozyga: there is a (small) chance that we can get away witout13:33
mvowithout13:33
zygabrb13:44
zygasee you at the standup13:44
ijohnsonmorning folks13:55
mborzeckiijohnson: hey13:58
ijohnsonhey mborzecki13:58
mborzeckiijohnson: 8064 landed, i've pushed some updates to #8001 and doing a little cleanup now, i'll push it after the standup hopefully13:58
mupPR #8001: boot: enable UC20 kernel extraction and bootState20 handling <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8001>13:58
ijohnsonmborzecki: ack thanks for doing that13:59
mborzeckiijohnson: or maybe i should push it to my fork, in case it's too dramatic :)13:59
ijohnsonmborzecki: how dramatic of a change is it ?13:59
mborzeckiijohnson: splitting the boot state update 20 commit() into separate successful/candidate kernel code paths14:00
ijohnsonmborzecki: you meant a separate commit for setNext and markSuccessful ?14:01
ijohnsonerr commit() method I mean14:01
mborzeckiijohnson: yeah, actually doing that via 2 separate types, each implementing bootStateUpdate14:01
ijohnsonmborzecki: smells a lot like my rewrite I have locally for the next step with base snaps14:01
mborzeckihahah ;)14:02
ijohnsonmborzecki: but sure feel free to push it, I can always re-work mine on top of yours14:02
sdhd-saschaHi, should i ask here, or on #maas, about:14:26
sdhd-sascha# snap install maas14:26
sdhd-sascha2020-01-30T14:25:28Z INFO Waiting for restart...14:26
sdhd-saschaerror: cannot perform the following tasks:14:26
sdhd-sascha- Run configure hook of "maas" snap if present (run hook "configure": chown: changing ownership of '/var/snap/maas/common/log/proxy': Operation not permitted)14:26
=== ricab|lunch is now known as ricab
ijohnsonmborzecki: let me know when you've pushed that up14:38
mborzeckiijohnson: sure14:38
zygasdhd-sascha: chown is usually not allowed, the exception is chown to a special snapd daemon user14:38
zygasdhd-sascha: I'm not sure if that's what maas is doing14:39
sdhd-saschazyga: i just installed the `apt` version. I tried the snap inside of lxd ...14:41
sdhd-saschamaybe, i look later deeper into the script.14:42
zygasdhd-sascha: I don't know how that's related14:42
pedronismvo: Chipaca: I'm having a break, ping me later when you want to chat about download14:43
zygaI'll grab lunch/dinner now14:43
zygaand finish my cold soup :)14:43
mvopedronis: are you ok with picking 8067 for 2.43? if we have to do a release it seems like a nice and simple fix14:52
ijohnsonpedronis: mvo: mborzecki: sorry I forgot to inquire during SU, but shall I go with mvo's suggestion and extract the initramfs-mounts bits from #8001 into a separate pre-req PR, or are we looking okay to merge with that in there?15:02
mupPR #8001: boot: enable UC20 kernel extraction and bootState20 handling <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8001>15:02
zygammm15:04
zygayummy food today :)15:04
zygapolish salad and veggie soup :)15:04
zygamvo: you should try the polish salad one day15:04
zygamborzecki: ^ do you know how it's called in English?15:05
zygarandom falures15:11
zygajust love'm15:11
Eighth_Doctormmm failure :D15:11
zygajust slower, travis stopped15:12
zygaeh15:12
=== heather is now known as hellsworth
mborzeckiijohnson: meh, i don't think i'll push it anytime today, got more complicated that i hoped15:30
pedronisijohnson: well, I reviewed that code and what it needs is really to be some kind of helper, I don't think splitting helps at this point15:31
pedronisbut maybe other reviewers have other preferences15:31
mborzeckizyga: polish salad?15:36
zygamborzecki: yeah... geez how to explain that15:36
mborzeckizyga: photo?15:36
zygahttps://www.google.com/search?q=sa%C5%82atka+jarzynowa15:36
zygasomething like this?15:36
mborzeckizyga: ah, well, no clue whether there's an generally accepted english name for it, veggie salad? boiled veggie sald?15:40
zygabut it's nothing like I've seen in other countries15:40
zygaanywy15:40
zygawe need a sprint in poland15:40
zygalodz would be great15:40
zyga:)15:41
Chipacamvo: pedronis: shared a doc with you about download. GOing to step out for ~40 minutes, let's talk when i get back?15:47
pedronisChipaca: ok15:48
mupPR snapcraft#2894 closed: Fix issue with multipass mount on win32 <Created by NickZ> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2894>15:48
mupPR snapcraft#2895 closed: lifecycle: raise detailed error if mksquashfs fails <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2895>15:48
mupPR snapcraft#2897 closed: meta: include environment in hook wrappers <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2897>15:54
mupPR snapcraft#2898 closed: meta: remove dead code from snap packaging <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2898>16:00
ijohnsonpedronis: ok I asked mvo about splitting it and I think it's best to leave it in for now, and I can refactor the bootloader kernel bits in initramfs-mounts into a helper later16:07
ijohnsonmborzecki: sure, I will go through the rest of the comments in 8001 and address them then, perhaps you can cleanup anything else you need tomorrow AM16:09
=== heather is now known as hellsworth
sdhd-saschahow can i debug or step this process:16:40
sdhd-sascha```16:40
sdhd-sascha$ sudo snap refresh lxd16:40
sdhd-saschaerror: snap "lxd" has "auto-refresh" change in progress16:40
sdhd-sascha```16:40
sdhd-saschastop16:40
pedronisChipaca: back?16:45
Chipacapedronis: back16:49
Chipacasdhd-sascha: snap watch --last auto-refresh16:49
sdhd-saschaChipaca: thank you. It's seems to hang16:51
Chipacasdhd-sascha: snap tasks --last auto-refresh would be the next thing to look at16:51
pedronisChipaca: should we have the chat?16:55
sdhd-saschaIs it normal, that three times `snap-confine` runs, like this:16:55
sdhd-sascha```16:55
sdhd-sascha$ ps -Af | grep lxd16:55
sdhd-sascharoot        3504       1  0 Jan29 ?        00:00:49 lxcfs /var/snap/lxd/common/var/lib/lxcfs -p /var/snap/lxd/common/lxcfs.pid16:55
sdhd-sascharoot      264698    2355  0 05:10 ?        00:00:02 systemctl start snap.lxd.activate.service16:55
sdhd-sascharoot      264699       1  0 05:10 ?        00:00:00 /bin/sh /snap/lxd/13073/commands/daemon.activate16:55
sdhd-sascharoot      264758  264699  0 05:10 ?        00:00:00 lxd activateifneeded16:55
sdhd-sascharoot     2561183       1  0 17:53 ?        00:00:00 /snap/core/8592/usr/lib/snapd/snap-confine snap.lxd.daemon /usr/lib/snapd/snap-exec lxd.daemon16:55
sdhd-sascharoot     2561205 2561183  0 17:53 ?        00:00:00 /snap/core/8592/usr/lib/snapd/snap-confine snap.lxd.daemon /usr/lib/snapd/snap-exec lxd.daemon16:55
sdhd-sascharoot     2561206 2561183 98 17:53 ?        00:00:21 /snap/core/8592/usr/lib/snapd/snap-confine snap.lxd.daemon /usr/lib/snapd/snap-exec lxd.daemon16:55
sdhd-sascharoot     2561767 2554559  0 17:53 pts/7    00:00:00 sudo systemctl restart snap.lxd.daemon.service16:55
sdhd-sascharoot     2561768 2561767  0 17:53 pts/7    00:00:00 systemctl restart snap.lxd.daemon.service16:55
Chipacapedronis: I'll ping mvo and get a cuppa and yes16:56
pedronisChipaca: I'm in the standup16:56
mvoChipaca: here16:56
* sdhd-sascha I killed all the process. Now it seems to work16:57
* Chipaca resumes all the downloads17:40
mupPR snapd#8067 closed: cmd/snap-confine,tests: support x.y.z nvidia version <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8067>17:45
mupPR snapcraft#2900 opened: Travis pr snapstore <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2900>18:27
pedronisChipaca: I added to your doc18:51
Chipacapedronis: thanks18:52
Chipacapedronis: I don't think I can wrangle that in tomorrow tho18:52
Chipacapedronis: that == the hmac option18:52
pedronisChipaca: that's fine, it's not hard to add once we have the basics18:52
pedronisof the rest18:52
pedronisHEAD support and resume params18:52
Chipacathat one i probably can get up tomorrow :)18:52
pedronisijohnson: as far as I can tell this are the not yet applied/answered things in #8001: https://github.com/snapcore/snapd/pull/8001#discussion_r368975082 , https://github.com/snapcore/snapd/pull/8001#discussion_r372449659 , https://github.com/snapcore/snapd/pull/8001#discussion_r37245132618:57
mupPR #8001: boot: enable UC20 kernel extraction and bootState20 handling <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8001>18:57
ijohnsonpedronis: this is what I have that I'm doing now https://pastebin.ubuntu.com/p/YsN6rDWqq4/18:58
pedronissounds right18:59
ijohnsonso I think your 3 things are contained in that18:59
ijohnsongood that we found the same things just about19:01
mupPR snapcraft#2899 closed: ci: publish the CI built snap to the Snap Store <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2899>21:01

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!