=== mup_ is now known as mup [11:56] Any objections to me self-approving https://code.launchpad.net/~cjwatson/lazr.restful/py3-print/+merge/378511 ? I don't think it makes sense to have somebody else spend their time reading a bulk print syntax conversion [11:58] cjwatson: no objections from my side [12:16] landed, thanks [12:17] https://code.launchpad.net/~cjwatson/lazr.restful/wsgiref-py2/+merge/378432 wants an actual review, I think, but is also very short [12:23] And https://code.launchpad.net/~cjwatson/lazr.restful/py3-raise/+merge/378513 [12:47] I'd also like reviews of https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378430 and https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378459, please - more various dependency mangling for py3 [13:19] https://code.launchpad.net/~cjwatson/lazr.restful/six-urllib/+merge/378515 [13:26] And https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378518 to upgrade pip [14:20] cjwatson: GIT_PROXY_COMMAND appears to not be doing anything [14:21] I've edited the script to create a file in /tmp when it's run [14:21] but no file appears [14:21] "the script" = snap-git-proxy [14:23] tomwardill: Which git invocation is failing? [14:23] clone [14:23] tomwardill: Outside the docker container? [14:23] yep [14:23] https://pastebin.canonical.com/p/vWjcSTgWR9/ [14:23] tomwardill: Have you tried stracing git? [14:24] not yet, my strace parsing is not good. [14:24] will give it a try though [14:24] add strace to deps and wrap strace -f -s1024 -tt around the git call [14:24] then you should get something useful in the build log [14:25] happy to have a look / walk you through it if you can get a trace [14:25] righto, trying [14:25] but you could start by searching the trace for snap-git-proxy and seeing if it's e.g. trying to exec it but failing [14:30] Can I have a review of https://code.launchpad.net/~cjwatson/launchpadlib/py38-access-token/+merge/378523 to fix a crash on focal please? [14:30] sometimes, I dislike pythons string syntax if you forget the , in a list [14:31] looking [14:32] cjwatson: +1 [14:35] Thanks [14:41] cjwatson: snap-git-proxy doesn't appear in the strace: https://pastebin.canonical.com/p/Dv4vNfh5b2/ [14:41] (I ctrl-c'd when it looked like it had entered a polling/timeout loop) [14:51] tomwardill: Could you add -v to the strace arguments so that we get unabbreviated versions of the environment variables in subprocesses? [14:51] tomwardill: GIT_PROXY_COMMAND is actually only for git:// [14:52] aha! [14:52] tomwardill: For https://, git should honour https_proxy [14:52] aha! aha! [14:52] right. [14:52] that might explain it [14:52] I'll get a trace with -v and then try and work out why https_proxy isn't behaving [15:04] cjwatson: okay, it looks like what ever is meant to be running on the buildd machine on 8222 isn't actually running [15:05] looks like that's started in startProxy in SnapBuildProxyMixin [15:06] oorrrr... there' [15:06] there's a firewall problem [15:06] Did you remember to call that? [15:07] The local proxy on 8222 should write access logs to the build log [15:07] lpbuildd/oci.py: args.extend(self.startProxy()) [15:07] Hm looks OK [15:07] yeah, i mostly suspect firewall [15:07] just constructing a test environment to find out [15:08] OK, if you don't get anywhere that way, I'd consider stracing (only) the top-level launchpad-buildd process as the build is running and looking for CONNECT requests [15:24] aha! progress [15:25] `ufw allow in on lpbuilddbr0 to any port 8222` did the trick [15:25] and now I'm failing in docker, which is more what I expected [15:25] Ah good [16:07] https://docs.docker.com/config/daemon/systemd/ well, that proxy section is a bit ergh [16:11] specifically...? [16:17] Easier if you put stuff in place before installing docker, I expect (since then you don't need to restart anything) [16:39] one step further down the line... [16:56] 2020-02-04 16:56:20+0000 [-] Returning build status: OK [16:56] IT LIVES! [16:56] w00t [16:57] okay, wasn't actually all that bad a change, just took a while to get there... [17:48] tomwardill: this Issue just went past on my timeline and I thought of you https://github.com/docker/for-linux/issues/690 [17:59] SpecialK|Canon: that’s the same problem as the lxd one I mentioned in the meeting [17:59] nodnod [21:59] wgrant: Could you have a look at https://code.launchpad.net/~cjwatson/lazr.restful/py3-declarations/+merge/378548, please? (I think it's probably a bit much to ask people not very familiar with lazr.restful to review that.)