| tomwardill | just when you think you're done with the firewall things... it strikes back! | 10:15 |
|---|---|---|
| tomwardill | just spent 10 minutes wondering why my bzr push wasn't working... | 10:15 |
| ilasc | tomwardill: was trying to think of something constructive to reply to that... came up with nothing :) I was pushing to the wrong repo yesterday, spent an hour wondering why things are not working as they should :D | 10:26 |
| tomwardill | computers: how do they work!? | 10:29 |
| wgrant | They don't. | 10:29 |
| tomwardill | ... a valid point | 10:29 |
| wgrant | I always drop in for the valuable contributions. | 10:31 |
| SpecialK|Canon | <3 | 10:31 |
| ilasc | LOL | 10:31 |
| tomwardill | cjwatson: I'm getting the Mir thing on running tests now too | 11:26 |
| cjwatson | I haven't had time to debug it, so if you feel the urge then please do | 11:30 |
| cjwatson | It doesn't happen in the wrapper I normally use, only when I ssh into the container and run tests directly with bin/test | 11:30 |
| tomwardill | yeah, same | 11:31 |
| cjwatson | https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378658 is another py3 dependency upgrade | 14:19 |
| cjwatson | full test suite passed | 14:19 |
| ilasc | do we feel strongly about names for the migration endpoint ? /migrate or /inject ? | 14:26 |
| ilasc | what are we leaning towards ? | 14:26 |
| cjwatson | ilasc: inject seems more explicit; I'd go with that | 14:27 |
| cjwatson | migrate leaves the direction unclear | 14:28 |
| ilasc | cjwatson: excellent, thanks! agreed | 14:28 |
| pappacena | +1 for inject. We could need this endpoint for other purposes, other than migration | 14:28 |
| ilasc | and forgot to say in Standup: thank you for taking on the webhooks QA and test issue! | 14:28 |
| ilasc | cool, we're all in agreement, thanks guys! | 14:29 |
| cjwatson | I was feeling slightly guilty about stealing that from you, but you did say you wanted to get onto lp-signing work | 14:30 |
| cjwatson | And as it happened writing target-generic tests for this turns out to be weirdly difficult | 14:30 |
| cjwatson | Something very odd going on in the innards of the navigation menu system | 14:30 |
| ilasc | hmmm.... definitely no need to feel guilty, that would've been a 3 months time sync for me by the sound of it, very glad I didn't step on that particular landmine at this point - really appreciate you looking at it, you're right I did want to get to lp-signing as soon as possible | 14:35 |
| cjwatson | ok :) | 14:37 |
| cjwatson | ilasc: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378660 | 14:53 |
| ilasc | wow! that was fast! looking now | 14:54 |
| cjwatson | Well, I was working on it most of the morning :) | 14:54 |
| SpecialK|Canon | Agreed re inject, fwiw | 14:55 |
| cjwatson | Including lots of "why on earth is the navigation menu not showing up at all?" | 14:55 |
| ilasc | SpecialK|Canon: +1 | 14:56 |
| ilasc | cjwatson: sounds like u had my kind of morning, however the first part did make laugh as in my world it would translate to "well I was working on it most of this spring" :) | 14:57 |
| ilasc | but I see what you mean on the navigation topic | 14:58 |
| tomwardill | cjwatson: the rename to 'oci_project' in the DB patch, are you intending to backport that fix to 'OCIProjectSeries'? | 15:02 |
| cjwatson | tomwardill: Renaming DB columns is kind of unreasonably painful. I'd suggest it might be a good idea to paper over it at the app level though (i.e. oci_project_id = Int(name='ociproject', allow_none=False); oci_project = Reference(oci_project_id, "OCIProject.id")) | 15:03 |
| cjwatson | tomwardill: Sorry, I should have caught it before | 15:03 |
| tomwardill | well, the rename wasn't a thing before this patch :) | 15:04 |
| cjwatson | Yeah, but William is right that we've preferred this style in most new things for a while | 15:04 |
| tomwardill | Ran 48 tests with 0 failures, 0 errors, 0 skipped in 7.600 seconds | 15:25 |
| tomwardill | now to re-add all the tests I've taken out | 15:25 |
| cjwatson | Ugh, I really hate system-site-packages, so confusing | 15:32 |
| tomwardill | indeed | 15:32 |
| tomwardill | I've had a fair few disagreements with that | 15:32 |
| cjwatson | I'd love to stop using it, but python-apt, mostly | 15:38 |
| cjwatson | https://github.com/sivel/python-apt-wheel not quite the shape of thing I'd ideally like, but I wonder if it'd be worthwhile | 15:44 |
| tomwardill | that seems to be a lot of technology involved | 15:51 |
| cjwatson | Right, ideally we'd just unpack the .deb and slam it into a .whl | 15:53 |
| cjwatson | (We have a few other system Python dependencies too; it's never been worth solving all of them without a strategy for python-apt) | 15:54 |
| cjwatson | Also would need to think about how it interacts with OS upgrades | 15:55 |
| tomwardill | cjwatson: given the name uniqueness constraint on OCIRecipe, where is best to check for existing recipes with the same name on creation? the .new method of OCIRecipeSet? | 15:58 |
| cjwatson | tomwardill: I think that's our usual strategy, ues | 15:59 |
| cjwatson | *yes | 15:59 |
| cjwatson | Compare SnapSet.new | 16:00 |
| tomwardill | cool, thought so | 16:01 |
| SpecialK|Canon | I've lost count of how many times I've been bitten by MoinMoin syntax not being MD/rST | 16:32 |
| SpecialK|Canon | I only have enough room in my brain for a small number of markup languages | 16:33 |
| cjwatson | tomwardill: Could you have a look at https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378670 ? That's my system-site-packages nightmare for today | 17:11 |
| tomwardill | on it | 17:11 |
| cjwatson | And addresses the reason that qastaging isn't updating | 17:11 |
| cjwatson | Also staging in fact | 17:12 |
| cjwatson | dogfood was OK because it updates in place so had a cached wheel | 17:12 |
| cjwatson | But production would run into the same thing | 17:12 |
| tomwardill | well, it's kind of ergh-ish, but all fixes for this type of thing are :) | 17:13 |
| tomwardill | +1, lgtm, glad I didn't have to write it. | 17:14 |
| cjwatson | I would feel exactly that way if I hadn't had to write it | 17:17 |
| cjwatson | Thanks, and agreed | 17:17 |
| tomwardill | cjwatson: Storm is giving me "RuntimeError: Property used in an unknown class" | 17:39 |
| tomwardill | query looks like this: https://pastebin.canonical.com/p/tKWcSKWNTs/ in OCIRecipeSet | 17:40 |
| cjwatson | tomwardill: Can I see the OCIRecipe model? | 17:42 |
| cjwatson | Query itself looks OK | 17:42 |
| tomwardill | cjwatson: https://pastebin.canonical.com/p/kGHKKWdc2p/ | 17:42 |
| tomwardill | oh wait | 17:42 |
| tomwardill | that's the interface | 17:42 |
| tomwardill | sec | 17:43 |
| cjwatson | I was going to say | 17:43 |
| tomwardill | cjwatson: https://pastebin.canonical.com/p/mV2nHh8Wvh/ slightly better | 17:43 |
| cjwatson | tomwardill: That looks OK to me. Um. What's the traceback? | 17:46 |
| cjwatson | tomwardill: Or maybe push WIP to a temporary branch and I can try it | 17:46 |
| tomwardill | sure, one sec | 17:47 |
| tomwardill | cjwatson: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+ref/runtime-errors | 17:48 |
| tomwardill | test is `lp.oci.tests.test_ocirecipe.TestOCIRecipeSet.test_new` | 17:48 |
| cjwatson | OK, give me a bit to build that | 17:50 |
| tomwardill | cjwatson: I've got it | 17:55 |
| cjwatson | Oh? | 17:55 |
| tomwardill | passing 'owner' to self.exists, rather than 'oci_project' | 17:55 |
| tomwardill | stupid copy and paste error | 17:56 |
| tomwardill | (found it by debugging at the point of raise and wondering why it was searching the Person class) | 17:56 |
| cjwatson | Ah right, wrong caller | 17:56 |
| cjwatson | Got it | 17:56 |
| cjwatson | pappacena: Audit trail stuff looks good on dogfood. The only comment I have is that the colspan="2" thing doesn't look quite right on all queues. On the Rejected queue the audit trail appears under the file list, which is reasonable enough. But on the Done queue there's no checkbox column and so it appears under the version instead, which looks odd | 18:03 |
| cjwatson | pappacena: Example of the latter is https://dogfood.paddev.net/ubuntu/xenial/+queue?queue_state=3&queue_text=httmock | 18:03 |
| cjwatson | pappacena: I think you need something conditional on view/availableActions there (see a bit further up in lib/lp/soyuz/templates/distroseries-queue.pt) | 18:04 |
| pappacena | uhm... yes, it doesn't look alright this way. | 18:04 |
| pappacena | Thanks for showing. I will try to reproduce locally and open a MP later today | 18:04 |
| cjwatson | It's deployable like this, just a little odd-looking | 18:04 |
| cjwatson | Thanks for this feature, I bet it will make some people very happy | 18:05 |
| pappacena | I hope so! :-) | 18:05 |
| pappacena | I'll work on a fix today... let me just finish something I'm in the middle here with the signing service... | 18:05 |
| cjwatson | Thanks | 18:15 |
| cjwatson | I've done most of the QA, but I need to wait for my fix-clean-build patch to finish landing so that (qa)staging come back up before I can get any further | 18:15 |
| cjwatson | So possibly a deployment tomorrow late morning ish, which is always nice for the snap store weekly report | 18:16 |
| pappacena | Cool! I'll try to have it ready to review by the end of the day today | 18:19 |
| pappacena | cjwatson: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/378679 | 19:31 |
| pappacena | The fix for the extra colspan when there is no action | 19:31 |
| cjwatson | Thanks, looking | 20:20 |
| cjwatson | pappacena: one query | 20:22 |
| cjwatson | (in a comment there) | 20:22 |
| pappacena | Sure. I will check in a minute | 20:35 |
| pappacena | Replied there... I needed to double check and test something about your comment. | 20:51 |
| cjwatson | pappacena: of course you're right - sorry for my confusion. Go ahead and land at your convenience | 21:05 |
| pappacena | No problem! I got a bit confused too, and had to check to make sure. ;-) | 21:06 |
| pappacena | I'll top-approve now | 21:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!