| tomwardill | landing rocketfuel changes branch | 11:28 |
|---|---|---|
| cjwatson | tomwardill: Er | 11:29 |
| cjwatson | +getopt_output="$(getopt -o '' -l no-workspace,lpusername:,assume-yes -- "$@")" || exit 1 | 11:29 |
| cjwatson | ++eval set -- "$getopt_output" | 11:29 |
| cjwatson | Second line is a syntax error isn't it? | 11:30 |
| tomwardill | huh | 11:30 |
| tomwardill | err, sure I tested that | 11:30 |
| tomwardill | one mo | 11:30 |
| tomwardill | ... | 11:30 |
| cjwatson | You can switch it back to Needs Review if you're quick | 11:31 |
| tomwardill | yeah, just did | 11:31 |
| tomwardill | hopefully quick enough | 11:31 |
| cjwatson | Yeah | 11:32 |
| cjwatson | Also the "while :; do" indentation is still weird | 11:32 |
| cjwatson | Shouldn't it start at column 1? | 11:32 |
| tomwardill | oh, so it should | 11:33 |
| tomwardill | it was originally tabbed, not spaced | 11:33 |
| tomwardill | so that's what I thought you meant :) | 11:33 |
| cjwatson | Ah - no, I meant the vertical position :) | 11:33 |
| tomwardill | okay, both fixed | 11:34 |
| cjwatson | Cool, looks better now :) | 11:34 |
| * tomwardill clears throat... | 11:34 | |
| tomwardill | "landing rocketfuel changes branch | 11:35 |
| tomwardill | " | 11:35 |
| tomwardill | (take 2) | 11:35 |
| cjwatson | tomwardill: Could you have a look at https://code.launchpad.net/~cjwatson/lp-source-dependencies/+git/lp-source-dependencies/+merge/378804 and https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378805 ? More attempts to get staging working | 12:56 |
| tomwardill | on it | 12:57 |
| tomwardill | +1 to both | 12:58 |
| cjwatson | Thanks | 12:58 |
| cjwatson | (I think we should seriously reconsider the policy of using sdists for most things and wheels only where necessary. Installing sdists involves executing code and is generally a much slower and much more complex operation than installing wheels. For pure-Python packages it makes basically no difference to auditability, or if anything probably improves it since you're just unpacking zip files ... | 12:59 |
| cjwatson | ... rather than doing complicated things with setup.py. For packages containing extensions we do indeed need to make sure that we trust the builds; but we could build them once somewhere trustworthy and commit that, which we have to do anyway in several cases.) | 12:59 |
| cjwatson | I remember wgrant being opposed at one point to lp-source-dependencies containing very many wheels, but it's possible I misunderstood him, that he's changed his mind, or that I can persuade him. :-) | 13:00 |
| wgrant | For pure python maybe | 13:01 |
| wgrant | But for extensions we'd have to do weird things to separate them by arch, series, etc. | 13:01 |
| cjwatson | We already do by arch | 13:02 |
| cjwatson | Series perhaps | 13:02 |
| wgrant | Also a full build really doesn't take that long | 13:02 |
| cjwatson | Uh | 13:02 |
| cjwatson | It really does | 13:02 |
| cjwatson | It massively slows down our production deployments | 13:02 |
| wgrant | That might advocate for wheels being included in the deployment artifact | 13:03 |
| cjwatson | (We mostly don't notice locally because most people don't rm -rf download-cache/wheels/) | 13:03 |
| wgrant | I'm pretty sure the build on my desktop took under ten minutes | 13:04 |
| wgrant | After I did that | 13:04 |
| cjwatson | Yeah, it's a lot worse on a lot of our hardware | 13:04 |
| cjwatson | The staging deployment hadn't even finished failing everywhere after I got up this morning, so it spent something like nine hours just doing five or so builds | 13:05 |
| cjwatson | There's a problem with pip's wheel caching - the wheels are cached by hash of the source path, so the download cache isn't preserved usefully when we sync it out to deployment targets | 13:05 |
| cjwatson | But maybe we could copy them out to some other directory with predictable paths and then use that in the deployment artifact | 13:06 |
| wgrant | That is so weird | 13:07 |
| cjwatson | (sdists also involve dealing with the usual setup_requires nightmare) | 13:09 |
| cjwatson | Mostly much better with setuptools invoking pip to do that now, except that that's actually made things worse on Python 3 due to https://github.com/pypa/pip/issues/6264 | 13:10 |
| cjwatson | On Python 2 we dodged that bug due to luck | 13:10 |
| cjwatson | I think we're going to have to finish the job of abolishing our use of --system-site-packages | 13:11 |
| cjwatson | Which would make things much less confusing anyway, but there are a couple of remaining hard problems to solve | 13:13 |
| cjwatson | Basically python-apt and python-pil (and maybe python-tdb for code imports, but we can probably just add that to the virtualenv) | 13:13 |
| cjwatson | For python-apt I have an evil plan that looks more or less like https://paste.ubuntu.com/p/4xHRt4xZwS/ | 13:17 |
| cjwatson | We'd have to keep up with updates (but we have to do that anyway for lots of our Python dependencies) and there may be some care involved with libapt compatibility, especially across series, but those problems seem tractable | 13:18 |
| cjwatson | I'm not sure I'm comfortable taking that sort of approach for python-pil / pillow though, because ouch @ image parsing libraries on our security boundary | 13:19 |
| cjwatson | Aside from some build system stuff, we only use it for checking sizes of images uploaded in forms. I wonder if we could plausibly just call out to imagemagick for that | 13:23 |
| pappacena | Thanks for the comments on my MP, cjwatson. I'm splitting the ArchiveSigningKey renaming into this new one: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/378826 while I'll check the other feedbacks | 16:29 |
| tomwardill | that discussion of development environments in London was ace, as it caused me to actually fix all the broken things in mine | 16:32 |
| cjwatson | pappacena: Great, thanks, will look | 16:34 |
| roadmr | is this a good place to whine about Launchpad timeouts on specific operations? :) | 16:56 |
| cjwatson | Only if they come with OOPS IDs | 16:57 |
| tomwardill | and cake | 16:57 |
| roadmr | https://oops.canonical.com/oops/?oopsid=OOPS-e0d2dfcb5398a0477ac9d343b669f4c1 🎂 | 16:58 |
| roadmr | that's a sample OOPS but - it used to sporadically timeout when adding people to the sso-2f-testers team - these days it *always* times out (but still adds the person) | 16:58 |
| roadmr | maybe the list of people is now too big? it's 1300 or so I think | 16:58 |
| cjwatson | Yeah, looks like it needs some bulk-loading. Could you file a bug and quote the OOPS ID please? | 16:59 |
| roadmr | totally | 16:59 |
| * cjwatson probably won't have time but hopefully somebody else will :) | 17:00 | |
| roadmr | yes, and it's not a showstopper, just annoying | 17:01 |
| roadmr | thanks! | 17:01 |
| roadmr | https://bugs.launchpad.net/launchpad/+bug/1862670 | 17:06 |
| mup | Bug #1862670: timeout/oops when adding people to a certain LP team (but adding still succeeds?) <Launchpad itself:New> <https://launchpad.net/bugs/1862670> | 17:06 |
| wgrant | cjwatson: I'm sorry did you just propose fixing a security issue by calling out to imagemagick? | 20:30 |
| cjwatson | wgrant: eh there's a reason I haven't just put together a patch for it yet ... | 21:46 |
| cjwatson | pillow also seems made of CVEs though | 21:47 |
| cjwatson | I happened to have a look at it and the last security update was, err, last week | 21:47 |
| cjwatson | and we only pick that up when we happen to restart appservers for other reasons | 21:48 |
| cjwatson | surely in 2020 CE there exists a simple thing to find the dimensions of images that isn't composed of cheese and security holes | 21:50 |
| cjwatson | https://pypi.org/search/?q=image+size has several things in pure Python that look 100x simpler and probably usable | 21:56 |
| pappacena | Silly Zope question here, but... I'm trying to register a class as a component here, but I'm getting a strange error saying " __init__() takes exactly 4 arguments (1 given)". My configure.zcml directive looks quite similar to other examples in Launchpad... anyone knows what am I missing? | 21:59 |
| pappacena | https://www.irccloud.com/pastebin/i7QTFuxN/configure.zcml | 21:59 |
| pappacena | this is my configure.zcml | 21:59 |
| cjwatson | pappacena: what's ArchiveSigningKey's __init__? | 22:00 |
| pappacena | ahm... it's empty | 22:00 |
| cjwatson | pappacena: normally something registered as a utility would have at most an __init__(self) without extra options | 22:00 |
| pappacena | ahhh, no no! | 22:01 |
| cjwatson | pappacena: the thing in class= is really just a factory - whatever you put there is called with () to create the component that's registered as the utility | 22:01 |
| pappacena | it's not empty... I've declared that receiving paremeters! 🤦♂️ | 22:01 |
| pappacena | Ok, I moved one step... let me keep on doing things here. Thanks, cjwatson! | 22:02 |
| cjwatson | np | 22:03 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!