/srv/irclogs.ubuntu.com/2020/02/10/#snappy.txt

mborzeckimorning06:19
mborzeckimvo:  hey07:31
mvomborzecki: hey, good morning!07:32
mvomborzecki: how is life, anything important happend on friday?07:32
mborzeckimvo: iirc nothing super important, pedronis is off today07:33
mborzeckimvo: the pulseaudio test seems to be causing issues on 20.0407:35
mvomborzecki: yeah, cool. no bad news is good news07:35
mvomborzecki: anything in particular needs reviews?07:35
* mvo is current going top-bottom07:35
mborzeckimvo: i was not albe to reproduce it, but according to standup notes ian maanged to do so calling spread in loop ratehr than with -repeat07:35
mvomborzecki: hm, that's annoying, any clues?07:36
mborzeckimvo: no, not really, maybe we should consider skipping the test on 20.04 until we figure it out, seems to break travis runs quite often07:37
mvomborzecki: yeah, that works for me07:38
mborzeckimvo: oh, and 8077 could use a review ;)07:38
mborzecki#807707:38
mupPR #8077: boot: enable base snap updates in bootstate20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8077>07:38
mborzeckimvo: and something off with autorefresh https://forum.snapcraft.io/t/snap-is-updating-off-schedule/15323/10 even though the schedule is calcualted correctly07:41
mvomborzecki: and it's not because the last update happend ages ago ? (or there was some sort of clock glitch?)07:45
zygagood morning07:46
mvohey zyga07:47
zygasorry, I overslept07:47
mvozyga: no worries07:47
zygabut almost on time for 9 am start07:47
mvozyga: flexible hours++07:47
mvozyga: :)07:47
zygawinter holidays started for the kids today07:47
zygaso no alarm clocks or anything07:47
mvozyga: sounds very nice if you ask me :)07:48
zygayeah, all quiet07:49
mborzeckizyga: hey07:49
zyga:)07:49
zygalet me make some coffee quickly07:49
mborzeckimvo: no, looking at the log there's an update on Feb 05 12:22:39 and anothr one on Feb 06 09:54:28, while the 'ages ago' thing is 60 days07:50
mvomborzecki: meh, that's annoying, thank you07:58
pstolowskimorning07:59
mborzeckipstolowski: hey08:02
mvohey pstolowski !08:03
mborzeckiquick errand, back in 3008:04
zygahey pawel :)08:09
mupPR snapd#8096 closed: tests: retry mounting the udisk2 device due to timing issue <Simple 😃> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8096>08:13
mborzeckire08:29
pstolowskihmmm i need to do something about task pruning wrt pre-seeded image08:33
zygare09:59
zygapstolowski: can you tell me more please?10:00
mborzeckihmm so i reproduced the problem with pulseaudio, and looks like the pulseaudio daemon is not actually listetning on any socket10:01
mvomborzecki: woah10:03
mborzeckimvo: i'll try with a custom script for the server10:04
zygamborzecki: how is that possible10:06
zygamborzecki: as in misbehaving and not listening on any socket10:06
pstolowskizyga: on the pre-baked image we have changes & tasks with spawn-times in the past. i wonder if prune mat abort them if the image is booted after >24h from pre-baking10:07
pstolowskis/mat/may/10:07
mborzeckizyga: idk, lsof clearly shows it's not listening on anyting, no logs, nothing, any action tries /run/user/12345/pulse/native and gets connection refused (cause nobody's listening)10:08
zygapstolowski: ah10:08
zygapstolowski: interesting!10:08
mborzeckizyga: restarting pulseaudio magically fixes this10:08
zygapstolowski: that's tricky, do we need any extra state so that they are not pruned?10:08
zygamborzecki: is that easy to reproduce?10:08
pstolowskizyga: i wonder if that isn't a general concern (but maybe i'm missing something): what if you have a change in flight, power off in the middle, turn back on after >24h. you may hit readyTime.IsZero() == true and spawnTime.Before(abortLimit) == true afaict, meaning the change gets aborted. this is if you are unlucky and the change does not finish in 10 minutes after boot (this is the prune ticker interval)10:10
mborzeckizyga: not really, happened just one so far10:11
pstolowskizyga: i don't think we need extra state for pre-seed case, should be enough to check if there is any "become-operational" change and if so, just block pruning for some time based on its ready-time10:13
pstolowskii need a test case, this is indeed a bit tricky stuff10:14
zygapstolowski: yeah, I think we don't model suspend/off time in our system10:16
mborzeckiE: [pulseaudio] socket-server.c: bind(): Address already in use10:41
mborzeckiE: [pulseaudio] module.c: Failed to load module "module-native-protocol-unix" (argument: ""): initialization failed.10:41
mborzeckiheh10:41
zygamborzecki: that's interesting10:46
zygamborzecki: do we have any pulseaudio fakes?10:46
zygamborzecki: that might clobber the unix socket10:46
zygamborzecki: or perhaps it's something more silly, like stale socket being left in place10:46
zygamborzecki: I don't recall what happens if a socket is in the FS and you try to create a new one there10:46
mborzeckizyga: added rm -f /run/user/12345/pulse/native just in case it's needed10:47
zygamborzecki: do we remove /run/user/12345 anywhere?10:47
zygamborzecki: I think the code that handles the test user10:51
zygamborzecki: as in, uses it10:51
zygamborzecki: could remove /run/user/12345 after each test10:51
mborzeckizyga: and probably kill all processes of test user too10:56
zygamborzecki: yeah, that's a good idea10:56
zygamborzecki: too bad that doesn't scale to "root" :-)10:56
zygamborzecki: it would be easier for us10:56
mupPR snapd#8108 opened: tests/main/interfaces-pulseaudio: use custom pulseaudio script, set kill timeout <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8108>11:00
mborzeckimvo: zyga: ^^11:00
zygareading11:00
mborzeckistill running some tests, will force push as needed11:00
zygareviewed11:02
mborzeckihmm why does paplay hang when it cannot connect after the plug was disconnected?11:02
zygamborzecki: paplay is simple, maybe it assumes too much11:03
zygamborzecki: but really, no idea11:03
zygamborzecki: does it spin or hang?11:03
zygamborzecki: can you look at https://github.com/snapcore/snapd/pull/798011:44
mupPR #7980: packaging,snap-confine: stop being setgid root <Created by zyga> <https://github.com/snapcore/snapd/pull/7980>11:44
mborzeckizyga: sure11:44
zygamborzecki: I've handled the review from jamie and apart from one small tweak it is ready for re-review11:44
zyga  mborzecki requested a review on https://github.com/snapcore/snapd/pull/810812:21
mupPR #8108: tests/main/interfaces-pulseaudio: use custom pulseaudio script, set kill timeout <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8108>12:21
zygaer12:21
zyganot on this one12:21
zygaI meant 792512:21
* zyga switches to https://github.com/snapcore/snapd/pull/782512:22
mupPR #7825: many: use transient scope for tracking apps and hooks <Security-High> <Created by zyga> <https://github.com/snapcore/snapd/pull/7825>12:22
mborzeckizyga: some comments in https://github.com/snapcore/snapd/pull/798013:00
mupPR #7980: packaging,snap-confine: stop being setgid root <Created by zyga> <https://github.com/snapcore/snapd/pull/7980>13:01
zygaaha13:01
zygalooking13:01
zygathank you for reviewing!13:01
zygamborzecki: updated13:07
zygamborzecki: please look again :)13:07
zygaI need to take Bit out13:08
mborzeckizyga: thanks!13:10
mupPR snapd#8107 closed: tests/lib/prepare: use a local copy of uc20 initramfs skeleton <Simple 😃> <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8107>13:26
mborzecki#8081 needs a 2nd review, zyga maybe you can take a look since you did a pass before?13:26
mupPR #8081: tests/main/user-session-env: add test verifying environment variables inside the user session <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8081>13:27
zygamborzecki: yes13:27
zygamborzecki: looking13:27
mborzeckithanks!13:27
zygamborzecki: do you remember why [[ vs [ ?13:28
zygawow13:28
mborzeckizyga: [[ is bash builtin, [ is /bin/test alias, but bash does a builtin anyway?13:28
zygatunderstorm13:28
zygathunder hit nearby13:28
zygawow, that was LOUD13:28
zygawonder if any glasses broken13:29
zygaor windows or whatever13:29
mborzeckizyga: had hailstorm here today :P13:29
mborzeckiand +9C :P13:29
zygamvo: how is your weather? do you experience the big storm that sweeps across EU now?13:29
zygamborzecki: same here +913:29
zygait's so warm for such a windy day13:29
zygamborzecki: as for [[ vs [, I would use [ unless [[ is required,13:30
mborzeckizyga:  i can push a patch htere13:31
zygabecause it's non obvious why [[ is used here and we use [ nearly everywhere unless we require extra semantics from [[13:31
zygamborzecki: I can apply a inline suggestion, just wanted to understand why first13:31
mborzeckizyga: inline is fine, saves the checkout/commit/push cycle13:31
=== ricab is now known as ricab|lunch
zygayep13:33
zygathanks13:33
zygamborzecki: no permission to push13:34
mborzeckizyga: weird13:34
mborzeckilet me do it locally13:34
zygatry applying my suggestion13:34
zygamaybe it's that13:34
ijohnsonhappy monday folks13:42
ijohnsonmborzecki: were you able to sort out the weirdness with pulseaudio ?13:48
ijohnsonI have some thoughts from my investigation on Friday that I didn't get around to putting in the SU doc13:48
mborzeckiijohnson: yeah, sort of, plase look at https://github.com/snapcore/snapd/pull/810813:49
mupPR #8108: tests/main/interfaces-pulseaudio: use custom pulseaudio script, set kill timeout <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8108>13:49
ijohnsonack looking now13:49
mborzeckiperhaps not all of it is needed, but i suppose it won't hurt13:49
mborzeckiwow, thunderstorm here13:51
ijohnsonahhhh okay your last line at the end explains one of the things that was very confusing to me13:51
ijohnsonI was constantly seeing it fail when I had restarted it in a way that it stuck around, but having your last statement kill it would make the execute not fail13:52
ijohnsonit was very confusing because I even put a `exit 0` at the end of the execute section and it still would say the run failed13:52
mborzeckiijohnson: yeah, i believe the pulseuadio process is keeping the pty allocated by ssh still open, so either nohup with that pulseaudio start line, or su -P (?), or just kill it before leaving13:56
mborzeckiijohnson: that daemon start script is superfluous, but it makes the setup simpler, eg. pulseaudio doesn't try to use bluez and so on13:57
ijohnsonmborzecki: great! yeah I think your PR looks good, did you try it running spread in a loop?13:57
mborzeckiijohnson: i was able to get it to block on each run eventually :P13:58
mborzeckibtw https://news.ycombinator.com/item?id=22279585 (cc zyga)13:59
zygamvo: let me review the netlink code now14:37
Saviqcachio: are "fedora-rawhide-64" images something you build? we're having trouble with GPG keys on those https://github.com/MirServer/mir/issues/126014:43
cachioSaviq, yes14:43
cachiowell I just update this14:44
cachioapply the latest changes14:44
cachioSaviq, I'll take a look14:44
mborzeck1aaand no power, running on battery14:51
ijohnsonmborzeck1: oh no hope your power is restored soon14:58
zygamvo: I'll grab lunch/dinner and sit on that netlink PR15:01
zygamvo: I'm not super happy about it, it's very messy still (I know there are constraints)15:02
zygamvo: I'd like to make it simpler and more robust15:02
mupPR snapcraft#2924 opened: cli: explicitly ensure type 'snapd' is non-legacy <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2924>15:05
=== ricab|lunch is now known as ricab
=== msalvatore_ is now known as msalvatore
* zyga eats15:16
mborzeck1ijohnson: posted some comments in #807715:19
mupPR #8077: boot: enable base snap updates in bootstate20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8077>15:19
ijohnsonmborzeck1: thanks will look after meeting15:19
mborzeck1and power is backing, switching systems15:19
mborzeck1s/backing/back/15:19
mvozyga: in a meeting right now15:26
zygano rush15:26
mvozyga: but yeah, thank you15:26
mvozyga: simple++15:26
=== Eleventh_Doctor is now known as Pharaoh_Atem
* cachio lunch15:39
ijohnsonmvo: I had to add one more commit to https://github.com/snapcore/snapd/pull/8106, do you think I can merge if it goes green now?16:04
mupPR #8106: tests: add "core" suite for UC specific tests <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8106>16:04
mvoijohnson: +116:13
mvozyga: back now16:13
ijohnsonthanks mvo16:13
mvoijohnson: thank you :)16:13
ijohnsonalso it seems mborzecki's pulseaudio changes aren't enough, I will try to merge my stuff with what he has and if it works I will push to his branch16:14
zygaoh fun16:16
* ijohnson goes to buy another goat to sacrifice to the pulseaudio spread test gods16:23
mupPR snapd#8109 opened: [RFC] o/devicestate: don't prune tasks immediediately <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8109>16:29
zygapstolowski: some instant suggestions on comments16:33
pstolowskizyga: thanks, i think i'm gonna change it, just had an enlightement16:34
zygashould I refrain from reviewing the rest?16:35
pstolowskizyga: yep, please hold on, thanks!16:36
zygaok16:36
oSoMoNjdstrand, I would appreciate your input on bug #185964316:44
mupBug #1859643: [snap] cannot use shared NSS db <snap> <chromium-browser (Ubuntu):Triaged by osomon> <https://launchpad.net/bugs/1859643>16:44
zygaoSoMoN: I believe jamie is off today16:49
oSoMoNzyga, ah, thanks, I'll try again tomorrow then16:49
mvozyga: I updated 8063 now16:50
zygaaha16:51
zygalet me read it quickly16:52
zygamvo: done16:53
zygamvo: it looks great, there are a few comment that were not responded to though16:53
zygalet me update those that were quickly16:53
zygadone16:54
zygamvo: can you scan through those quickly16:54
zygaI think a quick line in remove-user/task.yaml will solve the first one16:54
zygathe [[ can probably just become [16:54
zygathe wording on snap remove user is something we can talk about (not blocking) but I think the original error is not comprehensible much16:55
mvozyga: aha, github did hide some from me, sorry for this16:55
zygamvo: the api docs can be "not documented"16:55
mvozyga: I see them now16:55
mvozyga: let me look at those16:55
zygamvo: but I wasn't sure16:55
zygamvo: I guess we ought to document this16:55
zygamvo: but not super critical16:55
zygamvo: if you rush this16:55
zygamvo: lastly since this deals with users I would love to see even a post-factum review from security16:55
zygamvo: and perhaps the test I suggested16:56
zygaas it could be a nasty CVE if that were to work16:56
zygamvo: (this doesn't capture that the changes you made look great)16:56
* zyga hugs mvo16:56
mvozyga: thank you! I address the other bits now16:57
* mvo hugs zyga16:57
=== ricab is now known as ricab__
pstolowskiijohnson: hey, will you find some time to look at #8046?17:07
mupPR #8046: many, tests: integrate all preseed bits and add spread tests <Complex> <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8046>17:07
ijohnsonpstolowski: yes I will try to get to it today or tomorrow17:07
pstolowskiijohnson: thanks!17:08
* zyga breaks, family is back17:18
=== heather1 is now known as hellsworth
mupPR snapd#8110 opened: store: add support for resume in DownloadStream <Created by mvo5> <https://github.com/snapcore/snapd/pull/8110>17:28
cachiomvo, https://paste.ubuntu.com/p/Vns7w2Jq8v/17:43
mupPR core20#21 opened: Add bash-completion support <Created by xnox> <https://github.com/snapcore/core20/pull/21>17:58
mupPR snapd#8111 opened: tests: Adding new backend which includes images with tpm support <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8111>18:00
* cachio afk18:02
cachioI'll be out 30 minutes18:03
mupPR core18#147 opened: Add bash-completion support <Created by xnox> <https://github.com/snapcore/core18/pull/147>18:06
zygamvo: I'm making progress on netlink code18:12
zygamvo: I will have it tonight18:12
zygaah, maciek is off already18:33
mvozyga: nice18:42
mvocachio: nice!18:43
mvocachio: cool to see this18:43
mupPR snapd#8106 closed: tests: add "core" suite for UC specific tests <Test Robustness> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8106>19:06
zygaI sent mvo the epoll based netlink stuff19:45
zygaand will wrap up for the day19:45
zygaijohnson: I can telegram you a zip if you want to see19:46
ijohnsonzyga: if I want to see what?19:46
zygaijohnson: epoll based netlink listener in go19:46
ijohnsonoh, nah I have other things to review/look at this afternoon :-)19:46
ijohnsonin other news I think I have the pulseaudio spread test under control19:47
zyga:)19:47
zygasure19:47
ijohnsonhaven't hit the failure yet in 2 consecutive runs :-)19:47
zygahave fun with pulseaudio there, I'd love to know what's the root problem in the end19:47
ijohnsondon't get your hopes up too much, my solution is just to start it, kill it violently, and restart it, but there's now at least some more information in the logs if someone wanted to file a bug upstream with pulseaudio folks19:56
mupPR snapd#8112 opened: tests: move main/ubuntu-core-* tests to core/ suite <Simple 😃> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8112>20:02
cmatsuokaijohnson: can I assign dimitri's snapcraft build bug to you, just as a reminder to unblock the PR once the prerequisite bugs are fixed?20:21
ijohnsoncmatsuoka: sure, I just updated the PR today, so it's ready as soon as snapcraft is ready20:21
cmatsuokaijohnson: thanks, hopefully we'll have this fixed soon20:22
zygaondra: wrote regression test, fix coming up tomorrow20:23
mupIssue core20#20 closed: Unpublish the core20 snap for i386 <publication> <Created by anonymouse64> <Closed by xnox> <https://github.com/snapcore/core20/issue/20>20:36
NickZHas anyone tested on Fedora 31 recently? It appears that it's broken and has been for a while20:56
NickZhttps://forum.snapcraft.io/t/error-system-does-not-fully-support-snapd/14911/1421:00
mupPR snapcraft#2920 closed: meta: initialize Snap at once in from_dict() <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2920>21:00
NickZSnapd, that is21:01
cachioSaviq, I left a message in the issue21:19
cachiowith that the problem should be fixed21:19
Saviqcachio: thanks!21:23
cachioSaviq, yaw,21:23
Saviq cachio: while we could do this, shouldn't an image rebuild fix this? It feels wrong to ignore gpg errors?21:30
mupPR snapcraft#2919 closed: sanity_checks: fix sanity check on Windows <Created by NickZ> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2919>21:33
cachioSaviq, we have these error often on rolling systems21:34
cachioin opensuse we already and usign the same option21:35
cachioon tumbleweed21:35
cachioSaviq, I can try tomorrow to fix that21:36
mupPR snapcraft#2925 opened: project loader: use get_build_base() to assign plugin handler base <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2925>22:00
zygaondra: https://github.com/snapcore/snapd/pull/811322:06
mupPR #8113: cmd/snap-confine: bring /var/lib/dhcp from host, if present <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8113>22:06
mupPR snapd#8113 opened: cmd/snap-confine: bring /var/lib/dhcp from host, if present <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8113>22:06
mupPR snapcraft#2924 closed: cli: explicitly ensure type 'snapd' is non-legacy <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/2924>23:10

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!