[00:56] <mup> PR snapd#8115 closed: overlord/devicestate: fix preseed unit tests on systems not using /snap <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8115>
[01:32] <mup> PR snapcraft#2926 closed: plugin handler: process elf files only if base is specified <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2926>
[01:32] <mup> PR snapcraft#2928 closed: logging: use .warning instead of deprecated .warn <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2928>
=== hggdh is now known as hggdh-msft
[04:11] <mup> PR snapcraft#2931 opened: store: improve platform detection <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2931>
[06:29] <mborzecki> morning
[06:34] <mvo> hey mborzecki
[06:34] <mborzecki> mvo: hey
[06:34] <mborzecki> mvo: looks like despite all the workarounds paplay still gets stuck
[06:37] <mborzecki> quick round trip to schoold, back in 30
[06:37] <mvo> mborzecki: meh, that's sad
[06:37] <mvo> mborzecki: see you in 30"
[07:09] <mborzecki> re
[08:00] <pstolowski> morning
[08:01] <mborzecki> pstolowski: hey
[08:06] <mvo> hey pstolowski
[08:13] <mvo> pstolowski: looks like 8102 is super close, just one question in there that smeels like a followup, I'm in favor of merging (also it's green :)
[08:15] <pstolowski> mvo: hey. zyga raised a valid concern there, i need to think
[08:48] <zyga> pstolowski: I think the way the code worked before was more flexible
[08:49] <zyga> pstolowski: and I fear if you add the right test now we will see it is not working correctly :/
[08:49] <zyga> pstolowski: perhaps we should keep it like it was before, in ifacestate but based on repo data
[08:49] <zyga> pstolowski: that is a far safer 2.44 patch
[08:51] <pstolowski> zyga: i could use exported GuessCoreSnap() from repo like i had initially in that branch. but i wonder if what we had before had any practical significance since we do restart into new snapd/core?
[08:51] <zyga> pstolowski: that question requires analysis - I don't know
[08:51] <zyga> pstolowski: but I do know the old mode reacted instantly while the new mode reacts on restart
[08:56]  * pstolowski quick erran, bb shortly
[08:56] <pstolowski> *errand
[09:08] <mborzecki> anyone seen centos-7 fail in recent spread runs?
[09:10] <mborzecki> hmm looks like it's working now
[09:14] <zyga> I didn't
[09:20] <mup> PR snapd#8121 opened: spread: move centos to stable systems <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8121>
[09:22] <zyga> mborzecki: can you review https://github.com/snapcore/snapd/pull/8113
[09:22] <mup> PR #8113: cmd/snap-confine: bring /var/lib/dhcp from host, if present <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8113>
[09:22] <mborzecki> sure
[09:25] <mborzecki> zyga: hm should this be done in interfaces/network_control.go as a mount entry?
[09:26] <zyga> mborzecki: I don't think so, it feels like a standard thing you can get to with devmode
[09:26] <zyga> but
[09:26] <zyga> it's an idea
[09:26] <zyga> perhaps?
[09:26] <zyga> dunno
[09:27] <mborzecki> zyga: right, but with devmode you can also access fonts and we still add a mount when desktop is connected
[09:27] <mborzecki> well, absically so that it ends up in the right place
[09:28] <zyga> mborzecki: that's a valid point of view
[09:29] <mborzecki> zyga: ok, let me add a comment and maybe we can discuss it more
[09:29] <zyga> ok
[09:33] <mborzecki> zyga: if we have add a mount in MountConnectedPlug(), it should behave the same right? however, the iface is not auto connected, but even so, without the connection on AA enabled systems the process won't be able to access /var/lib/dhcp either
[09:43] <zyga> mborzecki: I think so, there are subtle differences between the two
[09:43] <zyga> mborzecki: but I think it could work out okay
[09:50] <mvo> 8110 needs a second review (should be easy)
[09:50]  * zyga looks
[09:53] <zyga> mvo: reviewed, please look
[09:54] <mvo> zyga: thank you
[09:55]  * zyga goes to prepare the nvidia patch
[10:01] <mup> PR snapd#8063 closed: cmd/snap: implement 'snap remove-user' <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8063>
[10:02] <mup> PR snapd#8110 closed: store: add support for resume in DownloadStream <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8110>
[10:19] <mborzecki> #8060 needs a 2nd review, should be fairly simple
[10:19] <mup> PR #8060: gadget: skip update when mounted filesystem content is identical <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8060>
[10:19] <zyga> booo
[10:19] <zyga> I already did
[10:19] <zyga> two weeks of waiting
[10:19] <zyga> man
[10:19] <mborzecki> same for #8047
[10:19] <mup> PR #8047: tests: detect LXD launching i386 containers <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8047>
[10:31] <pedronis> mvo: done
[10:38] <pstolowski> re
[10:41] <mborzecki> mvo: hm crazy idea to consider if you're feeling brave: https://github.com/snapcore/snapd/pull/8105/files#r378169956
[10:41] <mup> PR #8105: store: detect if server does not support http range headers <Created by mvo5> <https://github.com/snapcore/snapd/pull/8105>
[10:42] <mvo> mborzecki: yeah, love this
[10:42] <mborzecki> mvo:  no need to truncating and overwriting what's already there
[10:48] <mup> PR snapd#8108 closed: tests/main/interfaces-pulseaudio: use custom pulseaudio script, set kill timeout <Test Robustness> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8108>
[10:52] <pedronis> pstolowski: hi, https://github.com/snapcore/snapd/blob/master/overlord/snapstate/handlers.go#L1351
[10:52] <pedronis> sorry
[10:52] <pedronis> pstolowski: I meant, https://github.com/snapcore/snapd/pull/8102#discussion_r378175775
[10:52] <mup> PR #8102: o/ifacestate: move ResolveDisconnect to ifacestate <Needs Samuele review> <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8102>
[10:53] <mvo> thanks pstolowski, ijohnson, mborzecki and pedronis for your suggestions in 8119! much appreciated your excellent feedback
[10:53]  * mvo waits for it to become green
[10:57] <zyga> re
[10:57] <zyga> sorry, had a small unexpected errand at home (drilling)
[10:57] <zyga> reproduced nvidia issue
[10:57] <zyga> working on a fix
[10:58] <mborzecki> zyga: through drilling?
[10:58] <zyga> mborzecki: $wife needed to install new baby gate thing (we have few doors in our house so everything is unprotected and open) and the gate arrived now instead of next week
[10:59] <pstolowski> pedronis: thank you. i thought we always restart but wasn't sure if it answers the concern, and if that's all there is to it
[11:02] <mvo> zyga: nice, thank you!
[11:11] <pedronis> pstolowski: I actually think we might have a bug, but in the other direction, repo thinks we are using snapd too early
[11:13] <pstolowski> pedronis: hmm you might be right
[11:13] <mup> PR snapd#8122 opened: interfaces/opengl: allow datagrams to nvidia-driver <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8122>
[11:13] <zyga> mborzecki: ^
[11:17] <pedronis> pstolowski: because the actuall connections don't get switch over until reloadConnections happens early at start, but the repo will think we are using snapd as soon as we do setup-profiles for it?
[11:19] <mvo> mborzecki: 7972 is green now, I guess it can be merged?
[11:21] <mborzecki> mvo: yes
[11:22] <zyga> mvo: please consider 8122 for the point release
[11:22] <zyga> mvo: it's not urgent but feels safe as it is just extra permissions for opengl specific to nvidia
[11:22] <zyga> mvo: I guess you can consider it pre-reviewed by jamie as he proposed the change in the first place
[11:23] <mup> PR snapd#7972 closed: overlord/snapstate, wrappers: undo of snapd on core <Remodel 🚋> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7972>
[11:23] <mvo> zyga: yeah, I think that's sensible
[11:25] <mvo> pedronis: concerns for 8122 for 2.43.3? looks small and safe
[11:27] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/8121#issuecomment-585161782
[11:27] <zyga> boo
[11:27] <mup> PR #8121: spread: move centos to stable systems <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8121>
[11:27] <mborzecki> hahah
[11:30] <mborzecki> pfff but really, `spread -list google-unstable:` erorrs out right away, so there's no way to tell whetner there are any tests to run even
[11:31] <pstolowski> pedronis: sorry, i had to check the code.. yes, this looks problematic
[11:36] <mborzecki> zyga: pushed a workaround
[11:40] <mup> PR snapd#8116 closed: test/lib/user: add helper lib for doing things for and as a user <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8116>
[11:42] <zyga> mborzecki: I've reworked the dhcp PR to do what you suggested, altered appropriate tests
[11:42] <zyga> fingers crossed :)
[11:42] <zyga> I'll grab some tea
[11:42] <mborzecki> zyga: does it work still? :)
[11:43] <zyga> mborzecki: should, I'll know in 30 minutes
[11:43] <zyga> brb
[11:43] <mborzecki> haha
[11:43] <mborzecki> btw. maybe i should post my cloud-init configs for prebuilding spread images
[11:48] <ogra> mwhudson, are you still the go-to guy for subiquity bugs ?
[11:53] <zyga> mborzecki: do!
[12:03] <pedronis> pstolowski: not with urgency but we need to slowly try to reduce the need for guess* in repo and/or pass the value in from ifacestate
[12:06] <zyga> mborzecki: it's a little harder than the other one but I should have an alternate PR shortly
[12:10] <pstolowski> pedronis: ack, will do soon. going to land resolve-disconnect PR then (after addressing remaining comments)
[12:13] <mup> PR snapcraft#2931 closed: store: improve platform detection <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2931>
[12:28] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/8123
[12:28] <mup> PR #8123: interfaces/network-control: bring /var/lib/dhcp from host <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8123>
[12:28] <mup> PR snapd#8123 opened: interfaces/network-control: bring /var/lib/dhcp from host <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8123>
[12:29] <zyga> mborzecki: some tests are still running locally but that's the rough idea
[12:33] <mborzecki> zyga: thanks, will take a look
[12:36] <zyga> hmm
[12:36] <zyga> doesn't work ..
[12:36] <zyga> (regression test failed)
[12:36]  * zyga looks
[12:40] <zyga> ah, I didn't connect the interface in the test
[12:40] <zyga> mborzecki: it's weird that this passed in the other one
[12:40] <zyga> are all tests running with --devmode?
[12:53] <zyga> one more try
[13:14] <zyga> mborzecki: oh boy
[13:14] <zyga> update.go:85: cannot change mount namespace according to change mount (/var/lib/snapd/hostfs/var/lib/dhcp /var/lib/dhcp none rw,bind 0 0): cannot write to "/var/lib/snapd/hostfs/var/lib/dhcp" because it would affect the host in "/var/lib/snapd"
[13:17] <pedronis> pstolowski: I did a pass on #8046
[13:17] <zyga> got lots of - Fetch and check assertions for snap "core" (8683) (cannot get device session from store: store server returned status 400 and body "{\"error_list\":[{\"code\":null,\"message\":\"Nonce is missing or invalid.\"}],\"errors\":[\"Nonce is missing or invalid.\"],\"result\":\"error\"}\n")
[13:17] <mup> PR #8046: many, tests: integrate all preseed bits and add spread tests <Complex> <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8046>
[13:18] <pstolowski> pedronis: ty
[13:19] <pedronis> zyga: store was redeploying something, maybe it's related
[13:19] <mup> PR snapd#8105 closed: store: detect if server does not support http range headers <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8105>
[13:21] <zyga> mhm
[13:33] <pedronis> pstolowski: #8102 can be merged now?
[13:33] <mup> PR #8102: o/ifacestate: move ResolveDisconnect to ifacestate <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8102>
[13:35] <pstolowski> pedronis: i wanted to address your remark about SystemSnapName never returning ""; but perhaps will do in a followup
[13:35] <mup> PR snapd#8124 opened: tests: Fix core revert channel after 2.43 has been released to stable <Skip spread> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8124>
[13:41] <pstolowski> pedronis: ok if i squash-merge #8102 in case of something unexpected and a need for revert?
[13:41] <mup> PR #8102: o/ifacestate: move ResolveDisconnect to ifacestate <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8102>
[13:44] <zyga> mborzecki: please check https://github.com/snapcore/snapd/pull/8123
[13:44] <mup> PR #8123: interfaces/network-control: bring /var/lib/dhcp from host <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8123>
[13:44] <zyga> mborzecki: it's an interesting development
[13:44] <zyga> mborzecki: if accepted we could remove more things from snap-confine
[13:44] <zyga> mborzecki: and move them to the correct interface
[13:46] <mup> PR snapcraft#2932 opened: elf: resolve paths in `ldd()` to purge relative path components <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2932>
[13:48] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/8121 is still red
[13:49] <mup> PR #8121: spread: move centos to stable systems <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8121>
[13:49] <zyga> mborzecki: I'd like to look at https://github.com/snapcore/snapd/pull/8121
[13:49] <zyga> mborzecki: it produces some selinux denials
[13:50] <zyga> mborzecki: I'll try to fix them now but I may need your eyes later
[13:50] <mup> PR pc-amd64-gadget#34 opened: Makefile: add "regex" to the modules for the non-uefi grub <Created by mvo5> <https://github.com/snapcore/pc-amd64-gadget/pull/34>
[13:51] <ijohnson> morning folks
[13:51] <zyga> good morning
[13:51] <ijohnson> hey zyga
[13:51] <mborzecki> ijohnson: hey
[13:51] <mup> PR snapd#8119 closed: httputil: add NoNetwork(err) helper, spread test and use in serial acquire <Squash-merge> <⚠ Critical> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8119>
[13:57] <mup> PR snapd#8122 closed: interfaces/opengl: allow datagrams to nvidia-driver <Bug> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8122>
[13:58] <zyga> thank you mvo!
[14:09]  * cachio afk
[14:13] <zyga> mvo, xnox: do you know what triggers cgroup v2 mode in systemd? will we auto-transition to v2 at some point or is that an explicit toggle?
[14:13] <zyga> I'm trying to understand if ubuntu core 20 will be cg-v1 or cg-v2
[14:14] <xnox> zyga:  ubuntu 20.04 LTS will be hybrid
[14:14] <xnox> fedora latest is v2-only
[14:14] <xnox> hybrid is the same as what bionic is, i believe
[14:14] <zyga> right, but is that configuration or some kind of auto-detection in systemd
[14:14] <zyga> based on something (kernel version?)
[14:14] <xnox> no
[14:15] <xnox> this is a build-time systemd option
[14:15] <zyga> ah, I see
[14:15] <zyga> thank you!
[14:15] <xnox> however, a user can override it with a kernel cmdline option
[14:15] <zyga> do you thin core 22 will be v2?
[14:15] <zyga> *think
[14:15] <xnox> so for example on focal you can test and boot in v2-only mode if you want to prepare for the future / fedora
[14:15] <xnox> i think fedora/rhel/suse will be v2-only before core22 ships
[14:16] <mborzecki> zyga: systemd.unified_cgroup_hierarchy=1
[14:16] <zyga> mborzecki: I do know this :)
[14:16] <zyga> I was wondering what kind of future is ahead
[14:17] <mborzecki> xnox: do you think rhel8 will become v2 at some point, or rather rhel9?
[14:18] <mup> PR pc-amd64-gadget#34 closed: Makefile: add "regex" to the modules for the non-uefi grub <Created by mvo5> <Merged by xnox> <https://github.com/snapcore/pc-amd64-gadget/pull/34>
[14:46] <mborzecki> zyga: do you have any graphical snaps on TW? like gnome-logs, gnome-calculator?
[14:46] <mborzecki> zyga: if so, do the fonts render correctly?
[14:47] <zyga> yes
[14:47] <zyga> let me check
[14:47] <mup> PR snapd#8125 opened: data/selinux: unify tabs/spaces <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/8125>
[14:47] <zyga> mborzecki: ^ can you look at that quickly please
[14:48] <zyga> booting tw
[14:50] <zyga> mborzecki: gnome-calcuator runs ok
[14:50] <zyga> well
[14:50] <zyga> almost
[14:50] <zyga> the x in the corder is broken
[14:50] <zyga> (close window)
[14:51] <zyga> gnome-logs also works and has the same issue
[14:56] <mborzecki> zyga: hm i still get boxes instead of fonts
=== alan_g is now known as alan_g_
[15:14] <zyga> back with tea
[15:14] <zyga> mborzecki: hm
[15:15] <zyga> I should install arch and try
[15:15] <zyga> mborzecki: did you you try to debug it?
[15:31] <pstolowski> oh well travis is super slow
[15:34] <mvo> yeah, it's terrible when trying to make a release
[15:35]  * zyga goes for lunch/dinner 
[16:30] <zyga> back
[16:30] <zyga> funny day - everyone had something else for dinner
[16:31] <zyga> mvo: any luck with the release?
[16:41] <mup> PR snapd#8126 opened: release: 2.43.3 <Created by mvo5> <https://github.com/snapcore/snapd/pull/8126>
[16:43] <mvo> zyga: it's almost out
[16:44] <zyga> I see the tarball
[16:44] <zyga> I'll make a suse package
[16:45] <mvo> I need to create the proper github release but in a meeting right now so a bit slow
[16:45] <zyga> ah wait, I didn't read the github page properly
[16:45] <zyga> sure
[16:45] <zyga> I'll wait
[16:45] <mvo> zyga: should be ready in ~15min
[16:48] <mvo> zyga: please have a look
[16:48] <zyga> looking
[16:48] <zyga> yep
[16:48] <zyga> making the package now
[16:48] <zyga> thank you :)
[16:51] <zyga> building
=== alan_g_ is now known as alan_g
[17:02] <zyga> suse updated
[17:02] <zyga> there's a small patch back to master
[17:02] <zyga> I'll open it shortly
[17:14] <zyga> jdstrand: can you try to look at https://github.com/snapcore/snapd/pull/8113 and https://github.com/snapcore/snapd/pull/8123 (they form a either-or pair)
[17:15] <mup> PR #8113: cmd/snap-confine: bring /var/lib/dhcp from host, if present (approach a) <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8113>
[17:15] <mup> PR #8123: interfaces/network-control: bring /var/lib/dhcp from host (approach b) <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8123>
[17:16] <zyga> huh
[17:16] <zyga> Feb 12 15:50:58 feb121515-669259 systemd[5577]: snapd.service: Failed to execute command: Exec format error
[17:16] <zyga> Feb 12 15:50:58 feb121515-669259 systemd[5577]: snapd.service: Failed at step EXEC spawning /snap/snapd/x2/usr/lib/snapd/snapd: Exec format error
[17:16] <zyga> mvo: ^
[17:16] <zyga> I'm seeing this in CI
[17:27] <mvo> zyga: uh, related to the release?
[17:35] <mvo> cachio: 2.43.3 snapd snap is in beta now, 2.43.3 core should be available soon
[17:35] <cachio> mvo, nice, I'll start right now
[17:35] <cachio> thnaks
[17:35] <mvo> cachio: thank you!
[17:37] <mup> PR snapcraft#2933 opened: remote-build: introduce --launchpad-snapcraft-channel option <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2933>
[18:02] <pedronis> mvo: did you backport the minor nvidia version fix?
[18:08] <mvo> pedronis: it's not in
[18:09] <mvo> pedronis: which is slightly silly, I was too cautious before and then forgot
[18:09] <pedronis> it's ok I suppose, but checked because I was confused when looking at the changelog
[18:10] <mvo> pedronis: yeah, we talked about adding it
[18:10] <mvo> pedronis: and I was unsure (a bit) and did not cherry pick right away and then it felt through the cracks
[18:12] <mup> PR snapd#8121 closed: spread: move centos to stable systems <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8121>
[18:15] <ogra> heh, funny ... "snap find 'screen recorder'" finds xonotic ... i wonder why
[18:19] <techalchemy> zyga, thanks for the fix!
[18:38] <jdstrand> zyga: those aren't showing up in https://github.com/snapcore/snapd/pulls/review-requested/@me (for me :)
[18:38] <jdstrand> zyga: please add the 2.44 milestone if you want them there unless you are seeing these are emergency
[18:49] <cachio> ijohnson, hey
[18:50] <cachio> I updated the spread pr
[18:50] <cachio> the problem with the tests is that there is not unit tests at all for google backend
[18:51] <cachio> ijohnson, for testing what I did is to use the -vv command for spread and iterate over differnt images to see if the selected is the desired one
[18:51] <cachio> ijohnson, the problem is that the images change over time
[18:51] <cachio> so it is difficult to test that in a spread test d
[20:18] <cachio> zyga, when you have time could you please take a look to https://github.com/snapcore/snapd/pull/7900
[20:18] <mup> PR #7900: tests: do reset of tests during restore and add checks to validate the fs <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7900>
[20:18] <cachio> I remember you developed a tool
[20:28] <zyga> jdstrand: ack, not an emergency, just curious choice
[20:28] <zyga> techalchemy: pleasure :-)
[20:29] <zyga> cachio: sure, I’ll look in an hour
[20:29] <cachio> zyga, thanks
[21:09] <zyga> cachio: looks very interesting, I will review it in detail first thing tomorrow
[21:09] <zyga> Today is too late for a detailed review
[21:09] <zyga> I have some comments but I am happy to see progress on robustness
[21:11] <cachio> zyga, nice, thanks
[21:11] <cachio> it needs some improvements but I think it could help
[21:11] <cachio> zyga, see you tomorrow