/srv/irclogs.ubuntu.com/2020/02/14/#snappy.txt

mupPR snapcraft#2937 closed: spread tests: do not attempt to remove snapd snap <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2937>00:25
mupPR snapcraft#2938 closed: remote build: default to snapcraft's stable channel <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2938>00:28
mupPR pc-amd64-gadget#35 opened: grub.cfg-boot: drop compatibility mode <Created by anonymouse64> <https://github.com/snapcore/pc-amd64-gadget/pull/35>02:35
mborzeckimorning06:23
mborzeckiMake current revision for snap "snapd" unavailable ([--root / is-active snapd.core-fixup.service] failed with exit status 3: failed06:42
mborzeckiseen this one before06:42
mborzeckihmm maybe we should ignore the stderr/stdout when calling systemctl is-active and just look at the exit code06:52
mborzeckiquick errand, some utility guys coming over, hopefully they'll be gone in 30 mins or so06:55
mborzeckire07:36
mborzeckimvo: hey07:59
mupPR snapd#8132 opened: systemd: improve is-active check for 'failed' services <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8132>07:59
pstolowskimorning08:04
mborzeckipstolowski: hey08:04
zygasnow :)08:06
mvogood morning pstolowski mborzecki and zyga08:06
mborzeckizyga: hey, snow? got plenty of rain here :)08:07
zygalet's hope today is more productive08:07
pstolowskio/08:07
zygamborzecki: yeah, there's even nice patches on the ground08:07
zygais it freezing?08:07
zygasupposedly +1 so no08:07
zygaoh well08:07
pstolowskizyga: snow, but melting away immediately08:08
mborzeckisimple pr to start your morning with #813208:08
mupPR #8132: systemd: improve is-active check for 'failed' services <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8132>08:08
zygamborzecki: ha08:09
zygaremember when you told me about that dhcp thing08:09
zygathat it failed for you08:09
zygasuprirse08:09
zygait really only fails on arch, out of all the systems08:09
* zyga runs and see why08:09
mvopstolowski: 8128 LGTM, do you want to merge it?08:36
pstolowskimvo: merged, thank you!08:38
mupPR snapd#8128 closed: o/devicestate: StartOfOperationTime helper for Prune (1/2) <Needs Samuele review> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/8128>08:38
zygamborzecki: can you re-review https://github.com/snapcore/snapd/pull/8123/files09:16
mupPR #8123: interfaces/network-control: bring /var/lib/dhcp from host (approach b) <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8123>09:16
zygait's updated and passes on arch09:16
zygajust want to ack the new permissions09:16
mupPR snapd#8133 opened: cmd/snap-confine: allow snap-confine to load nss libs <Created by zyga> <https://github.com/snapcore/snapd/pull/8133>09:20
zygamborzecki: ^ this is a RFC-ish09:23
zygamore to raise awareness09:23
zygaI don't expect it will land09:23
zygamborzecki: was there a bug report on https://github.com/snapcore/snapd/pull/8132?09:47
mupPR #8132: systemd: improve is-active check for 'failed' services <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8132>09:47
zygapstolowski: there's a conflict on https://github.com/snapcore/snapd/pull/8120 and on https://github.com/snapcore/snapd/pull/804609:51
mupPR #8120: cmd/snap-preseed: snapd version check for the target <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8120>09:51
mupPR #8046: many, tests: integrate all preseed bits and add spread tests <Complex> <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8046>09:51
pstolowskizyga: thanks, i'm switching back to these PRs after de-tour with #8130 (prune tests are tricky)09:53
mupPR #8130: overlord, state: don't abort changes if spawn time before StartOfOperationTime (2/2) <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8130>09:53
zygasure :-)09:53
zygamborzecki: I ported parts of the desktop interface over to common10:00
mborzeckizyga: nice!10:00
zygamborzecki: but only the simple parts, I'll do more once the prereq lands10:00
mborzeckizyga: as for 8132, afaik there was no bug reprot, noticed that in a failed spread run today10:01
zygamborzecki: https://github.com/snapcore/snapd/pull/813410:01
mupPR #8134: interfaces: use commonInteface for desktopInterface <Created by zyga> <https://github.com/snapcore/snapd/pull/8134>10:01
zygamborzecki: ok, I wanted to cross-reference if there was one, no worries10:01
zygamborzecki: ^ this one can be reviewed and merged separately from the rest10:01
mupPR snapd#8134 opened: interfaces: use commonInteface for desktopInterface <Created by zyga> <https://github.com/snapcore/snapd/pull/8134>10:01
mborzeckibtw. to my surpise snapd.core-fixup.service was in failed state on 20.04, but it should `exit 0` if not running on ubuntu core10:02
zygaohhh10:02
zygathat's weird10:02
zygawhat's the condition?10:02
zygapedronis: please review 8123 if you can10:03
zygapedronis: I applied your suggestions and I think this is the right way forward indeed10:03
* zyga breakfast10:03
mupPR snapd#8135 opened: bootloader: make uboot a RecoveryAwareBootloader <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8135>10:24
pstolowskipedronis: updated/replied on  #804610:26
mupPR #8046: many, tests: integrate all preseed bits and add spread tests <Complex> <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8046>10:26
mupPR snapd#8131 closed: boot: add current_kernels to modeenv <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8131>10:35
mupPR snapd#8132 closed: systemd: improve is-active check for 'failed' services <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8132>10:37
zygamvo: ^ I added a comment to consider that for stable10:38
zygamvo: up to you to decide10:38
mvozyga: good point10:39
mupPR snapd#8060 closed: gadget: skip update when mounted filesystem content is identical <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8060>10:39
mvozyga: cherry-picked10:39
zygathank you!10:39
zygasnapd failover failed again11:29
zygais anyone looking at fixing that?11:29
zygahttps://www.irccloud.com/pastebin/ZHsaJSrS/11:29
zygamore debug notes11:29
zygahttps://www.irccloud.com/pastebin/fyoWz9Pr/11:29
zygathen more log spam11:31
zygahttps://www.irccloud.com/pastebin/HtomsMSS/11:31
zyga(that last one is repeated heavily)11:31
zygamborzecki: ^ IIRC you asked for logs before11:31
zygado you want more or shall I kill this run?11:32
zygaI'll make coffee11:34
zygamvo: I may skip standup today, I'll let you know11:35
mupPR snapd#8136 opened: boot: write current_kernels in bootstate20, makebootable <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8136>11:36
ijohnsonthanks for the merge on 8131, I opened the followup https://github.com/snapcore/snapd/pull/8136 just now11:36
mupPR #8136: boot: write current_kernels in bootstate20, makebootable <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8136>11:36
* ijohnson disappears for a couple hours11:39
mupPR snapcraft#2935 closed: build providers: remove tzdata workaround <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2935>11:56
mborzeckicmatsuoka: hi12:04
* pstolowski lunch12:08
cachioxnox, hi, I am trying to test the image in http://cdimage.ubuntu.com/ubuntu-core/20/pending/12:19
cachioxnox, using kvm12:19
cachioI can make that work12:20
cachiois there any specific parameter for kvm/qemu which I need to use?12:20
xnoxcachio:  yes13:25
xnoxyou need ovmf from focal; secureboot firmware; qc35 machine type; snakeoil variables13:25
xnoxcachio:  i use virtmanager desktop gui app to elect secureboot / tpm and override variables with snakeoil vars.13:26
xnoxi guess we should document this somewhere.13:26
xnoxotherwise from cmdline it is something like this13:26
cachionice, I'll try that and if it works I'll add that to our snapd testing docs13:26
xnoxsudo kvm -smp 4 -m 2048 -machine pc-q35-4.0 -global ICH9-LPC.disable_s3=1 -drive file=/usr/share/OVMF/OVMF_CODE.secboot.fd,if=pflash,format=raw,unit=0,readonly=on -drive file=OVMF_VARS.snakeoil.fd,if=pflash,format=raw,unit=1 -drive file=pc.img,if=none,format=raw,id=disk1 -device virtio-blk-pci,drive=disk1,bootindex=113:26
cachioxnox, owesome, thanks13:27
xnoxso /usr/share/OVMF/OVMF_CODE.secboot.fd is simply readonly13:27
xnoxbu tthe OVMF_VARS.snakeoil.fd is a "per-VM UEFI variables store" which should be started with like $ cp /usr/share/OVMF/OVMF_VARS.snakeoil.fd my-VM-VARS.fd13:27
xnoxcause we pre-built what the initial variables / uefi status should be13:28
cachioxnox, nice13:30
cachioxnox, I'll try it13:30
cachioxnox, thanks13:30
xnox(the vars have pre-enrolled settings to enforce secureboot, and have the keys currently used for signing enrolled)13:33
cachioxnox, is it any way to get /usr/share/OVMF/OVMF_CODE.secboot.fd on bionic?13:41
cachioor it is just available on focal?13:41
cachioI'll create a vm with focal to test is13:42
zygamvo: I'm making good progress on OOM handling13:45
zygamvo: I'll skip standup as I'm in a car seat going with folks for lunch13:46
xnoxcachio:  you can download ovmf package from launchpad from focal and install it.13:46
zygamvo: I'll have some demo code on Monday, I hope, running in spread13:46
xnoxcachio:  it's an arch:all package with prebuilt static contents13:46
xnoxcachio:  why are you on bionic still instead of focal?13:46
zygamvo: I'm tweaking services so that we can regen services easily with extra entries13:46
cachioxnox, I'll try that13:47
zygamvo: I still haven't thought of a better way to surface this13:48
zygamvo: so I'm going ahead with "snap set core oom-protect ..."13:48
zygamvo: I'll send two small patches that build towards that, one to snap.Info and one to wrappers13:51
ijohnsonhello again folks13:52
zygamvo: and other than that I'll focus on trying to set oom score and write a test that shows how a memory hog cannot kill a protected service13:54
zygamvo: and that's my update, I'll keep hacking until we arrive for dinner and then after that13:55
zygamborzecki: ^ FYI if you are interested in changes to wrappers13:55
ijohnsonzyga: also I saw that snapd failover test failure last night and was looking into it13:56
zygaijohnson: thank you, I am not looking into it13:56
zygaijohnson: so if you want to dive in please do13:57
ijohnsonyes it's on my list for today13:57
zygaijohnson: I kept a failed log on https://github.com/snapcore/snapd/pull/813313:57
mupPR #8133: cmd/snap-confine: allow snap-confine to load nss libs <Created by zyga> <https://github.com/snapcore/snapd/pull/8133>13:57
ijohnsonthanks13:57
zygagreat, thanks13:57
ijohnsonmvo: looking at 8135, will we need uboot to implement ExtractedRunKernelImageBootloader as well as RecoveryAwareBootloader in order to have uc20 support there?14:39
mvoijohnson: yes,  I think you are right14:46
ijohnsonmvo: perhaps your PR is enough to unblock foundations with setting up a uc20 gadget snap however14:46
mvoijohnson: yeah, that was my hope14:47
mvoijohnson: give them something to play with14:47
ijohnsonmvo: but makebootable20RunMode will fail if there's not an ExtractedRunKernelImageBootloader available, so probably the image won't get past install mode14:47
ijohnsonmvo: ok, if you like I can work on that with foundations when they get farther along the process ?14:47
mvoijohnson: that sounds acceptable for now, they need to first write the right uboot.env14:47
mvoijohnson: \o/ that would be most welcome14:48
ijohnsonack14:48
mupPR snapd#8137 opened: tests: skipping interfaces-openvswitch on centos due to package is not available <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8137>15:06
* cachio bank & lunch15:14
mupPR snapcraft#2939 opened: pluginhandler: user directories scoped to partdir for snapcraftctl <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2939>15:15
mupPR snapd#8138 opened: snap/info: add SnapRevisionFileName <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8138>16:02
pedronisijohnson: mvo: finishing the current boot stuff is probably higher priority as long as they are unblocked for a bit16:13
mupPR snapd#8135 closed: bootloader: make uboot a RecoveryAwareBootloader <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8135>16:13
mvopedronis: ack16:14
ijohnsonack16:14
zygamaciek is off already16:21
zygaah, right16:21
zygaoh well :)16:21
zygapedronis: I replied to the unrestricted path extension question https://github.com/snapcore/snapd/pull/8123#discussion_r37952624416:30
mupPR #8123: interfaces/network-control: bring /var/lib/dhcp from host (approach b) <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/8123>16:30
pedroniszyga: are you saying that with that change a layout can now create directories under /var in the host?16:35
pedronisasked in the PR as well16:36
zygapedronis: layouts cannot create anything in /var/lib/snapd/*, which includes hostfs, it would allow a snap to create a directory on the host if that location is bridged with snap-confine's default set - this includes /var/snap (but that is black-listed from layouts), /var/lib/snapd (also black-listed), /var/tmp (allowed), /var/log (allowed) and finally /var/lib/extrausers (allowed)16:40
zygaI'll paste this response to the PR16:40
zygapedronis: (to be precise, users cannot request a layout, not that layouts cannot create)16:42
zygapedronis: interestingly, /var/log snap-confine-made, fixed mount, is marked with a TODO, asking to move it to an interface16:44
zygapedronis: I think the approach is right but perhaps we need to investigate the unrestricted path more16:44
zygapedronis: here we _do_ want it (in /var/lib/dhcp) because otherwise we'll end up with a mimic16:44
zygapedronis: but the point of the interface is to expose _real_ /var/lib/dhcp to the snap, creating it if necessary16:44
zygapedronis: I would be happy with a special case that says var/lib/dhcp can be made16:45
zygaand continue the investigation into what is exactly allowed per interface, akin to what Maciek hinted at16:45
pedroniszyga: to be clear I'm slightly less worried about interfaces, my worry is layout, whether we have enough checks in place, not to make something odd happens16:45
pedronisif we change something there16:45
pedronisbecause the new unrestriction16:45
zygapedronis: so, users cannot request a layout to /var/lib/snapd/hostfs/* so the answer is that it is not something that interacts with layouts directly16:46
zygapedronis: and actually, thinking about it now16:47
zygapedronis: my comment was incorrect - given that layouts and snap-confine made mount points don't interact16:48
zygapedronis: this doesn't change anything layouts can make16:48
zygapedronis: I was confused because if you put a layout from $SNAP/foo to /var/lib/foo16:48
zygathat feels like it might interact16:48
zygabecause perhaps /var/lib/foo is bridged by snap-confine to the host16:48
zygabut that's irrelevant for /var/lib/snapd/hostfs/var/ that is allowed16:48
zygabecause /var/lib/foo is not in a prefix of hostfs, you end up with a mimic16:49
zygaas such I think this is safer than I assumed, since nothing apart from snapd code can request new hostfs entries16:49
zyga(I added this to the PR thread)16:50
pedronisthx, I'll reread on Monday morning at this point16:51
zygathank you, that's a good idea :)16:51
zygapedronis: I would like to see a more central system for permissions16:52
zygapedronis: some of it is in layout validation16:52
zygapedronis: some in appamor on snap-confine16:52
zygapedronis: we should think about what we'd like to make explicit16:52
pedronisyea, it all feels very disjoint, no clear suggestion atm though16:52
zygaand also some in snap-update-ns trespassing exceptions16:52
zygayeah, spanning C, apparmor and two Go parts (one with state access one without)16:53
zygabut I agree that it would be good to make it easier to see at a glance16:53
zygaperhaps a shared go package that just list stuff that both snapd and snap-update-ns import and use16:53
zygaand even generated .c for snap-confine16:53
zygaor something along those lines16:53
* zyga just unblocked a lot of progress17:25
zygasssheeesh :)17:25
* zyga EODs17:31
ijohnsoncachio: do you in spread if there's an easy way to "skip" a test? for example I have a test with environment variable variants and on uc18 with one of the variants it doesn't make sense to run, so I want to skip that one17:49
ijohnsoncachio: what I did was just `if ...; then echo "skip"; exit 0; fi` is that a good way to do that?17:50
cachioijohnson, you want to skip a variant on a specific system right?17:50
ijohnsonyes17:51
ijohnsonwhat I have works, just wondering if there's a more elegant way to do this17:51
cachioijohnson, the if solution is the one we use for those cases17:51
cachioas you did17:51
ijohnsonokay, so what I have is the right thing to do17:51
ijohnsonthanks!17:51
cachioI have a pr for that but it is not approved17:52
cachioto create run conditions17:52
cachioso you write the if but just once17:52
cachiohere you need to add that if in the prepare, execute and restore17:52
ijohnsonyeah right, that would be nice17:55
=== ijohnson is now known as ijohnson|lunch
mupPR snapd#8139 opened: interfaces/{desktop-legacy,unity7}: adjust for new ibus socket location <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8139>19:40
mupIssue pc-amd64-gadget#36 opened: Broken kernel.efi does not reboot automatically <Created by anonymouse64> <https://github.com/snapcore/pc-amd64-gadget/issue/36>19:55
=== sergiusens_ is now known as sergiusens
zygakenvandine: FYI https://bugs.launchpad.net/snapd/+bug/186325521:21
mupBug #1863255: Programs installed in Snap format do not detect the keyboard  <amd64> <apport-bug> <focal> <package-from-proposed> <snapd:New> <snapd (Ubuntu):Confirmed> <https://launchpad.net/bugs/1863255>21:21
zygakenvandine: not sure if this is widespread but my 20.04 system doesn't have working keyboard input in some graphical snap apps21:22
zygakenvandine: and someone just reported a bug that's similar21:22
kenvandineoh interesting21:22
zygaWimpress: ^21:22
kenvandinelike what apps?21:22
zygakenvandine: I tried irccloud-desktop21:22
* kenvandine looks at bug21:22
zygawasn't able to type my email address21:22
kenvandinei'm using irccloud-desktop right now21:23
kenvandineworking fine21:23
kenvandineweird21:23
zygathe reporter tried spotify, thunderbird and superproductivity21:23
zygaI suspect it depends on classic vs strict21:23
zygabut something is wonky21:23
zygaweird21:23
zygaI had a fresh insstall21:23
zygaI tried wayland and x21:23
zygaall up to date21:23
zygasomething to chase next week21:24
zygabut just wanted to give you a note21:24
Wimpresszyga: I've been using 20.04 daily for weeks.21:24
WimpressAnd have dozens of snaps that I rely on.21:24
WimpressNot experienced that issue.21:24
zygaWimpress: hmmm hmm hmm21:24
zygamust be something in fresh vs updated installs21:24
zygaI wonder what could be a factor21:25
zygainput stack is such a mystery to me21:25
zygaWimpress: can you create a new user account and try if they work there?21:25
zygamaybe that gives you a pristine config21:25
WimpressNot right now. But I'll make a note to test.21:28
zygathanks, I'll  try some more as well21:28
zygathank you guys!21:28
mupPR snapcraft#2940 opened: build providers: remove use of cloud-init <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2940>21:46
=== heather1 is now known as hellsworth
mupPR snapcraft#2941 opened: [WIP] extensions: add cleanup extension <Created by galgalesh> <https://github.com/snapcore/snapcraft/pull/2941>22:28
mupPR snapd#8138 closed: snap/info: add Filename <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8138>23:05
mupPR snapcraft#2942 opened: pluginhandler: do not search installdir or stagedir for dependencies <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2942>23:07
=== ijohnson|lunch is now known as ijohnson
mupPR snapd#8140 opened: [DRAFT] tests: add more UC20 tests <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8140>23:09
mupPR snapcraft#2943 opened: spread: capture developer debug information <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2943>23:22

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!