tlm | hey kelvinliu_ what version of k8s.io should we be running at the moment in juju based on your last PR ? | 00:12 |
---|---|---|
kelvinliu_ | tlm: 1.17 | 00:13 |
tlm | ta think I did a bad merge | 00:13 |
kelvinliu_ | the current version is comentted in the toml file | 00:14 |
kelvinliu_ | ah? | 00:14 |
tlm | all good will squash mine with develop | 00:15 |
kelvinliu_ | ok | 00:15 |
timClicks_ | wallyworld: did moving the links to the bottom of the install page make things easier for you to update the installer links? | 02:17 |
wallyworld | timClicks_: not sure, i exepcted to find them where they appeared in the final render and had to go hunting for them | 04:11 |
wallyworld | but maybe that was a first time thing | 04:12 |
anastasiamac | babbageclunk: PTAL https://github.com/juju/juju-restore/pull/5 | 04:33 |
babbageclunk | ting an l | 04:33 |
anastasiamac | :) | 04:34 |
timClicks_ | wallyworld: you must have missed that comment at the top .. "ARE YOU UPDATING THIS DOCUMENT WITH A NEW RELEASE? Ctrl+F "LINKS TO CHANGE"" | 04:52 |
wallyworld | i did | 04:55 |
wallyworld | my fist instinct is to change stuff in situ so i can see the output on the rhs pane | 04:56 |
wallyworld | and you think boys read directions? :-D | 04:56 |
anastasiamac | yes, m sure boys do :) | 04:58 |
anastasiamac | also they r very good when given a to-do list :) | 04:58 |
anastasiamac | babbageclunk: \o/ thnx :) i've addressed and will land | 05:20 |
kelvinliu_ | wallyworld: im still working on the extend fileset stuff, i don't think i will have time to do the focal build today, should I do it tmr or handover to someone else? | 05:49 |
wallyworld | let's leave for now | 05:49 |
wallyworld | we need to solve before 2.7.3 at the latest, would be nice to do for 2.7.2 is something quick | 05:50 |
wallyworld | *if | 05:50 |
zeestrat | timClicks_: re plugins, I have a small port forwarding plugin for troubleshooting because I run my local dev inside Vagrant. | 06:00 |
kelvinliu_ | ok | 06:13 |
timClicks_ | zeestrat: that's neat | 07:26 |
hpidcock | wallyworld: if you get a chance to give the green tick on https://github.com/juju/juju/pull/11214 that would be awesome | 07:48 |
wallyworld | will do, wiull look now and after dinner if i don't get it done immediately | 07:52 |
wallyworld | hpidcock: gotta run for dinner, left 2 comments, back in an hour or so | 07:59 |
achilleasa | manadart: the test from https://github.com/juju/juju/commit/d8666bd39bb1401ecc95d7144e3cf2429549fc15 probably needs jc.SameContents; I am occasionally getting https://paste.ubuntu.com/p/bsHMQPz7Gy. I will add a drive-by fix in the PR I am working on ATM | 09:25 |
manadart | achilleasa: Ack. Thanks. | 09:26 |
stickupkid | manadart, you see this https://discourse.jujucharms.com/t/juju-2-7-2-release-notes/2667/2?u=simonrichardson | 09:29 |
stickupkid | that should have been, "have you seen this" - need some wake up juice | 09:32 |
manadart | stickupkid: I gave him a work-around in another post. I will follow up. | 09:32 |
manadart | https://discourse.jujucharms.com/t/juju-upgrade-controller-fails-space-not-found/2559/13 | 09:32 |
nammn_de | manadart: time later for a cr on this one? https://github.com/juju/juju/pull/11183 | 09:44 |
nammn_de | Just for heads up, I talked to rick_h yesterday about move-to-space, so it will come up during daily again as we weren't 100% sure about some possible outcomes | 09:44 |
manadart | nammn_de: I will look when I can. | 09:45 |
nammn_de | manadart: sure, take your time. Thanks! | 09:48 |
stickupkid | achilleasa, on your travels in spaces etc, did you see any place where we generated random names/ids | 11:03 |
* stickupkid wonders if names repo does this | 11:04 | |
stickupkid | I'm loathed to use https://github.com/juju/utils/blob/master/randomstring.go | 11:07 |
achilleasa | stickupkid: random? nothing rings a bell | 11:07 |
stickupkid | manadart, random string of 8 chars of go full bore on a uuid | 11:07 |
manadart | stickupkid: I say 8 chars. 2 UUIDs is a bit long. BTW, your patch was hanging at "starting" for me. I am working off this change set ATM: https://pastebin.ubuntu.com/p/fKMYwt3mgH/ | 11:10 |
stickupkid | manadart, k, will fix | 11:11 |
stickupkid | manadart, applied the patch, but these are annoying changes | 11:18 |
stickupkid | -for k, subnetIDs := range subnetIDsForZone { | 11:18 |
stickupkid | +for i, subnetIDs := range subnetIDsForZone { | 11:18 |
stickupkid | :| | 11:18 |
manadart | stickupkid: Change it back. I don't care. | 11:23 |
stickupkid | manadart, haha | 11:23 |
manadart | stickupkid: I realise it's a map not a slice, so I needn't have changed it. | 11:24 |
stickupkid | manadart, i've fixed the tests | 11:24 |
manadart | stickupkid: BTW, it looks like we have to omit both external and FAN networks in our considerations. | 11:26 |
stickupkid | manadart, I've landed your patch with the test fixes https://github.com/juju/juju/pull/11188 | 11:27 |
manadart | stickupkid: OK. I will update here and work off your changes. Still debugging. | 11:29 |
manadart | stickupkid: Boom. https://pastebin.ubuntu.com/p/ct6SkQWf6c/ | 11:56 |
stickupkid | WOW | 11:57 |
stickupkid | manadart, ho? | 11:57 |
stickupkid | manadart, https://github.com/go-goose/goose/pull/78 | 12:13 |
manadart | jam: Do you have permission to merge there? ^ | 12:19 |
rick_h | morning party folks | 12:39 |
rick_h | stickupkid: what are we giving random names to? | 12:40 |
stickupkid | rick_h, port name for openstack, needs to be namespaced by a model uuid and a network id, but also some random bit, as we don't have the instance id yet | 12:54 |
rick_h | stickupkid: just uuid them? do we care? | 12:55 |
rick_h | guess that gets to be crazy with double uuids already there lol | 12:56 |
stickupkid | yeah, bingo | 12:56 |
rick_h | hah | 12:56 |
stickupkid | rick_h, gets it | 12:56 |
stickupkid | :) | 12:56 |
stickupkid | it's like crazy uuid town | 12:56 |
rick_h | I can haz uuids! ALL the uuids! | 12:57 |
stickupkid | hahaha | 12:57 |
stickupkid | yeah | 12:57 |
rick_h | stickupkid: so there's > 1 per machine/unit. so unit tag + int? | 12:57 |
* rick_h runs the boy to school, back in a couple | 12:58 | |
stickupkid | rick_h, i'll see if that info readily available, otherwise I've got a nice compromise atm | 12:58 |
rick_h | stickupkid: awesome ok | 13:17 |
stickupkid | manadart, fan type filtering has landed | 14:15 |
manadart | stickupkid: OK. | 14:17 |
hml | achilleasa: proved that calling dispatch for actions on k8s units is all that’s needed. making that work outside of spike will be more interesting. :-) | 14:56 |
stickupkid | manadart, food for thought? https://github.com/juju/juju/pull/11188#discussion_r381348454 | 15:02 |
stickupkid | manadart, updated | 16:16 |
achilleasa | Can I get a CR+QA on https://github.com/juju/juju/pull/11233? | 16:17 |
achilleasa | rick_h: do you think I should backport ^^^ for 2.7.3? | 16:17 |
hml | achilleasa: looking | 16:18 |
rick_h | achilleasa: looking | 16:32 |
rick_h | achilleasa: hmmm...I'm nervous about a change in behavior fallout but guess we're wanting it anyway | 16:32 |
rick_h | achilleasa: so I've talked myself into +1 to backport | 16:33 |
achilleasa | rick_h: I am not sure if you are ever supposed to use the command that particular way so perhaps noone will notice ;-) | 16:34 |
rick_h | achilleasa: yea, that's what I got to as well | 16:37 |
manadart | stickupkid: Will look in bit. OK to merge if you are not around? | 16:50 |
stickupkid | to late, kicked off the merge | 16:50 |
stickupkid | :p | 16:50 |
hml | achilleasa: approved, but have a question about leadership in reliation to this fix, in the pr | 16:52 |
achilleasa | hml: if you still have your test controller up, add another mysql unit and juju run the cmd on that | 16:53 |
hml | achilleasa: already done. | 16:53 |
hml | achilleasa: it was more a question of how to tell in the code change. the description says it, but how do i know in the code? | 16:54 |
achilleasa | ah... well, all application setting reads are guarded via a token checks; the check for reading happens here: https://github.com/juju/juju/blob/develop/apiserver/facades/agent/uniter/uniter.go#L1580-L1600 | 16:58 |
hml | achilleasa: ah, okay. ty | 16:58 |
achilleasa | writes are guarded via this decorator: https://github.com/juju/juju/blob/develop/state/leadership.go#L50 | 16:59 |
achilleasa | hml: can you also sanity check https://github.com/juju/juju/pull/11234 (backport to 2.7). I am also running the QA steps again with this branch on lxd | 17:15 |
hml | achilleasa: sure | 17:15 |
hml | achilleasa: looks the same to me - approved | 17:17 |
babbageclunk | thumper: I'm changing github.com/juju/utils/tar - should I extract it to juju/tar? | 23:16 |
anastasiamac | babbageclunk: m not thumper but i think it's woarth it (and follows hat we r trying to do with other juju/utils)... so insignificantly but +1 | 23:20 |
babbageclunk | anastasiamac: that counts! I'll need a wallyworld or thumper -alike to make the repo though | 23:21 |
anastasiamac | babbageclunk: :) | 23:22 |
babbageclunk | So I'll do it in-place for now | 23:22 |
rick_h | babbageclunk: https://github.com/juju/tar | 23:29 |
babbageclunk | rick_h: oh awesome, thanks wallyworld- and thumper-alike! I'd have pinged you but I didn't think you were still around | 23:30 |
thumper | babbageclunk: yep, do it | 23:30 |
* babbageclunk does it | 23:31 | |
* thumper needs to think about food... | 23:31 | |
thumper | maybe | 23:31 |
babbageclunk | dammit now you've got me thinking about food | 23:31 |
thumper | babbageclunk: I've decided to fast through lunch... | 23:32 |
thumper | perhaps I'll eat later | 23:32 |
thumper | I have many calls this afternoon, and I'm behind on email | 23:32 |
thumper | I ate last night, I'm fine | 23:32 |
anastasiamac | wow stoic | 23:34 |
hpidcock | thumper: I've been doing 18hour fasts everyday... I know them feels | 23:46 |
thumper | hpidcock: working for you? | 23:47 |
hpidcock | thumper: yep, lost some weight, but more importantly, more energy for the day. | 23:48 |
thumper | hpidcock: the stability of the energy is a big part | 23:48 |
* thumper out for physio, bbl | 23:49 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!