[10:21] <nikolam> I have a problem that transmission-gtk does not honor maximum number of IP connections. It quickly eats all 2000 connections that the wireless router giver for NAT and then all internet traffic halts, icluding torrents
[10:27] <tomreyn> according to https://github.com/transmission/transmission/wiki/Editing-Configuration-Files the default "peer-limit-global" is 240.
[10:27] <tomreyn> (and 60 per torrent)
[10:27] <nikolam> yes, but it does not honors it.
[10:28] <nikolam> I have a dd-wrt router serving local network and I can show on it's information how number of connections grows forever
[10:28] <tomreyn> hmm, maybe check with folks in #transmission. and look for a bug, or file one, against ubuntu
[10:28] <nikolam> someone responded having same version on Debian and not doing same thing.
[10:30] <tomreyn> where did you set peer-limit-global? is this editable on the GUI?
[10:30] <nikolam> yes, it's available in transmission-gtk GUI
[10:31] <tomreyn> i see. maybe you can check whether it's actusally written to the configuration files. there should be $HOME/.config/transmission-daemon and $HOME/.config/transmission and i assume this setting needs to be configured in the daemon configuration file.
[10:32] <tomreyn> (but i'm not certain on that)
[10:32] <tomreyn> (so check both)
[10:32] <tomreyn> you'd also need to restart the component (client or daemon) which you reconfigured.
[10:34] <tomreyn> see also https://github.com/transmission/transmission/wiki/Configuration-Files and https://github.com/transmission/transmission/wiki/Editing-Configuration-Files
[10:35] <nikolam> there's /home/username/.config/transmission and there is "peer-limit-global": 500 in it, I have previously set it to like 350 or so
[10:35] <nikolam> it is gui app I don't think it uses daemon
[10:37] <tomreyn> you seem to be right there - apparently you either use the gtk application or the daemon, not both.
[10:37] <tomreyn> i'm not too much into transmission
[10:39] <tomreyn> so /home/username/.config/transmission should be the configuration file for the gtk / gui application. which is read and applied (only) when the application starts.
[10:40] <tomreyn> i.e. be sure to restart it after making changes
[10:41] <nikolam> it restarts but making many connections, more then limit.
[10:42] <tomreyn> i'm afraid i told you all that i know / could quickly grasp
[10:43] <nikolam> yes, got to digg deeper, maybe recompile it or reset settings or see what it depends on
[11:22] <nikolam_> same happens with defautl settings for transmission-gtk. will keep looking
[13:27] <RonaldsMazitis> so I downloaded thunar source code in order to look how could I add some icon besides "go to home folder" icon
[13:27] <RonaldsMazitis> it turns out, text "go to home folder" does not exist in source code
[13:27] <RonaldsMazitis> https://askubuntu.com/questions/337225/how-to-remove-a-default-action-in-thunar
[13:29] <RonaldsMazitis> well, if You remove one of array elements that said "delete" You can remove "delete" item from right click on file
[13:30] <RonaldsMazitis> it turns out, in open source code, You can't really even understand or edit the code, cause there are almost zero documentation on how to edit the code to add some feature
[13:31] <brainwash> you probably have to invest more time
[13:32] <RonaldsMazitis> I grep the whole source code
[13:32] <brainwash> let me try to find it
[13:33] <RonaldsMazitis> and there is no references on actual menu items
[13:34] <brainwash> https://git.xfce.org/xfce/thunar/tree/thunar/thunar-window.c#n377
[13:34] <RonaldsMazitis> for example, "find in this folder" is not mentioned nowhere in code, but it appears when You compile
[13:34] <brainwash> "find in this folder" is a custom action
[13:35] <RonaldsMazitis> and it's not in thunar-window.c
[13:35] <RonaldsMazitis> it's nowhere
[13:36] <brainwash> again
[13:36] <brainwash> this https://docs.xfce.org/xfce/thunar/custom-actions
[13:37] <brainwash> custom actions are added by distributions
[13:37] <brainwash> or the user
[13:38] <brainwash> https://git.xfce.org/xfce/thunar/tree/plugins/thunar-uca/uca.xml.in
[13:39] <brainwash> only the "Open Terminal Here" one provided by thunar
[13:39] <brainwash> is provided
[13:41] <RonaldsMazitis> ok
[13:42] <RonaldsMazitis> but what about "go to home folder
[13:42] <RonaldsMazitis> it does not exist
[13:42] <brainwash> well
[13:42] <brainwash> I already linked it
[13:42] <brainwash> https://git.xfce.org/xfce/thunar/tree/thunar/thunar-window.c#n377
[13:43] <RonaldsMazitis> where do You see open home folder there
[13:43] <RonaldsMazitis> the label is not there
[13:43] <brainwash> line 377
[13:44] <RonaldsMazitis> but that's not what written on label
[13:45] <brainwash> the label?
[13:45] <RonaldsMazitis> it appears when You put your mouse on home icon
[13:45] <brainwash> "Go to the home folder"
[13:46] <RonaldsMazitis> yeah
[13:46] <brainwash> then I don't understand
[13:46] <brainwash> line 377 contains that exact string
[13:46] <brainwash> { "open-home", "go-home-symbolic", N_ ("_Home"), "<alt>Home", N_ ("Go to the home folder"), G_CALLBACK (thunar_window_action_open_home), },
[13:46] <RonaldsMazitis> grep does not show it
[13:47] <RonaldsMazitis> ah
[13:47] <RonaldsMazitis> sorry
[13:48] <RonaldsMazitis> forget the
[14:18] <xubuntu34i> Hello! )
[14:19] <xubuntu34i> I love linux! And you?
[14:55] <RonaldsMazitis> static GtkActionEntry action_entries[] =
[14:55] <RonaldsMazitis> it's impossble to say what this method does
[14:56] <RonaldsMazitis> or where it is used
[14:56] <RonaldsMazitis> I mean array
[14:56] <RonaldsMazitis> C code does not make sense
[14:57] <RonaldsMazitis> action_entries is not used in any other code
[14:58] <RonaldsMazitis> there should be loop that draws buttons and takes array values, but there is not anything
[14:58] <RonaldsMazitis> all hail linux and open source, so open
[15:00] <brainwash> I think the problem is you
[15:01] <brainwash> maybe a lack of skill, maybe a lack of patience
[15:01] <lighterowl> RonaldsMazitis: there is no thing as "method" defined in C, or even C++ for that matter.
[15:01] <RonaldsMazitis> oh ok
[15:01] <lighterowl> and GtkActionEntry sounds like a struct/functor/function pointer to something that should be executed when an action is made by the user.
[15:02] <lighterowl> if open source code bothers you, I'll gladly refer you to my own company, where we maintain 30-year old C code.
[15:02] <lighterowl> s/my own company/company where I happen to work/
[15:02] <brainwash> the thunar code is probably only half that old :D
[15:03] <lighterowl> :)
[15:03] <brainwash> RonaldsMazitis: there are other file managers too. find the one which is easier to modify.
[15:03] <RonaldsMazitis> GtkActionEntry is nowhere mentioned
[15:03] <RonaldsMazitis> in the whole code base
[15:04] <brainwash> really?
[15:04] <brainwash> is your grep binary broken?
[15:04] <RonaldsMazitis> it's in several files
[15:05] <RonaldsMazitis> but it's always just for an array
[15:05] <lighterowl> RonaldsMazitis: https://api.gtkd.org/gtk.c.types.GtkActionEntry.html
[15:05] <lighterowl> oh look, I wasn't that wrong in my conjecture after all.
[15:05] <brainwash> and the array is not used anywhere?
[15:06] <RonaldsMazitis> I search for array and it's only in same line with gtkactionentry
[15:06] <RonaldsMazitis> that's not really helpfull
[15:06] <lighterowl> huh
[15:06] <lighterowl> um
[15:06] <lighterowl> I don't even
[15:06] <lighterowl> nevermind
[15:07] <RonaldsMazitis> static const GtkActionEntry action_entries[] =
[15:07] <lighterowl> yeah. so action_entries should be used somewhere in the same file, otherwise this is just an unused variable.
[15:07] <brainwash> it is used somewhere
[15:08] <brainwash> how else would thunar work?
[15:08] <lighterowl> did you just confuse the type and the name of a variable? because I really feel like I'm missing something.
[15:08] <RonaldsMazitis>   gtk_action_group_add_actions (window->action_group, action_entries, G_N_ELEMENTS (action_entries), GTK_WIDGET (window));
[15:08] <RonaldsMazitis> oh yeah this explains everything
[15:08] <brainwash> there you go
[15:08] <lighterowl> ...
[15:09] <brainwash> this is getting pretty silly though
[15:09] <brainwash> is this the first time you try to edit source code?
[15:10] <lighterowl> sounds like it.
[15:12] <RonaldsMazitis> gtk_action_group_add_actions
[15:12] <lighterowl> I'm really enjoying this.
[15:13] <RonaldsMazitis> I'm going down the rabbit hole with this
[15:13] <RonaldsMazitis> how many functions later there is function that draws things or do something other than sending more parameters in
[15:14] <brainwash> I warned you about thunar
[15:14] <brainwash> it is quite complex
[15:15] <lighterowl> RonaldsMazitis: are you really just doing all that to add a custom action to the folder's context menu? because that is ... you know, already working and customisable?
[15:16] <RonaldsMazitis> not the context menu
[15:16] <lighterowl> oh.
[15:16] <RonaldsMazitis> I want to icon besides home button
[15:16] <RonaldsMazitis> and next and back button
[15:16] <brainwash> but what exactly is the problem now?
[15:17] <brainwash> you have the xml file, you have the actions array
[15:18] <RonaldsMazitis> thunar-windows-ui.xml
[15:18] <RonaldsMazitis> window*
[15:18] <brainwash> a callback function for your command is missing, right?
[15:19] <RonaldsMazitis> yea
[15:19] <brainwash> something like this https://git.xfce.org/xfce/thunar/tree/thunar/thunar-window.c#n2953
[15:20] <lighterowl> lgtm
[15:34] <RonaldsMazitis> might be help full to know which variable hold the location
[15:34] <RonaldsMazitis> the file manager is into
[15:36] <brainwash> thunar_window_get_current_directory()
[15:36] <brainwash> or
[15:36] <brainwash> window->current_directory
[15:36] <lighterowl> RonaldsMazitis: here's something to get you started - http://paste.debian.net/1131539/
[15:37] <lighterowl> now it's all up to you to implement execute_ronalds_custom_action() to actually do what you want.
[15:37] <RonaldsMazitis> lighterowl I did this
[15:37] <lighterowl> oh, ok.
[15:40] <RonaldsMazitis> 	system("/usr/bin/catfish");
[15:40] <RonaldsMazitis> but I might like to add parameter of currect location
[15:40] <lighterowl> oh my
[15:40] <RonaldsMazitis> D:
[15:40] <RonaldsMazitis> :D
[15:41] <lighterowl> let's sprintf into a buffer that's then passed to system() and ignore stupid stuff like spaces in paths.
[15:41] <RonaldsMazitis> don't judge me, I did really basic C stuff 5 years ago
[15:41] <lighterowl> oh, ok.
[15:41] <RonaldsMazitis> pardon me, buffer?
[15:41] <RonaldsMazitis> :D
[15:46] <RonaldsMazitis>   current_directory = thunar_navigator_get_current_directory (THUNAR_NAVIGATOR (page));
[15:46] <lighterowl> RonaldsMazitis: do I understand correctly that you just want to run Catfish in the current directory?
[15:47] <RonaldsMazitis> yeah
[15:49] <lighterowl> oh
[15:49] <lighterowl> shame he left
[15:49] <lighterowl> I'll code it up just for fun, then.
[15:50] <lighterowl> brainwash: I really admire your patience.
[15:50] <brainwash> you should be able to figure out this last missing part
[15:54] <RonaldsMazitis> https://cboard.cprogramming.com/c-programming/52075-need-pass-parameters-system.html
[15:55] <RonaldsMazitis> https://paste.ubuntu.com/p/nqjCC5V2Vn/
[15:56] <RonaldsMazitis> but where does xml will get the icon?
[15:59] <brainwash> isn't the icon defined in the array?
[16:00] <brainwash> home button has the icon name "go-home-symbolic"
[16:02] <RonaldsMazitis> there is no such file
[16:02] <RonaldsMazitis> in source files
[16:02] <brainwash> because it's a general icon name
[16:02] <brainwash> icon themes provide the icon files
[16:03] <RonaldsMazitis> oh
[16:04] <brainwash> try the name "filefind"
[16:11] <RonaldsMazitis> okay
[16:11] <RonaldsMazitis> so I now need to make deb package
[16:48] <RonaldsMazitis> how to compile from source?
[16:48] <RonaldsMazitis> make install does not work
[16:56] <lighterowl> RonaldsMazitis: ./autogen.sh; make;
[16:56] <lighterowl> you generally shouldn't do make install, as this will probably overwrite your distribution's packages (though the default prefix should be /usr/local, so probably not).
[16:59] <RonaldsMazitis> dt-autogen: You must have "glib2" installed. You can get if from
[16:59] <RonaldsMazitis> ftp://ftp.gtk.org/pub/gtk/
[17:00] <lighterowl> you'll probably get a lot of similar messages. you need to have development packages installed.
[17:00] <RonaldsMazitis> synaptic shows that I have libglib2
[17:00] <lighterowl> yes, but not libglib2.0-dev
[17:02] <RonaldsMazitis> now I have
[17:02] <RonaldsMazitis> still same message
[17:02] <RonaldsMazitis> cli as well?
[17:03] <lighterowl> cli? just sudo apt install libglib2.0-dev.
[17:05] <RonaldsMazitis> gtk-doc
[17:06] <brainwash> sudo apt build-dep thunar
[17:06] <lighterowl> oh right, you need to build a deb as well.
[17:06] <RonaldsMazitis> https://paste.ubuntu.com/p/YmT3QWZFXp/
[17:07] <RonaldsMazitis> configure: error: X Window system libraries and header files are required
[17:07] <lighterowl> RonaldsMazitis: please read this - https://wiki.debian.org/BuildingTutorial - you'll be doing us all a favour.
[17:07] <RonaldsMazitis> but it should run without deb package?
[17:08] <lighterowl> RonaldsMazitis: running apt build-dep thunar will have apt download all build dependencies of thunar, thus letting you compile and run the program locally. if you want to make a custom deb package later on, refer to the article I linked.
[17:09] <RonaldsMazitis> sudo apt build-dep thunarReading package lists... DoneE: You must put some 'source' URIs in your sources.list
[17:09] <lighterowl> my oh my
[17:09] <lighterowl> I'm done.
[17:09] <RonaldsMazitis> I'm really sorry
[17:10] <RonaldsMazitis> I have sources in sources.list
[17:10] <RonaldsMazitis> does not ubuntu come with sources already?
[17:11] <brainwash> deb-src sources are not enabled by default
[17:11] <RonaldsMazitis> I guess so
[17:11] <brainwash> they are commented out in your sources.list
[17:12] <brainwash> the Software & Updates GUI allows you to enable them
[17:12] <RonaldsMazitis> yeah
[17:15] <RonaldsMazitis> The required package exo-2 was not found on your system.
[17:18] <brainwash> message from apt?
[17:19] <brainwash> libexo-2-dev
[17:20] <RonaldsMazitis> The required package libxfce4ui-2 was not found on your system.
[17:22] <brainwash> libxfce4ui-2-dev
[17:22] <brainwash> did you run the build-dep command?
[17:23] <RonaldsMazitis> yeah trying
[17:24] <RonaldsMazitis> The required package libxfce4ui-2 was found on your system,
[17:24] <RonaldsMazitis> still missing
[17:24] <brainwash> even after installing libxfce4ui-2-dev?
[17:25] <RonaldsMazitis> yea
[17:25] <RonaldsMazitis> https://paste.ubuntu.com/p/Xy2VqhJKRq/
[17:26] <brainwash> mmh
[17:27] <RonaldsMazitis> libxfce4ui-2-0 is already the newest version (4.13.4-1ubuntu1).
[17:27] <RonaldsMazitis> *** The required package libxfce4ui-2 was found on your system,*** but the installed version (4.14.1) is too old.
[17:27] <brainwash> Depends: libxfce4ui-2-0 (>= 4.13.0)
[17:28] <brainwash> you are using a PPA for Xfce?
[17:29] <brainwash> like, did you install Xfce 4.14 via PPA?
[17:30] <RonaldsMazitis> https://packages.debian.org/experimental/amd64/libxfce4ui-2-0/download
[17:30] <RonaldsMazitis> no
[17:30] <brainwash> uhm
[17:30] <RonaldsMazitis> I installed xfce with xubuntu
[17:30] <brainwash> you manually downloaded a deb package and installed it?
[17:31] <RonaldsMazitis> installed via command line
[17:31] <brainwash> this is getting confusing again
[17:31] <brainwash> >but the installed version (4.14.1) is too old.
[17:33] <brainwash> I guess you shouldn't try to compile latest thunar on xubuntu 18.04
[17:33] <RonaldsMazitis> https://paste.ubuntu.com/p/HjnR2vM5D5/
[17:33] <RonaldsMazitis> ok
[17:33] <brainwash> https://git.xfce.org/xfce/thunar/commit/?id=59244a32f25dae0aae51a595e383ab49fe255887
[17:34] <RonaldsMazitis> https://launchpad.net/ubuntu/bionic/+source/thunar
[17:34] <brainwash> download the source for thunar 1.8.12 or 1.6.x
[17:34] <brainwash> https://git.xfce.org/xfce/thunar/snapshot/thunar-1.8.12.tar.gz
[17:36] <brainwash> a recent change in the master branch now requires you to have libxfce4ui-2-0 version 4.15
[17:37] <brainwash> because development is heading towards Xfce 4.15/4.16
[17:39] <RonaldsMazitis> I downloaded
[17:39] <RonaldsMazitis> the one from ubuntu source
[17:41] <brainwash> apt source thunar?
[17:41] <RonaldsMazitis> so
[17:41] <RonaldsMazitis> I configured
[17:41] <brainwash> how did you obtain the thunar source code?
[17:41] <RonaldsMazitis> from the link
[17:42] <RonaldsMazitis> https://launchpad.net/ubuntu/+source/thunar/1.6.15-0ubuntu1
[17:42] <brainwash> okay
[17:42] <RonaldsMazitis> what do I do after configuring?
[17:42] <RonaldsMazitis> ./configure
[17:42] <brainwash> did it work now?
[17:42] <RonaldsMazitis> worked
[17:42] <brainwash> "make"
[17:42] <RonaldsMazitis> yes
[17:48] <LittleSeneca> What kind of hardware are people running?
[17:55] <RonaldsMazitis> https://paste.ubuntu.com/p/sPVFSMWz5M/
[17:55] <RonaldsMazitis> this is not right
[17:55] <lighterowl> I'm running Xubuntu 19.10 on a Lenovo P53 with Intel i7-9850H and 64GB RAM.
[17:56] <RonaldsMazitis> omg You have 64 gigs
[17:56] <RonaldsMazitis> I have 4
[17:56] <RonaldsMazitis> :D
[17:56] <lighterowl> well, it's work hardware, so it's not really mine.
[18:01] <RonaldsMazitis> https://paste.ubuntu.com/p/N9s4PPTyx7/
[18:02] <RonaldsMazitis> lighterowl I got error with that system part
[18:02] <brainwash> it surely would help if knew how to program
[18:03] <RonaldsMazitis> string = sprintf(String, "/usr/bin/catfish --path= %s", current_directory);
[18:03] <RonaldsMazitis> something like that?
[18:04] <brainwash> check the source code for examples :)
[18:07] <RonaldsMazitis> https://www.geeksforgeeks.org/sprintf-in-c/
[18:08] <RonaldsMazitis> https://paste.ubuntu.com/p/BMxW9BGXDT/
[18:08] <RonaldsMazitis> this should be correct
[18:11] <RonaldsMazitis> with lower system
[18:13] <RonaldsMazitis> system is unused
[18:17] <RonaldsMazitis> : stray ‘\302’ in program char String[255];
[18:24] <lighterowl> RonaldsMazitis: this isn't perfect, but will work better - https://paste.ubuntu.com/p/tmS6T5Cr2v/
[18:26] <RonaldsMazitis> lighterowl thanks
[18:26] <brainwash> lighterowl: not freeing err?
[18:26] <lighterowl> brainwash: crap, I knew I must've forgotten something.
[18:27] <RonaldsMazitis> something is different?
[18:28] <lighterowl> it won't be noticeable to you as the end user, but use this version instead : https://paste.ubuntu.com/p/c3DbWrZYc7/
[18:28] <RonaldsMazitis> after make it's launchable
[18:29] <RonaldsMazitis> ?
[18:29] <lighterowl> well, it works for me.
[18:29] <RonaldsMazitis> yeah
[18:29] <RonaldsMazitis> it makes
[18:30] <brainwash> lighterowl: also strange that you involve thunarx_
[18:32] <brainwash> https://git.xfce.org/xfce/thunar/tree/thunar/thunar-file.h
[18:33] <RonaldsMazitis> after sudo make install
[18:33] <RonaldsMazitis> it should be installed?
[18:33] <lighterowl> brainwash: I must've seen this thunarx stuff in some other function. I'll try with thunar_file_get_file instead.
[18:34] <brainwash> RonaldsMazitis: it will be installed in /usr/local
[18:34] <RonaldsMazitis> it's there but it's not executable
[18:34] <brainwash> and therefore should have higher priority than the system installed version
[18:35] <brainwash> not executable?
[18:35] <brainwash> you have to kill the currently running thunar daemon
[18:35] <brainwash> thunar --quit
[18:36] <brainwash> or relog
[18:36] <lighterowl> brainwash: yeah, works file with thunar_file_get_file. thanks. :)
[18:36] <lighterowl> I meant works fine.
[18:38] <RonaldsMazitis> no new icons added
[18:38] <lighterowl> did you edit the xml too?
[18:38] <RonaldsMazitis> yeah
[18:39] <brainwash> you killed the thunar daemon process?
[18:39] <RonaldsMazitis> thunar --quit
[18:39] <RonaldsMazitis> yeah
[18:40] <brainwash> and the command "which thunar" gives what?
[18:40] <RonaldsMazitis>  /usr  /local /bin/  thunar
[18:40] <RonaldsMazitis> launches
[18:41] <RonaldsMazitis> yeah
[18:41] <RonaldsMazitis> exactly that location shows
[18:41] <RonaldsMazitis> in which thunar
[18:41] <brainwash> then your code edits are incomplete
[18:42] <RonaldsMazitis> it would help if I added some numbers
[18:42] <RonaldsMazitis> in xml
[18:42] <brainwash> numbers?
[18:43] <brainwash> you could switch existing entries around and see if that has an effect
[18:43] <pikapika> Does Thunar keep logs of files you've opened somewhere?
[18:43] <lighterowl> RonaldsMazitis: for reference, here's a full diff of my changes. http://paste.debian.net/1131565/
[18:43] <RonaldsMazitis> https://paste.ubuntu.com/p/j5kJHpFYKF/
[18:43] <lighterowl> this tells us only half of the story. "open-search" must also be present in the action_entries array.
[18:43] <pikapika> Interesting coincidence I asked this right when you were talking about thunar RonaldsMazitis
[18:43] <brainwash> pikapika: I don't think thunar does, but application which you use to open files can
[18:43] <pikapika> but where does it save the logs?
[18:44] <brainwash> check .local/share/recently-used.xbel
[18:44] <brainwash> but again, thunar does not access that file
[18:44] <RonaldsMazitis> https://paste.ubuntu.com/p/pMyWrmxfJH/
[18:45] <pikapika> I really should make some tagging system, too many files scattered everywhere
[18:46] <pikapika> brainwash, does it have some hooks built-in where I can add such logging facility myself or would that entail actually changing the source and maintaining my own version?
[18:47] <brainwash> pikapika: sounds like something that would need to be implemented in the code
[18:47] <pikapika> L(
[18:47] <pikapika> :(
[18:47] <pikapika> Thanks for the help
[18:47] <brainwash> you could check if Nautilus does that
[18:47] <lighterowl> changing thunar source seems to be a very common theme today!
[18:51] <RonaldsMazitis> https://paste.ubuntu.com/p/YxNK8xZcsx/
[18:51] <brainwash> RonaldsMazitis: it should work, it seems to work for lighterowl
[18:51] <brainwash> I did not test it
[18:52] <lighterowl> why would you? it sucks.
[18:52] <RonaldsMazitis> I posted the whole file
[18:53] <brainwash> does it work if you run it from the source directory?
[18:53] <brainwash> ./thunar/thunar
[18:54] <brainwash> or, does running thunar from terminal give any error/warning message?
[18:54] <RonaldsMazitis> nope
[18:55] <lighterowl> does the process immediately end (i.e. do you see a new line with the prompt in your console), or is the console frozen until you close the window?
[18:56] <brainwash> the first case would indicate that the daemon process is still active
[18:56] <lighterowl> yes. I stumbled upon this myself and was surprised.
[18:56] <lighterowl> :)
[18:56] <RonaldsMazitis> it opens and closes normally
[18:56] <brainwash> I think everyone is surprised by it
[18:56] <RonaldsMazitis> ./thunar/thunar
[18:57] <RonaldsMazitis> what if I remove thunar
[18:57] <RonaldsMazitis> with apt
[18:57] <RonaldsMazitis> what then?
[18:57] <brainwash> sounds like a bad idea
[18:57] <RonaldsMazitis> it has dependencies right?
[18:57] <brainwash> other components depend on thunar
[18:57] <brainwash> right
[18:58] <RonaldsMazitis> so Yours have the icons?
[18:58] <brainwash> I did not test
[18:58] <brainwash> I'm on Windows right now :>
[18:58] <lighterowl> HERESY
[18:59] <lighterowl> ;)
[19:00] <brainwash> can you test if adding another action to the bar works?
[19:00] <brainwash> one of the preexisting ones
[19:00] <brainwash> or did you test that already?
[19:00] <RonaldsMazitis> I already have 	  <toolitem action="open-tab" />
[19:00] <lighterowl> #worksforme https://imgur.com/wG5fdbh.png
[19:01] <brainwash> there you have it
[19:01] <RonaldsMazitis> I want to add that open-tab aswell
[19:02] <RonaldsMazitis> it's easier because callbacks are same
[19:02] <brainwash> I can't think of anything that would make it not work for you RonaldsMazitis
[19:02] <lighterowl> and here's the final diff just for reference : http://paste.debian.net/1131568/
[19:03] <RonaldsMazitis> cool wait I'm making it without open-tab action
[19:04] <lighterowl> brainwash: out of curiosity, are you one of the Thunar maintainers? or XFCE in general?
[19:04] <brainwash> only a contributor
[19:04] <lighterowl> cool.
[19:05] <brainwash> I'm somewhat familiar with thunar, xfdesktop and few other components
[19:05] <lighterowl> maybe you'd have an idea about what may cause this bug? ;) https://bugzilla.xfce.org/show_bug.cgi?id=14394
[19:05] <lighterowl> argh. this is xfce4-panel.
[19:06] <brainwash> sadly, not worked with the panel much
[19:07] <lighterowl> that's cool. thanks for taking a look.
[19:08] <brainwash> and I've never encountered that bug
[19:08] <brainwash> I think
[19:08] <lighterowl> yeah, it's a real heisenbug.
[19:08] <RonaldsMazitis> https://paste.ubuntu.com/p/pRmPs3h3fY/
[19:08] <brainwash> probably another reason why I don't bother looking into it :D
[19:08] <RonaldsMazitis> here is all I
[19:08] <RonaldsMazitis> go
[19:10] <RonaldsMazitis> I'm just thinking that search in directory and new tab on location bar would good for the thunar
[19:10] <RonaldsMazitis> it certainly would be better with those buttons
[19:10] <brainwash> I think there was a bug report for adding New Tab button
[19:11] <brainwash> maybe I can find it
[19:15] <brainwash> seems to be gone or it never existed
[19:16] <RonaldsMazitis> but my code seems fine
[19:18] <brainwash> I have no idea why it's not working for you
[19:19] <brainwash> but if we think about.. almost everything did not work for you today
[19:19] <brainwash> it was a long way
[19:20] <brainwash> maybe try from scratch and carefully apply your changes
[19:20] <RonaldsMazitis> lighterowl can You please send me source code or something like that
[19:21] <brainwash> lighterowl was using the thunar 1.8 source I assume
[19:21] <brainwash> keep that in mind
[19:24] <RonaldsMazitis> 1.8.1.2
[19:24] <RonaldsMazitis> 1.8.12
[19:33] <RonaldsMazitis> https://paste.ubuntu.com/p/sjBHRTF2cY/
[19:33] <RonaldsMazitis> this happens in 1.8.12
[19:35] <RonaldsMazitis> ah
[19:36] <RonaldsMazitis> } missin
[19:37] <RonaldsMazitis>  error while loading shared libraries: libthunarx-3.so.0: cannot open shared object file: No such file or directory
[19:41] <brainwash> xubuntu 18.04 does not have libthunarx-3
[19:42] <brainwash> also, lighterowl changed the code and replaced the thunarx_ call
[19:44] <RonaldsMazitis> but I have 18.04
[19:44] <brainwash> then stick with thunar 1.6
[19:47] <brainwash> so, any reason why did not use lighterowl's code changes?
[19:49] <brainwash> I'm linking them again http://paste.debian.net/1131568/
[19:50] <brainwash> download thunar 1.6.x source code, apply those changes, compile, install, kill thunar daemon, start thunar
[19:51] <RonaldsMazitis> what's different?
[19:51] <RonaldsMazitis> I used them
[19:51] <brainwash> if you used those exact lines, then nothing is different
[19:52] <RonaldsMazitis> just installed 1.6
[19:52] <RonaldsMazitis> atleast now it opens
[19:52] <RonaldsMazitis> but them icons don't show
[19:55] <RonaldsMazitis> https://paste.ubuntu.com/p/QgNr6jkh3z/
[19:55] <RonaldsMazitis> https://paste.ubuntu.com/p/PVgG7gRk4H/
[19:56] <RonaldsMazitis> I changed standart view aswell
[20:00] <brainwash> guess I'll set up a VM and see if it works
[20:01] <RonaldsMazitis> I have 4 gb or RAM and VM's suck
[20:02] <RonaldsMazitis> but please use xubuntu 18.04
[20:03] <brainwash> yes, I downloaded 18.04
[20:11] <RonaldsMazitis> will numbers I add in xml will apper in UI?
[20:11] <brainwash> probably not
[20:17] <RonaldsMazitis> so I will delete
[20:17] <RonaldsMazitis> something
[20:18] <brainwash> are all icons missing?
[20:18] <RonaldsMazitis> it's making
[20:18] <brainwash> from where did you get "open-tab"?
[20:18] <RonaldsMazitis> I made it
[20:19] <RonaldsMazitis> it has same callback
[20:19] <RonaldsMazitis> as the file menu tab thing
[20:19] <brainwash> but the action name is "new-tab"
[20:19] <RonaldsMazitis> nothing changed
[20:20] <RonaldsMazitis> after deleting
[20:22] <brainwash> screenshot https://i.imgur.com/RfOESrV.png
[20:22] <RonaldsMazitis> can You please send me source code
[20:23] <brainwash> I used the 1.6.18 source, applied these changes http://paste.debian.net/1131568/, also added "new-tab" to the xml file and compile it
[20:23] <RonaldsMazitis> 	  <toolitem action="open-tab" />
[20:23] <RonaldsMazitis> changes don't work
[20:23] <brainwash> "open-tab" is not correct
[20:23] <brainwash> it is "new-tab"
[20:24] <RonaldsMazitis> please repost
[20:24] <RonaldsMazitis> http://paste.debian.net/1131568/,
[20:24] <RonaldsMazitis> oh wait it works
[20:25] <RonaldsMazitis> ok
[20:25] <RonaldsMazitis> so
[20:26] <RonaldsMazitis> maybe can't use same callback
[20:26] <RonaldsMazitis> I am making now
[20:27] <RonaldsMazitis> does not work
[20:27] <brainwash> works for me
[20:27] <RonaldsMazitis> FILES.FM me source code
[20:27] <RonaldsMazitis> please
[20:28] <RonaldsMazitis> I have no idea why not work
[20:28] <brainwash> how hard can it be to apply the changes?
[20:28] <RonaldsMazitis> I am applied everything
[20:28] <RonaldsMazitis> might be something I can't see
[20:28] <brainwash> start from zero
[20:28] <RonaldsMazitis> noo
[20:28] <RonaldsMazitis> please
[20:28] <RonaldsMazitis> I will try your version
[20:29] <RonaldsMazitis> I did like 6 versions
[20:29] <RonaldsMazitis> already
[20:29] <RonaldsMazitis> and same stuff happens
[20:29] <brainwash> my version is: https://git.xfce.org/xfce/thunar/snapshot/thunar-1.6.18.tar.gz  +  http://paste.debian.net/1131568/
[20:29] <brainwash> that is the code
[20:30] <RonaldsMazitis> authogen
[20:30] <RonaldsMazitis> autogen*
[20:30] <brainwash> ./autogen.sh
[20:30] <brainwash> make
[20:31] <brainwash> thunar --quit
[20:31] <brainwash> ./thunar/thunar
[20:31] <lighterowl> that is actually exactly what I did.
[20:31] <brainwash> see my screenshot https://i.imgur.com/RfOESrV.png
[20:31] <brainwash> I just did that in a new VM
[20:31] <brainwash> xubuntu 18.04
[20:32] <RonaldsMazitis> wait your 64 gb ram thing probably is faster in vm
[20:32] <RonaldsMazitis> than my actual pc
[20:32] <RonaldsMazitis> making now
[20:32] <brainwash> my VM has 2gb only
[20:32] <lighterowl> well, I'm not on that machine right now, but I don't see how that's relevant.
[20:32] <RonaldsMazitis> still same
[20:32] <brainwash> and it loads everything into RAM because it's a live session
[20:32] <lighterowl> I'm on even on xubuntu right now, lol.
[20:33] <lighterowl> *not even
[20:33] <RonaldsMazitis> I installed your version and it's tha same
[20:33] <RonaldsMazitis> wait
[20:33] <RonaldsMazitis> what
[20:33] <RonaldsMazitis> there is no buttons added
[20:34] <RonaldsMazitis> so You want me to copy paste
[20:34] <RonaldsMazitis> 7 times
[20:34] <RonaldsMazitis> I thought You will send me source
[20:34] <RonaldsMazitis> modified
[20:35] <tomreyn> !enter
[20:40] <RonaldsMazitis> ok
[20:40] <RonaldsMazitis> now it works for me
[20:41] <RonaldsMazitis> magic happened
[20:41] <brainwash> sure
[20:42] <RonaldsMazitis> one button is missing
[20:42] <RonaldsMazitis> next button
[20:48] <RonaldsMazitis> and it's back to not working
[20:52] <RonaldsMazitis> and after reinstall back to working again, but still only 4 icons
[20:59] <RonaldsMazitis> so 4 icons
[21:00] <RonaldsMazitis> no forward because limitations?
[21:05] <RonaldsMazitis> I can make two open parent buttons
[21:06] <RonaldsMazitis> so space is not limited
[21:06] <RonaldsMazitis>         <placeholder name="placeholder-history-actions" /> JUST DOES NOT WORK
[21:11] <RonaldsMazitis> If I extract original  files on desktop in folder, it's back to begging
[21:18] <brainwash> RonaldsMazitis: isn't forward button only visible if you can go forward?
[21:18] <brainwash> I already closed the VM
[21:18] <RonaldsMazitis> it's not there
[21:20] <brainwash> what does "reinstall" mean?
[21:21] <brainwash> sudo make install?
[21:21] <RonaldsMazitis> make, then make install
[21:23] <RonaldsMazitis> https://ibb.co/Dr2DyXT
[21:23] <RonaldsMazitis> no forward button
[21:24] <lighterowl> thank god that php folder is in the trash.
[21:24] <lighterowl> ;)
[21:24] <RonaldsMazitis> I love php
[21:25] <RonaldsMazitis> :D
[21:25] <lighterowl> that's nice.
[21:26] <brainwash> where did the buttons go?! :)
[21:27] <brainwash> are the buttons gone when you run thunar from the source directory?
[21:28] <RonaldsMazitis> yes
[21:28] <RonaldsMazitis> https://paste.ubuntu.com/p/xyJXgtnhKf/
[21:29] <RonaldsMazitis> what buttons? it's just forward missing
[21:29] <RonaldsMazitis> here is everything
[21:30] <brainwash> where is the back button?
[21:30] <brainwash> in your screenshot
[21:30] <RonaldsMazitis> open parent is back
[21:30] <RonaldsMazitis> ohg
[21:30] <RonaldsMazitis> yeah
[21:30] <RonaldsMazitis> back button is missing aswell
[21:40] <RonaldsMazitis> send me whole xml
[21:40] <RonaldsMazitis> it's just not working
[21:40] <RonaldsMazitis> I'm getting mad at this
[21:40] <brainwash> it never worked?
[21:40] <brainwash> I thought that you got it working
[21:41] <RonaldsMazitis> it works but placeholder-history-actions
[21:41] <RonaldsMazitis> well I use original and just add new tab-and open-search and that makes forward and back to dissapear
[21:44] <brainwash> they weren't missing in my case
[21:45] <brainwash> https://i.imgur.com/RfOESrV.png
[21:45] <brainwash> and I have been using the same code changes as you did
[21:47] <RonaldsMazitis> oka
[21:47] <RonaldsMazitis> I added forward and back