| wallyworld_ | kelvinliu: if you have a chance at some stage, here's that PR https://github.com/juju/juju/pull/11258 | 01:08 |
|---|---|---|
| kelvinliu | yep | 01:08 |
| wallyworld_ | kelvinliu: sorry, i didin't see your comments before i hit merge | 03:36 |
| wallyworld_ | i thought it had been approved | 03:36 |
| wallyworld_ | i managed to hit abort just in time | 03:38 |
| kelvinliu | wallyworld_: nws, just a few minor suggestions | 03:50 |
| hml | can i pls get a quick review of https://github.com/juju/juju/pull/11256 | 14:16 |
| achilleasa | hml: I have rebased 11255. Can you take another look at the pod-spec commits and verify that the k8s QA steps now work for you? | 14:17 |
| hml | achilleasa: sure | 14:17 |
| hml | achilleasa: working on the qa - for some reason i’m pulling down the old code. instead of the new… | 15:12 |
| achilleasa | make install followed by make for the operator before bootstrapping seems to do the trick for me | 15:13 |
| hml | achilleasa: not.. the actual code, i do a git log after i pull down the pr and get commits from feb 26 and feb 17 instead of feb 28 | 15:13 |
| achilleasa | hml: those are the right dates. I had the PR on the backburner until part 1 landed | 15:15 |
| hml | achilleasa: hrm… okay. checking commit shas right now. | 15:16 |
| achilleasa | so it's just rebase on top of different head; it preserves the original commit dates unless you explicitly override | 15:16 |
| achilleasa | you should see dcf42c9 as the head for my branch locally | 15:17 |
| hml | achilleasa: the shas are okay. trying the iaas charm again | 15:22 |
| achilleasa | manadart: where can I find the cleanup script for manual machines? | 15:28 |
| manadart | achilleasa: I don't think there is one. | 15:30 |
| achilleasa | manadart: it's the one where we clean up the juju data so the machine can be reprovisioned. IIRC you patched it recently | 15:30 |
| manadart | achilleasa: Ah, that one. https://github.com/juju/juju/blob/develop/scripts/removejujuservices.bash | 15:32 |
| achilleasa | manadart: thanks | 15:32 |
| manadart | This is also installed into /usr/sbin IIRC, via a cloud init during provisioning. | 15:32 |
| achilleasa | manadart: is it overwritten when uprading? | 15:32 |
| manadart | achilleasa: No, there is no associated upgrade step. | 15:33 |
| achilleasa | wonder whether it's worth adding one... probably should | 15:34 |
| achilleasa | though if you get rid of the uniter state, even if you reprovision the start hook wont fire because the unit will not have been started... it's probably safe to skip the upgrade | 15:35 |
| hml | achilleasa: qa was good - approved | 15:54 |
| achilleasa | thanks! | 15:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!