[18:12] <fredlef1> blackboxsw: I think I have all you comments addressed : https://github.com/canonical/cloud-init/pull/216
[18:13] <blackboxsw> fredlef1: +1 I like it, I'm currently working on a patch for you at the moment but need to sort a unit test issue
[18:13] <blackboxsw> fredlef1: here's the wip I was thinking. https://paste.ubuntu.com/p/PRnnJtSKww/
[18:13] <blackboxsw> wip == work in progress
[18:14] <blackboxsw> fredlef1: sorry for not getting this sooner, I expect to have this buttoned up before my lunch (~45 mins from now0
[18:16] <blackboxsw> fredlef1: the trouble I was originally thinkg with the branch was how Ec2 proper would react to a requests.ConnectionError/TimeoutError, if IMDS were for some reason down. But retrying in the face of that is ok, and I wanted to confirm that _imds_exception_cb performs properly in that case. and I think it does
[18:17] <blackboxsw> fredlef1: so anyway, should have those couple unit tests in place within an hour and then I think we are clear there for landing. and rharper and I think https://github.com/canonical/cloud-init/pull/229 may be in good shape for landing as the next PR we merge
[18:17] <fredlef1> your diff looks good
[18:17] <blackboxsw> fredlef1: your two branches are the only thing that is gating our next Ubuntu Focal (20.04) package upload
[18:17] <blackboxsw> so I hope we get through those 2 branches today/tomorrow
[18:17] <blackboxsw> hopefully today
[20:50] <rharper> blackboxsw: do you need any more reviews  for FFE branches ?
[20:50] <blackboxsw> rharper: nope, still on fred's PR #216.
[20:50] <blackboxsw> I think I have unit tests in order will push that an then I'll address your reviews on my branches
[20:50] <rharper> sure
[21:02] <blackboxsw> ok done with fred's branch https://github.com/canonical/cloud-init/pull/216
[21:02] <blackboxsw> posted a patch that I think will be accepted there
[21:02] <blackboxsw> grabbing some reviews now
[22:38] <Nick_A> Can someone please confirm if this is valid network version 1 syntax for dhcpv6? http://paste.openstack.org/show/EqXcd7Pi7DEaiGP6YjCW/
[22:47] <powersj> Nick_A, I believe it is per https://cloudinit.readthedocs.io/en/latest/topics/network-config-format-v1.html#network-config-v1
[22:47] <powersj> but I'll let rharper confirm
[22:51] <rharper> Nick_A: looks sane;  if you've a newer cloud-init, you can use:  cloud-init devel net-convert
[22:51] <rharper> https://paste.ubuntu.com/p/7spXqkFtGj/
[22:51] <rharper> Nick_A: the lack of MAC and set-name may make the config unreliable if nics are added/removed from instance;  and from boot to boot depending on your platform
[23:03] <Nick_A> thank you