| Odd_Bloke | rharper: blackboxsw: I'd really like us to resolve the FFE/landing new things logjam today. AIUI, we have two changes that we would like to land in focal before release, both of which have PRs open. https://github.com/canonical/cloud-init/pull/114 isn't ready to land, but https://github.com/canonical/cloud-init/pull/214/ is. | 14:17 |
|---|---|---|
| Odd_Bloke | blackboxsw: What are we waiting on for #114? CI is failing, is fixing that all we need? | 14:18 |
| Odd_Bloke | Actually, #214 is Approved, CI is passing and the FFE has been granted, so I've just landed that. | 14:22 |
| Odd_Bloke | Better to ask forgiveness etc. | 14:22 |
| rharper | Odd_Bloke: +1 on landing | 14:49 |
| rharper | Odd_Bloke: AIUI, I was just looking for confirmation that we'll land whatever in master, and cherry pick into focal, and next ubuntu/devel new-upstream-snapshot will just need to drop the cherry picks (as patches) as the snashot will contain those; I'm being lazy hoping someone else confirms; but I could step through that process on local branches and make sure the tools DTRT | 14:51 |
| Odd_Bloke | blackboxsw: Given our earlier conversation, I think https://github.com/canonical/cloud-init/pull/211 can now get a +1 from you? | 16:06 |
| blackboxsw | Odd_Bloke: yes I think we can, wrapping up a meeting. and we are starting the next meeting | 16:17 |
| blackboxsw | #startmeeting Cloud-init bi-weekly status | 16:20 |
| blackboxsw | Hello and welcome to another cloud-init community status meeting. | 16:20 |
| blackboxsw | our IRC channel topic carries the next planned status meeting for those that wish to participate. | 16:21 |
| blackboxsw | All are welcome and interruptions encouraged | 16:21 |
| blackboxsw | #chair rharper Odd_Bloke smoser | 16:22 |
| blackboxsw | Let's try that again | 16:22 |
| blackboxsw | #startmeeting Cloud-init bi-weekly status | 16:22 |
| meetingology | Meeting started Tue Mar 10 16:22:58 2020 UTC. The chair is blackboxsw. Information about MeetBot at http://wiki.ubuntu.com/meetingology. | 16:22 |
| meetingology | Available commands: action commands idea info link nick | 16:22 |
| blackboxsw | Hello and welcome to another cloud-init community status meeting. | 16:23 |
| blackboxsw | our IRC channel topic carries the next planned status meeting for those that wish to participate. | 16:23 |
| blackboxsw | All are welcome and interruptions encouraged | 16:23 |
| blackboxsw | #chair rharper Odd_Bloke smoser | 16:23 |
| meetingology | Current chairs: Odd_Bloke blackboxsw rharper smoser | 16:23 |
| blackboxsw | Previous meeting notes are here | 16:23 |
| blackboxsw | #link https://cloud-init.github.io/status-2020-02-18.html#status-2020-02-18 | 16:24 |
| blackboxsw | he topics we cover in this meeting are the following: Previous Actions, Recent Changes, In-progress Development, Community Charter, Upcoming Meetings, Office Hours (~30 mins). | 16:24 |
| blackboxsw | *the even | 16:24 |
| Odd_Bloke | o/ | 16:24 |
| blackboxsw | #topic Previous Actions | 16:24 |
| blackboxsw | \O | 16:24 |
| blackboxsw | sorry, have my big head on | 16:24 |
| tribaal | o/ | 16:24 |
| blackboxsw | :). Last meeting had no actions carried over. So I think this topic is a noop this week | 16:25 |
| blackboxsw | #topic Recent Changes | 16:25 |
| blackboxsw | recent changes landed in tip of master via git log --since 2020-02-18 https://paste.ubuntu.com/p/sJVpvjFbPj/ | 16:26 |
| blackboxsw | we've added some tooling/actions for github, ec2 IMDSv2 token redacting from logs, alloowing kernel cmdline to tell cloud-init network-config=disabled and not falling back to IMDSv1 on Ec2-proper platform | 16:27 |
| blackboxsw | thanks fred-lefebvre for the ec2 IMDS fallback branch and others for some additional driveby doc updates | 16:28 |
| blackboxsw | Also, we performed an upload to Ubuntu Focal (20.04) series with latest tip of cloud-init to make sure the development release is up to date with recent features | 16:29 |
| blackboxsw | Ubuntu Focal release is currently in feature freeze, so that will affect what patches we pull into Ubuntu Focal at this time as 'new features' would need a Feature Freeze Exception during the stage of Ubuntu development. | 16:30 |
| blackboxsw | #link https://wiki.ubuntu.com/FocalFossa/ReleaseSchedule | 16:30 |
| blackboxsw | As Odd_Bloke alluded to just before this meeting, we are trying to keep tip of master | 16:31 |
| blackboxsw | open for commits. | 16:31 |
| blackboxsw | On the ubuntu-side of the house we will sort cherry picking bug fixes into ubuntu focal during this short feature freeze period of time | 16:32 |
| blackboxsw | If there are significant features that your cloud platform really would like to see on the first public release of Ubuntu Focal, then please get ahold of us in channel of on the mailing list to suggest that we shepherd those features in during this freeze. | 16:33 |
| blackboxsw | But, generally cloud-init team will continue to follow the SRU process to get updates into Focal after feature freeze is lifted. | 16:33 |
| blackboxsw | and again, our SRU test/verification process for Ubuntu will continue to target Xenial, Bionic, Eoan and Focal series for the updates we plan to make in the near future | 16:35 |
| blackboxsw | one thing to note in recent changes as well is that we've now added the ability to query distro, kernel, cpu arch, python runtime version and and merged cloud-config to cloud-config jinja templates. So #cloud-config userdata can be opinionated based on your target distribution or runtime environment. | 16:37 |
| blackboxsw | #link https://cloudinit.readthedocs.io/en/latest/topics/instancedata.html#format-of-instance-data-json | 16:37 |
| blackboxsw | I think that about wraps recent changes | 16:37 |
| blackboxsw | #topic In-progress Development | 16:37 |
| blackboxsw | #link https://github.com/canonical/cloud-init/pulls | 16:38 |
| blackboxsw | our active pulls above is probably the best source of info on features/bugfixes in flight. | 16:38 |
| blackboxsw | Though behind the scenes we have held a couple of meetings to determine how much more automation/tooling we need to clean up to improve our github developer process | 16:39 |
| blackboxsw | I think Odd_Bloke and I have around 4 PRs that we are hoping to clean up to get a couple of things in place: | 16:39 |
| blackboxsw | foremost I believe Odd_Bloke is scrubbing the github review process PR so that we have a good starting point for expectations for every developer, author or committer. | 16:40 |
| blackboxsw | I think ultimately the goal there is to make sure committers can provide a set of expectations on active PR reviews to PR authors, so that active developers get better prioritized reviews. | 16:42 |
| blackboxsw | we are going to add and enable a number of github actions and workflows that should do the following: | 16:42 |
| blackboxsw | - age PRs and add labelling to indicate to reviewers and authors that a review needs attention or it will be automatically closed (after around 4 weeks of languishing) | 16:43 |
| blackboxsw | - label/notify steps to signed the contributor license agreement if unsigned | 16:43 |
| blackboxsw | - run addtional integration tests on active PRs in CI | 16:44 |
| blackboxsw | not sure if I am I missing anything else there. | 16:45 |
| blackboxsw | but ideally we'd like to find a process that helps upstream unblock PRs and get review comments faster | 16:45 |
| blackboxsw | so, it'll be an iterative process | 16:45 |
| blackboxsw | and thanks for the reviews and suggestions so far on https://github.com/canonical/cloud-init/pull/160 as it is the first cut at trying to document the process | 16:46 |
| tribaal | Nice! | 16:47 |
| blackboxsw | woot. the hope I believe is to land that this week as well as branches like https://github.com/canonical/cloud-init/pull/164 https://github.com/canonical/cloud-init/pull/236 and https://github.com/canonical/cloud-init/pull/125 | 16:48 |
| blackboxsw | additionally a gap that we still have vs when we hosted in Launchpad, is our auto-merge Launchpad bug commenting/maintenance: | 16:49 |
| blackboxsw | We still have a need for the following: | 16:49 |
| blackboxsw | - comment on LP bugs linking to an open github PR | 16:49 |
| blackboxsw | - comment on merged commitish in github and Fix Commited state when a PR lands in upstream | 16:49 |
| blackboxsw | so we'll be tackling that too in order to make upstream maintainers happier and better advertise fixes to bug filers | 16:50 |
| blackboxsw | right now that's all a manual process since we haven't retooled our bug-related tooling | 16:50 |
| blackboxsw | #topic Community Charter and upcoming meeting | 16:51 |
| blackboxsw | let's set the status meeting for next session | 16:52 |
| blackboxsw | oops and I realize only now that I blew it this week due to daylight savings... meeting wasn't 'supposed' to start until 25 mins from now : / | 16:52 |
| blackboxsw | #topic cloud-init pull-requests https://git.io/JeVed | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting March 1 16:15 UTC | 19.4 (Dec 17) drops Py2.7 : origin/stable-19.4 | 20.1 (Feb 18) | https://bugs.launchpad.net/cloud-init/+filebug | 16:53 |
| === blackboxsw changed the topic of #cloud-init to: pull-requests https://git.io/JeVed | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting March 1 16:15 UTC | 19.4 (Dec 17) drops Py2.7 : origin/stable-19.4 | 20.1 (Feb 18) | https://bugs.launchpad.net/cloud-init/+filebug | ||
| blackboxsw | that's better. | 16:53 |
| AnhVoMSFT | it says March 1, is that correct? | 16:53 |
| === blackboxsw changed the topic of #cloud-init to: pull-requests https://git.io/JeVed | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting March 24 16:15 UTC | 19.4 (Dec 17) drops Py2.7 : origin/stable-19.4 | 20.1 (Feb 18) | https://bugs.launchpad.net/cloud-init/+filebug | ||
| tribaal | there :) | 16:54 |
| blackboxsw | hah, good I got another participant | 16:54 |
| blackboxsw | :) | 16:54 |
| AnhVoMSFT | UK will also have their own daylight savings March 29th I believe | 16:54 |
| blackboxsw | sorry AnhVoMSFT tribaal :) | 16:54 |
| blackboxsw | yeah this time of year always messes with timing. We try to set things in terms of UTC to avoid thrashing | 16:54 |
| blackboxsw | but even that fails due to human error (my bad) | 16:55 |
| blackboxsw | Other community charter tasks are generally categorized in bugs labelled bitesize | 16:56 |
| blackboxsw | #link https://bugs.launchpad.net/cloud-init/+bugs?field.tag=bitesize | 16:56 |
| blackboxsw | general topics for this year were tasks that are easily done in parallel, such as json schema addtions and datasource readthe docs updates/corrections and fleshing out. | 16:57 |
| blackboxsw | jsonschema example is here for review if anyone wants to take a stab at testing it out. or extending schema for other config modules.https://github.com/canonical/cloud-init/pull/152 | 16:57 |
| blackboxsw | and again all cloud-init contributors are encouraged to review/comment any active cloud-init PRs @ https://github.com/canonical/cloud-init/pulls the more voices, the better the quality | 16:58 |
| blackboxsw | #topic Office Hours (next 30 mins) | 16:58 |
| blackboxsw | During this topic, please bring up any questions, discussions, bugs or features or paper cuts that need attention. there should be a couple of cloud-init developers with eyes on the channel to actively respond. | 16:59 |
| blackboxsw | just before the start of this meeting Odd_Bloke was asking about getting the pytest branch landed for cloud-init. (moving off of nosetests as the project is EOL/unmaintained) | 17:00 |
| tribaal | that's nice. pytest is becoming the de-facto standard these days anyway | 17:00 |
| blackboxsw | yeah, didn't want to get stuck using something that becomes unsupported or unsupportable. we don't have the bandwidth in this project to maintain stacks that aren't being looked at by the collective internet ;) | 17:05 |
| Odd_Bloke | blackboxsw: I believe that branch is now only blocked on you removing your "Request changes" review now that we've established that we don't need to hold off on landing things for Feature Freeze. | 17:05 |
| tribaal | makes total sense :) | 17:05 |
| blackboxsw | Odd_Bloke: do you know if rharper did the new-upstream-snapshot into focal already | 17:05 |
| blackboxsw | to have a 'clean slate' for the pytest branch landing | 17:05 |
| Odd_Bloke | blackboxsw: We can new-upstream-snapshot from an older commit, I don't believe that's a blocker. | 17:06 |
| blackboxsw | Odd_Bloke: not a blocker, but I could do that now as it's 5 mins | 17:06 |
| blackboxsw | then we can land right aftr | 17:07 |
| blackboxsw | sound good? I see nothing queued https://launchpad.net/ubuntu/focal/+queue?queue_state=3&queue_text=cloud-init | 17:07 |
| Odd_Bloke | Sure, if you're happier doing that. :) | 17:08 |
| blackboxsw | I aam :) | 17:09 |
| blackboxsw | ok doing that right now | 17:09 |
| blackboxsw | then we can start the cherry picking just after | 17:09 |
| blackboxsw | Odd_Bloke: I'm adding this as the debian/changelog section title | 17:10 |
| blackboxsw | * New upstream snapshot: bug-fix-only feature-freeze-exception | 17:10 |
| blackboxsw | instead of * New upstream snapshot: | 17:11 |
| blackboxsw | sound reasonable? | 17:11 |
| Odd_Bloke | It isn't bug-fix-only because we have the FFe for a non-bugfix. | 17:11 |
| Odd_Bloke | I was just reading the wiki page that suggested wording, I think, let me take a look. | 17:12 |
| blackboxsw | https://github.com/canonical/cloud-init/pull/241 | 17:13 |
| blackboxsw | ahh right, reviewing that now | 17:13 |
| blackboxsw | yeah not quite sure how to handle our FFe uploads | 17:13 |
| Odd_Bloke | Oh, if it's only that change, then I don't think we need anything specific in the changelog. We have an FFE bug that we're closing with that upload. | 17:14 |
| * blackboxsw re-reads https://wiki.ubuntu.com/FreezeExceptionProcess | 17:14 | |
| Odd_Bloke | And that means it's _definitely_ not bug-fix-only, there isn't a single bugfix in there. ;) | 17:14 |
| blackboxsw | ok that sounds good, will just keep the New upstream snapshot | 17:14 |
| blackboxsw | ok thanks for the review. redoing. | 17:14 |
| Odd_Bloke | Hopefully I'm right and you don't get yelled at. :p | 17:14 |
| powersj | better to upload and ask for forgiveness... | 17:15 |
| blackboxsw | ehh, unlikely :) it seems like steve and others have been pretty lax about changelog text (or manipulating it after the fact) :) | 17:15 |
| Odd_Bloke | Cool, I'll do the same thing locally to review. | 17:15 |
| blackboxsw | Odd_Bloke: force pushed | 17:16 |
| blackboxsw | https://github.com/canonical/cloud-init/pull/241/files | 17:16 |
| Odd_Bloke | blackboxsw: Approved. | 17:16 |
| blackboxsw | thanks Odd_Bloke | 17:17 |
| blackboxsw | build-and-pushing it up | 17:17 |
| blackboxsw | ok onto your pytest branch now | 17:18 |
| blackboxsw | while I await the ubuntu "accepted" response email | 17:18 |
| blackboxsw | Uploading cloud-init_20.1-10-g71af48df-0ubuntu1.dsc: done. | 17:20 |
| blackboxsw | just waiting on review/acceptance | 17:21 |
| blackboxsw | community-notice: tip of cloud-init published into Ubuntu Focal (20.04) [ubuntu/focal-proposed] cloud-init 20.1-10-g71af48df-0ubuntu1 (Accepted) | 17:22 |
| blackboxsw | ok Odd_Bloke merged at long last https://github.com/canonical/cloud-init/pull/211 | 17:26 |
| blackboxsw | nosetest is dead, long live pytest | 17:26 |
| Odd_Bloke | \o/ | 17:26 |
| Odd_Bloke | blackboxsw: https://github.com/canonical/cloud-init/pull/239 <-- another small one for you | 17:27 |
| blackboxsw | approve Odd_Bloke and thanks. it is waiting on you for merge (and CI completion) | 17:29 |
| blackboxsw | works on my focal box | 17:30 |
| blackboxsw | which was broken before | 17:30 |
| blackboxsw | Odd_Bloke: https://github.com/canonical/cloud-init/pull/164 is ready for you I think (labeling in cron) | 17:33 |
| blackboxsw | for CLA ! CLA. | 17:33 |
| blackboxsw | or do we want that PR to actually ignore certain paths (like doc changes) as not-requiring CLA | 17:33 |
| Goneri | blackboxsw, could you take a look at https://github.com/canonical/cloud-init/pull/62 Pleaaaase :-) | 17:43 |
| blackboxsw | Goneri: yes, and so sorry about that. | 17:44 |
| Goneri | np, and Yeah! for pytest :-D | 17:44 |
| blackboxsw | ... and that about wraps up on our cloud-init status meeting. :) I'll close it out and post the minutes for next time | 17:44 |
| blackboxsw | #endmeeting | 17:45 |
| meetingology | Meeting ended Tue Mar 10 17:45:01 2020 UTC. | 17:45 |
| meetingology | Minutes: http://ubottu.com/meetingology/logs/cloud-init/2020/cloud-init.2020-03-10-16.22.moin.txt | 17:45 |
| blackboxsw | ok minutes published to cloud-init.github.io should be up sson | 17:46 |
| blackboxsw | soon | 17:46 |
| meena | sweet mother of glob, it's Tuesday already | 18:39 |
| Odd_Bloke | blackboxsw: I've approved https://github.com/canonical/cloud-init/pull/164 and have just rebased it. :) | 18:42 |
| blackboxsw | thanks Odd_Bloke I'll watch CI and land when complete | 18:42 |
| tribaal | meena: scary isn't it? | 18:50 |
| meena | what a week / month | 18:52 |
| * meena is now doing the mom at home thing, and my partner is back to work | 18:53 | |
| blackboxsw | meena it is crazy how much the the being at home thing affects us all :). if I didn't have a calendar invite telling me it's tuesday, I'd never know what day it was. | 19:07 |
| meena | i had an appointment today (well, the baby did) so i was out, and i should've known which day it is, but since then it feels like another two days could've gone by | 19:08 |
| blackboxsw | heh it's tough on disrupted sleep too I bet | 19:19 |
| blackboxsw | Odd_Bloke: rharper: just confirmed the ec2 redacted token fix that landed is good on latest ec2 cloud-images for cloud-init 20.1.9 and Fred's not falling back to IMDSv1 is in on ec2-proper good shape too. | 19:20 |
| blackboxsw | just double checked since that landed in our previous new-upstream-snapshot before the FFe today and cloud-images looked updated | 19:21 |
| rharper | blackboxsw: nice | 19:22 |
| sarnold | blackboxsw: do you have a link handy for that fix? | 19:25 |
| Odd_Bloke | We're seeing intermittent CI failures during cloud tests. For example, https://travis-ci.org/canonical/cloud-init/jobs/660756966. An educated guess is that we're taking too long to download lxd images due to bandwidth constraints, but I don't know that for sure. | 19:26 |
| blackboxsw | sarnold: you mean the fix to avoid falling back to IMDSv1 on true ec2 clouds? | 20:18 |
| blackboxsw | https://github.com/canonical/cloud-init/commit/1f860e5ac7ebb5b809c72d8703a0b7cb3e84ccd0 for the above | 20:19 |
| sarnold | blackboxsw: hmm, I meant the redacted tokens in the json | 20:19 |
| blackboxsw | ahh one sec | 20:19 |
| blackboxsw | sarnold: https://github.com/canonical/cloud-init/commit/fa639704f67539d9c1d8668383f755cb0213fd4a | 20:19 |
| sarnold | blackboxsw: cool, thanks | 20:20 |
| blackboxsw | no problem. | 20:20 |
| rharper | Odd_Bloke: so, paride reported iso tests failing due to snapd.seeded issues once again | 20:32 |
| rharper | Odd_Bloke: I would suspect it's the same for those images with lxd as snap | 20:32 |
| blackboxsw | sarnold: also FWIW, I just launched a focal minimal VM via an IAM profile and re-enabled security-credentials crawling to validate that that sensitive key is properly redacted for non-root user by runnning cloud-init query --all | grep redact | pastebinit https://paste.ubuntu.com/p/874pcvn326/ | 20:36 |
| rharper | ahosmanMSFT: I tested your https://github.com/canonical/cloud-init/pull/206 today; and it needed just a bit more to keep the instance around; without the extra changes when the snapshot and image get torn down in my testing | 20:37 |
| Odd_Bloke | rharper: Aha, good point. | 20:38 |
| Odd_Bloke | Another small tox PR: https://github.com/canonical/cloud-init/pull/242 | 21:17 |
| Odd_Bloke | blackboxsw: I noticed a slight issue with the CLA workflow which is fixed in https://github.com/canonical/cloud-init/pull/243 | 21:30 |
| blackboxsw | cool Odd_Bloke can you add a trello card + PR link there for tracking please? | 21:31 |
| blackboxsw | so if I don't get to it we can make sure to wrap it up tomorrow early | 21:31 |
| * blackboxsw is in omg need more trello cards mood at the moment | 21:32 | |
| Odd_Bloke | blackboxsw: Why don't you assign yourself? :p | 21:33 |
| blackboxsw | heh | 21:33 |
| blackboxsw | can do | 21:33 |
| Odd_Bloke | rharper: Were those snapd.seeded issues happening on xenial, do you know? | 21:38 |
| rharper | no | 21:38 |
| rharper | bionic and newer | 21:38 |
| rharper | lxd is still a deb in Xenial AFAIK | 21:38 |
| Odd_Bloke | OK, so probably not the source of our CI issues, as that should be running xenial. | 21:38 |
| rharper | ah, ok | 21:39 |
| blackboxsw | created my needed trello card... and the world is right again | 21:39 |
| Nick_A | what would be the best way to get cloud-init to add "critical: true" to every interface it sticks in netplan on ubuntu? | 22:31 |
| sarnold | ohai Nick_A :) | 22:33 |
| Nick_A | hey | 22:33 |
| Nick_A | what channels are you not in? | 22:35 |
| sarnold | I ask myself that every day .. | 22:35 |
| powersj | Nick_A, a bug would be a good start | 22:53 |
| powersj | I don't think our network config handles that, but rharper can confirm | 22:54 |
| rharper | Nick_A: in the case that you provide netplan as network-config to cloud-init we pass-through this config to the OS; we do not tag any interface with critical: true as we don't know that it is (except in iscsi-root scenario, where we do mark the iscsi interfaces a critical-connection) | 22:58 |
| blackboxsw | rharper: just confirmed ec2 doesn't provide classless static routes via dhcp responses. so I *think* incrementing route-metric is unneeded | 23:06 |
| blackboxsw | will pull it from my branch | 23:06 |
| rharper | blackboxsw: ok | 23:08 |
| blackboxsw | rharper: pastebin coming to confirm with you | 23:09 |
| blackboxsw | https://paste.ubuntu.com/p/zrFtx7S7Ct/ | 23:10 |
| rharper | blackboxsw: yes, agreed | 23:10 |
| blackboxsw | I think the ec2 networkd dhcp internal response representation lacking "ROUTES" means no classless routes are used for multiple nics | 23:10 |
| blackboxsw | ok goo | 23:10 |
| blackboxsw | good even. and goo | 23:11 |
| blackboxsw | ok will have ec2 ready for review tomorrow. touching up unit test now | 23:11 |
| blackboxsw | and will file the related FFe bug | 23:13 |
| blackboxsw | for ubuntu inclusion in focal | 23:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!