stub | Yeah, Citus really took off when they stopped being a fork and became an extension. I think they did a lot of the work in core to enable that to happen. They are now owned by Microsoft. | 01:11 |
---|---|---|
cjwatson | Could anyone review https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/380391 for me, please? This is the thing Software Heritage needs. | 15:58 |
cjwatson | And I have a few smallish py3 branches too: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/380137 https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/380385 https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/380386 https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/380388 | 15:58 |
pappacena | I'll take a look on your reviews now, cjwatson | 18:43 |
cjwatson | Thanks | 18:44 |
cjwatson | pappacena: Did you notice my feedback on https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/380252 BTW? I didn't leave it as a formal vote so far, just a comment | 18:45 |
cjwatson | pappacena: And I think several of your turnip MPs should be landable ... | 18:46 |
pappacena | Right, I saw it, made the change on that branch and forgot to ping you back. I think both this MP and the one for copied_from_archive one (https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/380382) can be reviewed already | 18:46 |
pappacena | Ah, did we have a deploy for production of the Turnip dependencies branch? | 18:47 |
cjwatson | Oh, so you did, OK | 18:47 |
cjwatson | pappacena: you don't need a deployment for that | 18:47 |
cjwatson | they just need to land on turnip-dependencies master first | 18:47 |
cjwatson | you need (at least) a deployment before *removing* anything | 18:47 |
pappacena | Sure, makes sense. I'll top-approve the MPs changing dependencies, then. Thanks! | 18:48 |
cjwatson | pappacena: Do you have a matching DB patch MP somewhere for BPPH.creator and xPPH.copied_from_archive? | 18:49 |
pappacena | Yes. Let me find it | 18:49 |
cjwatson | Failed to find it in /launchpad-project/+activereviews but I might have missed it | 18:49 |
cjwatson | I'm almost at EOD but these are top of my queue now | 18:50 |
pappacena | https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/380254 | 18:50 |
cjwatson | Thanks. Ah, I guess you had it as WIP | 18:52 |
pappacena | Yes, I think so. | 18:52 |
pappacena | My bad | 18:52 |
cjwatson | No worries | 18:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!