/srv/irclogs.ubuntu.com/2020/03/10/#snappy.txt

mupPR snapcraft#2967 opened: requirements: uprev click to 7.1.1 <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2967>01:07
mborzeckimorning06:11
mborzeckire07:02
zygaGood morning07:04
mborzeckizyga: hey07:04
zygaI fixed the exec env bug but it will take me some more time to adjust tests in two packages07:04
zygaI made it impossible to easily cause bugs like that again07:04
pstolowskimornings08:02
mborzeckipstolowski: mvo: morning08:05
mvomborzecki: good morning08:07
mvoand good morning to pstolowski08:07
pstolowskio/08:08
zygahey pawel08:10
zygamvo: I'm considering taking today off08:10
zygaI feel super tired somehow08:10
zygaI will work some more on wrapping up two things from yesterday08:10
zygaand EOD around noon08:10
mupPR snapd#8225 closed: snapcraft.yaml: use sudo -E and remove workaround <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8225>08:23
mvozyga: sure, get well08:23
zygamvo: I hope I'm not sick, I just feel tired08:23
zygaanyway, I'll finish what I have to first :)08:23
mupPR snapd#8233 closed: snap-confine: unconditionally add /dev/net/tun to the device cgroup <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8233>08:25
mupPR snapd#8214 closed: tests: test that after "remove-user" the system is unmanaged <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8214>08:40
mupPR snapd#8211 closed: tests: run ipv6 network-retry test too <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8211>08:41
mupPR snapd#7999 closed: devicestate: allow encryption regardless of grade <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7999>08:44
mupPR snapd#7673 closed: interfaces/desktop: allow access to system prompter interface <Created by alexmurray> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7673>09:19
amurraymvo: thanks for merging my PR :)09:48
mvoamurray: thanks for making it in the first place :)09:48
pedronispstolowski: hi, what's the status of #8201 ?09:59
mupPR #8201: tests: mock prune ticker in overlord tests to reduce wait times <Created by stolowski> <https://github.com/snapcore/snapd/pull/8201>09:59
pstolowskipedronis: hi; it's ready but i'm pondering if it makes sense to pass N to tick10:00
pedronispstolowski: should we close #8198 ? afaiu mvo skipped some tests in 2.44 instead10:02
mupPR #8198: o/tests: bump TestEnsureLoopPruneAbortsOld sleep time <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8198>10:03
pstolowskidone10:04
mupPR snapd#8198 closed: o/tests: bump TestEnsureLoopPruneAbortsOld sleep time <⛔ Blocked> <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/8198>10:04
mborzeckiwe don't have a page that lists know model names do we?10:08
pedronismborzecki: known in which sense?10:15
mborzeckipedronis: say, i forgot the actual model name for rpi3 on core18, not sure there's an easy way to find a list of model names of supported devices10:22
pedronismborzecki: ah, no we don't have a list but should have one I suppose in the new UC docs (cc degville)10:32
mborzeckipedronis: our use case may be a bit weird, a i know where to find the models repo ;) others may not10:33
mupPR snapd#8234 opened: devicestate: support dropping "cloud.cfg" user-data cloud-init <Created by mvo5> <https://github.com/snapcore/snapd/pull/8234>10:34
=== ricab__ is now known as ricab
=== ricab__ is now known as ricab
degvillepedronis / mborzecki: thanks for bringing this up. So, I guess I can get the model names from the model assertions (http://cdimage.ubuntu.com/ubuntu-core/18/stable/current/). If so, I'll add them to the supported platforms page I've already created.10:48
mborzeckidegville: sounds good, there's also a repository with model assertions right here https://github.com/snapcore/models in case it's useful10:51
degvillemborzecki: brilliant, thanks!10:51
mborzeckidegville: some of those are for core20 though10:51
degvillemborzecki: ok, thanks.10:52
pedronismborzecki: seems #8185 needs a master merge?  snapd-failover failed there (cc mvo)11:14
mupPR #8185: tests: add uc20 kernel snap upgrade managers test, fix bootloadertest bugs <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8185>11:14
mborzeckipedronis: i'll merge master and push there, hopefully it's not another unexpected failure more in snapd-failover11:16
mvothanks mborzecki11:17
* zyga has completed fixing snap environment11:31
zygathis was nice11:31
mupPR snapd#7731 closed: usersession/userd: add "apt" to the white list of URL schemes handled by xdg-open <⛔ Blocked> <Created by oSoMoN> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7731>11:51
mupPR snapd#8235 opened: cmd/snap-preseed: handle --reset flag <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8235>11:51
mupPR snapd#7588 closed: cmd/snap: add a "snap routine portal-info" command <Created by jhenstridge> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7588>11:58
mupPR snapd#8232 closed: interfaces: miscellaneous policy updates <Created by jdstrand> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8232>12:05
* zyga lunch12:11
* zyga notices open season for PRs :)12:12
mvozyga: haha - not quite, I think it's just the result of a week of staleness12:14
jdstrandmvo: hi! do you want a separate 2.44-specific PR for PR 8232?12:14
mupPR #8232: interfaces: miscellaneous policy updates <Created by jdstrand> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8232>12:14
ackkhi, I'm seeing these errors when I "snap try" over the current running snap: https://paste.ubuntu.com/p/zQq2cFPCbM/ could it be related to the content interface?12:15
jdstrandmvo: also, is ijohnson off? if so, someone else can review PR 823112:15
mupPR #8231: interfaces/{docker,kubernetes}-support: updates for lastest k8s <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8231>12:15
zygamvo: can we merge https://github.com/snapcore/snapd/pull/8230 once green, I have a fix piled up on top and would love to reuse the branch12:15
mupPR #8230: cmd/snap-exec: add test case for LP:#1860369 <Created by zyga> <https://github.com/snapcore/snapd/pull/8230>12:15
zygaafter lunch I'll address the uio issue raised by a customer12:16
* zyga thanks jdstrand once again for insight on that topic12:16
jdstrandnp :)12:16
mvojdstrand: 8232> if it's not a burden to you, then yes12:22
jdstrandmvo: not at all! coming up :)12:22
mvojdstrand: 8321> I think someone from the team can review it12:23
mvozyga: 8230> we can merge once it has two reviews :)12:23
zygait's just a test showing we have a bug, I guess we can get those quickly12:23
ackkwith a simplified testcase I get: - Setup snap "maas" (unset) security profiles (cannot update mount namespace of snap "maas": cannot update preserved namespace of snap "maas": cannot update snap namespace: read-only file system)12:24
mvozyga: uio> did you figure out more about this?12:24
zygamborzecki: could you look at 8230 please, super easy12:24
mvozyga: yeah12:24
zygamvo: yes, mostly jdstrand did12:24
jdstrandmvo: thanks! I will continue to work on figuring out what to do with a weird k8s access with highest priority. I'd like to say it would be ready today, but I'm not sure yet12:24
zygamvo: I can give you the details now or in the standup, as you wish12:24
mvojdstrand: ok12:24
mvojdstrand: I want to release 2.44-final this week but we are still early12:25
mvozyga: either way is fine, maybe a tl;dr summary here?12:25
zygamvo: tl;dr; is apparor-parser requires hand-holding without the optimizations that we disable; we disable them because they are very slow on smaller systems. The fix involves fine tuning the profile so that we don't hit this pathological case12:26
jdstrandmvo: ack. I'm trying not to cause you any delays! :)12:27
mvojdstrand: :)12:28
mvozyga: nice, thank you12:28
zyga brb12:28
mupPR snapd#8236 opened: interfaces: miscellaneous policy updates - 2.44 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8236>12:36
jdstrandmvo: there you go ^12:36
mvojdstrand: \o/12:36
jdstrandI'll do a similar on for PR 823112:37
mupPR #8231: interfaces/{docker,kubernetes}-support: updates for lastest k8s <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8231>12:37
mvojdstrand: +112:37
mupPR snapd#8237 opened: interfaces/{docker,kubernetes}-support: updates for lastest k8s - 2.44 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8237>12:40
=== sergiusens_ is now known as sergiusens
pedronismborzecki: there's a arch failure in 8185 now: https://api.travis-ci.org/v3/job/660576207/log.txt12:55
pedronispstolowski: did a pass on #8201, bunch of questions13:02
mupPR #8201: tests: mock prune ticker in overlord tests to reduce wait times <Created by stolowski> <https://github.com/snapcore/snapd/pull/8201>13:02
pstolowskipedronis: thanks13:03
mborzeckipedronis: hmm interesting, we had a workaround for a similar problem with snap services in one of the failover tests, restarted the travis job for now, but we'll probably need to add a litte fix tehre to make the test more robust13:11
zygasnapd/boot/export_test.go:38:14 uses type aliases13:11
mupPR snapd#8238 opened: many: fix a pari of ineffectual assignments <Created by zyga> <https://github.com/snapcore/snapd/pull/8238>13:14
zygahttps://www.irccloud.com/pastebin/M7lC1BK4/13:16
mupPR snapd#8179 closed: interfaces: power control interface <Needs Samuele review> <⛔ Blocked> <Created by EthanHsieh> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8179>13:16
zygapstolowski: is this still expected? overlordSuite.TestEnsureLoopPruneAbortsOld13:17
zygapstolowski: IIRC you fixed it last week13:17
pstolowskizyga: yes, but not landed. the PR is being reviewed13:17
zygaah13:17
zygaok13:17
* zyga switches to uio13:20
mupPR snapcraft#2967 closed: requirements: uprev click to 7.1.1 <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2967>13:21
mupPR snapd#8239 opened: interfaces/audio_playback: Fix pulseaudio config access [2.44] <Created by Erick555> <https://github.com/snapcore/snapd/pull/8239>13:28
cmatsuokacachio: I retrieved the image and I'm booting it locally, it's failing in install mode but it's different from what we saw in Frankfurt13:29
cmatsuokahmm, slightly different, but the cause seems to be the same13:32
mupPR snapd#8215 closed: interfaces: make the network-status interface implicit on classic <Created by jhenstridge> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8215>13:42
mupPR snapd#8239 closed: interfaces/audio_playback: Fix pulseaudio config access [2.44] <Created by Erick555> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8239>13:58
mupPR snapd#8236 closed: interfaces: miscellaneous policy updates - 2.44 <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8236>13:59
zyga2fa14:00
zygalogged out again?14:00
mupPR snapd#8240 opened: tests: just remove user when the system is not managed on create-user-2 test (2.44) <Created by mvo5> <https://github.com/snapcore/snapd/pull/8240>14:13
mupPR snapd#8241 opened: interfaces: work around apparmor_parser slowness affecting uio <Created by zyga> <https://github.com/snapcore/snapd/pull/8241>14:13
mupPR snapd#8230 closed: cmd/snap-exec: add test case for LP:#1860369 <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8230>14:15
mupPR snapd#8242 opened: many: improve environment handling, fixing duplicate entries <Created by zyga> <https://github.com/snapcore/snapd/pull/8242>14:34
zyga^ that's a longer PR sorry14:35
zygamvo: about https://github.com/snapcore/snapd/pull/8242 -- let me know if you want a fix that's hacky but small and "maybe ok" for 2.4414:38
zygamvo: otherwise I don't consider it a thing to rush14:38
mupPR #8242: many: improve environment handling, fixing duplicate entries <Created by zyga> <https://github.com/snapcore/snapd/pull/8242>14:38
zygabut please check as the bug affects microk8s14:39
zygaso perhaps we may have to14:39
pstolowskimvo: should the --reset be tagged for 2.44.x?14:39
zygaI did some impact analysis in the bug report, in comment 1314:39
zygahttps://bugs.launchpad.net/snapd/+bug/1860369/comments/1314:39
mupBug #1860369: Python apps broken in MicroStack (a classic snap) after Jan 14 snapcraft update <core20> <snapd:In Progress by zyga> <https://launchpad.net/bugs/1860369>14:39
pedronismborzecki: now it (8185) failed again on arch and also fedora :/14:41
* cachio lunch15:03
mvopstolowski: +115:04
pstolowskik15:04
=== epod is now known as luk3yx
pstolowskimvo: i remember you mentioned 'Core snap is installed when reverting a core18 based snap' ~last week; was the problem understood?15:23
mvopstolowski: no :(15:30
mvopstolowski: I think there is a bugreport and a testcase15:30
mvopstolowski: but iirc noone looked at it15:30
pstolowskimvo: ack, ty15:30
mvopstolowski: https://bugs.launchpad.net/snapd/+bug/186494415:35
mupBug #1864944: Core snap is installed when reverting a core18 based snap <original-1853411> <snapd:New> <https://launchpad.net/bugs/1864944>15:35
mvopstolowski: it even has a test case that looks super easy to convert into ta spread test15:36
pstolowskimvo: yeah, i saw it, just wasn't sure if it was missing an update. i'm trying the steps right now15:36
mvopstolowski: \o/15:37
pstolowskimvo: reproduced15:55
mvopstolowski: nice!15:58
zygaback from break15:59
pstolowskimvo, pedronis: Revert() does not set base in snapsup, so it gets "core" by default16:03
pedronispstolowski: ah16:04
pedronisgood catch16:04
mvopstolowski: \o/ nice find16:04
* mvo hugs pstolowski 16:04
zygapedronis: thank you for the review on environment PR16:07
zygapedronis: I think we could chat about it tomorrow (or when you have time) to figure out what we want to do16:07
zygapedronis: I'll spend the rest of today on fixing the uio performance bug to the point where the draft can be opened and we can try to cherry-pick that to 2.4416:07
zygapedronis: but as I said to mvo earlier, I don't know the priority of the environment bug as it seems to affect microk8s16:08
zygapedronis: could be low (workaround in snapcraft, perhaps) or higher (blocked on us)16:08
pedroniszyga: what's the bug number?16:11
pedronisanyway if this is the fix, we cannot rush it, it's kind of large16:11
zygapedronis: I agree16:12
zygapedronis: it's referred from the 2nd commit, let me find it16:12
zygahttps://bugs.launchpad.net/snapd/+bug/186036916:12
mupBug #1860369: Python apps broken in MicroStack (a classic snap) after Jan 14 snapcraft update <core20> <snapd:In Progress by zyga> <https://launchpad.net/bugs/1860369>16:12
pedroniszyga: it seems the branch adds feature that were not there, like ignoring order of hook envs etc16:26
zygaignoring order of hook envs?16:27
pedroniszyga: ApplyDelta seems much more powerful than SubstituteEnv16:27
pedronis(because of the changed check), I'm not sure fixing a bug and expanding feature should happen together unless they relate to each other16:28
pedroniszyga: SubsituteEnv says very precisely: "and substitutes them top-down from the given environment"16:29
zygapedronis: while that is true I think we need to sit down and evaluate what is the semantics we want; We should check what is documented on snapcraft docs and if that makes sense. We should also check how adapters impact anything. I suspect that previous behavior was buggy in more than one way. At the same time I agree that ApplyDelta is more "able" than previous code and can result in what people meant more than what16:32
zygapeople got16:32
pedroniszyga: I can only repeat my point, if we want this in quickly expanding feature is a problem16:33
zygapedronis: I don't know if this is needed urgently, I hope it's not but in such case I also offered a small targeted branch that fixes PATH issue in a more hacky but controlled way16:34
zygapedronis: I think we should discuss and figure out how to evolve the bigger branch to the point where we are happy with it as my main goal was to fix the type system of the problem. We can discuss and change specific bits of implementation if what I did would affect existing snaps in a way we didn't intend16:35
pedroniszyga: have you tried what happens with the new code and a circular reference ?16:35
zygaI don't believe I have, unless one of the existing tests has effective circular refs16:35
* zyga looks16:35
zygapedronis: both get expanded to empty16:37
zygapedronis: there's an existing test for that16:38
zygapedronis: in env_test.go:26516:38
zyga(it behaved this way before as well)16:39
pedronisyes, but for different reasons16:39
mupPR snapd#8243 opened: o/snapstate: set base in SnapSetup on snap revert <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8243>16:47
pstolowskimvo: ^16:47
zygapedronis: I think this is interesting https://github.com/snapcore/snapd/pull/8242#discussion_r39046105816:50
mupPR #8242: many: improve environment handling, fixing duplicate entries <Bug> <Needs Samuele review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8242>16:50
zygapedronis: I want to EOD soon as I want to sleep a little longer today, would you mind if we parked this until tomorrow?16:51
zygapedronis: I want to spend some more time on the uio code16:51
pedroniszyga: that's fine, my general input that we should try to be more convervative with the change16:51
zygaI agree16:52
mvopstolowski: nice, thank you16:52
zygaI wonder what people would expect in the example I gave, I think it's a good chance we will get 50-50 responses16:52
pstolowskieod, need to run an errand16:52
zygapedronis: note that current code (in master) just inserts both PATH values, because of the bug16:52
zygaso you kind of get a superposition :)16:53
zygabut that's for sure not what we want16:53
pedronisunless we promised that we merge values16:53
pedronisthe one in the app should win16:53
cjp256zyga/pedronis: the priority for build env is high for core20, as it won't generate command wrappers.  snapcraft currently forces the wrappers for when adapter != none, and it became a problem when we stopped generating unnecessary wrappers16:53
cjp256but core20 still isn't for some time, so it's not a rush imo :)16:54
zygapedronis: I wonder if the fact that this was shoved through shell wrappers meant that we got the expanding semantics at any time in the past16:55
zygapedronis: tomorrow I'll write a regression test for this16:55
zygapedronis: as in end-to-end spread test16:55
zygapedronis: at least then it's measured16:55
mvocachio: if you could double check and approve 8240 that would be great17:03
mvozyga: are you around? I wonder how 1866424 should be attacked, it seems a missing gpio should not cause snapd to stop refreshing forever17:09
zygaaround17:09
mvozyga: I wonder if we could make missing gpios a warning?17:09
zygamvo: "ish", the problem is what you want to happen then17:09
mvozyga: but it's a bit tricky as it's a real error17:09
zygabut yeagh17:09
mvozyga: yeah, the gpio will be missing from the profile17:09
zygait's not really missing, the user was holding it wrong (unexporting behind snapd's back)17:09
mvozyga: so subsequent stuff may misbehave17:10
zygabut I agree it's a very bad property17:10
zygamvo: consider this idea:17:10
zygamvo: when an interface instance (plug or slot)'s corresponding method fails, we could mark it as bad and skip it in the profile generation17:10
zygamvo: we could warn (finally a use case for warnings)17:10
zygamvo: it would require some changes around but not too hard17:11
zygamvo: I would rather do it at interface level17:11
zygamvo: rather than at the level of a specific method17:11
zygamvo: because it's more proper, in my eyes, to say "this plug or slot is entirely absent"17:11
mvozyga: yeah, the downside of that is that it requires more discussion/work so it will take longer but I agree17:11
zygamvo: rather than to say "a specific part of the implementation failed so we skipped it"17:12
zygamvo: since those can have security implications17:12
zygamvo: .e.g. apparmor gave you access to /dev but udev tagging failed so you have open access17:12
mvozyga: aha, indeed, I was thinking we would only narrow access down17:13
zygaunfortunately that is not the case17:13
zygamvo: I could look at that after UIO tomorrow17:13
mvozyga: yeah, makes sense. i pasted what you wrote into the bug17:13
zygamvo: if you have an agreement on the design17:14
mvozyga: that would be nice indeed17:14
zygaperfect, thank you17:14
mvozyga: it sounds like we can have a quick chat during standup/after stnadup17:14
zygathat sounds good17:14
zygawhat I said has a scary component17:14
mvozyga: we certainly need samuele to think about it/agree :)17:14
zygabecause what it means if an implicit slot misbehaves?17:14
zygamvo: does it mean it is disconnected17:14
zygais it broken?17:14
zygasome things to ponder over17:15
mvozyga: we could error in those cases maybe?17:15
zygayes but the devil is in the details, a single interface (plug or slot) interacts with loads of parts17:15
zygain my eyes it would be neutered _for the purpose of a given connection_17:15
zygaso not globally17:15
zygaso less chance to break the world17:16
* mvo nods17:16
* zyga EODs without finishing UIO17:22
zygaI'm sorry, need to rest17:23
mvozyga: no worries, get some good rest!17:26
mupPR snapcraft#2965 closed: rosdep: include EOL ROS distros <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2965>18:49
mupPR snapcraft#2964 closed: build providers: remove LXD specific env setup <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2964>19:04
ogra$ grep ubuntu /etc/group19:24
ograsudo:x:27:ubuntu19:24
ogradocker:x:113:ubuntu19:24
ograhmm, so why are there entries for a non-existing ubuntu user in my readonly /etc/group file in core1619:25
mupPR snapcraft#2962 closed: Go: unable to build snap when using `go mod` and main package is not in the root <Created by pavel-d> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2962>21:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!