Chipaca | morning! | 08:47 |
---|---|---|
niemeyer | Hallo! | 09:16 |
Chipaca | there's so much neat code in charmhelpers | 10:15 |
Facu | Muy buenos días a todos! | 11:00 |
Chipaca | Facu: heyy | 11:32 |
Facu | Chipaca, holas | 11:33 |
Chipaca | niemeyer: could you take another pass at the testing pr? it seems good to go from where i stand | 12:07 |
Chipaca | Facu: ditto, wrt docstrings pr | 12:07 |
Facu | Chipaca, sure | 12:08 |
* Facu is fighting juju error units... not in his charm, but in postgresql!! | 12:55 | |
Facu | stupid postgresql | 12:57 |
* Facu kills the unit and re-deploy | 12:57 | |
Chipaca | $ make | 13:07 |
Chipaca | Please add copyright headers to the following files: | 13:07 |
Chipaca | ./.git/logs/refs/remotes/jameinel/document-charm.py | 13:07 |
Chipaca | (and so it goes on) | 13:07 |
Chipaca | sigh | 13:07 |
Facu | Chipaca, not with my branch ;) | 13:09 |
Chipaca | late late late late | 13:31 |
Chipaca | Facu: 2020-03-12 12:33:05 <Chipaca> Facu: wrt PrefixedEvent (and thanks to Dmitrii-Sh for pointing this out) means you do self.on["dumper"] and you get a PrefixedEvent that has non-prefixed events on it | 14:14 |
Chipaca | Facu: that's local time for me, ie GMT | 14:32 |
Chipaca | Facu: https://irclogs.ubuntu.com/2020/03/12/%23smooth-operator.html#t12:23 FWIW | 14:35 |
Facu | Chipaca, I missed that, thanks | 14:42 |
Facu | Chipaca, so, regarding the change of what an Interface could do to hook into the events through the charm... | 15:09 |
Facu | we brought from Frankfurt the idea of doing... | 15:09 |
Facu | mysql_relation_events = charm.on.relation_events_for(mysql_relation_name) | 15:09 |
Facu | self.framework.observe(mysql_relation_events.joined, self._client_joined) | 15:09 |
Facu | I changed it a little to be able to not have different methods for the different event types... | 15:09 |
Facu | mysql_relation_events = charm.on.events_for(relation=mysql_relation_name) | 15:09 |
Facu | self.framework.observe(mysql_relation_events.joined, self._client_joined) | 15:09 |
Facu | But we really can do this *now*... | 15:09 |
Facu | mysql_events = charm.on[mysql_relation_name] | 15:09 |
Facu | self.framework.observe(mysql_events.relation_joined, self._client_joined) | 15:09 |
Facu | So don't know if the change is worthwhile... | 15:09 |
Facu | it looks a little weird accesing 'on' as a dictionary | 15:10 |
Facu | we totally could add a method 'get_events_for' which is really __getitem__ | 15:10 |
Facu | mysql_events = charm.on.get_events_for(mysql_relation_name) | 15:10 |
Facu | self.framework.observe(mysql_events.relation_joined, self._client_joined) | 15:11 |
* Facu wonders if he should open an issue about this | 15:13 | |
Chipaca | Facu: the on being a dictionary-ish thing was a surprise, indeed | 15:20 |
Chipaca | sorry, was getting coffee :-) | 15:20 |
Chipaca | Facu: how does that appear in documentation? | 15:20 |
Chipaca | i'd expect an explicit method to be more obvious | 15:20 |
Chipaca | it's also unclear what .keys() or .values() would be used for in this dictionary :-) | 15:21 |
Facu | Chipaca, right, it's interesting to define if we *really* want to present it as a proper dict | 15:22 |
Chipaca | it has that cool-look-what-i-can-do feeling :-) | 15:23 |
Chipaca | Facu: but it'd be interesting to see it in use | 15:24 |
Chipaca | Beret: see? it works :-D | 15:29 |
Chipaca | whole computer feels sluggish, and on closer inspection the freq is stuck at 800MHz or under | 18:13 |
Chipaca | brb going to reboot into an older kernel to see if it's #22 that's breaking the freq | 18:39 |
* Facu eods | 20:22 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!