[08:47] morning! [09:16] Hallo! [10:15] there's so much neat code in charmhelpers [11:00] Muy buenos días a todos! [11:32] Facu: heyy [11:33] Chipaca, holas [12:07] niemeyer: could you take another pass at the testing pr? it seems good to go from where i stand [12:07] Facu: ditto, wrt docstrings pr [12:08] Chipaca, sure [12:55] * Facu is fighting juju error units... not in his charm, but in postgresql!! [12:57] stupid postgresql [12:57] * Facu kills the unit and re-deploy [13:07] $ make [13:07] Please add copyright headers to the following files: [13:07] ./.git/logs/refs/remotes/jameinel/document-charm.py [13:07] (and so it goes on) [13:07] sigh [13:09] Chipaca, not with my branch ;) [13:31] late late late late [14:14] Facu: 2020-03-12 12:33:05 Facu: wrt PrefixedEvent (and thanks to Dmitrii-Sh for pointing this out) means you do self.on["dumper"] and you get a PrefixedEvent that has non-prefixed events on it [14:32] Facu: that's local time for me, ie GMT [14:35] Facu: https://irclogs.ubuntu.com/2020/03/12/%23smooth-operator.html#t12:23 FWIW [14:42] Chipaca, I missed that, thanks [15:09] Chipaca, so, regarding the change of what an Interface could do to hook into the events through the charm... [15:09] we brought from Frankfurt the idea of doing... [15:09] mysql_relation_events = charm.on.relation_events_for(mysql_relation_name) [15:09] self.framework.observe(mysql_relation_events.joined, self._client_joined) [15:09] I changed it a little to be able to not have different methods for the different event types... [15:09] mysql_relation_events = charm.on.events_for(relation=mysql_relation_name) [15:09] self.framework.observe(mysql_relation_events.joined, self._client_joined) [15:09] But we really can do this *now*... [15:09] mysql_events = charm.on[mysql_relation_name] [15:09] self.framework.observe(mysql_events.relation_joined, self._client_joined) [15:09] So don't know if the change is worthwhile... [15:10] it looks a little weird accesing 'on' as a dictionary [15:10] we totally could add a method 'get_events_for' which is really __getitem__ [15:10] mysql_events = charm.on.get_events_for(mysql_relation_name) [15:11] self.framework.observe(mysql_events.relation_joined, self._client_joined) [15:13] * Facu wonders if he should open an issue about this [15:20] Facu: the on being a dictionary-ish thing was a surprise, indeed [15:20] sorry, was getting coffee :-) [15:20] Facu: how does that appear in documentation? [15:20] i'd expect an explicit method to be more obvious [15:21] it's also unclear what .keys() or .values() would be used for in this dictionary :-) [15:22] Chipaca, right, it's interesting to define if we *really* want to present it as a proper dict [15:23] it has that cool-look-what-i-can-do feeling :-) [15:24] Facu: but it'd be interesting to see it in use [15:29] Beret: see? it works :-D [18:13] whole computer feels sluggish, and on closer inspection the freq is stuck at 800MHz or under [18:39] brb going to reboot into an older kernel to see if it's #22 that's breaking the freq [20:22] * Facu eods