| niemeyer | Good morning all | 10:27 |
|---|---|---|
| niemeyer | Is everyone out today? | 10:27 |
| jam | well, all except you and I | 11:05 |
| niemeyer | :) | 11:05 |
| niemeyer | Hi | 11:06 |
| niemeyer | So yeah, we discussed that issue on Friday a bit | 11:06 |
| niemeyer | Do you have the logs? | 11:06 |
| niemeyer | Let me copy & paste into the PR for the record, and then we can cover it further | 11:07 |
| niemeyer | Done | 11:09 |
| niemeyer | Somehow this doesn't look like an active conversation.. | 11:21 |
| jam | sorry, otp will be back in 20 or so | 11:26 |
| jam | back | 12:01 |
| niemeyer | I'll step out for lunch.. we can catch up in the standup | 12:02 |
| jam | thanks for posting the context in review. | 12:03 |
| jam | ok | 12:03 |
| jam | niemeyer: so your vote on github is still Needs Fixing, so it will block landing. I don't know if you want to change that to Comment and I'll have someone else do a review, or whether you're happy with where it is now. | 13:58 |
| niemeyer | jam: That review point is still open, so I'm happy to have another look once you feel it's ready to go | 14:00 |
| jam | niemeyer: enabled by default and use 'emit' was just pushed | 14:00 |
| niemeyer | jam: Thanks.. I thought it wasn't implemented in terms of individual emitting methods yet.. glad it's almost ready | 14:03 |
| niemeyer | I'm joining the snap standup and will be back shortly | 14:03 |
| jam | so currently I haven't exposed a "emit_relation_changed" as an explicit user request (vs enabling 'update_relation' to trigger a relation changed event). If we want to expose the 'emit' functions we can, but we can also add that later. | 14:06 |
| * Chipaca waves | 16:14 | |
| Chipaca | i'm only here for a couple of meetings today, but hiya | 16:15 |
| niemeyer | o/ | 16:15 |
| * Chipaca EODs | 20:25 | |
| niemeyer | Have a good evening | 20:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!