[10:27] Good morning all [10:27] Is everyone out today? [11:05] well, all except you and I [11:05] :) [11:06] Hi [11:06] So yeah, we discussed that issue on Friday a bit [11:06] Do you have the logs? [11:07] Let me copy & paste into the PR for the record, and then we can cover it further [11:09] Done [11:21] Somehow this doesn't look like an active conversation.. [11:26] sorry, otp will be back in 20 or so [12:01] back [12:02] I'll step out for lunch.. we can catch up in the standup [12:03] thanks for posting the context in review. [12:03] ok [13:58] niemeyer: so your vote on github is still Needs Fixing, so it will block landing. I don't know if you want to change that to Comment and I'll have someone else do a review, or whether you're happy with where it is now. [14:00] jam: That review point is still open, so I'm happy to have another look once you feel it's ready to go [14:00] niemeyer: enabled by default and use 'emit' was just pushed [14:03] jam: Thanks.. I thought it wasn't implemented in terms of individual emitting methods yet.. glad it's almost ready [14:03] I'm joining the snap standup and will be back shortly [14:06] so currently I haven't exposed a "emit_relation_changed" as an explicit user request (vs enabling 'update_relation' to trigger a relation changed event). If we want to expose the 'emit' functions we can, but we can also add that later. [16:14] * Chipaca waves [16:15] i'm only here for a couple of meetings today, but hiya [16:15] o/ [20:25] * Chipaca EODs [20:31] Have a good evening