tlm[m]FYI issue is that version of OpenSSL doesn’t support ecdsa keys, the encoding is fine.01:39
thumperwallyworld: does the caas controller use the machine agent engine?04:27
thumperI think it does, just want clarification04:27
tlm[m]I think so04:27
thumperI realised that my approach isn't working, so I need to back up and try again04:31
* thumper is looking to add dependency engine metrics for worker restart counts04:31
wallyworldthumper: yeah, it does with a few tweaks04:36
wallyworldthere's a separate caas model set of workers04:36
wallyworldand separate caas application agent (vs unit agent)04:36
* thumper nods04:37
thumperI still need to backup though04:37
thumperyay metrics04:37
wallyworldthumper: i don't get why we need remote-application since it can be inferred from the unit name04:59
wallyworldmaybe babbageclunk knows?04:59
thumperit is there for application relation changes05:00
thumperI don't think it should be needed for non-application relation changes05:00
thumperbut the validation is there now05:00
thumpersomething to be cleaned up maybe?05:00
thumperbut we need to provide people with the way to unblock05:00
wallyworldupgrading should not even result in any app relation changes, right? since the charms don't have that yet05:00
thumperbut if someone upgrades to 2.7.5, they need a way to unblock themselves05:01
wallyworldhence it seems wrong to expect that entry when it's not even used in the context of the hook05:01
wallyworldyes, workaround needed, but also agree we should fix05:02
wallyworldanother 2.7.6 fix i'd say05:02
wallyworldwell *the* 2.7.6 fix05:02
thumperwallyworld: yeah, I think achilleasa is going to look next week05:02
* thumper EODs05:02
wallyworldhpidcock: i think you fix bug 1849660 right?05:13
mupBug #1849660: AWS A1 instances are not available via juju in eu-central-1 <juju:Triaged> <juju 2.8:Triaged> <https://launchpad.net/bugs/1849660>05:13
hpidcockwallyworld: might need to run the AWS update scripts05:14
wallyworldi thought we had already? i thought the bug was fixed but just not marked as fix committed05:15
hpidcockoh yeah05:16
hpidcockshould be fixed'05:16
wallyworldta, will makrk as such05:16
hpidcockwallyworld: if you feel like a PR readthrough of the charm upgrade stuff05:16
hpidcockstill working through it, needs some cleanup possibly05:17
hpidcockbut it works05:17
wallyworldhpidcock: wanna rebase and resolve conflicts?05:22
hpidcockwallyworld: one momento, having lunch05:38
wallyworldall good, i've got plenty to do05:39
achilleasawallyworld: I will work on that next week. Should be a simple upgrade step (read unit name, mangle it to an app name and write it back to the state file). I may be able to cobble together a sed script to use as a manual workaround for stuck units until the fix lands08:12
achilleasacan I get a CR on https://github.com/juju/juju/pull/11390?08:53
achilleasawhoops... ^ needs rebasing to resolve conflics08:54
stickupkidI don't get this, I don't know what it gives you? https://github.com/go-goose/goose/blob/v2/http/client.go#L111-L11209:20
stickupkidif you want to pool http clients, the there are better ways09:20
stickupkidmanadart, https://github.com/go-goose/goose/pull/8510:07
stickupkidjust updated the description10:10
manadartstickupkid: OK.10:13
=== parlos is now known as parlos_afk
achilleasaI have resolved the conflicts on 11390. Can I get a CR on it? (if you review it make sure you run the QA steps for both actions/hooks)10:19
wallyworldachilleasa: i don't understand why we even need that yaml attribute since the app name can always be derived from the unit name, and if it is used to signal the hook is firing as a result of an app data change ,that's fine, but it shouldn't be needed otherwise, and in this case, it definitely doesn't seem valid to error because the system is being upgraded from one where there's no app relation data10:29
wallyworldso perhaps there's a bigger problem to fix10:29
achilleasawallyworld: my guess is that it's a sanity check introduced as part of the application databag work10:33
wallyworldstill doesn't seem right ti me10:34
achilleasawallyworld: AFAICT from the validation code, for RelationChanged it seems like you are allowed to have an empty unit but the application must always be populated. Maybe it's there to signal something on the application level?10:37
wallyworldinteresting. not being familiar with the code, my thought was that one of app/unit must be optional, it seems unit is the optional one10:38
achilleasawallyworld: though for RelationJoined/Departed both are required10:38
wallyworldthat seems weird since if you know the unit, you know the app10:39
wallyworldmight need to ask xtian/john10:39
manadartstickupkid: Do we need the Options defs in both http/client.go and client/client.go?10:42
stickupkidmanadart, well I'm unsure if people are using http/client directly. If so, we do need to do that to ensure backwards compatibility. Otherwise we have to move to v3 of goose10:43
stickupkidmanadart, if we're sure then I probably just set it in the constructor, but that means a signature change etc10:44
manadartstickupkid: So can't we use the http/client ones in client/client?10:44
manadartWe already import it...10:44
stickupkidmanadart, it would seem weird that client/client constructor takes http/client ones no?10:45
stickupkidmanadart, what if client/client wants it's own options?10:45
manadartstickupkid: I can live with it.10:46
stickupkidmanadart, i'm not a fan by the way, I just wanted to be safer10:46
stickupkidmanadart, my prefered method is make a factory10:47
jamguild, has anyone felt that juju 2.8 takes *much* longer to link than 2.7 ?12:30
hmljam, not that i’ve noticed.  but add-model seems to take a longer time than i’d expect.12:31
jamtime go test -check.v in cmd/juju/commands takes around 30s before it gets to the 5s test.12:32
jamwhich the test itself is stupid slow, but 6x slower to compile it.12:32
=== parlos_afk is now known as parlos
=== parlos is now known as parlos_afk
hmlachilleasa:  resolved comments in https://github.com/juju/juju/pull/11376 and retested upgrade15:51
stickupkidjam, I'll keep my eye out, I might use my old computer as my new one is stupid fast15:52
jamstickupkid, so I also got a new machine this year, dropped my compile times by something like 6x (yay massive cores).15:59
jamgit co 2.7; dep ensure -v -vendor-only; time go install github.com/juju/juju/... 1m1s15:59
jamback to 2.8, its 57s, so maybe I'm just crazy15:59
jamstickupkid, so I'm not entirely crazy 'time go install' was the same, but16:08
jamcd cmd/juju/commands; time go test -check.v -check.f dontrunanytests16:08
jamis 36s vs 51s16:09
stickupkidgit co 2.7 and install took 30s for me.16:09
jamanyway, 30s to spin up a test suite takes it way outside the 'productive loop' for me.16:09
stickupkid2.8 took 21s16:10
jamvery nice16:10
stickupkidi'll see what the cmd/juju/commands one is16:10
stickupkid9s for 2.816:11
stickupkidroughly the same for 2.716:12
jamstickupkid, what go version are you running?16:14
stickupkidI should move it back to 1.1216:15
jamI'm on 1.13.9 (whatever from snaps),16:15
stickupkidnot on a snap16:15
stickupkidit doesn't play well with my editor16:16
jamstickupkid, have you ever seen 'dep check' say that Gopkg.lock doesn't match?16:19
jamstickupkid, I hit a weird bug where static_analysis failed on my machine, but if I push the PR updating Gopkg.lock it says it doesn't match on the bot16:20
jamstickupkid, but I don't know how to clear out whatever cache dep is using that has a bad version in it.16:20
stickupkidjam, yeah, but not for a long time, me achilleasa ran into it. Note: you can't remake the Gopkg.lock from scratch, you need a seeded version16:20
stickupkidjam, nuke your vendor folder?16:21
jamstickupkid, yeah, I'm aware you can't reset Gopkg.lock when I was figuring out dep ensure in the beginning.16:21
jamI deleted the dir from vendor, but not the whole dir, maybe I'll try that16:21
jamstickupkid, I noticed static analysis complaining about a bunch of stuff I didn't touch. Was the test added recently?16:22
stickupkidjam, nope, got a link16:23
jamstickupkid, https://jenkins.juju.canonical.com/job/github-static-analysis-go-juju/2149/console16:24
stickupkidjam, it doesn't like this file for some reason https://github.com/juju/juju/pull/11389/files#diff-6e09331bad8b6f463aba28902512a50d16:26
stickupkidjam, I suspect the github one is using a different version than local, i.e. it's probably because it's 1.12 v 1.1316:33
=== parlos_afk is now known as parlos
jamstickupkid, so client_test I fixed, it was that I had an import in the wrong section16:57
jambut it was complaining about more than that.16:57
stickupkidyeah, I need to clean up the grep output, it's because generated files really message that output up16:57
jamstickupkid, https://pastebin.canonical.com/p/Sb8MzPvn4D/16:57
jamI can fix client_test.go which I did touch, it was the leadership upgradeseries, mock_statetracker etc16:57
jamthat I didn't touch16:58
jamthat made me confused16:58
stickupkidjam, yeah, ignore them16:58
jamstickupkid, also, it doesn't say *what* the issue is, just "there was an issue"16:58
=== parlos is now known as parlos_afk
jamI had to figure out (a) it was go-import and (b) that it was a problem with client_test.go16:58
stickupkidjam, agreed16:59
jamstickupkid, also it mentions output.tar.gz but I couldn't find that as part of Jenkins anywhere16:59
stickupkidjam, I'm thinking that the output would be better served in s3, jenkins just isn't reliable for us around this17:01
bdxI wanted to bring up https://bugs.launchpad.net/juju/+bug/184991617:01
mupBug #1849916: [jaas] add-model doesn't respect region <juju:Incomplete> <https://launchpad.net/bugs/1849916>17:01
bdxthis bug is still impacting myself and others, the same way that it was on 2019-10-2617:02
bdxit's pretty critical for us, because it blocks us from using/creating models on jaas17:02
bdxI'll be around to help give some info and/or diagnoses on this if need be17:03
bdxif someone who knows these waters might be kind enough to lend hand at looking into this further it would be greatly appreciated17:04
achilleasahml: there is an error in one of the upgrade tests in 1137617:33
hmlachilleasa:  i’ll take a look17:34
achilleasaother than that I think it's ready to land. Do you want me to approve it now before my EOD so you can land it once the errors are fixed?17:35
=== tvansteenburgh1 is now known as tvansteenburgh
hmlachilleasa:  yes please…  if there’s a big change to fix the test, i’ll have someone review that piece from NZ/AU17:36
=== parlos_afk is now known as parlos
hatchbdx I'll send this around to some folks to see if they have any ideas as it's outside of my wheelhouse17:49
hmlachilleasa:  it was an easy fix, had to update the args for a call in the test which changed signature.17:53
hmlachilleasa:  verifying in github jobs, then squash and merge17:53
bdxhatch: thanks!17:56
wallyworldthumper[m]: https://github.com/juju/juju/pull/1139621:02
wallyworldthumper: you gonna look at my pr? it will make you happy23:01
babbageclunkcan someone take a look at my juju-restore pr to fix HA node counting? https://github.com/juju/juju-restore/pull/1323:01
thumperwallyworld: which PR?23:01
wallyworldthumper: it's posted above23:01
thumperwallyworld: I was probably not here23:02
wallyworldasked via github to :-)23:02
thumperwallyworld: yep, will get to it after my call with timClicks23:03
thumperwallyworld: 71 files? what have I gotten myself into?23:09
wallyworldthumper: it's mechanical :-) and you will lovethe result23:10
thumperI'm reviewing now23:10
thumperwallyworld: approved with one change requested23:24
wallyworldty will look after meeting23:24
thumperbabbageclunk: approved with one change requested too23:29
* thumper goes to get lunch now23:29
babbageclunkthumper: awesome thanks!23:39

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!