/srv/irclogs.ubuntu.com/2020/04/02/#snappy.txt

mupPR snapd#8398 opened: usersession/userd: add "slack" to the white list of URL schemes handled by xdg-open <Created by troyready> <https://github.com/snapcore/snapd/pull/8398>01:05
mborzeckimorning05:45
mborzeckimvo: hey06:47
mborzeckimvo: the console_conf PR in subiquity has landed06:48
mborzeckimvo: i'm assembling the image to try everything out06:49
mvohey mborzecki06:54
mvomborzecki: niiiiiiiiiiiice06:54
pstolowskimorning07:01
mvohey pstolowski07:10
mborzeckipstolowski: hey07:37
mupPR snapd#8397 closed: cmd/snap-confine/mount-support-nvidia.c: add libnvoptix as nvidia library <Simple πŸ˜ƒ> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8397>07:39
zygaHey07:43
zygaHad a very fractured night07:43
zygaBarely awake now07:43
zygaSorry, I will be late today07:43
zygaI will not be at the desktop sync07:44
mupPR snapd#8382 closed: packaging: detect/disable broken seed in the postinst <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8382>07:50
mvopedronis_, zyga, pstolowski, mborzecki I will release 2.44.2 this morning, please let me know if there is anything last-minute you want to have in it07:56
mupPR snapd#8226 closed: interfaces/policy/policy_test.go: add more tests <Created by jdstrand> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8226>07:57
zygaack07:57
=== pedronis_ is now known as pedronis
zygamvo: I would really like to have https://github.com/snapcore/snapd/pull/808907:57
mupPR #8089: features: enable robust mount ns updates <Created by zyga> <https://github.com/snapcore/snapd/pull/8089>07:58
zygamvo: but it's up to you07:58
mvozyga: hm, it's not on master yet, we should at least get it there07:59
zygamvo: yeah but it's pending for a long time08:00
zygajust shinging some light on it08:00
mvozyga: ta08:00
zygaif it helps our customers enable it via gadget08:00
zygaand it's well-known to improve08:00
zygaer, cause improvements08:01
* zyga is trying to say awake08:01
mvozyga: I'm not against it, just saying it needs to land in master first and get reviews etc08:01
mvozyga: haha - did you had coffee already :) ?08:01
zyga+3/-2 - let's review it :)08:01
zygamvo: yeah, my wife just brought me a cup08:01
zyga2-3 AM, 4AM, 6AM wake-ups (for me) last night, not great08:02
mborzeckimeh, when i repack cor20 snap the system no longer boots, it stops at initrd-switch-root and complains it cannot resolve /sbin/init even though /sysroot/sbin/init is there (though it points to /lib/systemd/systemd but it's there too)08:03
pstolowskimvo: thanks, i don't have anything08:03
zygamborzecki: is there any write-up on how to try core20 locally?08:04
zygamborzecki: can you please review the tiny branch referenced above (8089)08:04
mborzeckizyga: try or build?08:04
zygamborzecki: be able to run from source08:04
zygamborzecki: boot and see what happens, etc08:04
zygamborzecki: (in qemu)08:04
mborzeckizyga: i don't think so, but it's the usual thing, grab the model, build image with u-i, run qemu but adding UEFI08:05
pstolowskigrr during the transition to new laptop i forgot to set git author initially and managed to commit with defaults to all my PRs, and have to fight with CLA checks (need rebasing to fix as it's for past commits, not just latest)08:05
zygammm08:05
zygapstolowski: ouch, there's a way to rewrite the author and committer documented in git rebase08:06
zygapstolowski: you didn't migrate your HOME?08:06
pstolowskizyga: i know of git commit --amend --reset-author which works for last commit; i'm not sure rebase has anything specific like that, but simply rebasing fixes this08:17
abeatohm, CI fails on 'apt update'08:17
pstolowskizyga: yeah i didn't migrate home, i wanted to have clean slate (instead of removing cruft after migration)08:18
* zyga nods08:18
mborzeckiaah08:21
mborzeckiw8, how's that even possible?08:21
zygamborzecki: 2 st phase of debugging08:24
zyga2st is a new number, between 1st and 2nd08:24
* zyga should sleep08:24
* mborzecki trying a differnt rsync incantation08:26
mborzeckirsync --wingardium-leviosa --dwim08:28
zygait works on 2st try08:28
mborzeckiyup, much better now08:31
abeatocould somebody retrigger tests for https://github.com/snapcore/snapd/pull/8320 ?08:47
mupPR #8320: interfaces: updates to login-session-observe, network-manager and modem-manager interfaces <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/8320>08:47
mupPR snapd#8399 opened: interfaces/policy: fix comment in recent new test <Created by pedronis> <https://github.com/snapcore/snapd/pull/8399>08:48
mborzeckibtw. snap debug state is super slow when there's many tasks08:49
mupPR snapd#8400 opened: osutil: make the TestWriter() test less racy <Simple πŸ˜ƒ> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8400>08:55
zygamvo: let's merge it but I left a kind of -1 comment09:07
mvozyga: tell me how to do it non-racy :)09:07
mvozyga: I thought aobut it but couldn't come up with an idea09:07
zygathat's much more towards a solution than what we usually do :)09:07
zygamvo: no that I disagree it is hard09:07
mvozyga: I mean, we test that during the time until the deadline is triggered we get data09:08
mvozyga: *if* the system is that slow that there is just no thread scheduled during $time we lost09:08
zygamvo: but just doing 0.1 seconds * number_of_times_we_had_to_change_it really feels iffy09:08
zygamvo: I get that, but in general a test for more than one concurrent activity must not be based on wall clock time09:09
mvozyga: well, $time is a fundamental part of the test, so I don't really know how to do it non-racy, I'm open for ideas though09:09
zygamvo: here it seems that way but really what you want is to show a certain sequence of events happens in two threads09:09
zygamvo: not that it took this amount of time or that amount of time09:09
mvozyga: yes, in general I agree, but this test is precisely about testing wall-clock behavior09:09
zygamvo: anyway, I will look09:09
zygamvo: I think at some point the tipping point makes us research how to deal with sutuff09:10
zyga*stuff09:10
zygamvo: I can only re-iterate that this is not about that wall clock time _at all_ but about the sequence09:10
zygamvo: in a way if we find a way to do this we will get correct *and* faster tests09:10
mvozyga: did you look at the test? it's about hitting a deadline and what happens until this deadline is hit09:10
zygaas arbitrary sleep durations go away09:11
zygamvo: I did, perhaps my point is not expressed clearly enough though09:11
zygamvo: anyway, I will look09:11
mvozyga: don't get me wrong, I agree 100% in general, but I don't see how to do this for this specific case09:11
mborzeckihmmm soo, the chooser run nicely in a local terminal, but is stul reading from stdin when running in a uc20 shell, same command line but different effect09:12
mborzeckieven simple echo '{}' | python3 -m console_conf.cmd.tui --recovery-chooser-mode is stuck09:12
mvomborzecki: oh no!09:13
pedronismvo: mmh09:13
zygamborzecki: can you debug log the mode of stdin/stdout09:13
zygamborzecki: are you in binary or text mode09:14
zygamborzecki: what's the encoding?09:14
mborzeckiah w8, maybe that09:14
pedronismvo: those tests are really testing context.WithTimeout, not our code09:14
zygamborzecki: cheers :)09:14
pedronismvo: so a bit unclear if need all of them, or the cancel one is enough09:14
pedronisor we just need our own base context09:14
mvopedronis: fair enough, we could remove it entirely09:15
mvopedronis: happy to update the PR to remove it, wdyt?09:17
pedronismvo: I think the Cancel one is enough, but maybe I'm missing something ?09:17
pedroniswe lose the happy case ?09:17
pedronismaybe the happy case is just with a cancelable that we cancel after and not before09:18
mvopedronis: I guess so, I don't know more about this particular case then you :) it was a drive-by from my bug triage09:18
mupPR snapd#8401 opened: snap: improve TestWaitRecovers test <Simple πŸ˜ƒ> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8401>09:18
zygamborzecki: the chooser was merged but I will continue with my review09:23
zygamborzecki: there are some things that probably ought to be followed upon09:23
mwhudsoncan i make stage-packages: architecture dependent?09:24
mvomwhudson: iirc "- on amd64\n  - "pkg"" works09:25
mwhudsonmvo: just found a forum post with a syntax like that, yeah09:25
mwhudsonmvo: is it documented at all?09:26
mvomwhudson:09:26
mvomwhudson: https://forum.snapcraft.io/t/architectures/497209:26
mvomwhudson: I thnk that might be the docs09:26
mvomwhudson: actually no09:26
mvomwhudson: it's just about the architecture :/09:26
mwhudsonlike can i say - on amd64, arm64\n  - efibootmgr09:27
mborzeckidamn, it works over ssh, but not in a console09:27
mborzeckizyga: ^^09:27
zygamborzecki: what do you get in the console09:27
mvomwhudson: yeah, this should work09:27
zygamborzecki: binary/text?09:27
zygamborzecki: and what encoding if text09:27
mborzeckieven though i added LANG, TERM and whatnot in the console09:27
zygamborzecki: did you add the debugging?09:28
mvomwhudson: I couldn't find docs for this, might be worthwhile to check with degville and/or the snapcraft guys if "stage-package:\n- on $arch:\n  - pkg1" is documented somewhere and just hard to find09:28
mwhudsonmvo: i shall whine on the forum!09:29
mvomwhudson: :) +109:29
abeatomvo, could you please retrigger tests for https://github.com/snapcore/snapd/pull/8320 and https://github.com/snapcore/snapd/pull/8220 ?09:33
mupPR #8320: interfaces: updates to login-session-observe, network-manager and modem-manager interfaces <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/8320>09:33
mupPR #8220: interfaces/seccomp: allow passing an address to setgroups <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/8220>09:33
mwhudsonmvo, degville: what's "try" about in this context?09:41
mvoabeato: sure, looking09:42
mwhudsonaaah i found https://snapcraft.io/docs/snapcraft-advanced-grammar09:43
mupPR snapd#8320 closed: interfaces: updates to login-session-observe, network-manager and modem-manager interfaces <Created by alfonsosanchezbeato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8320>09:49
pedronismborzecki: mvo: what's the status of #8253 ?09:50
mupPR #8253: snap-bootstrap: expand data partition on install <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8253>09:50
pedronismvo: do we need it for beta?09:50
mborzeckipedronis: thought i +1'ed it already, let me check09:51
mborzeckipedronis: there's an open question about explicitly identifying expand/noexpand for partitions at the gadget yaml level, but i don't think we can resolve it now09:52
mvomborzecki: I would say let's always expand and if we have a use-case *not* to do that we can add an extension to the gadget.yml (cc pedronis) - irrc this is what I suggested in there too, no?09:58
pedronismvo: it sounded you suggested the reverse, to have an explicit way to expand10:15
mvopedronis: that was my first thinking but that's silly, it will be the common case I think, let me clarify10:15
mvopedronis: I updated the PR with my thinking, hope it makes sense10:20
mupPR snapd#8378 closed: o/configcore: introduce core config handlers (3/N) <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/8378>10:29
mupPR snapd#8402 opened: o/configstate: add backlight option for core config <Created by stolowski> <https://github.com/snapcore/snapd/pull/8402>10:38
mupPR snapd#8160 closed: overlord/configstate: add backlight option <Created by EthanHsieh> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/8160>10:40
mupPR snapd#8220 closed: interfaces/seccomp: allow passing an address to setgroups <Created by alfonsosanchezbeato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8220>10:47
mborzeckimvo: soo it works :P10:57
mborzeckimvo: need to patch subiquity though10:57
ijohnsonmorning folks11:00
ijohnsonhey mborzecki seems I missed the deadline on your subiquity PR, but I still would like to do a review11:00
zygaijohnson: I'm doing a review as well11:01
mborzeckiijohnson: hey, no problem11:01
zygaI think that's good11:01
zygaand yes, you should too11:01
mborzeckibtw. so with patched subiquity, it works, i can trigger the chooser, the UI runs and all, reboot is requested11:01
mborzeckibut then i get this: https://i.imgur.com/IYb0mgs.png11:01
mborzeckiit'd noble that it's trying fd0 but i doubt it's gonna succeed anytime soon11:02
zygafd0?11:02
zygawhaat :)11:02
zygainsert assertion in disk A and pres return to continue ;D ?11:02
zyga*press11:02
mborzeckihaha right? :)11:02
ijohnsonhaha wow11:03
zygamborzecki: https://github.com/CanonicalLtd/subiquity/pull/655#pullrequestreview-38564836411:04
mupPR CanonicalLtd/subiquity#655: console_conf: implement UC20 recovery chooser <Created by bboozzoo> <Merged by xnox> <https://github.com/CanonicalLtd/subiquity/pull/655>11:04
pstolowskipedronis: is this https://forum.snapcraft.io/t/how-to-install-and-enable-syslog/15012 the general idea wrt persistent storage config flag?11:05
zygapost merge review for https://github.com/snapcore/snapd/pull/8370#pullrequestreview-38553048311:07
mupPR #8370: snap-bootstrap: fix disk layout sanity check <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8370>11:07
pedronispstolowski: yes,  something like that, not sure the directory needs to be created or not11:07
pedronisit needs to be created for auto11:07
pedronisbut not sure about persistent11:07
zygaijohnson: can you review https://github.com/snapcore/snapd/pull/8389 as well, it would help me make progress11:10
mupPR #8389: tests: make session tool way more robust <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8389>11:10
ijohnsonsure I was meaning to look at it11:10
zygait's not the end of that road11:11
zygabut it's a step along the way11:11
pstolowskipedronis: ok. so we want to support actual systemd storage type as a config option (auto|persistent), and not simplify it/hide it behind e.g. persistent=true|false?11:11
pedronispstolowski: just persistent=true|false, I don't think auto makes a lot of sense for use on core11:16
pedronispstolowski: it might be that we implement false as auto11:17
pedronisbut not sure , we can discuss in the PR11:17
mborzeckiso should the auto-import udev rule have KERNEL!="fd*" as well?11:17
pstolowskipedronis: ok, thanks11:18
zygapstolowski: https://github.com/snapcore/snapd/pull/8402#pullrequestreview-38632744911:18
mupPR #8402: o/configstate: add backlight option for core config <Created by stolowski> <https://github.com/snapcore/snapd/pull/8402>11:18
pstolowskizyga: thanks11:19
ijohnsonzyga: approved with a question about busctl11:24
zygaijohnson: looking11:24
zygaFYI, the contributor needs to go through the CLA process11:25
zygaI didn't find any documentation on that in our HACKING11:25
zygashould we have some?11:25
zygahttps://github.com/snapcore/snapd/pull/839811:25
mupPR #8398: usersession/userd: add "slack" to the white list of URL schemes handled by xdg-open <Created by troyready> <https://github.com/snapcore/snapd/pull/8398>11:25
zygaijohnson: replied11:27
ijohnsonthanks11:28
zygaijohnson: I added one more comment at the bottom of session-tool spread test11:32
zygaijohnson: I wanted to take a break from this monstrosity and look at other things for a while (reviews) but I need to address this in a follow-up11:32
zygaijohnson: if you are happy with my comments I will merge this now11:32
ijohnsonsure no problem11:32
ijohnsongo for it11:32
zygathank you!11:33
zygaI'll include -- and the comments you mentioned in a follow up11:33
zygaand now reality will verify my oh-so-alredy-regretful commit message11:33
zyga"make session tool way more robust"11:33
mupPR snapd#8389 closed: tests: make session tool way more robust <Test Robustness> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8389>11:33
ijohnsonnext PR: "make session tool way way way more robust for realz this time (I promise)"11:34
zygaijohnson: I will probably use "tests/session-tool: you cannot wait to see how this will break next"11:34
ijohnsonzyga: "tests/session-tool: this one weird trick makes old linux distros so mad"11:35
zygaijohnson: "tests/session-tool: mark as manual and move to tests/masochism"11:37
zygaI'll go make coffee and return to prepare the big PR with things that have recently landed11:41
mvomborzecki: nice, is the patch complicated?11:49
mborzeckimvo: no, it's quite trivial, got merged already11:50
zygaogra: https://github.com/snapcore/snapd/pull/8329#pullrequestreview-38587686812:14
mupPR #8329: interfaces: allow raw access to USB printers <Created by ogra1> <https://github.com/snapcore/snapd/pull/8329>12:14
zygamborzecki: is your comment on https://github.com/snapcore/snapd/pull/8377 a +1?12:26
mupPR #8377: sandbox/cgroup: add ProcessPathInTrackingCgroup <Created by zyga> <https://github.com/snapcore/snapd/pull/8377>12:26
mupPR snapd#8399 closed: interfaces/policy: fix comment in recent new test <Skip spread> <Created by pedronis> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/8399>12:29
sdhd-saschahi, all :-)12:39
mupPR snapd#8377 closed: sandbox/cgroup: add ProcessPathInTrackingCgroup <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8377>12:42
sdhd-saschaI didn't write C++ yet. I read a lot about it, around 12 years ago. Now, i help a very very litle bit with the backend of #WirVsVirus. What DB layer is scalable, and NoSQL. What DB should is a choice for this task ?12:43
sdhd-saschaCan anybody give a hint ?12:43
zygasdhd-sascha: don't use json with manual serialization12:44
sdhd-saschazyga: ?12:45
zygasdhd-sascha: we don't have experience with nosql beyond that I think12:45
sdhd-saschai found mongo, with this: https://github.com/datastax/cpp-driver12:46
sdhd-saschaBut, why use in 2020 a language where i have to free memory manually ?.... Oooh12:46
sdhd-saschaDon't know why C++ was the choice... ;-)12:46
ograzyga, commented12:48
mupPR snapd#8401 closed: snap: improve TestWaitRecovers test <Simple πŸ˜ƒ> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8401>12:48
* ogra curses ... why did nvidia *completely* change with the nvidia-4XX series .. 12:49
zygaogra: to punish us for not pushing ahead with nvidia-runtime snap12:49
ograyeah apparently ...12:49
zygamvo: master is over 50 minutes in travis now12:50
zygamvo: we're going to see failures soon12:50
ograsadly i have a snap where i need to force-preload the nvidia libs (it completely unsets LD_LIBRARY_PATH and is proprietary) ... works just fine with nvidia-3XX and before ... but with 440 ... i get12:51
ograERROR: ld.so: object '/var/lib/snapd/lib/gl/libOpenGL.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.12:51
* sdhd-sascha ogra: ooh, nvidia ;-)12:51
ograthe lib is there with find and ls and the ldd dependencies dont seem to have changed vs 3XX either ... i dont get why i cant preload it12:52
zygaogra: it's classic?12:52
ogranope12:52
ograstrict12:52
zygahmm12:52
ograzoom-client12:52
zygacan we ldconfig to look at /var/lib/snapd/gl12:52
zygaand drop that silly SNAP_LIBRARY_PATH thing?12:53
ograwell, all these vars get unset by the zoom binary ... i cant make any use of them anyway12:53
zygaogra: hence >  can we ldconfig to look at /var/lib/snapd/gl12:53
zygaogra: so no variables at all but it _still looks_12:53
zygaogra: we could even be more ... say, creative12:54
zygaand have a new mount point12:54
zyga /app12:54
ograhmm12:54
zygaand mount current revision of the app there12:54
zygaand have a fixed ldconfig12:54
ogradoes ldconfig actually load anything ? i thought it only resolves deps ...  i need them in ram before the app starts12:54
zygaso we take libs from [/var/lib/snapd/lib/*, /app/lib/$triplet, regular locations]12:55
ograor do you mean combine ldconfig and LD_PRELOAD ?12:55
zygaogra: it finds them12:55
zygae.g. copy a .so to /usr/local/lib12:55
zygaand run a binary that needs it12:55
zygathen ldconfig12:55
zygathen run it again12:55
zygawe could essentially tell the linker, here they are12:55
ograyes, but zoom doesnt if it isnt loaded already12:55
zyga?12:55
zygathis is entirely unrelated to zoom12:55
ograwell, i can try ...12:56
zygait would be some work12:56
zygabut as a spike to see if it works12:56
zygaI think it could12:56
zygarepackage core snap to have different ldconfig12:56
abeatoijohnson, fyi I have UC20 running yesterday, the crash happened because I was greedy and was no giving enough memory to kvm - I've found I need at least 2GB.12:59
ijohnsonah yes that's another thing I forgot to tell you :-)12:59
ogra2GB ... nobody thinks of the netbooks !13:00
abeatoijohnson, and the problem with the eth was related to the image, the one I built locally had some problem, maybe I need edge ubuntu-image13:00
abeatothe cdimage one worked in the end13:00
ijohnsonabeato: ah that's great news13:19
abeatoijohnson, yeah, really happy to start testing uc20 :) - thanks for your help13:21
zygahttps://github.com/google/thread-weaver13:27
ogramoving snapd to java now ?13:29
zygacore 22j13:29
ograhah13:29
zygawe can finally support arm7tdmi13:31
ograyay, finally going for ARMv4 :)13:32
* ogra digs in the box for old nokia phones to run core on13:33
mupPR snapd#8219 closed: interfaces: use udev backend if udev socket exists <Security-High> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8219>13:43
mupPR snapd#7963 closed: xdgopenproxy: forward requests to the desktop portal <β›” Blocked> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/7963>13:46
zygamborzecki: follow up https://github.com/snapcore/snapd/pull/840313:52
mupPR #8403: sandbox/cgroup: avoid making arrays we don't use <Simple πŸ˜ƒ> <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/8403>13:52
mupPR snapd#8403 opened: sandbox/cgroup: avoid making arrays we don't use <Simple πŸ˜ƒ> <Skip spread> <Created by zyga> <https://github.com/snapcore/snapd/pull/8403>13:52
ijohnsonhey I fixed the usb audio thing, yet again my usb hub seems to be causing problems :-/ plugging the device directly into my desktop makes it work fine14:18
* ijohnson is happy with high fidelity audio output now14:18
mupPR snapd#8404 opened: client: increase timeout in client tests to 100ms <Simple πŸ˜ƒ> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8404>14:35
mvozyga: you will love this test failure https://paste.ubuntu.com/p/yKy6G2x59x/ (in a PPA)14:54
mupPR snapd#8089 closed: features: enable robust mount ns updates <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8089>15:01
zygamvo: looking15:06
zygaMvo: heh15:06
mvozyga: I will look later15:06
mvozyga: in a meeting right now15:06
* zyga hugs mvo15:07
mvozyga: but yeah, lots of fun, the PPA is super slow right now15:07
zygaI’m sorry, I know we are in tough times15:07
zygaback now15:19
* zyga took a walk15:19
zygaI guess people are renting dogs to walk now15:20
zygaI see more people with dogs than I ever did here15:20
* zyga stares at tig output15:28
zygatime to rebase that WIP thing away15:28
zygahmmm15:43
zygaimport cycle15:43
zygaperfect :)15:43
zygahttps://www.irccloud.com/pastebin/cBg4Sia0/15:43
zygaclient -> asserts -> release ->sandbox/cgroup -> naming -> snapdenv -> release15:43
zyga"fun"15:43
zygaI really dislike this part of go15:43
zygaas theoretically nice it may be15:43
* zyga wonders what to do15:44
zygacan snapdenv not import release?15:44
zygapedronis: how would you feel if I changed snapdenv.SetUserAgentFromVersion to take arguments instead of consuming release as a package?15:45
pedroniszyga: to be honest I feel the proble here is more release -> sandbox/cgroup15:48
zygaok, let me check why that is there15:48
zygaForceDevMode wants to know15:48
zygapedronis: how about we move ForceDevMode to sandbox/ ?15:49
pedronisyes, that would have been my proposal too15:49
pedroniswe can keep some tables or something in release if that make sense15:49
pedronisor move them15:49
zygapedronis: the, funny enough, release will be about os-release again :D15:49
zygaok, let me try :)15:49
mupPR snapd#8405 opened: boot: simplify modeenv mocking to always write a modeenv <Simple πŸ˜ƒ> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8405>15:56
zygafun15:58
zygaso many cycles15:58
mvomborzecki: I merged 8305, there are some tweaks worth doing in a followup. looks great overall, thanks for pushing this!15:59
mupPR snapd#8305 closed: cmd/snap-recovery-chooser: add recovery chooser <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8305>15:59
mborzeckimvo: thanks for merging!15:59
zygahmm16:00
zygaI think that user agent thing is really a problem16:00
zygabut let me try something16:00
pedroniszyga: doesn't moving ForceDevMode help?16:05
zygano, it's all interconnected :/16:05
pedroniswhat is interconnected?16:05
pedronismaster is fine, what's the change?16:05
ijohnsonzyga: github actions debian dependencies failed again: https://pastebin.ubuntu.com/p/jkYFxdGjdK/16:05
zygahttps://www.irccloud.com/pastebin/WVqzY0tr/16:06
zygapedronis: I'm trying a few ideas16:06
ijohnsonzyga: seems like an issue  with the repos?16:06
zygaijohnson: I asked IS about this16:06
zygaijohnson: and it's a spike on a pipe that connects us to them16:06
pedroniszyga: sorry, why is snapdenv importing sandbox16:07
zygaijohnson: it's really flaky in the sense that we run out of bandwidth16:07
ijohnsonzyga: :-/ oh well16:07
zygapedronis: snapdenv needs to know if it's in devmode for the user agent16:07
zygapedronis: ForcedDevMode thing16:07
zygaijohnson: it shows up as an alert on our side (we know it's saturated) and we drop connections16:07
pedroniszyga: I see16:08
ijohnsoncool16:08
pedronisI forgot that16:08
pedronislet me think a bit16:08
zygapedronis: yeah, I'm looking at this for possibilities16:08
zygapedronis: I'll share what I have soon16:12
mupPR snapd#8406 opened: usersession: extend timerange in TestExitOnIdle <Created by mvo5> <https://github.com/snapcore/snapd/pull/8406>16:20
mvowoah, down to 52(!) prs16:20
mvoyay16:20
zygamvo: yeah, that close button sure works well ;D16:31
zyga(I'm in a silly humor mode)16:31
pedroniszyga: progress? I think I have some ideas of what I would do16:31
mvozyga: uh  - I did not check how we got to this number :(16:31
zygayeah16:31
zygapedronis: yeah, let me open a PR16:32
zygamvo: by merging, i was just silly16:32
mupPR snapd#8402 closed: o/configstate: add backlight option for core config <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8402>16:32
mupPR snapd#8253 closed: snap-bootstrap: expand data partition on install <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8253>16:35
zygapedronis: ok16:36
zygapedronis: https://github.com/snapcore/snapd/pull/840716:36
mupPR #8407: many: move IsForcedDevMode to sandbox/misc, move UA to snapdenv/usera… <Created by zyga> <https://github.com/snapcore/snapd/pull/8407>16:36
mupPR snapd#8407 opened: many: move IsForcedDevMode to sandbox/misc, move UA to snapdenv/usera… <Created by zyga> <https://github.com/snapcore/snapd/pull/8407>16:36
zygapedronis: I verified this really works for me to be able to import cgroup bits in cmd/run16:37
zygathere are two patches here, squashed because I reset the tree for simplicity16:37
zygaI think sandbox/misc can just become sandbox now though16:37
zygapedronis: I'll clean my other desk and wait for a ping, I'm just a meter away :)16:38
pedroniszyga: thank you, I'll probably play a bit with it and push some slightly different org, at least you are unblocked16:39
zygapedronis: I need one to land so if you feel strongly about it please propose yours and lets land it16:40
zygaotherwise I cannot merge master and make progress16:40
pedronis?16:40
zygapedronis: I need _any_ variant of this to land to progress16:41
zyga(or I must bundle an unapproved variant in my branch temporarily)16:42
pedronisthat sounds fine16:42
pedronisI'm not entirely sure what's the problem with that16:42
pedronisanyway my goal here is to reduce the diff, reduce a bit need to add more packages16:43
zygamy original problem was inability to import sandbox/cgroup from cmd/snap IIRC16:43
zygaor maybe I'm forgetting bits, I'm tired a bit today (ENOSLEEP)16:43
pedronisit's ok, I'm just not sure why you think proposing a PR with the intermediate solution is a problem16:44
pedronisexcept for size16:44
zygano, it's not16:45
zygait's ok :)16:45
kenvandinejdstrand: i think i need a minor tweak to the appstream-metadata interface16:46
kenvandinehttps://github.com/snapcore/snapd/blob/master/interfaces/builtin/appstream_metadata.go#L4916:46
kenvandinethat allow read access to the contents of those dirs16:47
kenvandinebut not read on the dir itself16:47
kenvandinejdstrand: right?16:47
kenvandinejdstrand: snap-store is checking for read access on the dirs as it iterates them and fails16:52
jdstrandkenvandine: are you saying that snap-store is trying to figure out what files are in /usr/share/metainfo and is failing to enumerate them?16:58
kenvandinei think it's just checking if it can read the dir16:58
jdstrandkenvandine: oh, were you asking what those rules do? yes, not a read on the dir, just everything under the dir16:58
jdstrandkenvandine: sounds like you need:16:59
kenvandineif i manually tweak the profile, how do i recompile it to test my theory?16:59
jdstrand/usr/share/metainfo/{,**} r,16:59
kenvandineyeah, i've tweaked the profile locally to test16:59
jdstrandkenvandine: sudo apparmor_parser -r /var/lib/snapd/apparmor/profiles/snap.snap-store.snap-store (or whatever file you modified)16:59
kenvandinebingo17:00
zygajdstrand: o/17:01
zygajdstrand: do you have 3minutes?17:01
jdstrandkenvandine: I'm planning on doing a PR for some things in the next few days. if I slid this in there, would that be good enough for you?17:01
zygajdstrand: https://github.com/snapcore/snapd/pull/8408 is verbatim from the refresh-app-awareness-v2 branch17:01
mupPR #8408: snap/naming: add validator for snap security tag <Created by zyga> <https://github.com/snapcore/snapd/pull/8408>17:01
zygacherry picked to reduce the diff17:01
kenvandine /usr/share/metainfo/{,**} r,17:02
kenvandine /usr/share/appdata/{,**} r,17:02
kenvandinejdstrand: that's what i need17:02
mupPR snapd#8408 opened: snap/naming: add validator for snap security tag <Created by zyga> <https://github.com/snapcore/snapd/pull/8408>17:02
kenvandinejdstrand: that's fine17:02
kenvandinewe need it in 20.04 ;)17:02
jdstrandkenvandine: ack, trello'd17:02
jdstrand"to trello: the act of adding or modifying a trello card"17:03
kenvandinelol17:03
kenvandinejdstrand: thanks!17:03
jdstrandkenvandine: np17:03
zygahmm, we may need to discuss deps with IS17:04
zygaand I need to check why we don't cache them17:04
zyga(deps, repos)17:04
jdstrandzyga: what do you need wrt PR 8408?17:04
mupPR #8408: snap/naming: add validator for snap security tag <Created by zyga> <https://github.com/snapcore/snapd/pull/8408>17:04
jdstrandzyga: a review now?17:04
jdstrandzyga: or something else?17:04
zygajdstrand: please either look if you want to review it and if so enqueue it, or just defer the review to others17:04
jdstrandzyga: enqueued, thanks!17:06
zygathanks!17:06
* zyga EODs and returns to cleaning stuff from the other desk17:06
jdstrandbye zyga :)17:14
zygabye, have a good evening :)17:14
mupPR snapd#8409 opened: snap-bootstrap: seal and unseal encryption key using tpm <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8409>17:19
mupPR snapd#8095 closed: snap-bootstrap: add tpm support (draft) <UC20> <Created by cmatsuoka> <Closed by cmatsuoka> <https://github.com/snapcore/snapd/pull/8095>17:25
mupPR snapcraft#2999 closed: requirements: uprev python-apt to 1.6.0 (bionic package) <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2999>17:51
mupPR snapd#8405 closed: boot: simplify modeenv mocking to always write a modeenv <Simple πŸ˜ƒ> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8405>17:53
=== Eighth_Doctor is now known as Conan_Kudo
=== Conan_Kudo is now known as Eighth_Doctor
mupPR snapd#8410 opened: many: disentagle release and snapdenv from sandbox/* <Created by pedronis> <https://github.com/snapcore/snapd/pull/8410>18:44
mupPR snapd#8407 closed: many: move IsForcedDevMode to sandbox/misc, move UA to snapdenv/usera… <Created by zyga> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8407>18:47
mupPR snapcraft#3007 closed: go: support projects with multiple binaries when using go.mod <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3007>19:39
mupPR # closed: core#38, core#107, core#108, core#110, core#11120:34
mupPR snapd#8411 opened: boot: cleanup more things, simplify code <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8411>20:41
mupPR # closed: core-build#11, core-build#22, core-build#26, core-build#37, core-build#51, core-build#5821:01
mupPR snapcraft#3000 closed: repo: use python-apt's fetch_binary implementation <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3000>21:07
mupPR snapcraft#3009 opened: repo: use python-apt's fetch_binary implementation <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3009>21:13
mupPR snapcraft#3008 closed: cli: use the channel-map api for status <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3008>21:35
zygasnapd is blocked in debian21:40
zygadh_missing: warning: usr/bin/snap-preseed exists in debian/tmp but is not installed to anywhere21:40
mupPR snapcraft#3009 closed: repo: use python-apt's fetch_binary implementation <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3009>22:53
mupPR snapcraft#3010 opened: cli: add progressive releases support to the release command <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3010>22:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!