| wallyworld | babbageclunk: easiest PR you will ever see, i promise https://github.com/juju/juju/pull/11408 | 00:58 |
|---|---|---|
| wallyworld | tlm: forgot to mention, can you look at this issue to see if it's related to the admission controller work? they've disabled rbac i think to work aroud https://github.com/ubuntu/microk8s/issues/1071#issuecomment-606501275 | 01:08 |
| tlm[m] | Ok | 01:09 |
| tlm[m] | No nothing to do with admission, it is related to incorrect setup of RBAC from the charm by the look of things | 01:18 |
| wallyworld | tlm: feel free to leave a comment with any insight to help unblock them as the current question is whether juju is at fault | 02:10 |
| tlm[m] | Will do | 02:10 |
| wallyworld | if not babbageclunk, then anyone else want to +1 a +0/-0 PR https://github.com/juju/juju/pull/11408 | 02:10 |
| babbageclunk | sorry, wasn't seeing notifications! | 03:04 |
| babbageclunk | wallyworld: approved | 03:05 |
| wallyworld | all good :-) | 03:05 |
| babbageclunk | I don't think I've ever seen a +0/-0 pr before | 03:06 |
| === thumper[m] changed the topic of #juju to: All about Juju devops tool. Discourse at https://discourse.juju.is, project site https://juju.is | ||
| achilleasa | can I get a CR on https://github.com/juju/juju/pull/11405? | 08:35 |
| stickupkid | achilleasa, I've started on it, but these jumped out | 08:45 |
| stickupkid | https://github.com/juju/juju/pull/11405#pullrequestreview-388045403 | 08:45 |
| achilleasa | stickupkid: what is that v2 bit? | 08:46 |
| stickupkid | so even though they're addative you should still create a new struct for best practice | 08:47 |
| achilleasa | ah, well, this is a new 2.8 API which we will freeze for the beta | 08:47 |
| achilleasa | so there is no need to version additions/modifications atm | 08:47 |
| stickupkid | ah ok, it fine | 08:47 |
| stickupkid | I'll continue onwards | 08:48 |
| achilleasa | I 'll copy this to the PR | 08:48 |
| stickupkid | ta | 08:49 |
| achilleasa | stickupkid: all that work for a meter status :D | 08:51 |
| stickupkid | achilleasa, new question https://github.com/juju/juju/pull/11405/files/6614b1de953c3c527dd7eeb1777bd6496a2eb585#diff-02d6e400b72751b96ebe2ac7086886ee | 08:57 |
| achilleasa | stickupkid: pushed a commit to address your comments | 10:14 |
| stickupkid | manadart, achilleasa very quick CR - https://github.com/juju/juju/pull/11410 - whilst I'm looking at AWS manual deployments | 12:00 |
| stickupkid | was requested that we expect the deployment to land on unit 0 | 12:01 |
| hml | achilleasa: changes made, | 12:23 |
| achilleasa | hml: I answered you question but I think my meter status changes caused a conflict with one of your tests | 12:41 |
| achilleasa | s/you/your | 12:42 |
| hml | achilleasa: added a few nit’s on method comment headers. looks like static analysis caught a few things. | 13:47 |
| achilleasa | hml: yeah.... just force-pushed the version without lint checks; missed some mocks :-( | 13:48 |
| achilleasa | hml: I will address the comments and re-push | 13:48 |
| achilleasa | hml: do you think the rename makes things more consistent? | 13:49 |
| hml | achilleasa: yes, i was thining of it myself a few times. with the addition of the other pieces to the doc, state became ambiguous. | 13:50 |
| achilleasa | hml: so besides the model migration (juju/description) and your relation changes, what else do we need to complete the root card? | 13:52 |
| achilleasa | there is a card about migrate steps (the TODO one for the operator?) | 13:52 |
| achilleasa | anything else that we are missing? | 13:52 |
| hml | achilleasa: there is a card for migration. | 13:52 |
| hml | achilleasa: we’re missing ensuring the caas operator upgrades are correct. | 13:52 |
| achilleasa | hml: https://trello.com/c/LEXkzAVm/2431-migration-steps-for-uniter-state-on-server is about the pending upgrade steps for the other state bits right? | 13:54 |
| hml | achilleasa: umm.. i’m reading migration. :-). typo? | 13:55 |
| stickupkid | I love petname command, it really does give so good names | 13:59 |
| achilleasa | hml: ah... wasn't sure so I created another card :D | 13:59 |
| stickupkid | s/so/some/ | 13:59 |
| stickupkid | lenient-pig | 13:59 |
| achilleasa | stickupkid: in 11405 should I have bumped the MeterStatus facade version? I think I can get away with it because the controller will always be upgraded before the agents so nothing can call that API anyway, right? | 14:39 |
| SpecialK|Canon | Hello! If I wanted to charm some software, is https://discourse.juju.is/t/charm-writing/1260 (from https://juju.is/docs/charm-bundles) the best place to start reading? | 15:12 |
| achilleasa | hml: another small PR for you: https://github.com/juju/description/pull/75; also, do you have any further comments on 11411? | 15:15 |
| hml | achilleasa: are the changes made to 11411, then? i’ll take a 2nd look then | 15:16 |
| achilleasa | hml: yes, it's green now | 15:16 |
| hml | achilleasa: is replated an autocorrectism? https://github.com/juju/description/pull/75/files#diff-320e610bf9322fa08db897722b714520R12. not familar with that one in this context. :-) | 15:24 |
| achilleasa | hml: that's me typing while a paw patrol cartoon is playing in the other side of the room :D | 15:28 |
| hml | hahahahah! | 15:28 |
| achilleasa | hml: fixed ;-) | 15:29 |
| stickupkid | achilleasa, i'd just bump it | 15:34 |
| hml | achilleasa: 75 approved | 15:35 |
| achilleasa | stickupkid: I know but this one is a bit odd in that it uses an apiserver/common bit as a mixin | 15:36 |
| achilleasa | hml: tyvm | 15:36 |
| stickupkid | achilleasa, we're talking about SetUnitStateArg right? | 15:37 |
| achilleasa | stickupkid: no, this guy: https://github.com/juju/juju/pull/11405/files#diff-6023308f657e593715902695e8a0cea5R44 | 15:38 |
| stickupkid | achilleasa, ho? | 15:39 |
| achilleasa | stickupkid: omw | 15:39 |
| hml | achilleasa: 11411 is approved with a small nit. | 15:41 |
| achilleasa | hml: argh... I hate typing doc comments. I will clear that up and land it | 15:46 |
| hml | achilleasa: hear ya! :-) | 15:59 |
| === narindergupta is now known as narinderguptamac | ||
| achilleasa | stickupkid: CR please: https://github.com/juju/juju/pull/11413 | 16:08 |
| achilleasa | hml: any idea why this refuses to become green? https://jenkins.juju.canonical.com/job/github-make-check-juju/4876/console | 17:10 |
| hml | achilleasa: still have red? just back from lunch | 17:30 |
| hml | achilleasa: https://pastebin.ubuntu.com/p/3wSsZMSpgC/ | 17:33 |
| hml | achilleasa: but that is weird… unless something else landed in a few hours between runs. | 17:35 |
| hml | achilleasa: i need to rebase a 2/3 time | 17:47 |
| === hpidcock_ is now known as hpidcock | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!