| tlm | kelvinliu: does the charm supply the name for a mutating webhook config ? https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#mutatingwebhook-v1-admissionregistration-k8s-io | 00:05 |
|---|---|---|
| tlm | don't mean the object meta name | 00:06 |
| kelvinliu | checking | 00:06 |
| kelvinliu | yes it does | 00:09 |
| kelvinliu | charm provides .meta.name and .WebHooks[].Name tlm | 00:11 |
| tlm | awesome thanks | 00:11 |
| kelvinliu | np | 00:11 |
| babbageclunk | wallyworld: thumper's not around, can you approve https://github.com/juju/juju/pull/11426 instead? (I'm sure he wouldn't mind) | 02:38 |
| wallyworld | ok, let me take a look | 02:39 |
| wallyworld | babbageclunk: just a couple of small nits | 02:47 |
| babbageclunk | awesome, thanks | 02:54 |
| === mup_ is now known as mup | ||
| wallyworld | kelvinliu: +1 on PR but maybe discuss? have a read of the comments | 03:08 |
| babbageclunk | wallyworld: alright, I'm going to hit merge on that even though thumper's not approved it | 03:08 |
| wallyworld | he will get over it | 03:09 |
| kelvinliu | wallyworld: I saw u mentioned more tests and to merge the hookChangeParams, HO? | 03:11 |
| wallyworld | kelvinliu: sure, give me 1 mnute to hit send on an email | 03:11 |
| kelvinliu | yep | 03:12 |
| babbageclunk | hey _thumper_ can you approve https://github.com/juju/juju/pull/11426? I tried getting wallyworld to approve it and then smash it in because you weren't around (having made the changes we talked about), but it looks like github prevents that. | 04:03 |
| _thumper_ | babbageclunk: sure | 04:03 |
| babbageclunk | thanks! | 04:04 |
| _thumper_ | I did leave a comment before | 04:04 |
| _thumper_ | but didn't think I needed to approve as well | 04:05 |
| _thumper_ | but have done now | 04:05 |
| babbageclunk | _thumper_: yeah, because you requested changes last time it enforces getting you to re-review | 04:07 |
| _thumper_ | yeah, sorry | 04:07 |
| _thumper_ | my "thumper" nick seems to be temporarily unavailable just now | 04:07 |
| _thumper_ | no idea why | 04:07 |
| babbageclunk | he's been hacked! | 04:08 |
| _thumper_ | boo | 04:08 |
| wallyworld | _thumper_: glad this was caught. raised against 2.8-beta1 but affects 2.7.6 also https://github.com/juju/juju/pull/11427 | 04:29 |
| * _thumper_ looks | 04:29 | |
| _thumper_ | wallyworld: approved, but you could simplify | 04:32 |
| wallyworld | ok | 04:32 |
| wallyworld | ty | 04:32 |
| wallyworld | _thumper_: you can but that's not why i got the controller state | 04:33 |
| wallyworld | i could have used either model or controller state to get config, but i had the controller one anyway | 04:33 |
| wallyworld | the controller state is used to get the cloud service info | 04:33 |
| _thumper_ | ah, ok | 04:34 |
| _thumper_ | is that controller specific? | 04:34 |
| wallyworld | not but here we are looking up the controller api addresses - the the controller cloud service mongo doc is what we need | 04:34 |
| wallyworld | as oopposed to a cloud service doc for a workload app | 04:35 |
| wallyworld | when we bootstrap, the controller get a k8s service mad efor it, like any other k8s app | 04:35 |
| wallyworld | and that service is mapped to a cloud service doc in mongo | 04:36 |
| wallyworld | and it records the address info | 04:36 |
| tlm | quick PR for anyone around https://github.com/juju/juju/pull/11428 | 05:37 |
| babbageclunk | tlm: approved | 05:38 |
| tlm | cheers | 05:38 |
| wallyworld | manadart: would love a +1 on forward port of 2.7 when you're online https://github.com/juju/juju/pull/11429 | 05:55 |
| manadart | wallyworld: Looking now. | 06:50 |
| wallyworld | ta | 06:51 |
| thumper | wallyworld: you coming to this meeting too? | 07:01 |
| kelvinliu | wallyworld: a tiny PR to add a helper func to caas layer for raw-k8s-set hook command, +1 plz https://github.com/juju-solutions/layer-caas-base/pull/26 | 07:05 |
| wallyworld | kelvinliu: ty, lgtm so long as it's been tested live | 07:06 |
| kelvinliu | lol | 07:07 |
| kelvinliu | could u just merge it plz ty | 07:08 |
| wallyworld | kelvinliu: merged, but mke sure to test to ensure there's no regression | 07:09 |
| kelvinliu | sure tested by copying to charm, I will be testing it again many times tmr | 07:12 |
| wallyworld | all good :-) | 07:12 |
| manadart | wallyworld: You still there? | 07:55 |
| manadart | wallyworld: Nevermind; approved the merge patch. | 08:02 |
| hpidcock | wallyworld: https://github.com/juju/juju/pull/11395 is ready for re-review with unit tests and requested changes. Ping me tomorrow/tonight/tuesday if there are any issues. | 08:28 |
| stickupkid | hpidcock, JUST DON'T PING ME ON THE WEEKEND? | 08:35 |
| hpidcock | hah | 08:35 |
| wallyworld | hpidcock: ty, will likely look tomorrow | 09:12 |
| stickupkid | manadart, thoughts https://github.com/juju/juju/pull/11425 | 09:24 |
| stickupkid | manadart, wallyworld that forward port of 2.7 won't land as there is a compile error | 09:32 |
| wallyworld | ah balls, ok | 10:29 |
| wallyworld | stickupkid: manadart: it's because in 2.8 there's no uniter state file anymore, so the method tp load it has gone away from the source code, and the 2.7.6 upgrade step fails to compile, so i'll need to resurrect that code for the upgrade step | 10:35 |
| stickupkid | sick | 10:35 |
| wallyworld | i'll do it tomorrow | 10:35 |
| stickupkid | manadart, is this what you meant by endpoint bindings? Or are you talking about the charms endpoint bindings https://github.com/juju/juju/pull/11425 | 10:51 |
| manadart | stickupkid: What you have there is correct for now, but we also want to get st.AllEndpointBindings and continue if any of those are equal to the deletion candidate. | 11:00 |
| stickupkid | haha, don't delete anything in reality | 11:00 |
| stickupkid | manadart, also this is becoming somewhat a behemoth of a method, I may split it out | 11:02 |
| hml | achilleasa: https://github.com/juju/juju/pull/11414 is ready for review. :-) | 12:34 |
| achilleasa | hml: will take a look in a few min; I have almost managed to bootstrap with an operator from my dockerhub account | 12:35 |
| hml | :-D | 12:35 |
| hml | achilleasa: looking at the unit test fails on 11414, looks like to do with no directory created. | 13:22 |
| stickupkid | manadart, what was the issue with contraints validation not being correctly implemented | 13:29 |
| manadart | stickupkid: It's naively correct for single network machines, but in order to handle multi-NIC, we need to compare units, not the application in aggregate. | 13:30 |
| stickupkid | ah | 13:30 |
| rick_h_ | each unit lives on its own machine and guimaas is a good example that what spaces/etc are in play vary from machine to machine | 13:31 |
| hml | achilleasa: wallyworld reminded me you can do a juju dumpdb too if you’ve enabled the develop feature flag at bootstrap. | 13:45 |
| hml | instead of juju-db.bash | 13:45 |
| hml | achilleasa: fixed fail in UniterSuite.TestUniterRelations, i *think* that’s the last one. | 13:48 |
| achilleasa | hml: any ideas how to upgrade on k8s? I am using dev mode but not sure how to get it to pull the new operator | 14:21 |
| hml | achilleasa: ho? | 14:22 |
| achilleasa | sure | 14:22 |
| stickupkid | manadart, got a sec, I'm being dumb | 14:43 |
| manadart | stickupkid: In Daily. | 14:44 |
| hml | achilleasa: we’re hitting https://bugs.launchpad.net/juju/+bug/1871496 | 14:49 |
| mup | Bug #1871496: Juju fails on deploy with error cloud service not found for microk8s <juju:Fix Released by wallyworld> <https://launchpad.net/bugs/1871496> | 14:49 |
| === narindergupta is now known as narinderguptamac | ||
| achilleasa | hml: left comments in 11414. I stil need to go through the last set of files but that probably means a second pass in the morning. Take a look esp at my last comments regarding the state implementation and let me know what you think | 16:40 |
| hml | achilleasa: having the relation data SetState all at once, is definately a goal, but would be an even bigger rewrite of this code, i think. it sounds like polish to me? | 16:46 |
| achilleasa | hml: note that my comment was not to do it all at once. just have an object to call State once, then give you a method to get the state for a relation by ID and to save the state of a relation. You still make a SetState for one relation but avoid the Ensure call | 16:48 |
| achilleasa | the end result will be the same but the proposed way would likely involve less API calls and be a bit cleaner | 16:49 |
| achilleasa | also, having to rewrite a large chunk of code while in beta wouldn't really be considered as polishing ;-) | 16:51 |
| hml | achilleasa: i’m not clear on why that avoids the Ensure call. The ensure call is made at other times, but it looks like the primary need is for new relations, not saved ones. | 16:51 |
| hml | achilleasa: ho? | 16:52 |
| achilleasa | hml: omw | 16:54 |
| wallyworld | hml: you can do dump-db anytime if the feature flag is enabled, it's only a client side flag | 20:51 |
| hml | wallyworld: ack | 20:51 |
| hml | wallyworld: i referenced a sha for yo to fix the merge from 2.7 to develop | 20:52 |
| wallyworld | great ok, will look after next meeting, ty | 20:52 |
| babbageclunk | wallyworld: hml's change looks good to me | 20:57 |
| wallyworld | yeah, was what i was going to do myself this morning, saved me the trouble :-) | 20:59 |
| hml | wallyworld: it was blocking me for a bit… then other stuff came up after i came up with the fix. :-) | 21:00 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!