| mup | PR snapcraft#3025 closed: tests: move FakeApt fixtures into deb tests <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3025> | 00:57 |
|---|---|---|
| zyga | o/ | 06:17 |
| mup | PR snapd#8471 closed: many: fix loading apparmor profiles on Ubuntu 20.04 with ZFS (2.44) <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8471> | 06:18 |
| pstolowski | morning | 06:58 |
| zyga | Hey Paweł :-) | 07:12 |
| zyga | Maybe a slow day for a change | 07:13 |
| pstolowski | zyga: hey! we will see, mvo had issues with finalizing 2.44 yesterday evening | 07:19 |
| pstolowski | i hope to progress with nested vm test for early core config today | 07:26 |
| zyga | pstolowski: what kind of issues? | 07:37 |
| zyga | pstolowski: 2.44 backports not working? | 07:37 |
| pstolowski | zyga: just tests afaiu, plus something slightly diverged and needed a small fix | 07:39 |
| zyga | I see | 07:39 |
| zyga | pstolowski: I see mvo mentioned that master is broken | 07:45 |
| pstolowski | zyga: i don't know about that, maybe missed something | 07:47 |
| zyga | it's in the standup doc, it seems to be that service that gets masked somehow | 07:47 |
| zyga | so tests don't pass | 07:47 |
| pstolowski | zyga: #8472 fixes it for 2.44 | 07:54 |
| mup | PR #8472: tests: disable some problematic tests for 2.44 <Created by mvo5> <https://github.com/snapcore/snapd/pull/8472> | 07:54 |
| pstolowski | (well, disables the test) | 07:54 |
| pstolowski | so yes we need a fix for master | 07:55 |
| pstolowski | i'll look at it | 07:56 |
| pstolowski | tests/main/interfaces-time-control passed on 20.04 for me | 08:14 |
| pstolowski | perhaps 20.04 was fixed since yesterday | 08:15 |
| zyga | pstolowski: I suspect it's something earlier that breaks it | 08:53 |
| zyga | re | 08:53 |
| pstolowski | zyga: aah, i didn't think about it. running entire suite then | 08:54 |
| mup | PR snapd#8473 opened: tests: when restoring chrony do not restart systemd-timesyncd <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8473> | 08:58 |
| zyga | MVO | 09:00 |
| zyga | BEHAVE :) | 09:00 |
| zyga | it's your day off | 09:00 |
| zyga | pstolowski: ^ | 09:01 |
| pstolowski | +1 | 09:01 |
| mup | PR snapcraft#3026 opened: spread tests: add core20 and cleanup systems <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3026> | 10:19 |
| * zyga is drained today | 10:34 | |
| zyga | echo .... | 10:54 |
| pstolowski | .... | 10:55 |
| zyga | ho ho ho | 10:56 |
| pstolowski | i'm running entire suite from mvo's PR locally to check this ntp issue | 10:56 |
| zyga | it's like we have a quarantine on the channel too | 10:56 |
| zyga | :D | 10:56 |
| zyga | thanks! | 10:56 |
| zyga | thank you for chasing reliablilty | 10:56 |
| pstolowski | zyga: so the test fails on test-snapd-timedate-control-consumer.timedatectl-timeserver set-ntp yes | 11:05 |
| zyga | mmm | 11:05 |
| zyga | yes | 11:05 |
| pstolowski | zyga: but i'm dropped in the shell, and manually it works | 11:05 |
| pstolowski | zyga: perhaps there is a race with ntp being synchronized? | 11:05 |
| zyga | oh that's curious | 11:05 |
| zyga | when it failed, how did it fail? | 11:05 |
| zyga | what was the error message? | 11:05 |
| pstolowski | sorry, not synchronized; i mean 'available' or some such | 11:06 |
| pstolowski | + test-snapd-timedate-control-consumer.timedatectl-timeserver set-ntp yes | 11:06 |
| pstolowski | Failed to set ntp: NTP not supported | 11:06 |
| pstolowski | zyga: ^ | 11:06 |
| pstolowski | same command now works manually on that system | 11:07 |
| zyga | r45d09i-o | 11:08 |
| zyga | that was not my password :) | 11:09 |
| zyga | just cleaning the keyboard | 11:09 |
| zyga | pstolowski: not sure if that helps, I sometimes run a spread with -shell, instead of debug, and then play through the "execute" part interactively | 11:17 |
| pstolowski | zyga: hmm we do check test-snapd-timedate-control-consumer.timedatectl-timeserver status before we carry on with the rest of the test | 11:18 |
| pstolowski | but maybe it's still racy | 11:18 |
| pstolowski | i'll try a retry around set | 11:18 |
| zyga | ah | 11:18 |
| pstolowski | ah, no, ignore me, i misunderstood it | 11:20 |
| pstolowski | ok, still digging in ;) | 11:20 |
| pstolowski | i think i have a tentative workaround, waiting for tests to finish. it involves retries in two places though and i'm unclear about the root cause | 12:07 |
| zyga | mmm | 12:08 |
| zyga | I was wondering if https://shop.3mdeb.com/product/tpm2/ is worth buying for desktops that don't have TPM support | 12:08 |
| mup | PR snapcraft#3027 opened: static: mypy requires __init__.py <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3027> | 12:16 |
| mup | PR snapd#8474 opened: [WIP] tests: retry timedatectl set ops <Created by stolowski> <https://github.com/snapcore/snapd/pull/8474> | 12:21 |
| zyga | looking | 12:22 |
| pstolowski | let's see how it goes across systems | 12:23 |
| zyga | pstolowski: is the move of the first block relevant? | 12:23 |
| zyga | I'm asking because there's a install of chrony that now now happens *after* | 12:24 |
| zyga | ah | 12:24 |
| zyga | that's the restore section | 12:24 |
| zyga | ok, makes sense | 12:24 |
| zyga | let's see how it works :) | 12:24 |
| diddledan | looks like the mount namespace is failing to be set-up before running the install hook in this forum post: https://forum.snapcraft.io/t/sudo-snap-install-gimp-fails/16526/5 | 12:27 |
| zyga | it seems so | 12:27 |
| zyga | diddledan: thanks for raising this, I replied | 12:28 |
| diddledan | thank you :-) | 12:28 |
| * diddledan huggle zyga | 12:29 | |
| diddledan | funny gif of the day to keep everyone smiling: https://i.redd.it/h9hr7wo8hxq41.gif | 12:30 |
| pstolowski | zyga: yeah i think the order of restore was a bit weird/suspect | 12:53 |
| zyga | mvo messaged me, | 12:54 |
| zyga | there's a failure in pulseaudio test in the release branch | 12:54 |
| zyga | he asked us to look | 12:54 |
| zyga | do you know which test we have for pulse? | 12:54 |
| pstolowski | interfaces-pulseaudio? | 12:55 |
| zyga | let's try it | 12:56 |
| zyga | running | 12:56 |
| zyga | running SPREAD_DEBUG_EACH=0 spread -debug google:tests/main/{interfaces-pulseaudio,interfaces-audio-playback-record} | 12:58 |
| ijohnson | morning zyga pstolowski | 12:59 |
| zyga | hey ijohnson | 12:59 |
| zyga | good morning | 12:59 |
| pstolowski | hi! | 12:59 |
| zyga | happy friday (indoors) | 12:59 |
| ijohnson | indeed! | 12:59 |
| ijohnson | is it just the 3 of us today then? | 12:59 |
| zyga | I think so | 12:59 |
| zyga | jdstrand: is around as well I think | 12:59 |
| ijohnson | nice, SU? | 13:00 |
| zyga | I'm looking into this failure by request from mvo https://www.irccloud.com/pastebin/H0N9IpA9/ | 13:00 |
| zyga | oh | 13:00 |
| * diddledan waves | 13:12 | |
| diddledan | I'm lurking :-p | 13:12 |
| roadmr | you lurker you | 13:12 |
| diddledan | https://youtu.be/mFfQQYsamqM | 13:13 |
| zyga | ijohnson: do you think sending a patch that moves a single test over to session tool is useful? | 13:18 |
| zyga | ijohnson: I have a few of those that I could just send | 13:19 |
| zyga | not sure that it helps for 2.44 though | 13:19 |
| ijohnson | zyga: I think it is useful in general maybe, but I don't think we should do it for the release branch yet | 13:19 |
| zyga | I was only thinking about master now | 13:19 |
| ijohnson | sure for master yes I think we should try to use session-tool as much as possible | 13:19 |
| zyga | ok, I'll send what I have then | 13:20 |
| ijohnson | ack | 13:27 |
| ijohnson | I've got the interfaces-audio-playback-record test running now off 2.44 branch to see if I can reproduce the failure | 13:27 |
| zyga | same here | 13:28 |
| zyga | ijohnson: I've sent a patch with tree tests | 13:29 |
| zyga | https://github.com/snapcore/snapd/pull/8475 | 13:29 |
| mup | PR #8475: tests: port snap-session-agent-* to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8475> | 13:29 |
| ijohnson | cool, I'll take a look in a little bit, gonna finish porting the interfaces-pulseaudio test changes to audio-playback-record first | 13:29 |
| mup | PR snapd#8475 opened: tests: port snap-session-agent-* to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8475> | 13:29 |
| zyga | thank you | 13:30 |
| zyga | ijohnson: reproduced! | 13:31 |
| ijohnson | nice | 13:31 |
| ijohnson | logs? | 13:31 |
| zyga | https://www.irccloud.com/pastebin/CXofm8kK/ | 13:31 |
| zyga | google:ubuntu-19.10-64 .../tests/main/interfaces-pulseaudio# ls -ld /run/user/12345/pulse/native | 13:32 |
| zyga | srw-rw-rw- 1 test test 0 Apr 10 13:25 /run/user/12345/pulse/native | 13:32 |
| mup | PR #10: Update README.md <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/10> | 13:32 |
| zyga | processes | 13:33 |
| zyga | https://www.irccloud.com/pastebin/0oP0R6j2/ | 13:33 |
| zyga | journal | 13:33 |
| zyga | https://paste.ubuntu.com/p/yYKS3Rv2JC/ | 13:33 |
| zyga | weird | 13:33 |
| zyga | pulse doesn't start | 13:33 |
| zyga | because it's running | 13:33 |
| zyga | Apr 10 13:25:17 apr101317-837037 dbus-daemon[612]: Unknown username "pulse" in message bus configuration file | 13:34 |
| mup | PR #10: Update README.md <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/10> | 13:34 |
| zyga | Apr 10 13:25:17 apr101317-837037 groupadd[19712]: group added to /etc/group: name=pulse, GID=125 | 13:34 |
| zyga | Apr 10 13:25:17 apr101317-837037 groupadd[19712]: group added to /etc/gshadow: name=pulse | 13:34 |
| zyga | Apr 10 13:25:17 apr101317-837037 groupadd[19712]: new group: name=pulse, GID=125 | 13:34 |
| zyga | Apr 10 13:25:17 apr101317-837037 useradd[19716]: new user: name=pulse, UID=116, GID=125, home=/var/run/pulse, shell=/usr/sbin/nologin | 13:34 |
| zyga | Apr 10 13:25:17 apr101317-837037 usermod[19722]: change user 'pulse' password | 13:34 |
| zyga | are we installing pulse? | 13:35 |
| * zyga checks the test | 13:35 | |
| ijohnson | oh | 13:35 |
| ijohnson | zyga you are running interfaces-pulseaudio | 13:35 |
| zyga | yes | 13:35 |
| zyga | well, both but here this one failed | 13:35 |
| ijohnson | hmm so that's failing again too ? | 13:35 |
| ijohnson | hmm, well fwiw I just ran audio-playback-record via spread and it didn't fail for me | 13:36 |
| * ijohnson tries again with interfaces-pulseaudio too | 13:36 | |
| ijohnson | also sorry I forgot is the failure we see on the release branch just 19.10, or is it 20.04 too? | 13:36 |
| zyga | 19.10 often, 20.04 once - according to mvo | 13:37 |
| ijohnson | ok | 13:37 |
| zyga | interesting | 13:37 |
| zyga | so we start pulse | 13:38 |
| zyga | it gets pid 20042 | 13:38 |
| zyga | that pid is gone now btw | 13:38 |
| zyga | then we wait for it to respond | 13:38 |
| zyga | but then another pulse runs | 13:38 |
| zyga | I'll look for the 20042 pid in the journal | 13:38 |
| zyga | nothing | 13:38 |
| zyga | ah, wait | 13:38 |
| zyga | the pid is useless | 13:38 |
| zyga | it's the pid of the shell :/ | 13:39 |
| zyga | actual pulse is 20080 | 13:39 |
| zyga | https://www.irccloud.com/pastebin/vFqZLjvh/ | 13:41 |
| zyga | ^ I was trying to run the failing command myself | 13:41 |
| ijohnson | right so this matches what happened last time, in that the daemon seemed to be around but wouldn't respond to anything | 13:42 |
| zyga | https://www.irccloud.com/pastebin/lUWR3zfO/ | 13:42 |
| zyga | pulseaudio log file | 13:42 |
| zyga | E: [pulseaudio] socket-server.c: bind(): Address already in use | 13:42 |
| zyga | because there's a socket | 13:42 |
| zyga | that's there | 13:42 |
| mup | PR snapd#8476 opened: secboot: add tpm support helpers <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8476> | 13:42 |
| zyga | and it cannot get it | 13:42 |
| zyga | :D | 13:43 |
| zyga | google:ubuntu-19.10-64 .../tests/main/interfaces-pulseaudio# ls -ld //run/user/12345/pulse/native | 13:43 |
| zyga | srw-rw-rw- 1 test test 0 Apr 10 13:25 //run/user/12345/pulse/native | 13:43 |
| zyga | google:ubuntu-19.10-64 .../tests/main/interfaces-pulseaudio# date | 13:43 |
| zyga | Fri Apr 10 13:43:48 UTC 2020 | 13:43 |
| mup | PR #10: Update README.md <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/10> | 13:43 |
| zyga | 2020-04-10 15:28:22 Debug output for google:ubuntu-19.10-64:tests/main/interfaces-pulseaudio : | 13:44 |
| zyga | ah wait, that last timestamp is my local time | 13:44 |
| ijohnson | zyga: so the socket is there, but nothing is holding on to it? | 13:44 |
| zyga | yes | 13:44 |
| zyga | and bind fails | 13:44 |
| zyga | because it's there | 13:44 |
| zyga | one sec | 13:44 |
| zyga | let me correlate pulse startup timestamps | 13:44 |
| zyga | with the date of that socket | 13:44 |
| zyga | Apr 10 13:25:22 apr101317-837037 dbus-daemon[612]: [system] Activating via systemd: service name='org.freedesktop.RealtimeKit1' unit='rtkit-daemon.service' requested by ':1.89' (uid=12345 pid=20080 comm="pulseaudio --exit-idle-time=300 -n -F /home/test/p" label="unconfined") | 13:45 |
| zyga | this is the only proof I have | 13:45 |
| mup | PR #10: Update README.md <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/10> | 13:45 |
| zyga | pulse requests realtime scheduling on startup | 13:45 |
| zyga | this is at 13:25:22 | 13:45 |
| zyga | the socket is ... roughly the same | 13:45 |
| zyga | let's get more precise timestamp | 13:46 |
| ijohnson | yay I reproduced it too on 19.10 | 13:47 |
| ijohnson | let's have a look | 13:47 |
| zyga | srw-rw-rw- 1 test test 0 2020-04-10 13:25:21.799833281 +0000 native | 13:47 |
| zyga | this is definitely younger | 13:47 |
| zyga | but | 13:47 |
| zyga | but only by a second | 13:47 |
| zyga | I doubt it wasn't pulse who made it | 13:47 |
| ijohnson | ah no actually I had an error in my test changes porting over, wrong variable name | 13:48 |
| * ijohnson tries again | 13:48 | |
| zyga | I'm so inclined to port this to session tool and see if it fails | 13:49 |
| zyga | also half of the prepare goes away with it | 13:50 |
| ijohnson | true, I'd say give it a shot, I mean if it makes the test more reliable then it's got to be better than the current situation | 13:50 |
| zyga | I cannot explain why socket bind failed | 13:51 |
| zyga | let me read the man page | 13:51 |
| zyga | EADDRINUSE | 13:52 |
| zyga | The specified local address is already in use or the filesystem socket object already exists. | 13:52 |
| zyga | so | 13:52 |
| zyga | ijohnson: I'll start by not rewriting this | 13:52 |
| zyga | but by adding an assert up top | 13:52 |
| zyga | that that socket file is gone | 13:52 |
| zyga | maybe it will fail early on that | 13:52 |
| zyga | any other ideas | 13:52 |
| zyga | to look in this session? | 13:52 |
| ijohnson | zyga: so in your session right now you cannot use paplay ? | 13:54 |
| zyga | correct | 13:54 |
| zyga | I tried | 13:54 |
| zyga | I get... | 13:54 |
| ijohnson | zyga: can you try restarting pulseaudio the way the test does ? | 13:54 |
| zyga | https://www.irccloud.com/pastebin/UcKlvZqR/ | 13:54 |
| zyga | as in? | 13:55 |
| zyga | kill the current process | 13:55 |
| zyga | and start it the way it was started? | 13:55 |
| ijohnson | yes pulseaudio --kill or something like that | 13:55 |
| zyga | ok | 13:55 |
| ijohnson | then do | 13:55 |
| ijohnson | as_user "pulseaudio --exit-idle-time=300 -n -F /home/test/pulse-test.pa --log-level=4 --verbose 2>&1 | tee $PA_TEST_LOG >/dev/null" & | 13:55 |
| zyga | (some of the variables are not defined in the debug shell) | 13:56 |
| zyga | so it's not as easy | 13:56 |
| zyga | one moment | 13:56 |
| ijohnson | ah yeah right | 13:56 |
| pstolowski | doh, my fix for timeserver failed after all :(. "Failed to restart systemd-timesyncd.service: Unit systemd-timesyncd.service is masked." | 13:57 |
| zyga | google:ubuntu-19.10-64 /run# su -l -c "HOME=/home/test XDG_RUNTIME_DIR=/run/user/12345 pulseaudio --exit-idle-time=300 -n -F /home/test/pulse-test.pa --log-level=4 --verbose 2>&1 | tee $PA_TEST_LOG >/dev/null" test | 13:57 |
| zyga | pstolowski: check the maintainer script of chrony | 13:58 |
| zyga | pstolowski: it must be doing that | 13:58 |
| zyga | ijohnson: weird, I think the shell is stuck now? | 13:58 |
| ijohnson | hmmm | 13:58 |
| zyga | ok, managed to kill that | 13:59 |
| zyga | https://www.irccloud.com/pastebin/V0D8IOLf/ | 13:59 |
| zyga | paplay failed again | 13:59 |
| ijohnson | hmm is the pid file for pulseaudio there? | 13:59 |
| pstolowski | zyga: hmm indeed, it;s restore section that failed because of this | 14:00 |
| ijohnson | zyga: it's like in /run/pulse dir I think | 14:00 |
| zyga | I killed pulse, let me try again | 14:00 |
| zyga | weird | 14:00 |
| zyga | killing pulse yanked *all* of /run/user/12345 | 14:00 |
| zyga | it's empty | 14:00 |
| zyga | restarted pulse, again socket already in use | 14:02 |
| ijohnson | mmm | 14:02 |
| zyga | the pid file is correct | 14:02 |
| zyga | https://www.irccloud.com/pastebin/WdaDZDVw/ | 14:02 |
| zyga | that's weird | 14:03 |
| zyga | look at this | 14:03 |
| zyga | srw-rw-rw- 1 test test 0 Apr 10 14:01 native | 14:03 |
| mup | PR #10: Update README.md <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/10> | 14:03 |
| zyga | I'm sure the permissions were 600 before | 14:03 |
| zyga | nah, they were the same | 14:04 |
| zyga | so... | 14:04 |
| zyga | is it connected | 14:04 |
| zyga | I'll check if that socket is really open | 14:04 |
| ijohnson | there is a pulseaudio running | 14:04 |
| ijohnson | and there is a socket | 14:04 |
| ijohnson | clients try to connect to that socket | 14:04 |
| ijohnson | and then pulseaudio just refuses | 14:04 |
| zyga | https://www.irccloud.com/pastebin/rI9Th6Dn/ | 14:04 |
| zyga | I don't know how to correlate the fd 9 there to the socket on disk | 14:06 |
| zyga | any ideas? | 14:06 |
| ijohnson | mmm lsof ? | 14:06 |
| zyga | empty | 14:07 |
| zyga | as in | 14:07 |
| zyga | lsof of tthe "native" socket is empty | 14:08 |
| zyga | nobody has that open | 14:08 |
| zyga | I'll try stracing pulse | 14:08 |
| ijohnson | well the test passed for me again so I'm just gonna keep running it | 14:08 |
| zyga | https://paste.ubuntu.com/p/4wSSB2mBcV/ | 14:09 |
| zyga | it immediately died though | 14:09 |
| zyga | this one worked | 14:09 |
| zyga | https://paste.ubuntu.com/p/HjsnJgqy9x/ | 14:09 |
| zyga | 21195 bind(14, {sa_family=AF_UNIX, sun_path="/run/user/12345/pulse/native"}, 30) = -1 EADDRINUSE (Address already in use) | 14:09 |
| zyga | HUH | 14:10 |
| zyga | are on disk unix sockets like TCP sockets | 14:10 |
| pstolowski | zyga: ok, reproduced outside of our tests by switching between systemd-timesyncd and chrony packages and restarting | 14:10 |
| ijohnson | wait, what do you mean when you say this one worked ? | 14:10 |
| zyga | ijohnson: this one is still running | 14:10 |
| zyga | ijohnson: the previous run (identical) failed quickly and quit | 14:10 |
| zyga | look at the end of each strace | 14:10 |
| ijohnson | ah, can you get another shell to try playing ? | 14:10 |
| * ijohnson looks | 14:10 | |
| zyga | no, same shell | 14:10 |
| zyga | in both cases I ran this command: | 14:11 |
| zyga | su -l -c "HOME=/home/test XDG_RUNTIME_DIR=/run/user/12345 strace -f -o /tmp/pulse.strace pulseaudio --exit-idle-time=300 -n -F /home/test/pulse-test.pa --log-level=4 --verbose 2>&1 | tee $PA_TEST_LOG >/dev/null" test & | 14:11 |
| zyga | the one that failed didn't get to bind | 14:11 |
| zyga | in the second log something weird happens | 14:12 |
| zyga | pulse makes a socket (fd 14) | 14:12 |
| ijohnson | hmm it's unclear why the strace that failed immediately didn't get to bind | 14:12 |
| zyga | and then connects! | 14:12 |
| zyga | 21195 connect(14, {sa_family=AF_UNIX, sun_path="/run/user/12345/pulse/native"}, 110) = 0 | 14:12 |
| zyga | which works | 14:12 |
| zyga | so it closes the socket (14) | 14:12 |
| zyga | makes a new socket (well also 14 now) | 14:12 |
| zyga | and then binds | 14:13 |
| zyga | which fails | 14:13 |
| * zyga reads unix(7) | 14:13 | |
| roadmr | 😱 | 14:13 |
| zyga | so | 14:16 |
| zyga | I think I know | 14:16 |
| zyga | well | 14:16 |
| zyga | maybe :) | 14:16 |
| zyga | one sec | 14:16 |
| zyga | yeah | 14:16 |
| zyga | hehehe | 14:16 |
| zyga | ijohnson: do you want to know what the problem is :DDD | 14:16 |
| ijohnson | ......... | 14:16 |
| ijohnson | what happens if I say no | 14:16 |
| ijohnson | :-D | 14:16 |
| roadmr | I WANT TO KNOW | 14:17 |
| zyga | ijohnson: I just go out, get hit by a bus | 14:17 |
| ijohnson | okay fine, I can't live with myself denying roadmr the conclusion to this suspense | 14:17 |
| roadmr | thanks 💚 | 14:17 |
| ijohnson | <3 | 14:17 |
| zyga | heh | 14:18 |
| zyga | ok | 14:18 |
| zyga | so the bug is really in the test code | 14:18 |
| zyga | we use su and shit to run as test | 14:18 |
| zyga | and guess what | 14:18 |
| zyga | systemd running in the user session starts pulseaudio.socket and .service | 14:19 |
| zyga | and we race and lose | 14:19 |
| zyga | it's really incorrect | 14:19 |
| zyga | if we were using session tool | 14:19 |
| zyga | we could really not start pulse at all | 14:19 |
| zyga | because just starting session for the test user gives us one already | 14:19 |
| zyga | without the race | 14:19 |
| ijohnson | hahahahahahahahahahaha | 14:19 |
| ijohnson | oh man | 14:19 |
| zyga | the socket is there because systemd took it | 14:19 |
| ijohnson | of course systemd is racing with us | 14:19 |
| zyga | for socket activation | 14:19 |
| roadmr | hehe ;) | 14:20 |
| ijohnson | well in this case zyga let's just port the whole thing to use session-tool | 14:20 |
| zyga | https://paste.ubuntu.com/p/3HCqGzXrv2/ | 14:20 |
| zyga | this is strace after masking pulseaudio.{session,socket} for the user | 14:21 |
| zyga | systemctl --user --global mask pulseaudio.{session,socket} | 14:21 |
| zyga | 21597 bind(14, {sa_family=AF_UNIX, sun_path="/run/user/12345/pulse/native"}, 30) = 0 | 14:21 |
| zyga | bind now worked | 14:21 |
| zyga | paplay now worked | 14:21 |
| zyga | https://www.irccloud.com/pastebin/QPrlRzPI/ | 14:21 |
| zyga | problem solved | 14:21 |
| ijohnson | I guess if we didn't want to jump ship to session-tool for the release branch we could just mask pulseaudio at the start of the test | 14:21 |
| zyga | can I get a cookie :D | 14:21 |
| zyga | ijohnson: yes | 14:22 |
| ijohnson | yes you can get all the cookies you want | 14:22 |
| zyga | my thoughts exactly | 14:22 |
| zyga | haha | 14:22 |
| zyga | I'll prepare a patch | 14:22 |
| ijohnson | you just need to get find them without leaving the house | 14:22 |
| zyga | and we really need to burn user.sh with fire | 14:22 |
| ijohnson | thanks zyga, good detective work | 14:22 |
| zyga | and remove all the hacks | 14:22 |
| zyga | it's working against us | 14:22 |
| roadmr | zyga: 🍪 | 14:23 |
| mup | PR snapcraft#3027 closed: static: mypy requires __init__.py <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3027> | 14:26 |
| zyga | ijohnson: just two tests, right? | 14:27 |
| zyga | I cannot grep any more | 14:27 |
| ijohnson | zyga: just interfaces-pulseaudio and interfaces-audio-playback-record | 14:27 |
| zyga | rm: cannot remove '/run/user/12345': Device or resource busy | 14:29 |
| zyga | this is also related | 14:29 |
| zyga | man this is a good day | 14:29 |
| roadmr | \o/ | 14:36 |
| zyga | https://github.com/snapcore/snapd/pull/8477 | 14:36 |
| mup | PR #8477: tests: fix racy pulseaudio tests <Created by zyga> <https://github.com/snapcore/snapd/pull/8477> | 14:36 |
| mup | PR snapd#8477 opened: tests: fix racy pulseaudio tests <Created by zyga> <https://github.com/snapcore/snapd/pull/8477> | 14:36 |
| zyga | ijohnson: I'm happy I didn't port this test | 14:38 |
| zyga | yes, porting it would have fix things but would we know why? | 14:38 |
| mup | PR snapd#8472 closed: tests: disable some problematic tests for 2.44 <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8472> | 14:38 |
| ijohnson | very true | 14:38 |
| ijohnson | but to be honest, do we really need to know all the reasons why all our user session tests are broken | 14:39 |
| ijohnson | haha | 14:39 |
| zyga | I rebased and force pushed as requested by mvo | 14:39 |
| ijohnson | also in other news, I fixed the uboot script and have a booting uc20 on the pi \o/ | 14:39 |
| zyga | wooot! | 14:39 |
| zyga | ijohnson: I plan to buy one more rpi4 | 14:39 |
| zyga | maybe next week you could show me how to get it working | 14:39 |
| zyga | I'll break for lunch now :) | 14:40 |
| ijohnson | sounds good | 14:42 |
| mup | PR snapcraft#3028 opened: static: add codespell excludes for .direnv <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3028> | 14:50 |
| zyga | pstolowski: so what about that ntp test? | 15:00 |
| zyga | do we know what the problem is? | 15:00 |
| pstolowski | zyga: i found another revelation :) | 15:00 |
| pstolowski | testing atm | 15:00 |
| zyga | super :) | 15:01 |
| mup | PR snapd#8478 opened: tests: fix racy pulseaudio tests <Created by zyga> <https://github.com/snapcore/snapd/pull/8478> | 15:03 |
| === Eickmeyer[q] is now known as Eickmeyer | ||
| pstolowski | zyga: pushed 1 more change to ntp test | 15:14 |
| zyga | pstolowski: looking | 15:15 |
| ijohnson | zyga: approved | 15:15 |
| zyga | ijohnson: thank you :) | 15:15 |
| zyga | LOL | 15:15 |
| zyga | pstolowski: nice | 15:15 |
| zyga | pstolowski: that's the bug? :D | 15:16 |
| zyga | how did we missit before | 15:16 |
| pstolowski | zyga: i have *no idea* how did it work before. maybe packaging changed. i reproduced on my local box outside of tests. systemd one gets masked when chrony gets installed. but chrony doesn't even provide systemd-timesyncd, it provides chrony[d].service | 15:17 |
| ijohnson | pstolowski: zyga which PR is the ntp test ? | 15:17 |
| zyga | 8484 | 15:17 |
| zyga | pstolowski: I think it's sensible that chrony masks systemd feature it replaces | 15:17 |
| zyga | so that's a good find | 15:17 |
| zyga | please polish the PR, provide one patch and check if you can get a 2.44 version as well | 15:17 |
| zyga | jdstrand: I think I won't do much today | 15:19 |
| zyga | jdstrand: we're getting ready for my fathers-in-law 70th birthday | 15:19 |
| zyga | jdstrand: and people look at me to EOW now | 15:19 |
| zyga | jdstrand: I'll get through all your comments for Monday though | 15:19 |
| zyga | jdstrand: I'll be off on Monday but if you are round, try looking at the two PRs then | 15:19 |
| jdstrand | zyga: sounds good! there is a chance I'll be off monday | 15:19 |
| zyga | that's great, I won't stres for Monday then | 15:20 |
| zyga | just for Tuesday :) | 15:20 |
| jdstrand | zyga: enjoy your long weeked :) | 15:20 |
| zyga | ditto :) | 15:20 |
| jdstrand | zyga: try not to stress for either ;) | 15:20 |
| zyga | I feel happy anyway, this was a 2.44 firefighting day | 15:20 |
| zyga | jdstrand: if you have a second over weekend | 15:20 |
| zyga | can I interest you in libzt-doc in debian? :) | 15:20 |
| zyga | I wrote some manual pages, | 15:20 |
| zyga | lots of text | 15:20 |
| zyga | if you want to see how I did, I'd be honored to get any feedback :) | 15:21 |
| zyga | it's not work related at all so feel free to just stay indoors and read books :) | 15:21 |
| * zyga needs to EOW now | 15:21 | |
| jdstrand | nice! :) | 15:21 |
| jdstrand | take care | 15:21 |
| zyga | cake is on the table | 15:21 |
| zyga | see you next week everyone! | 15:21 |
| zyga | I'll circle back to read PRs in the evening | 15:22 |
| ijohnson | have a good weekend zyga | 15:48 |
| cwayne | Wait I want cake | 16:05 |
| roadmr | 🎂 | 16:06 |
| cmatsuoka | who said cake? | 16:07 |
| cwayne | You did | 16:08 |
| cmatsuoka | oh | 16:09 |
| cmatsuoka | ok then, I thought it was someone else | 16:09 |
| * cmatsuoka goes back to sleep | 16:09 | |
| roadmr | zzz :) | 16:14 |
| mup | PR snapd#8477 closed: tests: fix racy pulseaudio tests (2.44) <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8477> | 16:37 |
| mup | PR snapcraft#3028 closed: static: add codespell excludes for .direnv <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3028> | 16:50 |
| mup | PR snapd#8479 opened: release: 2.44.3 <Created by mvo5> <https://github.com/snapcore/snapd/pull/8479> | 16:56 |
| mup | PR snapcraft#3026 closed: spread tests: add core20 and cleanup systems <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3026> | 16:56 |
| mup | PR snapcraft#3029 opened: tests: speed up clean command unit tests <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3029> | 17:44 |
| zyga | ijohnson: do you have a reproducer for https://bugs.launchpad.net/snapd/+bug/1871189 ? | 17:56 |
| zyga | or should I go for the full snaps? | 17:56 |
| mup | Bug #1871189: Snapd `cannot update snap namespace` when connecting / disconnecting interfaces <snapd:Triaged by zyga> <https://launchpad.net/bugs/1871189> | 17:56 |
| mup | PR snapd#8480 opened: [WIP] tests: fix timeserver-control-test for 2.44 <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8480> | 17:58 |
| pstolowski | zyga: there? | 18:00 |
| zyga | sure | 18:00 |
| pstolowski | zyga: my fix for ntp failed on pulseaudio on 19.10, everything else passed | 18:01 |
| zyga | hahaha | 18:01 |
| zyga | I guess we need mvo to merge all the fixes :) | 18:01 |
| pstolowski | zyga: i just force pushed to clean the history, so re-running the tests | 18:02 |
| zyga | pstolowski: can you force push 8484 with a description of what is broken and how you fixed it | 18:02 |
| pstolowski | zyga: prepared 2.44 cherry-pick just in case | 18:02 |
| zyga | or is that ready as-is? | 18:02 |
| zyga | spread tests are churning | 18:04 |
| zyga | I think we can only EOD and wait now :) | 18:04 |
| pstolowski | zyga: dang, i think i lost mvo's original commit in the battle :/ | 18:06 |
| zyga | pstolowski: git reflog | 18:06 |
| pstolowski | zyga: i'm too tired already | 18:06 |
| zyga | you still have it | 18:06 |
| zyga | can salvage | 18:06 |
| pstolowski | zyga: yeah, it's one line, not a problem. but i was testing without it before | 18:07 |
| pstolowski | anyway... eod | 18:07 |
| pstolowski | see you, and happy easter! | 18:07 |
| zyga | :) | 18:07 |
| zyga | you too :) | 18:07 |
| zyga | have a good evening and the rest of the weekend! | 18:08 |
| pstolowski | likewise! bye | 18:08 |
| mup | PR snapd#8478 closed: tests: fix racy pulseaudio tests <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8478> | 18:12 |
| === ijohnson is now known as ijohnson|lunch | ||
| mup | PR snapcraft#3030 opened: [WIP] repo: drop _AptCache and add migrate to install_stage_packages() <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3030> | 20:18 |
| === ijohnson|lunch is now known as ijohnson | ||
| mup | PR snapcraft#3022 closed: plugins: introduce v2.PluginV2 and v2.NilPlugin <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3022> | 22:18 |
| mup | PR snapcraft#2966 closed: build providers: move to buildd images <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2966> | 22:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
