| babbageclunk | wallyworld: since Kelvin's not around can you review https://github.com/juju/juju/pull/11439? | 02:20 |
|---|---|---|
| babbageclunk | wallyworld: thanks! | 02:26 |
| === narindergupta is now known as narinderguptamac | ||
| wallyworld | babbageclunk: nice to get that fix done :-) you forward port to develop? | 03:13 |
| babbageclunk | wallyworld: yup, doing it now | 03:59 |
| wallyworld | \o/ | 04:00 |
| babbageclunk | wallyworld: https://github.com/juju/juju/pull/11440 | 04:21 |
| wallyworld | looking | 04:22 |
| wallyworld | babbageclunk: ty, hardest review i've done in ages | 04:22 |
| babbageclunk | :) | 04:24 |
| === exsdev0 is now known as exsdev | ||
| === shann_ is now known as shann | ||
| manadart | stickupkid: https://github.com/juju/juju/pull/11441 | 10:20 |
| stickupkid | manadart, this has grown legs, mind CR whilst I fix da tests https://github.com/juju/juju/pull/11425 | 10:56 |
| manadart | stickupkid: Sure. | 10:56 |
| achilleasa | hml: did you try the caas upgrade after landing the relation changes? Do we have any other pending bits? | 13:40 |
| hml | achilleasa: yes… that was a card you missed. i did caas upgrades, migration and a few bits of clean up. | 13:41 |
| hml | achilleasa: the only pending bits i now of are the two prs i have up. | 13:41 |
| achilleasa | hml: looking at the panic one atm. Think we can get a test in to ensure that the errors bubble up properly? | 13:42 |
| hml | achilleasa: there is a test which bubble up some. they won’t go all the way easily as other code checks should prevent them from occuring. | 13:43 |
| hml | the same reason it’s difficult to test | 13:43 |
| hml | achilleasa: that’s for the Implicit relations… pondering if the Join when dying can be tested for bubble up | 13:44 |
| manadart | stickupkid: Daily in a couple? Just need to grab a drink. | 14:26 |
| stickupkid | manadart, yarp | 14:26 |
| === dosaboy_ is now known as dosaboy | ||
| achilleasa | rick_h: these are the two new errors that the operator can get when we turn on support for rel limits: https://pastebin.canonical.com/p/QsQ59vynwh/ any tweak suggestions for the wording? | 15:05 |
| rick_h | achilleasa: that looks good. Ideally we'd be able to hint to the charm's metadata yaml because this is kind of new/out of the operators hands | 15:15 |
| achilleasa | rick_h: for the second error you mean? Something like 'the metadata for the new charm version imposes...'? | 15:16 |
| rick_h | achilleasa: no I mean in general. Ignore me. It's wishful thinking | 15:17 |
| hpidcock | tlm: tlm[m]: can you have a look at https://bugs.launchpad.net/juju/+bug/1871894 you might know whats up | 23:01 |
| mup | Bug #1871894: Workload pod deployed by Juju 2.8 can't create secret <juju:Triaged by tlmiller> <https://launchpad.net/bugs/1871894> | 23:01 |
| tlm | k hpidcock | 23:02 |
| hpidcock | It might not have anything to do with the admission stuff | 23:02 |
| tlm | very strange | 23:03 |
| babbageclunk | I love the message "existing secret does not exist" | 23:07 |
| tlm | hpidcock: that is a bug with the admission controller | 23:42 |
| tlm | will try and cover it with a test | 23:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!